From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Ville Syrjala" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Proper dbuf global state (rev3)
Date: Thu, 27 Feb 2020 20:21:44 -0000 [thread overview]
Message-ID: <158283490435.29659.11583871539811399186@emeril.freedesktop.org> (raw)
In-Reply-To: <20200225171125.28885-1-ville.syrjala@linux.intel.com>
== Series Details ==
Series: drm/i915: Proper dbuf global state (rev3)
URL : https://patchwork.freedesktop.org/series/73421/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3643e15727b1 drm/i915: Handle some leftover s/intel_crtc/crtc/
c2f2161d6505 drm/i915: Remove garbage WARNs
2786de40d65c drm/i915: Add missing commas to dbuf tables
73430ed2f955 drm/i915: Use a sentinel to terminate the dbuf slice arrays
047f693c4cfa drm/i915: Make skl_compute_dbuf_slices() behave consistently for all platforms
391eab3b022c drm/i915: Polish some dbuf debugs
a684f63e9f43 drm/i915: Unify the low level dbuf code
e3028c82388d drm/i915: Introduce proper dbuf state
-:175: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#175: FILE: drivers/gpu/drm/i915/display/intel_display.c:18381:
+ dev_priv->active_pipes = cdclk_state->active_pipes =
-:623: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#623: FILE: drivers/gpu/drm/i915/intel_pm.h:77:
+#define intel_atomic_get_old_dbuf_state(state) \
+ to_intel_dbuf_state(intel_atomic_get_old_global_obj_state(state, &to_i915(state->base.dev)->dbuf.obj))
-:624: WARNING:LONG_LINE: line over 100 characters
#624: FILE: drivers/gpu/drm/i915/intel_pm.h:78:
+ to_intel_dbuf_state(intel_atomic_get_old_global_obj_state(state, &to_i915(state->base.dev)->dbuf.obj))
-:625: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#625: FILE: drivers/gpu/drm/i915/intel_pm.h:79:
+#define intel_atomic_get_new_dbuf_state(state) \
+ to_intel_dbuf_state(intel_atomic_get_new_global_obj_state(state, &to_i915(state->base.dev)->dbuf.obj))
-:626: WARNING:LONG_LINE: line over 100 characters
#626: FILE: drivers/gpu/drm/i915/intel_pm.h:80:
+ to_intel_dbuf_state(intel_atomic_get_new_global_obj_state(state, &to_i915(state->base.dev)->dbuf.obj))
total: 0 errors, 2 warnings, 3 checks, 555 lines checked
071b62e2fe20 drm/i915: Nuke skl_ddb_get_hw_state()
2b355bb11548 drm/i915: Move the dbuf pre/post plane update
35835c92bd7f drm/i915: Clean up dbuf debugs during .atomic_check()
7f9190b0dc0b drm/i915: Extract intel_crtc_ddb_weight()
45c49c9f3b73 drm/i915: Pass the crtc to skl_compute_dbuf_slices()
3f877cd02847 drm/i915: Introduce intel_dbuf_slice_size()
373ddcca596a drm/i915: Introduce skl_ddb_entry_for_slices()
aa3deb4ba4f5 drm/i915: Move pipe ddb entries into the dbuf state
80543eb34ce4 drm/i915: Extract intel_crtc_dbuf_weights()
-:137: WARNING:LINE_SPACING: Missing a blank line after declarations
#137: FILE: drivers/gpu/drm/i915/intel_pm.c:3960:
+ struct skl_ddb_entry *alloc, /* out */
+ int *num_active /* out */)
total: 0 errors, 1 warnings, 0 checks, 176 lines checked
5d4ec45f7e49 drm/i915: Encapsulate dbuf state handling harder
1fc35297be7f drm/i915: Do a bit more initial readout for dbuf
9cba9c99fb78 drm/i915: Check slice mask for holes
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-27 20:21 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 17:11 [Intel-gfx] [PATCH v2 00/20] drm/i915: Proper dbuf global state Ville Syrjala
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 01/20] drm/i915: Handle some leftover s/intel_crtc/crtc/ Ville Syrjala
2020-02-26 9:29 ` Jani Nikula
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 02/20] drm/i915: Remove garbage WARNs Ville Syrjala
2020-02-26 9:30 ` Jani Nikula
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 03/20] drm/i915: Add missing commas to dbuf tables Ville Syrjala
2020-02-26 9:30 ` Jani Nikula
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 04/20] drm/i915: Use a sentinel to terminate the dbuf slice arrays Ville Syrjala
2020-02-26 9:32 ` Jani Nikula
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 05/20] drm/i915: Make skl_compute_dbuf_slices() behave consistently for all platforms Ville Syrjala
2020-02-25 17:30 ` Lisovskiy, Stanislav
2020-03-02 14:50 ` Ville Syrjälä
2020-03-02 15:50 ` Lisovskiy, Stanislav
2020-04-01 7:52 ` Lisovskiy, Stanislav
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 06/20] drm/i915: Polish some dbuf debugs Ville Syrjala
2020-03-04 16:29 ` Lisovskiy, Stanislav
2020-03-04 18:26 ` Ville Syrjälä
2020-03-05 9:53 ` Lisovskiy, Stanislav
2020-03-05 13:46 ` Ville Syrjälä
2020-03-05 14:56 ` Lisovskiy, Stanislav
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 07/20] drm/i915: Unify the low level dbuf code Ville Syrjala
2020-03-04 17:14 ` Lisovskiy, Stanislav
2020-03-04 17:23 ` Lisovskiy, Stanislav
2020-03-04 18:30 ` Ville Syrjälä
2020-03-05 8:28 ` Lisovskiy, Stanislav
2020-03-05 13:37 ` Ville Syrjälä
2020-03-05 14:01 ` Lisovskiy, Stanislav
2020-03-05 8:46 ` Lisovskiy, Stanislav
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 08/20] drm/i915: Introduce proper dbuf state Ville Syrjala
2020-02-25 17:43 ` Lisovskiy, Stanislav
2020-04-01 8:13 ` Lisovskiy, Stanislav
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 09/20] drm/i915: Nuke skl_ddb_get_hw_state() Ville Syrjala
2020-02-26 11:40 ` Lisovskiy, Stanislav
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 10/20] drm/i915: Move the dbuf pre/post plane update Ville Syrjala
2020-02-26 11:38 ` Lisovskiy, Stanislav
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 11/20] drm/i915: Clean up dbuf debugs during .atomic_check() Ville Syrjala
2020-02-26 11:32 ` Lisovskiy, Stanislav
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 12/20] drm/i915: Extract intel_crtc_ddb_weight() Ville Syrjala
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 13/20] drm/i915: Pass the crtc to skl_compute_dbuf_slices() Ville Syrjala
2020-02-26 8:41 ` Lisovskiy, Stanislav
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 14/20] drm/i915: Introduce intel_dbuf_slice_size() Ville Syrjala
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 15/20] drm/i915: Introduce skl_ddb_entry_for_slices() Ville Syrjala
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 16/20] drm/i915: Move pipe ddb entries into the dbuf state Ville Syrjala
2020-02-27 16:50 ` Ville Syrjala
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 17/20] drm/i915: Extract intel_crtc_dbuf_weights() Ville Syrjala
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 18/20] drm/i915: Encapsulate dbuf state handling harder Ville Syrjala
2021-01-21 12:55 ` Lisovskiy, Stanislav
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 19/20] drm/i915: Do a bit more initial readout for dbuf Ville Syrjala
2021-01-21 12:57 ` Lisovskiy, Stanislav
2020-02-25 17:11 ` [Intel-gfx] [PATCH v2 20/20] drm/i915: Check slice mask for holes Ville Syrjala
2020-02-25 17:47 ` Lisovskiy, Stanislav
2020-02-26 18:04 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Proper dbuf global state (rev2) Patchwork
2020-02-27 20:21 ` Patchwork [this message]
2020-02-27 20:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Proper dbuf global state (rev3) Patchwork
2020-02-29 2:40 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158283490435.29659.11583871539811399186@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.