All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anson Huang <Anson.Huang@nxp.com>
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com,
	dmitry.torokhov@gmail.com, a.zummo@towertech.it,
	alexandre.belloni@bootlin.com, rui.zhang@intel.com,
	daniel.lezcano@linaro.org, amit.kucheria@verdurent.com,
	wim@linux-watchdog.org, linux@roeck-us.net,
	daniel.baluta@nxp.com, gregkh@linuxfoundation.org,
	linux@rempel-privat.de, tglx@linutronix.de,
	m.felsch@pengutronix.de, andriy.shevchenko@linux.intel.com,
	arnd@arndb.de, ronald@innovation.ch, krzk@kernel.org,
	robh@kernel.org, leonard.crestez@nxp.com, aisheng.dong@nxp.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-watchdog@vger.kernel.org
Cc: Linux-imx@nxp.com
Subject: [PATCH V3 5/7] input: keyboard: imx_sc_key: Fix build warning for !CONFIG_IMX_SCU case
Date: Mon,  9 Mar 2020 08:38:18 +0800	[thread overview]
Message-ID: <1583714300-19085-5-git-send-email-Anson.Huang@nxp.com> (raw)
In-Reply-To: <1583714300-19085-1-git-send-email-Anson.Huang@nxp.com>

Fix below build warning when COMPILE_TEST is enabled while IMX_SCU is not:

drivers/input/keyboard/imx_sc_key.c: In function ‘imx_sc_check_for_events’:
drivers/input/keyboard/imx_sc_key.c:87:27: warning: ‘msg.state’ is used
uninitialized in this function [-Wuninitialized]
state = (bool)(msg.state & 0xff);
                             ^
AR      drivers/input/keyboard/built-in.a

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
No change.
---
 drivers/input/keyboard/imx_sc_key.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/keyboard/imx_sc_key.c b/drivers/input/keyboard/imx_sc_key.c
index 2672fd4..1b55348 100644
--- a/drivers/input/keyboard/imx_sc_key.c
+++ b/drivers/input/keyboard/imx_sc_key.c
@@ -69,6 +69,7 @@ static void imx_sc_check_for_events(struct work_struct *work)
 	hdr->func = IMX_SC_MISC_FUNC_GET_BUTTON_STATUS;
 	hdr->size = 1;
 
+	msg.state = 0;
 	error = imx_scu_call_rpc(priv->key_ipc_handle, &msg, true);
 	if (error) {
 		dev_err(&input->dev, "read imx sc key failed, error %d\n", error);
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Anson Huang <Anson.Huang@nxp.com>
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com,
	dmitry.torokhov@gmail.com, a.zummo@towertech.it,
	alexandre.belloni@bootlin.com, rui.zhang@intel.com,
	daniel.lezcano@linaro.org, amit.kucheria@verdurent.com,
	wim@linux-watchdog.org, linux@roeck-us.net,
	daniel.baluta@nxp.com, gregkh@linuxfoundation.org,
	linux@rempel-privat.de, tglx@linutronix.de,
	m.felsch@pengutronix.de, andriy.shevchenko@linux.intel.com,
	arnd@arndb.de, ronald@innovation.ch, krzk@kernel.org,
	robh@kernel.org, leonard.crestez@nxp.com, aisheng.dong@nxp.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-watchdog@vger.kernel.org
Cc: Linux-imx@nxp.com
Subject: [PATCH V3 5/7] input: keyboard: imx_sc_key: Fix build warning for !CONFIG_IMX_SCU case
Date: Mon,  9 Mar 2020 08:38:18 +0800	[thread overview]
Message-ID: <1583714300-19085-5-git-send-email-Anson.Huang@nxp.com> (raw)
In-Reply-To: <1583714300-19085-1-git-send-email-Anson.Huang@nxp.com>

Fix below build warning when COMPILE_TEST is enabled while IMX_SCU is not:

drivers/input/keyboard/imx_sc_key.c: In function ‘imx_sc_check_for_events’:
drivers/input/keyboard/imx_sc_key.c:87:27: warning: ‘msg.state’ is used
uninitialized in this function [-Wuninitialized]
state = (bool)(msg.state & 0xff);
                             ^
AR      drivers/input/keyboard/built-in.a

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
No change.
---
 drivers/input/keyboard/imx_sc_key.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/keyboard/imx_sc_key.c b/drivers/input/keyboard/imx_sc_key.c
index 2672fd4..1b55348 100644
--- a/drivers/input/keyboard/imx_sc_key.c
+++ b/drivers/input/keyboard/imx_sc_key.c
@@ -69,6 +69,7 @@ static void imx_sc_check_for_events(struct work_struct *work)
 	hdr->func = IMX_SC_MISC_FUNC_GET_BUTTON_STATUS;
 	hdr->size = 1;
 
+	msg.state = 0;
 	error = imx_scu_call_rpc(priv->key_ipc_handle, &msg, true);
 	if (error) {
 		dev_err(&input->dev, "read imx sc key failed, error %d\n", error);
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-03-09  0:45 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09  0:38 [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Anson Huang
2020-03-09  0:38 ` Anson Huang
2020-03-09  0:38 ` [PATCH V3 2/7] firmware: imx: add COMPILE_TEST support Anson Huang
2020-03-09  0:38   ` Anson Huang
2020-03-16  0:53   ` Shawn Guo
2020-03-16  0:53     ` Shawn Guo
2020-03-16  3:37   ` Shawn Guo
2020-03-16  3:37     ` Shawn Guo
2020-03-09  0:38 ` [PATCH V3 3/7] rtc: add COMPILE_TEST support for i.MX SC RTC Anson Huang
2020-03-09  0:38   ` Anson Huang
2020-03-09  0:38 ` [PATCH V3 4/7] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY Anson Huang
2020-03-09  0:38   ` Anson Huang
2020-03-09  0:38 ` Anson Huang [this message]
2020-03-09  0:38   ` [PATCH V3 5/7] input: keyboard: imx_sc_key: Fix build warning for !CONFIG_IMX_SCU case Anson Huang
2020-03-09  0:38 ` [PATCH V3 6/7] watchdog: add COMPILE_TEST support for IMX_SC_WDT Anson Huang
2020-03-09  0:38   ` Anson Huang
2020-03-09  0:38 ` [PATCH V3 7/7] thermal: add COMPILE_TEST support for IMX_SC_THERMAL Anson Huang
2020-03-09  0:38   ` Anson Huang
2020-03-09 11:06 ` [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Alexandre Belloni
2020-03-09 11:06   ` Alexandre Belloni
2020-03-09 12:20   ` Anson Huang
2020-03-09 12:20     ` Anson Huang
2020-03-09 13:27   ` Guenter Roeck
2020-03-09 13:27     ` Guenter Roeck
2020-03-09 13:37     ` Anson Huang
2020-03-09 13:37       ` Anson Huang
2020-03-09 16:47     ` Alexandre Belloni
2020-03-09 16:47       ` Alexandre Belloni
2020-03-09 17:10       ` Guenter Roeck
2020-03-09 17:10         ` Guenter Roeck
2020-03-09 17:30         ` Alexandre Belloni
2020-03-09 17:30           ` Alexandre Belloni
2020-03-09 18:19           ` Guenter Roeck
2020-03-09 18:19             ` Guenter Roeck
2020-03-09 13:40 ` Peng Fan
2020-03-09 13:40   ` Peng Fan
2020-03-09 14:09   ` Anson Huang
2020-03-09 14:09     ` Anson Huang
2020-03-16  0:52   ` Shawn Guo
2020-03-16  0:52     ` Shawn Guo
2020-03-16  2:51     ` Peng Fan
2020-03-16  2:51       ` Peng Fan
2020-03-16  3:07       ` Shawn Guo
2020-03-16  3:07         ` Shawn Guo
2020-03-16  3:18         ` Peng Fan
2020-03-16  3:18           ` Peng Fan
2020-03-16  3:34           ` Shawn Guo
2020-03-16  3:34             ` Shawn Guo
2020-03-16  8:04             ` Anson Huang
2020-03-16  8:04               ` Anson Huang
2020-03-16  8:40               ` Alexandre Belloni
2020-03-16  8:40                 ` Alexandre Belloni
2020-03-16  8:44                 ` Anson Huang
2020-03-16  8:44                   ` Anson Huang
2020-03-16  9:00                   ` Alexandre Belloni
2020-03-16  9:00                     ` Alexandre Belloni
2020-03-16  9:08                     ` Anson Huang
2020-03-16  9:08                       ` Anson Huang
2020-03-16  9:15                       ` Alexandre Belloni
2020-03-16  9:15                         ` Alexandre Belloni
2020-03-16  9:40                         ` Anson Huang
2020-03-16  9:40                           ` Anson Huang
2020-03-16 10:00                           ` Alexandre Belloni
2020-03-16 10:00                             ` Alexandre Belloni
2020-03-16 10:18                             ` Anson Huang
2020-03-16 10:18                               ` Anson Huang
2020-03-17  2:18                           ` Peng Fan
2020-03-17  2:18                             ` Peng Fan
2020-03-17  2:29                             ` Anson Huang
2020-03-17  2:29                               ` Anson Huang
2020-03-17  2:32                             ` Guenter Roeck
2020-03-17  2:32                               ` Guenter Roeck
2020-03-17  2:35                               ` Anson Huang
2020-03-17  2:35                                 ` Anson Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1583714300-19085-5-git-send-email-Anson.Huang@nxp.com \
    --to=anson.huang@nxp.com \
    --cc=Linux-imx@nxp.com \
    --cc=a.zummo@towertech.it \
    --cc=aisheng.dong@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=amit.kucheria@verdurent.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=daniel.baluta@nxp.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=linux@roeck-us.net \
    --cc=m.felsch@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=ronald@innovation.ch \
    --cc=rui.zhang@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.