From: Anson Huang <anson.huang@nxp.com>
To: Guenter Roeck <linux@roeck-us.net>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux@rempel-privat.de" <linux@rempel-privat.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"m.felsch@pengutronix.de" <m.felsch@pengutronix.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"ronald@innovation.ch" <ronald@innovation.ch>,
"krzk@kernel.org" <krzk@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
Leonard Crestez <leonard.crestez@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case
Date: Mon, 9 Mar 2020 13:37:09 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916AE9BA2DEDA066DF0FCCDF5FE0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1ad38cdb-bf0d-1c19-b233-15a5857bd6fa@roeck-us.net>
> Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU
> case
>
> On 3/9/20 4:06 AM, Alexandre Belloni wrote:
> > On 09/03/2020 08:38:14+0800, Anson Huang wrote:
> >> Add stubs for those i.MX SCU APIs to make those modules depending on
> >> IMX_SCU can pass build when COMPILE_TEST is enabled.
> >>
> >> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> >> ---
> >> Changes since V2:
> >> - return error for stubs.
> >
> > I'm not sure why you are sending v3 with the stubs as we determined
> > that
> > 2/7 is enough to compile all the drivers with COMPILE_TEST.
> >
> >
> 2/7 alone is not sufficient. With only 2/7, one can explicitly configure
> IMX_SCU=n, COMPILE_TEST=y, and get lots of compile failures. Granted, one
> should not do that, but 0day does (I don't know if that is the result of
> RANDCONFIG), and I am not looking forward having to deal with the fallout.
So the V3 patch series looks better, adding stubs can cover various corner cases.
Anson
WARNING: multiple messages have this Message-ID (diff)
From: Anson Huang <anson.huang@nxp.com>
To: Guenter Roeck <linux@roeck-us.net>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: "m.felsch@pengutronix.de" <m.felsch@pengutronix.de>,
Leonard Crestez <leonard.crestez@nxp.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"krzk@kernel.org" <krzk@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"ronald@innovation.ch" <ronald@innovation.ch>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Aisheng Dong <aisheng.dong@nxp.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux@rempel-privat.de" <linux@rempel-privat.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Subject: RE: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case
Date: Mon, 9 Mar 2020 13:37:09 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916AE9BA2DEDA066DF0FCCDF5FE0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1ad38cdb-bf0d-1c19-b233-15a5857bd6fa@roeck-us.net>
> Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU
> case
>
> On 3/9/20 4:06 AM, Alexandre Belloni wrote:
> > On 09/03/2020 08:38:14+0800, Anson Huang wrote:
> >> Add stubs for those i.MX SCU APIs to make those modules depending on
> >> IMX_SCU can pass build when COMPILE_TEST is enabled.
> >>
> >> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> >> ---
> >> Changes since V2:
> >> - return error for stubs.
> >
> > I'm not sure why you are sending v3 with the stubs as we determined
> > that
> > 2/7 is enough to compile all the drivers with COMPILE_TEST.
> >
> >
> 2/7 alone is not sufficient. With only 2/7, one can explicitly configure
> IMX_SCU=n, COMPILE_TEST=y, and get lots of compile failures. Granted, one
> should not do that, but 0day does (I don't know if that is the result of
> RANDCONFIG), and I am not looking forward having to deal with the fallout.
So the V3 patch series looks better, adding stubs can cover various corner cases.
Anson
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-09 13:37 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 0:38 [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-09 0:38 ` [PATCH V3 2/7] firmware: imx: add COMPILE_TEST support Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-16 0:53 ` Shawn Guo
2020-03-16 0:53 ` Shawn Guo
2020-03-16 3:37 ` Shawn Guo
2020-03-16 3:37 ` Shawn Guo
2020-03-09 0:38 ` [PATCH V3 3/7] rtc: add COMPILE_TEST support for i.MX SC RTC Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-09 0:38 ` [PATCH V3 4/7] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-09 0:38 ` [PATCH V3 5/7] input: keyboard: imx_sc_key: Fix build warning for !CONFIG_IMX_SCU case Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-09 0:38 ` [PATCH V3 6/7] watchdog: add COMPILE_TEST support for IMX_SC_WDT Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-09 0:38 ` [PATCH V3 7/7] thermal: add COMPILE_TEST support for IMX_SC_THERMAL Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-09 11:06 ` [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Alexandre Belloni
2020-03-09 11:06 ` Alexandre Belloni
2020-03-09 12:20 ` Anson Huang
2020-03-09 12:20 ` Anson Huang
2020-03-09 13:27 ` Guenter Roeck
2020-03-09 13:27 ` Guenter Roeck
2020-03-09 13:37 ` Anson Huang [this message]
2020-03-09 13:37 ` Anson Huang
2020-03-09 16:47 ` Alexandre Belloni
2020-03-09 16:47 ` Alexandre Belloni
2020-03-09 17:10 ` Guenter Roeck
2020-03-09 17:10 ` Guenter Roeck
2020-03-09 17:30 ` Alexandre Belloni
2020-03-09 17:30 ` Alexandre Belloni
2020-03-09 18:19 ` Guenter Roeck
2020-03-09 18:19 ` Guenter Roeck
2020-03-09 13:40 ` Peng Fan
2020-03-09 13:40 ` Peng Fan
2020-03-09 14:09 ` Anson Huang
2020-03-09 14:09 ` Anson Huang
2020-03-16 0:52 ` Shawn Guo
2020-03-16 0:52 ` Shawn Guo
2020-03-16 2:51 ` Peng Fan
2020-03-16 2:51 ` Peng Fan
2020-03-16 3:07 ` Shawn Guo
2020-03-16 3:07 ` Shawn Guo
2020-03-16 3:18 ` Peng Fan
2020-03-16 3:18 ` Peng Fan
2020-03-16 3:34 ` Shawn Guo
2020-03-16 3:34 ` Shawn Guo
2020-03-16 8:04 ` Anson Huang
2020-03-16 8:04 ` Anson Huang
2020-03-16 8:40 ` Alexandre Belloni
2020-03-16 8:40 ` Alexandre Belloni
2020-03-16 8:44 ` Anson Huang
2020-03-16 8:44 ` Anson Huang
2020-03-16 9:00 ` Alexandre Belloni
2020-03-16 9:00 ` Alexandre Belloni
2020-03-16 9:08 ` Anson Huang
2020-03-16 9:08 ` Anson Huang
2020-03-16 9:15 ` Alexandre Belloni
2020-03-16 9:15 ` Alexandre Belloni
2020-03-16 9:40 ` Anson Huang
2020-03-16 9:40 ` Anson Huang
2020-03-16 10:00 ` Alexandre Belloni
2020-03-16 10:00 ` Alexandre Belloni
2020-03-16 10:18 ` Anson Huang
2020-03-16 10:18 ` Anson Huang
2020-03-17 2:18 ` Peng Fan
2020-03-17 2:18 ` Peng Fan
2020-03-17 2:29 ` Anson Huang
2020-03-17 2:29 ` Anson Huang
2020-03-17 2:32 ` Guenter Roeck
2020-03-17 2:32 ` Guenter Roeck
2020-03-17 2:35 ` Anson Huang
2020-03-17 2:35 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB3916AE9BA2DEDA066DF0FCCDF5FE0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=a.zummo@towertech.it \
--cc=aisheng.dong@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=amit.kucheria@verdurent.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=daniel.baluta@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=linux@roeck-us.net \
--cc=m.felsch@pengutronix.de \
--cc=robh@kernel.org \
--cc=ronald@innovation.ch \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.