[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prefer drm_WARN* over WARN*

From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Pankaj Bharadiya" <pankaj.laxminarayan.bharadiya@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prefer drm_WARN* over WARN*
Date: Mon, 06 Apr 2020 11:59:34 -0000	[thread overview]
Message-ID: <158617437415.4193.7868464366667651303@emeril.freedesktop.org> (raw)
In-Reply-To: <20200406112800.23762-1-pankaj.laxminarayan.bharadiya@intel.com>

== Series Details ==

Series: Prefer drm_WARN* over WARN*
URL   : https://patchwork.freedesktop.org/series/75543/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2b3269120530 drm/i915/display/icl_dsi: Prefer drm_WARN_ON over WARN_ON
ce36d1d4c808 drm/i915/display/atomic_plane: Prefer drm_WARN_ON over WARN_ON
9db54cf5c0c1 drm/i915/display/ddi: Prefer drm_WARN* over WARN*
cbddf2425b98 drm/i915/display/display: Prefer drm_WARN_ON over WARN_ON
0aae019835f6 drm/i915/display/display: Prefer drm_WARN_ON over WARN_ON
-:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18: 
+ struct drm_i915_private *i915 = container_of(T, struct drm_i915_private, power_domains);

total: 0 errors, 1 warnings, 0 checks, 71 lines checked
462c17ba380f drm/i915/display/dp: Prefer drm_WARN* over WARN*
3a60829da48b drm/i915/display/dpll_mgr: Prefer drm_WARN_ON over WARN_ON
9343391f6779 drm/i915/display/frontbuffer: Prefer drm_WARN_ON over WARN_ON
31d144a0fd99 drm/i915/display/global_state: Prefer drm_WARN* over WARN*
e61a3429efb8 drm/i915/display/overlay: Prefer drm_WARN_ON over WARN_ON
a17137b9ca74 drm/i915/display/sdvo: Prefer drm_WARN* over WARN*
ccea1b50c254 drm/i915/display/tc: Prefer drm_WARN_ON over WARN_ON
63fc326a1fca drm/i915/display/vlv_dsi: Prefer drm_WARN_ON over WARN_ON
a09caf119a41 drm/i915/gem: Prefer drm_WARN* over WARN*
-:24: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#24: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1444:
+			if (drm_WARN_ONCE(&i915->drm, err,
 				      "Unexpected failure to bind target VMA!"))

-:50: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!obj->userptr.mm"
#50: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:238:
+	if (drm_WARN_ON(obj->base.dev, obj->userptr.mm == NULL))

total: 0 errors, 0 warnings, 2 checks, 25 lines checked
d9387cef2125 drm/i915/i915_drv: Prefer drm_WARN_ON over WARN_ON
-:22: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#22: FILE: drivers/gpu/drm/i915/i915_drv.h:1650:
+#define INTEL_DISPLAY_ENABLED(dev_priv) \
+		(drm_WARN_ON(&dev_priv->drm, !HAS_DISPLAY(dev_priv)), !i915_modparams.disable_display)

-:22: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'dev_priv' may be better as '(dev_priv)' to avoid precedence issues
#22: FILE: drivers/gpu/drm/i915/i915_drv.h:1650:
+#define INTEL_DISPLAY_ENABLED(dev_priv) \
+		(drm_WARN_ON(&dev_priv->drm, !HAS_DISPLAY(dev_priv)), !i915_modparams.disable_display)

-:23: WARNING:LONG_LINE: line over 100 characters
#23: FILE: drivers/gpu/drm/i915/i915_drv.h:1651:
+		(drm_WARN_ON(&dev_priv->drm, !HAS_DISPLAY(dev_priv)), !i915_modparams.disable_display)

total: 0 errors, 1 warnings, 2 checks, 9 lines checked
0af155c5b3f1 drm/i915/pmu: Prefer drm_WARN_ON over WARN_ON
db552aba6881 drm/i915/pm: Prefer drm_WARN_ON over WARN_ON
4c4c2b16486b drm/i915/runtime_pm: Prefer drm_WARN* over WARN*
-:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
+ struct drm_i915_private *i915 = container_of(T, struct drm_i915_private, runtime_pm);

total: 0 errors, 1 warnings, 0 checks, 89 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx