* [PATCH v1 1/1] pinctrl: mediatek: remove shadow variable declaration
@ 2020-04-07 10:33 ` light.hsieh
0 siblings, 0 replies; 8+ messages in thread
From: light.hsieh @ 2020-04-07 10:33 UTC (permalink / raw)
To: linus.walleij
Cc: sean.wang, kuohong.wang, linux-kernel, Light Hsieh, linux-gpio,
linux-mediatek
From: Light Hsieh <light.hsieh@mediatek.com>
Remove shadow declaration of variable 'pullup' in mtk_pinconf_get()
Signed-off-by: Light Hsieh <light.hsieh@mediatek.com>
---
drivers/pinctrl/mediatek/pinctrl-paris.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
index 83bf29c..8f75115 100644
--- a/drivers/pinctrl/mediatek/pinctrl-paris.c
+++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
@@ -164,8 +164,6 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
case MTK_PIN_CONFIG_PU_ADV:
case MTK_PIN_CONFIG_PD_ADV:
if (hw->soc->adv_pull_get) {
- bool pullup;
-
pullup = param == MTK_PIN_CONFIG_PU_ADV;
err = hw->soc->adv_pull_get(hw, desc, pullup, &ret);
} else
--
1.8.1.1.dirty
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v1 1/1] pinctrl: mediatek: remove shadow variable declaration
2020-04-07 10:33 ` light.hsieh
@ 2020-04-07 13:37 ` Stanley Chu
-1 siblings, 0 replies; 8+ messages in thread
From: Stanley Chu @ 2020-04-07 13:37 UTC (permalink / raw)
To: light.hsieh
Cc: linus.walleij, sean.wang, Kuohong Wang (王國鴻),
linux-kernel, linux-gpio, linux-mediatek
Hi Light,
On Tue, 2020-04-07 at 18:33 +0800, light.hsieh@mediatek.com wrote:
> From: Light Hsieh <light.hsieh@mediatek.com>
>
> Remove shadow declaration of variable 'pullup' in mtk_pinconf_get()
>
> Signed-off-by: Light Hsieh <light.hsieh@mediatek.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-paris.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
> index 83bf29c..8f75115 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
> @@ -164,8 +164,6 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
> case MTK_PIN_CONFIG_PU_ADV:
> case MTK_PIN_CONFIG_PD_ADV:
> if (hw->soc->adv_pull_get) {
> - bool pullup;
> -
> pullup = param == MTK_PIN_CONFIG_PU_ADV;
> err = hw->soc->adv_pull_get(hw, desc, pullup, &ret);
> } else
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v1 1/1] pinctrl: mediatek: remove shadow variable declaration
@ 2020-04-07 13:37 ` Stanley Chu
0 siblings, 0 replies; 8+ messages in thread
From: Stanley Chu @ 2020-04-07 13:37 UTC (permalink / raw)
To: light.hsieh
Cc: linus.walleij, sean.wang, Kuohong Wang (王國鴻),
linux-kernel, linux-gpio, linux-mediatek
Hi Light,
On Tue, 2020-04-07 at 18:33 +0800, light.hsieh@mediatek.com wrote:
> From: Light Hsieh <light.hsieh@mediatek.com>
>
> Remove shadow declaration of variable 'pullup' in mtk_pinconf_get()
>
> Signed-off-by: Light Hsieh <light.hsieh@mediatek.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-paris.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
> index 83bf29c..8f75115 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
> @@ -164,8 +164,6 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
> case MTK_PIN_CONFIG_PU_ADV:
> case MTK_PIN_CONFIG_PD_ADV:
> if (hw->soc->adv_pull_get) {
> - bool pullup;
> -
> pullup = param == MTK_PIN_CONFIG_PU_ADV;
> err = hw->soc->adv_pull_get(hw, desc, pullup, &ret);
> } else
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: mediatek: remove shadow variable declaration
2020-04-07 10:33 ` light.hsieh
@ 2020-04-07 13:41 ` Yingjoe Chen
-1 siblings, 0 replies; 8+ messages in thread
From: Yingjoe Chen @ 2020-04-07 13:41 UTC (permalink / raw)
To: light.hsieh
Cc: linus.walleij, sean.wang, kuohong.wang, linux-kernel, linux-gpio,
linux-mediatek
On Tue, 2020-04-07 at 18:33 +0800, light.hsieh@mediatek.com wrote:
> From: Light Hsieh <light.hsieh@mediatek.com>
>
> Remove shadow declaration of variable 'pullup' in mtk_pinconf_get()
>
> Signed-off-by: Light Hsieh <light.hsieh@mediatek.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-paris.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
> index 83bf29c..8f75115 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
> @@ -164,8 +164,6 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
> case MTK_PIN_CONFIG_PU_ADV:
> case MTK_PIN_CONFIG_PD_ADV:
> if (hw->soc->adv_pull_get) {
> - bool pullup;
> -
> pullup = param == MTK_PIN_CONFIG_PU_ADV;
> err = hw->soc->adv_pull_get(hw, desc, pullup, &ret);
> } else
Hi, Light,
What is this based on?
The code in v5.6 doesn't looks like this.
Joe.C
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v1 1/1] pinctrl: mediatek: remove shadow variable declaration
@ 2020-04-07 13:41 ` Yingjoe Chen
0 siblings, 0 replies; 8+ messages in thread
From: Yingjoe Chen @ 2020-04-07 13:41 UTC (permalink / raw)
To: light.hsieh
Cc: linus.walleij, sean.wang, kuohong.wang, linux-kernel, linux-gpio,
linux-mediatek
On Tue, 2020-04-07 at 18:33 +0800, light.hsieh@mediatek.com wrote:
> From: Light Hsieh <light.hsieh@mediatek.com>
>
> Remove shadow declaration of variable 'pullup' in mtk_pinconf_get()
>
> Signed-off-by: Light Hsieh <light.hsieh@mediatek.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-paris.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
> index 83bf29c..8f75115 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
> @@ -164,8 +164,6 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
> case MTK_PIN_CONFIG_PU_ADV:
> case MTK_PIN_CONFIG_PD_ADV:
> if (hw->soc->adv_pull_get) {
> - bool pullup;
> -
> pullup = param == MTK_PIN_CONFIG_PU_ADV;
> err = hw->soc->adv_pull_get(hw, desc, pullup, &ret);
> } else
Hi, Light,
What is this based on?
The code in v5.6 doesn't looks like this.
Joe.C
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: mediatek: remove shadow variable declaration
2020-04-07 10:33 ` light.hsieh
@ 2020-04-16 8:02 ` Linus Walleij
-1 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2020-04-16 8:02 UTC (permalink / raw)
To: Light Hsieh
Cc: moderated list:ARM/Mediatek SoC support,
open list:GPIO SUBSYSTEM, linux-kernel, Sean Wang, Kuohong Wang
On Tue, Apr 7, 2020 at 12:34 PM <light.hsieh@mediatek.com> wrote:
> From: Light Hsieh <light.hsieh@mediatek.com>
>
> Remove shadow declaration of variable 'pullup' in mtk_pinconf_get()
>
> Signed-off-by: Light Hsieh <light.hsieh@mediatek.com>
Patch applied for fixes, thanks for fixing this!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: mediatek: remove shadow variable declaration
@ 2020-04-16 8:02 ` Linus Walleij
0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2020-04-16 8:02 UTC (permalink / raw)
To: Light Hsieh
Cc: open list:GPIO SUBSYSTEM, Sean Wang,
moderated list:ARM/Mediatek SoC support, linux-kernel,
Kuohong Wang
On Tue, Apr 7, 2020 at 12:34 PM <light.hsieh@mediatek.com> wrote:
> From: Light Hsieh <light.hsieh@mediatek.com>
>
> Remove shadow declaration of variable 'pullup' in mtk_pinconf_get()
>
> Signed-off-by: Light Hsieh <light.hsieh@mediatek.com>
Patch applied for fixes, thanks for fixing this!
Yours,
Linus Walleij
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread