From: Stephen Boyd <swboyd@chromium.org>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Suzuki K Poulose <Suzuki.Poulose@arm.com>
Cc: mike.leach@linaro.org, mathieu.poirier@linaro.org,
leo.yan@linaro.org, alexander.shishkin@linux.intel.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
suzuki.poulose@arm.com
Subject: Re: [RFC PATCH] coresight: dynamic-replicator: Fix handling of multiple connections
Date: Thu, 09 Apr 2020 00:16:59 -0700 [thread overview]
Message-ID: <158641661949.126188.2854214876274328570@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200408224347.GA388414@ewhatever.cambridge.arm.com>
Quoting Suzuki K Poulose (2020-04-08 15:43:47)
> On Tue, Apr 07, 2020 at 08:48:54PM +0530, Sai Prakash Ranjan wrote:
> >
> > Thanks, I can test it out.
>
> Please find the untested patch below.
>
> ---8>---
>
> [untested] coresight: Fix support for sparse port numbers
>
> On some systems the firmware may not describe all the ports
> connected to a component (e.g, for security reasons). This
> could be especially problematic for "funnels" where we could
> end up in modifying memory beyond the allocated space for
> refcounts.
>
> e.g, for a funnel with input ports listed 0, 3, 5, nr_inport = 3.
> However the we could access refcnts[5] while checking for
> references.
>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
Things don't blow up for me anymore with KASAN, so feel free to add
Tested-by: Stephen Boyd <swboyd@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Suzuki K Poulose <Suzuki.Poulose@arm.com>
Cc: mathieu.poirier@linaro.org, suzuki.poulose@arm.com,
alexander.shishkin@linux.intel.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org,
mike.leach@linaro.org
Subject: Re: [RFC PATCH] coresight: dynamic-replicator: Fix handling of multiple connections
Date: Thu, 09 Apr 2020 00:16:59 -0700 [thread overview]
Message-ID: <158641661949.126188.2854214876274328570@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200408224347.GA388414@ewhatever.cambridge.arm.com>
Quoting Suzuki K Poulose (2020-04-08 15:43:47)
> On Tue, Apr 07, 2020 at 08:48:54PM +0530, Sai Prakash Ranjan wrote:
> >
> > Thanks, I can test it out.
>
> Please find the untested patch below.
>
> ---8>---
>
> [untested] coresight: Fix support for sparse port numbers
>
> On some systems the firmware may not describe all the ports
> connected to a component (e.g, for security reasons). This
> could be especially problematic for "funnels" where we could
> end up in modifying memory beyond the allocated space for
> refcounts.
>
> e.g, for a funnel with input ports listed 0, 3, 5, nr_inport = 3.
> However the we could access refcnts[5] while checking for
> references.
>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
Things don't blow up for me anymore with KASAN, so feel free to add
Tested-by: Stephen Boyd <swboyd@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-09 7:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 10:28 [RFC PATCH] coresight: dynamic-replicator: Fix handling of multiple connections Sai Prakash Ranjan
2020-04-05 10:28 ` Sai Prakash Ranjan
2020-04-06 10:55 ` Mike Leach
2020-04-06 10:55 ` Mike Leach
2020-04-07 9:46 ` Sai Prakash Ranjan
2020-04-07 9:46 ` Sai Prakash Ranjan
2020-04-07 10:24 ` Suzuki K Poulose
2020-04-07 10:24 ` Suzuki K Poulose
2020-04-07 11:29 ` Sai Prakash Ranjan
2020-04-07 11:29 ` Sai Prakash Ranjan
2020-04-07 13:08 ` Suzuki K Poulose
2020-04-07 13:08 ` Suzuki K Poulose
2020-04-07 13:56 ` Sai Prakash Ranjan
2020-04-07 13:56 ` Sai Prakash Ranjan
2020-04-07 14:53 ` Suzuki K Poulose
2020-04-07 14:53 ` Suzuki K Poulose
2020-04-07 15:18 ` Sai Prakash Ranjan
2020-04-07 15:18 ` Sai Prakash Ranjan
2020-04-08 22:43 ` Suzuki K Poulose
2020-04-08 22:43 ` Suzuki K Poulose
2020-04-09 7:16 ` Stephen Boyd [this message]
2020-04-09 7:16 ` Stephen Boyd
2020-04-09 7:51 ` Sai Prakash Ranjan
2020-04-09 7:51 ` Sai Prakash Ranjan
2020-04-09 9:17 ` Suzuki K Poulose
2020-04-09 9:17 ` Suzuki K Poulose
2020-04-09 9:34 ` Sai Prakash Ranjan
2020-04-09 9:34 ` Sai Prakash Ranjan
2020-04-23 12:21 ` Sai Prakash Ranjan
2020-04-23 12:21 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158641661949.126188.2854214876274328570@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=Suzuki.Poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=saiprakash.ranjan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.