All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: saiprakash.ranjan@codeaurora.org
Cc: mike.leach@linaro.org, mathieu.poirier@linaro.org,
	leo.yan@linaro.org, alexander.shishkin@linux.intel.com,
	swboyd@chromium.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [RFC PATCH] coresight: dynamic-replicator: Fix handling of multiple connections
Date: Tue, 7 Apr 2020 14:08:07 +0100	[thread overview]
Message-ID: <bb209f80-ac02-6321-dac4-ebf9ee6fa9a0@arm.com> (raw)
In-Reply-To: <39a2b3fff165a108fa59d72b630b5f14@codeaurora.org>

On 04/07/2020 12:29 PM, Sai Prakash Ranjan wrote:
> Hi Suzuki,
> 
> Thanks for looking into this issue.
> 
> On 2020-04-07 15:54, Suzuki K Poulose wrote:
>> On 04/07/2020 10:46 AM, Sai Prakash Ranjan wrote:
>>
>> There seems to be two replicators back to back here. What is connected
>> to the other output of both of them ? Are there any TPIUs ? What happens
>> if you choose a sink on the other end of "swao_replicator" (ETB ?)
>>
> 
> The other outport of swao replicator is connected to EUD which is a
> QCOM specific HW which can be used as a sink like USB.
> And the other outport of other replicator(replicator_out) is connected to
> TPIU.
> 
>> After boot, what do the idfilter registers read for both the 
>> replicators ?
>>
> 
> Added some prints in replicator_probe.
> 
>   replicator probe ret=-517 devname=6046000.replicator idfilter0=0x0 
> idfilter1=0x0
>   replicator probe ret=0 devname=6b06000.replicator idfilter0=0xff 
> idfilter1=0xff
>   replicator probe ret=0 devname=6046000.replicator idfilter0=0xff 
> idfilter1=0xff

Curious to see how the idfilterX is set to 0:
	 if that is never used.
		Or
	 if the user doesn't reset it back to 0xff.

Does your test ever touch EUD (enable the port for EUD at
swao-replicator) ? What are the values before you run your test ?


Suzuki

WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: saiprakash.ranjan@codeaurora.org
Cc: mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	swboyd@chromium.org, leo.yan@linaro.org,
	linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org
Subject: Re: [RFC PATCH] coresight: dynamic-replicator: Fix handling of multiple connections
Date: Tue, 7 Apr 2020 14:08:07 +0100	[thread overview]
Message-ID: <bb209f80-ac02-6321-dac4-ebf9ee6fa9a0@arm.com> (raw)
In-Reply-To: <39a2b3fff165a108fa59d72b630b5f14@codeaurora.org>

On 04/07/2020 12:29 PM, Sai Prakash Ranjan wrote:
> Hi Suzuki,
> 
> Thanks for looking into this issue.
> 
> On 2020-04-07 15:54, Suzuki K Poulose wrote:
>> On 04/07/2020 10:46 AM, Sai Prakash Ranjan wrote:
>>
>> There seems to be two replicators back to back here. What is connected
>> to the other output of both of them ? Are there any TPIUs ? What happens
>> if you choose a sink on the other end of "swao_replicator" (ETB ?)
>>
> 
> The other outport of swao replicator is connected to EUD which is a
> QCOM specific HW which can be used as a sink like USB.
> And the other outport of other replicator(replicator_out) is connected to
> TPIU.
> 
>> After boot, what do the idfilter registers read for both the 
>> replicators ?
>>
> 
> Added some prints in replicator_probe.
> 
>   replicator probe ret=-517 devname=6046000.replicator idfilter0=0x0 
> idfilter1=0x0
>   replicator probe ret=0 devname=6b06000.replicator idfilter0=0xff 
> idfilter1=0xff
>   replicator probe ret=0 devname=6046000.replicator idfilter0=0xff 
> idfilter1=0xff

Curious to see how the idfilterX is set to 0:
	 if that is never used.
		Or
	 if the user doesn't reset it back to 0xff.

Does your test ever touch EUD (enable the port for EUD at
swao-replicator) ? What are the values before you run your test ?


Suzuki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-04-07 13:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05 10:28 [RFC PATCH] coresight: dynamic-replicator: Fix handling of multiple connections Sai Prakash Ranjan
2020-04-05 10:28 ` Sai Prakash Ranjan
2020-04-06 10:55 ` Mike Leach
2020-04-06 10:55   ` Mike Leach
2020-04-07  9:46   ` Sai Prakash Ranjan
2020-04-07  9:46     ` Sai Prakash Ranjan
2020-04-07 10:24     ` Suzuki K Poulose
2020-04-07 10:24       ` Suzuki K Poulose
2020-04-07 11:29       ` Sai Prakash Ranjan
2020-04-07 11:29         ` Sai Prakash Ranjan
2020-04-07 13:08         ` Suzuki K Poulose [this message]
2020-04-07 13:08           ` Suzuki K Poulose
2020-04-07 13:56           ` Sai Prakash Ranjan
2020-04-07 13:56             ` Sai Prakash Ranjan
2020-04-07 14:53             ` Suzuki K Poulose
2020-04-07 14:53               ` Suzuki K Poulose
2020-04-07 15:18               ` Sai Prakash Ranjan
2020-04-07 15:18                 ` Sai Prakash Ranjan
2020-04-08 22:43                 ` Suzuki K Poulose
2020-04-08 22:43                   ` Suzuki K Poulose
2020-04-09  7:16                   ` Stephen Boyd
2020-04-09  7:16                     ` Stephen Boyd
2020-04-09  7:51                   ` Sai Prakash Ranjan
2020-04-09  7:51                     ` Sai Prakash Ranjan
2020-04-09  9:17                     ` Suzuki K Poulose
2020-04-09  9:17                       ` Suzuki K Poulose
2020-04-09  9:34                       ` Sai Prakash Ranjan
2020-04-09  9:34                         ` Sai Prakash Ranjan
2020-04-23 12:21               ` Sai Prakash Ranjan
2020-04-23 12:21                 ` Sai Prakash Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb209f80-ac02-6321-dac4-ebf9ee6fa9a0@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.