From: Bernard Zhao <bernard@vivo.com>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Lyude Paul" <lyude@redhat.com>,
"Dhinakaran Pandiyan" <dhinakaran.pandiyan@intel.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Andrzej Pietrasiewicz" <andrzej.p@collabora.com>,
"José Roberto de Souza" <jose.souza@intel.com>,
"Bernard Zhao" <bernard@vivo.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com
Subject: [PATCH] amdgpu_connector_set_property, fix error branch not return errno
Date: Sat, 18 Apr 2020 02:27:20 -0700 [thread overview]
Message-ID: <1587202042-115745-1-git-send-email-bernard@vivo.com> (raw)
The "if(!encoder)" branch return the same value 0 of the success
branch, maybe return -EINVAL is more better.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
w
---
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index f355d9a..1f8c6b4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
if (!amdgpu_encoder->enc_priv)
- return 0;
+ return -EINVAL;
dig = amdgpu_encoder->enc_priv;
new_coherent_mode = val ? true : false;
@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
--
2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Bernard Zhao <bernard@vivo.com>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Lyude Paul" <lyude@redhat.com>,
"Dhinakaran Pandiyan" <dhinakaran.pandiyan@intel.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Andrzej Pietrasiewicz" <andrzej.p@collabora.com>,
"José Roberto de Souza" <jose.souza@intel.com>,
"Bernard Zhao" <bernard@vivo.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com
Subject: [PATCH] amdgpu_connector_set_property, fix error branch not return errno
Date: Sat, 18 Apr 2020 02:27:20 -0700 [thread overview]
Message-ID: <1587202042-115745-1-git-send-email-bernard@vivo.com> (raw)
The "if(!encoder)" branch return the same value 0 of the success
branch, maybe return -EINVAL is more better.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
w
---
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index f355d9a..1f8c6b4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
if (!amdgpu_encoder->enc_priv)
- return 0;
+ return -EINVAL;
dig = amdgpu_encoder->enc_priv;
new_coherent_mode = val ? true : false;
@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Bernard Zhao <bernard@vivo.com>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Lyude Paul" <lyude@redhat.com>,
"Dhinakaran Pandiyan" <dhinakaran.pandiyan@intel.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Andrzej Pietrasiewicz" <andrzej.p@collabora.com>,
"José Roberto de Souza" <jose.souza@intel.com>,
"Bernard Zhao" <bernard@vivo.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com
Subject: [PATCH] amdgpu_connector_set_property, fix error branch not return errno
Date: Sat, 18 Apr 2020 02:27:20 -0700 [thread overview]
Message-ID: <1587202042-115745-1-git-send-email-bernard@vivo.com> (raw)
The "if(!encoder)" branch return the same value 0 of the success
branch, maybe return -EINVAL is more better.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
w
---
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index f355d9a..1f8c6b4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
if (!amdgpu_encoder->enc_priv)
- return 0;
+ return -EINVAL;
dig = amdgpu_encoder->enc_priv;
new_coherent_mode = val ? true : false;
@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
/* need to find digital encoder on connector */
encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
if (!encoder)
- return 0;
+ return -EINVAL;
amdgpu_encoder = to_amdgpu_encoder(encoder);
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next reply other threads:[~2020-04-18 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 9:27 Bernard Zhao [this message]
2020-04-18 9:27 ` [PATCH] amdgpu_connector_set_property, fix error branch not return errno Bernard Zhao
2020-04-18 9:27 ` Bernard Zhao
2020-04-21 2:07 ` [PATCH v2] amdgpu: fixes error branch not return errno issue Bernard Zhao
2020-04-21 2:07 ` Bernard Zhao
2020-04-21 2:07 ` Bernard Zhao
2020-04-21 9:08 ` [add Markus.Elfring in mail list]Re:[PATCH " 赵军奎
2020-04-21 9:08 ` 赵军奎
2020-04-21 9:08 ` 赵军奎
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1587202042-115745-1-git-send-email-bernard@vivo.com \
--to=bernard@vivo.com \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrzej.p@collabora.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=narmstrong@baylibre.com \
--cc=opensource.kernel@vivo.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.