[PATCH] amdgpu_connector_set_property, fix error branch not return errno

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] amdgpu_connector_set_property, fix error branch not return errno
@ 2020-04-18  9:27 ` Bernard Zhao
  0 siblings, 0 replies; 9+ messages in thread
From: Bernard Zhao @ 2020-04-18  9:27 UTC (permalink / raw)
  To: Alex Deucher, Christian König, David (ChunMing) Zhou,
	David Airlie, Daniel Vetter, Sam Ravnborg, Lyude Paul,
	Dhinakaran Pandiyan, Neil Armstrong, Andrzej Pietrasiewicz,
	José Roberto de Souza, Bernard Zhao, amd-gfx, dri-devel,
	linux-kernel
  Cc: opensource.kernel

The "if(!encoder)" branch return the same value 0 of the success
branch, maybe return -EINVAL is more better.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
w
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index f355d9a..1f8c6b4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
 		if (!amdgpu_encoder->enc_priv)
-			return 0;
+			return -EINVAL;
 
 		dig = amdgpu_encoder->enc_priv;
 		new_coherent_mode = val ? true : false;
@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH] amdgpu_connector_set_property, fix error branch not return errno
@ 2020-04-18  9:27 ` Bernard Zhao
  0 siblings, 0 replies; 9+ messages in thread
From: Bernard Zhao @ 2020-04-18  9:27 UTC (permalink / raw)
  To: Alex Deucher, Christian König, David (ChunMing) Zhou,
	David Airlie, Daniel Vetter, Sam Ravnborg, Lyude Paul,
	Dhinakaran Pandiyan, Neil Armstrong, Andrzej Pietrasiewicz,
	José Roberto de Souza, Bernard Zhao, amd-gfx, dri-devel,
	linux-kernel
  Cc: opensource.kernel

The "if(!encoder)" branch return the same value 0 of the success
branch, maybe return -EINVAL is more better.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
w
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index f355d9a..1f8c6b4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
 		if (!amdgpu_encoder->enc_priv)
-			return 0;
+			return -EINVAL;
 
 		dig = amdgpu_encoder->enc_priv;
 		new_coherent_mode = val ? true : false;
@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH] amdgpu_connector_set_property, fix error branch not return errno
@ 2020-04-18  9:27 ` Bernard Zhao
  0 siblings, 0 replies; 9+ messages in thread
From: Bernard Zhao @ 2020-04-18  9:27 UTC (permalink / raw)
  To: Alex Deucher, Christian König, David (ChunMing) Zhou,
	David Airlie, Daniel Vetter, Sam Ravnborg, Lyude Paul,
	Dhinakaran Pandiyan, Neil Armstrong, Andrzej Pietrasiewicz,
	José Roberto de Souza, Bernard Zhao, amd-gfx, dri-devel,
	linux-kernel
  Cc: opensource.kernel

The "if(!encoder)" branch return the same value 0 of the success
branch, maybe return -EINVAL is more better.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
w
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index f355d9a..1f8c6b4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
 		if (!amdgpu_encoder->enc_priv)
-			return 0;
+			return -EINVAL;
 
 		dig = amdgpu_encoder->enc_priv;
 		new_coherent_mode = val ? true : false;
@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2] amdgpu: fixes error branch not return errno issue
  2020-04-18  9:27 ` Bernard Zhao
  (?)
@ 2020-04-21  2:07   ` Bernard Zhao
  -1 siblings, 0 replies; 9+ messages in thread
From: Bernard Zhao @ 2020-04-21  2:07 UTC (permalink / raw)
  To: Alex Deucher, Christian König, David (ChunMing) Zhou,
	David Airlie, Daniel Vetter, Lyude Paul, Sam Ravnborg,
	Bernard Zhao, José Roberto de Souza, Andrzej Pietrasiewicz,
	amd-gfx, dri-devel, linux-kernel
  Cc: opensource.kernel

The "if(!encoder)" branch return the same value 0 of the success
branch, maybe return -EINVAL is more better.

Signed-off-by: Bernard Zhao <bernard@vivo.com>

---
Changes since V1:
* commit message improve
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index f355d9a..1f8c6b4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
 		if (!amdgpu_encoder->enc_priv)
-			return 0;
+			return -EINVAL;
 
 		dig = amdgpu_encoder->enc_priv;
 		new_coherent_mode = val ? true : false;
@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2] amdgpu: fixes error branch not return errno issue
@ 2020-04-21  2:07   ` Bernard Zhao
  0 siblings, 0 replies; 9+ messages in thread
From: Bernard Zhao @ 2020-04-21  2:07 UTC (permalink / raw)
  To: Alex Deucher, Christian König, David (ChunMing) Zhou,
	David Airlie, Daniel Vetter, Lyude Paul, Sam Ravnborg,
	Bernard Zhao, José Roberto de Souza, Andrzej Pietrasiewicz,
	amd-gfx, dri-devel, linux-kernel
  Cc: opensource.kernel

The "if(!encoder)" branch return the same value 0 of the success
branch, maybe return -EINVAL is more better.

Signed-off-by: Bernard Zhao <bernard@vivo.com>

---
Changes since V1:
* commit message improve
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index f355d9a..1f8c6b4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
 		if (!amdgpu_encoder->enc_priv)
-			return 0;
+			return -EINVAL;
 
 		dig = amdgpu_encoder->enc_priv;
 		new_coherent_mode = val ? true : false;
@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2] amdgpu: fixes error branch not return errno issue
@ 2020-04-21  2:07   ` Bernard Zhao
  0 siblings, 0 replies; 9+ messages in thread
From: Bernard Zhao @ 2020-04-21  2:07 UTC (permalink / raw)
  To: Alex Deucher, Christian König, David (ChunMing) Zhou,
	David Airlie, Daniel Vetter, Lyude Paul, Sam Ravnborg,
	Bernard Zhao, José Roberto de Souza, Andrzej Pietrasiewicz,
	amd-gfx, dri-devel, linux-kernel
  Cc: opensource.kernel

The "if(!encoder)" branch return the same value 0 of the success
branch, maybe return -EINVAL is more better.

Signed-off-by: Bernard Zhao <bernard@vivo.com>

---
Changes since V1:
* commit message improve
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index f355d9a..1f8c6b4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
 		if (!amdgpu_encoder->enc_priv)
-			return 0;
+			return -EINVAL;
 
 		dig = amdgpu_encoder->enc_priv;
 		new_coherent_mode = val ? true : false;
@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
 		/* need to find digital encoder on connector */
 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
 		if (!encoder)
-			return 0;
+			return -EINVAL;
 
 		amdgpu_encoder = to_amdgpu_encoder(encoder);
 
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [add Markus.Elfring in mail list]Re:[PATCH v2] amdgpu: fixes error branch not return errno issue
  2020-04-21  2:07   ` Bernard Zhao
  (?)
@ 2020-04-21  9:08     ` 赵军奎
  -1 siblings, 0 replies; 9+ messages in thread
From: 赵军奎 @ 2020-04-21  9:08 UTC (permalink / raw)
  To: Markus.Elfring
  Cc: Alex Deucher, Christian König, David (ChunMing) Zhou,
	David Airlie, Daniel Vetter, Lyude Paul, Sam Ravnborg,
	José Roberto de Souza, Andrzej Pietrasiewicz, amd-gfx,
	dri-devel, linux-kernel, opensource.kernel



From: Bernard Zhao <bernard@vivo.com>
Date: 2020-04-21 10:07:50
To:  Alex Deucher <alexander.deucher@amd.com>,"Christian König" <christian.koenig@amd.com>,"David (ChunMing) Zhou" <David1.Zhou@amd.com>,David Airlie <airlied@linux.ie>,Daniel Vetter <daniel@ffwll.ch>,Lyude Paul <lyude@redhat.com>,Sam Ravnborg <sam@ravnborg.org>,Bernard Zhao <bernard@vivo.com>,"José Roberto de Souza" <jose.souza@intel.com>,Andrzej Pietrasiewicz <andrzej.p@collabora.com>,amd-gfx@lists.freedesktop.org,dri-devel@lists.freedesktop.org,linux-kernel@vger.kernel.org
Cc:  opensource.kernel@vivo.com
Subject: [PATCH v2] amdgpu: fixes error branch not return errno issue>The "if(!encoder)" branch return the same value 0 of the success
>branch, maybe return -EINVAL is more better.
>
>Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
>---
>Changes since V1:
>* commit message improve
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>index f355d9a..1f8c6b4 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
> 		if (!amdgpu_encoder->enc_priv)
>-			return 0;
>+			return -EINVAL;
> 
> 		dig = amdgpu_encoder->enc_priv;
> 		new_coherent_mode = val ? true : false;
>@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>-- 
>2.7.4

>

add Markus.Elfring in mail list 
Regards,
Bernard


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [add Markus.Elfring in mail list]Re:[PATCH v2] amdgpu: fixes error branch not return errno issue
@ 2020-04-21  9:08     ` 赵军奎
  0 siblings, 0 replies; 9+ messages in thread
From: 赵军奎 @ 2020-04-21  9:08 UTC (permalink / raw)
  To: Markus.Elfring
  Cc: David (ChunMing) Zhou, opensource.kernel, David Airlie,
	dri-devel, linux-kernel, José Roberto de Souza,
	Andrzej Pietrasiewicz, amd-gfx, Daniel Vetter, Alex Deucher,
	Sam Ravnborg, Christian König



From: Bernard Zhao <bernard@vivo.com>
Date: 2020-04-21 10:07:50
To:  Alex Deucher <alexander.deucher@amd.com>,"Christian König" <christian.koenig@amd.com>,"David (ChunMing) Zhou" <David1.Zhou@amd.com>,David Airlie <airlied@linux.ie>,Daniel Vetter <daniel@ffwll.ch>,Lyude Paul <lyude@redhat.com>,Sam Ravnborg <sam@ravnborg.org>,Bernard Zhao <bernard@vivo.com>,"José Roberto de Souza" <jose.souza@intel.com>,Andrzej Pietrasiewicz <andrzej.p@collabora.com>,amd-gfx@lists.freedesktop.org,dri-devel@lists.freedesktop.org,linux-kernel@vger.kernel.org
Cc:  opensource.kernel@vivo.com
Subject: [PATCH v2] amdgpu: fixes error branch not return errno issue>The "if(!encoder)" branch return the same value 0 of the success
>branch, maybe return -EINVAL is more better.
>
>Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
>---
>Changes since V1:
>* commit message improve
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>index f355d9a..1f8c6b4 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
> 		if (!amdgpu_encoder->enc_priv)
>-			return 0;
>+			return -EINVAL;
> 
> 		dig = amdgpu_encoder->enc_priv;
> 		new_coherent_mode = val ? true : false;
>@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>-- 
>2.7.4

>

add Markus.Elfring in mail list 
Regards,
Bernard

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [add Markus.Elfring in mail list]Re:[PATCH v2] amdgpu: fixes error branch not return errno issue
@ 2020-04-21  9:08     ` 赵军奎
  0 siblings, 0 replies; 9+ messages in thread
From: 赵军奎 @ 2020-04-21  9:08 UTC (permalink / raw)
  To: Markus.Elfring
  Cc: opensource.kernel, David Airlie, dri-devel, linux-kernel,
	José Roberto de Souza, Andrzej Pietrasiewicz, amd-gfx,
	Alex Deucher, Sam Ravnborg, Christian König



From: Bernard Zhao <bernard@vivo.com>
Date: 2020-04-21 10:07:50
To:  Alex Deucher <alexander.deucher@amd.com>,"Christian König" <christian.koenig@amd.com>,"David (ChunMing) Zhou" <David1.Zhou@amd.com>,David Airlie <airlied@linux.ie>,Daniel Vetter <daniel@ffwll.ch>,Lyude Paul <lyude@redhat.com>,Sam Ravnborg <sam@ravnborg.org>,Bernard Zhao <bernard@vivo.com>,"José Roberto de Souza" <jose.souza@intel.com>,Andrzej Pietrasiewicz <andrzej.p@collabora.com>,amd-gfx@lists.freedesktop.org,dri-devel@lists.freedesktop.org,linux-kernel@vger.kernel.org
Cc:  opensource.kernel@vivo.com
Subject: [PATCH v2] amdgpu: fixes error branch not return errno issue>The "if(!encoder)" branch return the same value 0 of the success
>branch, maybe return -EINVAL is more better.
>
>Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
>---
>Changes since V1:
>* commit message improve
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>index f355d9a..1f8c6b4 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>@@ -474,12 +474,12 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
> 		if (!amdgpu_encoder->enc_priv)
>-			return 0;
>+			return -EINVAL;
> 
> 		dig = amdgpu_encoder->enc_priv;
> 		new_coherent_mode = val ? true : false;
>@@ -494,7 +494,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -509,7 +509,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -523,7 +523,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -537,7 +537,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>@@ -551,7 +551,7 @@ static int amdgpu_connector_set_property(struct drm_connector *connector,
> 		/* need to find digital encoder on connector */
> 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
> 		if (!encoder)
>-			return 0;
>+			return -EINVAL;
> 
> 		amdgpu_encoder = to_amdgpu_encoder(encoder);
> 
>-- 
>2.7.4

>

add Markus.Elfring in mail list 
Regards,
Bernard

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-04-22  6:55 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-18  9:27 [PATCH] amdgpu_connector_set_property, fix error branch not return errno Bernard Zhao
2020-04-18  9:27 ` Bernard Zhao
2020-04-18  9:27 ` Bernard Zhao
2020-04-21  2:07 ` [PATCH v2] amdgpu: fixes error branch not return errno issue Bernard Zhao
2020-04-21  2:07   ` Bernard Zhao
2020-04-21  2:07   ` Bernard Zhao
2020-04-21  9:08   ` [add Markus.Elfring in mail list]Re:[PATCH " 赵军奎
2020-04-21  9:08     ` 赵军奎
2020-04-21  9:08     ` 赵军奎

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.