All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 9/9] drm/i915/gt: Restore aggressive post-boost downclocking
Date: Mon, 27 Apr 2020 13:40:46 +0100	[thread overview]
Message-ID: <158799124667.17035.5417544090527568555@build.alporthouse.com> (raw)
In-Reply-To: <20200427085408.13879-9-chris@chris-wilson.co.uk>

Quoting Chris Wilson (2020-04-27 09:54:08)
> We reduced the clocks slowly after a boost event based on the
> observation that the smoothness of animations suffered. However, since
> reducing the evalution intervals, we should be able to respond to the
> rapidly fluctuating workload of a simple desktop animation and so
> restore the more aggressive downclocking.
> 
> References: 2a8862d2f3da ("drm/i915: Reduce the RPS shock")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

*** ANECDOTAL ***

In measurements on Icelake, the chrome power test [frankly a horrible
test that is mostly idle, and has no feedback on UX quality metrics]:

before:
7214.52,Joules,power/energy-pkg/,2302922017998,100.00,,
2927.24,Joules,power/energy-cores/,2302922022934,100.00,,
840.42,Joules,power/energy-gpu/,2302922024419,100.00,,
166620,M,i915/actual-frequency/,2302922026977,100.00,,
1905549106177,ns,i915/rc6-residency/,2302922028812,100.00,,
290532899942,ns,i915/rcs0-busy/,2302922032428,100.00,,
0,ns,i915/bcs0-busy/,2302922034987,100.00,,
0,ns,i915/vcs0-busy/,2302922034237,100.00,,

after:
6713.43,Joules,power/energy-pkg/,2228832095923,100.00,,
2802.07,Joules,power/energy-cores/,2228832104461,100.00,,
587.04,Joules,power/energy-gpu/,2228832106940,100.00,,
132124,M,i915/actual-frequency/,2228832095439,100.00,,
1957236452947,ns,i915/rc6-residency/,2228832089455,100.00,,
265365231893,ns,i915/rcs0-busy/,2228832089043,100.00,,
0,ns,i915/bcs0-busy/,2228832085764,100.00,,
0,ns,i915/vcs0-busy/,2228832084838,100.00,,

Some video playback (which is mostly pushing GL textures through to the
compositor, nothing uses libva):

before:
9512.58,Joules,power/energy-pkg/,995287278884,100.00,,
2631.12,Joules,power/energy-cores/,995287289129,100.00,,
3661.46,Joules,power/energy-gpu/,995287294283,100.00,,
715924,M,i915/actual-frequency/,995287298748,100.00,,
389009635708,ns,i915/rc6-residency/,995287303131,100.00,,
409781702935,ns,i915/rcs0-busy/,995287305584,100.00,,
0,ns,i915/bcs0-busy/,995287310428,100.00,,
0,ns,i915/vcs0-busy/,995287314214,100.00,,

after:
8013.46,Joules,power/energy-pkg/,994173360392,100.00,,
2077.22,Joules,power/energy-cores/,994173366417,100.00,,
2518.69,Joules,power/energy-gpu/,994173370072,100.00,,
464025,M,i915/actual-frequency/,994173363951,100.00,,
351530351036,ns,i915/rc6-residency/,994173363398,100.00,,
632114323426,ns,i915/rcs0-busy/,994173364895,100.00,,
0,ns,i915/bcs0-busy/,994173367723,100.00,,
0,ns,i915/vcs0-busy/,994173369162,100.00,,

I spot checked a few games during scenes where the GPU was not capped
out, and it was drawing about ~100MHz less for ~1W less.

*** ANECDOTAL ***

The other data point is a happy user in #1698 who was wise enough to
demand both smooth UX and low power.

We do have a huge issue in that we have no insight into P&P in CI.
Not even a single machine running a desktop config and playing back a
move and reporting power usage vs dropped frames. Nor even running the
battery tests to check that we do suspend in S3.

I spent some time trying to find some benchmarks we could use to measure
jank and power used and found nothing useful. The closest would be
wrapping rapl around gnome-shell-perf-tool, but that is still a long way
from capturing enough use cases.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-04-27 12:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27  8:54 [Intel-gfx] [PATCH 1/9] drm/i915/gt: Sanitize GT first Chris Wilson
2020-04-27  8:54 ` [Intel-gfx] [PATCH 2/9] drm/i915/gt: Fix up clock frequency Chris Wilson
2020-04-27 19:52   ` Andi Shyti
2020-04-27 20:03     ` Chris Wilson
2020-04-27  8:54 ` [Intel-gfx] [PATCH 3/9] drm/i915/execlists: Check preempt-timeout target before submit_ports Chris Wilson
2020-04-27  8:54 ` [Intel-gfx] [PATCH 4/9] drm/i915/gt: Always enable busy-stats for execlists Chris Wilson
2020-04-27  8:54 ` [Intel-gfx] [PATCH 5/9] drm/i915/gt: Move rps.enabled/active to flags Chris Wilson
2020-04-27 19:53   ` Andi Shyti
2020-04-27  8:54 ` [Intel-gfx] [PATCH 6/9] drm/i915/gt: Track use of RPS interrupts in flags Chris Wilson
2020-04-27  8:54 ` [Intel-gfx] [PATCH 7/9] drm/i915/gt: Switch to manual evaluation of RPS Chris Wilson
2020-04-27 16:39   ` Andi Shyti
2020-04-27  8:54 ` [Intel-gfx] [PATCH 8/9] drm/i915/gt: Apply the aggressive downclocking to parking Chris Wilson
2020-04-27 20:38   ` Andi Shyti
2020-04-27  8:54 ` [Intel-gfx] [PATCH 9/9] drm/i915/gt: Restore aggressive post-boost downclocking Chris Wilson
2020-04-27 12:40   ` Chris Wilson [this message]
2020-04-27 17:06     ` Chris Wilson
2020-04-27 20:42       ` Andi Shyti
2020-04-27  9:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/9] drm/i915/gt: Sanitize GT first Patchwork
2020-04-27  9:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-04-27 10:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-27 11:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-04-27 19:51 ` [Intel-gfx] [PATCH 1/9] " Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158799124667.17035.5417544090527568555@build.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.