* [PATCH] firmware: arm_sdei: Put the SDEI table after using it
@ 2020-05-09 10:52 Hanjun Guo
2020-05-18 18:59 ` James Morse
0 siblings, 1 reply; 3+ messages in thread
From: Hanjun Guo @ 2020-05-09 10:52 UTC (permalink / raw)
To: James Morse; +Cc: linux-arm-kernel, Hanjun Guo
The acpi_get_table() should be coupled with acpi_put_table() if
the mapped table is not used for runtime after the initialization
to release the table mapping, put the SDEI table after using it.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/firmware/arm_sdei.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
index 334c8be..5c42757 100644
--- a/drivers/firmware/arm_sdei.c
+++ b/drivers/firmware/arm_sdei.c
@@ -1113,6 +1113,7 @@ static bool __init sdei_present_acpi(void)
if (ACPI_FAILURE(status))
return false;
+ acpi_put_table(sdei_table_header);
pdev = platform_device_register_simple(sdei_driver.driver.name, 0, NULL,
0);
if (IS_ERR(pdev))
--
1.7.12.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: arm_sdei: Put the SDEI table after using it
2020-05-09 10:52 [PATCH] firmware: arm_sdei: Put the SDEI table after using it Hanjun Guo
@ 2020-05-18 18:59 ` James Morse
2020-05-19 1:53 ` Hanjun Guo
0 siblings, 1 reply; 3+ messages in thread
From: James Morse @ 2020-05-18 18:59 UTC (permalink / raw)
To: Hanjun Guo; +Cc: linux-arm-kernel
Hi Hanjun,
On 09/05/2020 11:52, Hanjun Guo wrote:
> The acpi_get_table() should be coupled with acpi_put_table() if
> the mapped table is not used for runtime after the initialization
> to release the table mapping, put the SDEI table after using it.
I thought this didn't really matter once ACPI had switched to its global mapping of the
tables...
> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> index 334c8be..5c42757 100644
> --- a/drivers/firmware/arm_sdei.c
> +++ b/drivers/firmware/arm_sdei.c
> @@ -1113,6 +1113,7 @@ static bool __init sdei_present_acpi(void)
> if (ACPI_FAILURE(status))
> return false;
>
> + acpi_put_table(sdei_table_header);
> pdev = platform_device_register_simple(sdei_driver.driver.name, 0, NULL,
> 0);
> if (IS_ERR(pdev))
>
This conflicts with Sudeep's patch that moved all this code. I'll rebase and repost it.
Thanks!
James
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: arm_sdei: Put the SDEI table after using it
2020-05-18 18:59 ` James Morse
@ 2020-05-19 1:53 ` Hanjun Guo
0 siblings, 0 replies; 3+ messages in thread
From: Hanjun Guo @ 2020-05-19 1:53 UTC (permalink / raw)
To: James Morse; +Cc: linux-arm-kernel
On 2020/5/19 2:59, James Morse wrote:
> Hi Hanjun,
>
> On 09/05/2020 11:52, Hanjun Guo wrote:
>> The acpi_get_table() should be coupled with acpi_put_table() if
>> the mapped table is not used for runtime after the initialization
>> to release the table mapping, put the SDEI table after using it.
>
> I thought this didn't really matter once ACPI had switched to its global mapping of the
> tables...
>
>
>> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
>> index 334c8be..5c42757 100644
>> --- a/drivers/firmware/arm_sdei.c
>> +++ b/drivers/firmware/arm_sdei.c
>> @@ -1113,6 +1113,7 @@ static bool __init sdei_present_acpi(void)
>> if (ACPI_FAILURE(status))
>> return false;
>>
>> + acpi_put_table(sdei_table_header);
>> pdev = platform_device_register_simple(sdei_driver.driver.name, 0, NULL,
>> 0);
>> if (IS_ERR(pdev))
>>
>
>
> This conflicts with Sudeep's patch that moved all this code. I'll rebase and repost it.
Thank you very much!
Regards,
Hanjun
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-19 1:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-09 10:52 [PATCH] firmware: arm_sdei: Put the SDEI table after using it Hanjun Guo
2020-05-18 18:59 ` James Morse
2020-05-19 1:53 ` Hanjun Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.