* [PATCH v2 0/2] staging: vt6656: vt6655: cleaning Makefile
@ 2020-05-10 10:13 ` Matej Dujava
0 siblings, 0 replies; 10+ messages in thread
From: Matej Dujava @ 2020-05-10 10:13 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, devel
Cc: Quentin Deslandes, linux-kernel, Matej Dujava
This patchset will remove unused definitions of C Macros, reorder variable definition and increase indentation to match visual block.
---
v2: spliting original patch to 2 separate patches
Matej Dujava (2):
staging: vt6656: vt6655: clean Makefiles
staging: vt6655: vt6656: change order of makefile variable definitions
drivers/staging/vt6655/Makefile | 27 ++++++++++++---------------
drivers/staging/vt6655/device_main.c | 1 -
drivers/staging/vt6656/Makefile | 7 ++-----
3 files changed, 14 insertions(+), 21 deletions(-)
--
2.26.2
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 0/2] staging: vt6656: vt6655: cleaning Makefile
@ 2020-05-10 10:13 ` Matej Dujava
0 siblings, 0 replies; 10+ messages in thread
From: Matej Dujava @ 2020-05-10 10:13 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, devel; +Cc: linux-kernel
This patchset will remove unused definitions of C Macros, reorder variable definition and increase indentation to match visual block.
---
v2: spliting original patch to 2 separate patches
Matej Dujava (2):
staging: vt6656: vt6655: clean Makefiles
staging: vt6655: vt6656: change order of makefile variable definitions
drivers/staging/vt6655/Makefile | 27 ++++++++++++---------------
drivers/staging/vt6655/device_main.c | 1 -
drivers/staging/vt6656/Makefile | 7 ++-----
3 files changed, 14 insertions(+), 21 deletions(-)
--
2.26.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/2] staging: vt6656: vt6655: clean Makefiles
2020-05-10 10:13 ` Matej Dujava
@ 2020-05-10 10:13 ` Matej Dujava
-1 siblings, 0 replies; 10+ messages in thread
From: Matej Dujava @ 2020-05-10 10:13 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, devel
Cc: Quentin Deslandes, linux-kernel, Matej Dujava
This patch is removing CFLAGS that are defining flags that are not used.
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
---
drivers/staging/vt6655/Makefile | 3 ---
drivers/staging/vt6655/device_main.c | 1 -
drivers/staging/vt6656/Makefile | 3 ---
3 files changed, 7 deletions(-)
diff --git a/drivers/staging/vt6655/Makefile b/drivers/staging/vt6655/Makefile
index a151f30fc46f..e70357ec0af8 100644
--- a/drivers/staging/vt6655/Makefile
+++ b/drivers/staging/vt6655/Makefile
@@ -1,7 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
-# TODO: all of these should be removed
-ccflags-y := -DLINUX -D__KERNEL__ -D__NO_VERSION__
-ccflags-y += -DHOSTAP
vt6655_stage-y += device_main.o \
card.o \
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 5889023d19c4..41cbec4134b0 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -32,7 +32,6 @@
*
* Revision History:
*/
-#undef __NO_VERSION__
#include <linux/file.h>
#include "device.h"
diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile
index a0f3862dea75..f696a9d7a143 100644
--- a/drivers/staging/vt6656/Makefile
+++ b/drivers/staging/vt6656/Makefile
@@ -1,7 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
-# TODO: all of these should be removed
-ccflags-y := -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__
-ccflags-y += -DHOSTAP
vt6656_stage-y += main_usb.o \
card.o \
--
2.26.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 1/2] staging: vt6656: vt6655: clean Makefiles
@ 2020-05-10 10:13 ` Matej Dujava
0 siblings, 0 replies; 10+ messages in thread
From: Matej Dujava @ 2020-05-10 10:13 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, devel; +Cc: linux-kernel
This patch is removing CFLAGS that are defining flags that are not used.
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
---
drivers/staging/vt6655/Makefile | 3 ---
drivers/staging/vt6655/device_main.c | 1 -
drivers/staging/vt6656/Makefile | 3 ---
3 files changed, 7 deletions(-)
diff --git a/drivers/staging/vt6655/Makefile b/drivers/staging/vt6655/Makefile
index a151f30fc46f..e70357ec0af8 100644
--- a/drivers/staging/vt6655/Makefile
+++ b/drivers/staging/vt6655/Makefile
@@ -1,7 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
-# TODO: all of these should be removed
-ccflags-y := -DLINUX -D__KERNEL__ -D__NO_VERSION__
-ccflags-y += -DHOSTAP
vt6655_stage-y += device_main.o \
card.o \
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 5889023d19c4..41cbec4134b0 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -32,7 +32,6 @@
*
* Revision History:
*/
-#undef __NO_VERSION__
#include <linux/file.h>
#include "device.h"
diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile
index a0f3862dea75..f696a9d7a143 100644
--- a/drivers/staging/vt6656/Makefile
+++ b/drivers/staging/vt6656/Makefile
@@ -1,7 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
-# TODO: all of these should be removed
-ccflags-y := -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__
-ccflags-y += -DHOSTAP
vt6656_stage-y += main_usb.o \
card.o \
--
2.26.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] staging: vt6656: vt6655: clean Makefiles
2020-05-10 10:13 ` Matej Dujava
@ 2020-05-13 11:55 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2020-05-13 11:55 UTC (permalink / raw)
To: Matej Dujava; +Cc: Forest Bond, devel, linux-kernel
On Sun, May 10, 2020 at 12:13:34PM +0200, Matej Dujava wrote:
> This patch is removing CFLAGS that are defining flags that are not used.
>
> Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
> ---
> drivers/staging/vt6655/Makefile | 3 ---
> drivers/staging/vt6655/device_main.c | 1 -
This file is not a Makefile :(
Please properly describe patches.
Also state below the --- line what changed from the first version,
otherwise I have no idea.
Please fix up and send a v3 series.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] staging: vt6656: vt6655: clean Makefiles
@ 2020-05-13 11:55 ` Greg Kroah-Hartman
0 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2020-05-13 11:55 UTC (permalink / raw)
To: Matej Dujava; +Cc: devel, Forest Bond, linux-kernel
On Sun, May 10, 2020 at 12:13:34PM +0200, Matej Dujava wrote:
> This patch is removing CFLAGS that are defining flags that are not used.
>
> Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
> ---
> drivers/staging/vt6655/Makefile | 3 ---
> drivers/staging/vt6655/device_main.c | 1 -
This file is not a Makefile :(
Please properly describe patches.
Also state below the --- line what changed from the first version,
otherwise I have no idea.
Please fix up and send a v3 series.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile variable definitions
2020-05-10 10:13 ` Matej Dujava
@ 2020-05-10 10:13 ` Matej Dujava
-1 siblings, 0 replies; 10+ messages in thread
From: Matej Dujava @ 2020-05-10 10:13 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, devel
Cc: Quentin Deslandes, linux-kernel, Matej Dujava
This patch will add indentation to multiline variable and put obj-$(CONFIG_X)
at the begining of the file.
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
---
drivers/staging/vt6655/Makefile | 24 ++++++++++++------------
drivers/staging/vt6656/Makefile | 4 ++--
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/vt6655/Makefile b/drivers/staging/vt6655/Makefile
index e70357ec0af8..eda08a1516ab 100644
--- a/drivers/staging/vt6655/Makefile
+++ b/drivers/staging/vt6655/Makefile
@@ -1,15 +1,15 @@
# SPDX-License-Identifier: GPL-2.0
-vt6655_stage-y += device_main.o \
- card.o \
- channel.o \
- mac.o \
- baseband.o \
- rxtx.o \
- dpc.o \
- power.o \
- srom.o \
- key.o \
- rf.o
-
obj-$(CONFIG_VT6655) += vt6655_stage.o
+
+vt6655_stage-y += device_main.o \
+ card.o \
+ channel.o \
+ mac.o \
+ baseband.o \
+ rxtx.o \
+ dpc.o \
+ power.o \
+ srom.o \
+ key.o \
+ rf.o
diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile
index f696a9d7a143..aac323d6a684 100644
--- a/drivers/staging/vt6656/Makefile
+++ b/drivers/staging/vt6656/Makefile
@@ -1,5 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
+obj-$(CONFIG_VT6656) += vt6656_stage.o
+
vt6656_stage-y += main_usb.o \
card.o \
mac.o \
@@ -11,5 +13,3 @@ vt6656_stage-y += main_usb.o \
rf.o \
usbpipe.o \
channel.o
-
-obj-$(CONFIG_VT6656) += vt6656_stage.o
--
2.26.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile variable definitions
@ 2020-05-10 10:13 ` Matej Dujava
0 siblings, 0 replies; 10+ messages in thread
From: Matej Dujava @ 2020-05-10 10:13 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, devel; +Cc: linux-kernel
This patch will add indentation to multiline variable and put obj-$(CONFIG_X)
at the begining of the file.
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
---
drivers/staging/vt6655/Makefile | 24 ++++++++++++------------
drivers/staging/vt6656/Makefile | 4 ++--
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/vt6655/Makefile b/drivers/staging/vt6655/Makefile
index e70357ec0af8..eda08a1516ab 100644
--- a/drivers/staging/vt6655/Makefile
+++ b/drivers/staging/vt6655/Makefile
@@ -1,15 +1,15 @@
# SPDX-License-Identifier: GPL-2.0
-vt6655_stage-y += device_main.o \
- card.o \
- channel.o \
- mac.o \
- baseband.o \
- rxtx.o \
- dpc.o \
- power.o \
- srom.o \
- key.o \
- rf.o
-
obj-$(CONFIG_VT6655) += vt6655_stage.o
+
+vt6655_stage-y += device_main.o \
+ card.o \
+ channel.o \
+ mac.o \
+ baseband.o \
+ rxtx.o \
+ dpc.o \
+ power.o \
+ srom.o \
+ key.o \
+ rf.o
diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile
index f696a9d7a143..aac323d6a684 100644
--- a/drivers/staging/vt6656/Makefile
+++ b/drivers/staging/vt6656/Makefile
@@ -1,5 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
+obj-$(CONFIG_VT6656) += vt6656_stage.o
+
vt6656_stage-y += main_usb.o \
card.o \
mac.o \
@@ -11,5 +13,3 @@ vt6656_stage-y += main_usb.o \
rf.o \
usbpipe.o \
channel.o
-
-obj-$(CONFIG_VT6656) += vt6656_stage.o
--
2.26.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile variable definitions
2020-05-10 10:13 ` Matej Dujava
@ 2020-05-13 11:56 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2020-05-13 11:56 UTC (permalink / raw)
To: Matej Dujava; +Cc: Forest Bond, devel, linux-kernel
On Sun, May 10, 2020 at 12:13:35PM +0200, Matej Dujava wrote:
> This patch will add indentation to multiline variable and put obj-$(CONFIG_X)
> at the begining of the file.
Why change the order? What does that fix? Why do this? You say what
you do here, but not why. And without that, I can't see the reason to
accept this patch :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-05-13 11:56 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-10 10:13 [PATCH v2 0/2] staging: vt6656: vt6655: cleaning Makefile Matej Dujava
2020-05-10 10:13 ` Matej Dujava
2020-05-10 10:13 ` [PATCH v2 1/2] staging: vt6656: vt6655: clean Makefiles Matej Dujava
2020-05-10 10:13 ` Matej Dujava
2020-05-13 11:55 ` Greg Kroah-Hartman
2020-05-13 11:55 ` Greg Kroah-Hartman
2020-05-10 10:13 ` [PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile variable definitions Matej Dujava
2020-05-10 10:13 ` Matej Dujava
2020-05-13 11:56 ` Greg Kroah-Hartman
2020-05-13 11:56 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.