* [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting
@ 2020-05-13 6:03 Rajendra Nayak
2020-05-27 19:36 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Rajendra Nayak @ 2020-05-13 6:03 UTC (permalink / raw)
To: stanimir.varbanov, robh+dt, agross, bjorn.andersson
Cc: linux-arm-msm, linux-media, devicetree, linux-kernel, mka,
Rajendra Nayak
Add an optional power domain which when specified can be used for
setting the performance state of Venus.
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++-
Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
index 764affa..ac1ed64 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
@@ -25,12 +25,16 @@ properties:
maxItems: 1
power-domains:
- maxItems: 2
+ minItems: 2
+ maxItems: 3
power-domain-names:
+ minItems: 2
+ maxItems: 3
items:
- const: venus
- const: vcodec0
+ - const: opp-pd
clocks:
maxItems: 5
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
index 8552f4a..9af78cb 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
@@ -25,13 +25,17 @@ properties:
maxItems: 1
power-domains:
- maxItems: 3
+ minItems: 3
+ maxItems: 4
power-domain-names:
+ minItems: 3
+ maxItems: 4
items:
- const: venus
- const: vcodec0
- const: vcodec1
+ - const: opp-pd
clocks:
maxItems: 7
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting
2020-05-13 6:03 [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting Rajendra Nayak
@ 2020-05-27 19:36 ` Rob Herring
2020-06-01 5:56 ` Rajendra Nayak
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2020-05-27 19:36 UTC (permalink / raw)
To: Rajendra Nayak
Cc: stanimir.varbanov, agross, bjorn.andersson, linux-arm-msm,
linux-media, devicetree, linux-kernel, mka
On Wed, May 13, 2020 at 11:33:27AM +0530, Rajendra Nayak wrote:
> Add an optional power domain which when specified can be used for
> setting the performance state of Venus.
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
> Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++-
> Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> index 764affa..ac1ed64 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> @@ -25,12 +25,16 @@ properties:
> maxItems: 1
>
> power-domains:
> - maxItems: 2
> + minItems: 2
> + maxItems: 3
>
> power-domain-names:
> + minItems: 2
> + maxItems: 3
> items:
> - const: venus
> - const: vcodec0
> + - const: opp-pd
Humm, looks suspicious. This is a phyical power island in this block?
Because that's what 'power-domains' are supposed to represent. Not $os
pm-domain construct.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting
2020-05-27 19:36 ` Rob Herring
@ 2020-06-01 5:56 ` Rajendra Nayak
2020-07-01 11:20 ` Rajendra Nayak
0 siblings, 1 reply; 5+ messages in thread
From: Rajendra Nayak @ 2020-06-01 5:56 UTC (permalink / raw)
To: Rob Herring
Cc: stanimir.varbanov, agross, bjorn.andersson, linux-arm-msm,
linux-media, devicetree, linux-kernel, mka
On 5/28/2020 1:06 AM, Rob Herring wrote:
> On Wed, May 13, 2020 at 11:33:27AM +0530, Rajendra Nayak wrote:
>> Add an optional power domain which when specified can be used for
>> setting the performance state of Venus.
>>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++-
>> Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++-
>> 2 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>> index 764affa..ac1ed64 100644
>> --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>> +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>> @@ -25,12 +25,16 @@ properties:
>> maxItems: 1
>>
>> power-domains:
>> - maxItems: 2
>> + minItems: 2
>> + maxItems: 3
>>
>> power-domain-names:
>> + minItems: 2
>> + maxItems: 3
>> items:
>> - const: venus
>> - const: vcodec0
>> + - const: opp-pd
>
> Humm, looks suspicious. This is a phyical power island in this block?
yes, this is used to represent the physical 'cx' power island in the SoC
(Its a shared power island, not a power island specific to this block)
that can be scaled to different 'performance levels' based on the frequency
the codec is expected to run at.
> Because that's what 'power-domains' are supposed to represent. Not $os
> pm-domain construct.
>
> Rob
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting
2020-06-01 5:56 ` Rajendra Nayak
@ 2020-07-01 11:20 ` Rajendra Nayak
2020-07-09 11:09 ` Rajendra Nayak
0 siblings, 1 reply; 5+ messages in thread
From: Rajendra Nayak @ 2020-07-01 11:20 UTC (permalink / raw)
To: Rob Herring
Cc: stanimir.varbanov, agross, bjorn.andersson, linux-arm-msm,
linux-media, devicetree, linux-kernel, mka
On 6/1/2020 11:26 AM, Rajendra Nayak wrote:
>
> On 5/28/2020 1:06 AM, Rob Herring wrote:
>> On Wed, May 13, 2020 at 11:33:27AM +0530, Rajendra Nayak wrote:
>>> Add an optional power domain which when specified can be used for
>>> setting the performance state of Venus.
>>>
>>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>>> ---
>>> Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++-
>>> Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++-
>>> 2 files changed, 10 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>>> index 764affa..ac1ed64 100644
>>> --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>>> +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>>> @@ -25,12 +25,16 @@ properties:
>>> maxItems: 1
>>> power-domains:
>>> - maxItems: 2
>>> + minItems: 2
>>> + maxItems: 3
>>> power-domain-names:
>>> + minItems: 2
>>> + maxItems: 3
>>> items:
>>> - const: venus
>>> - const: vcodec0
>>> + - const: opp-pd
>>
>> Humm, looks suspicious. This is a phyical power island in this block?
>
> yes, this is used to represent the physical 'cx' power island in the SoC
> (Its a shared power island, not a power island specific to this block)
> that can be scaled to different 'performance levels' based on the frequency
> the codec is expected to run at.
Rob, Did you have any other concerns here? Should I be re-posting this?
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting
2020-07-01 11:20 ` Rajendra Nayak
@ 2020-07-09 11:09 ` Rajendra Nayak
0 siblings, 0 replies; 5+ messages in thread
From: Rajendra Nayak @ 2020-07-09 11:09 UTC (permalink / raw)
To: Rob Herring
Cc: stanimir.varbanov, agross, bjorn.andersson, linux-arm-msm,
linux-media, devicetree, linux-kernel, mka
On 7/1/2020 4:50 PM, Rajendra Nayak wrote:
>
> On 6/1/2020 11:26 AM, Rajendra Nayak wrote:
>>
>> On 5/28/2020 1:06 AM, Rob Herring wrote:
>>> On Wed, May 13, 2020 at 11:33:27AM +0530, Rajendra Nayak wrote:
>>>> Add an optional power domain which when specified can be used for
>>>> setting the performance state of Venus.
>>>>
>>>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>>>> ---
>>>> Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++-
>>>> Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++-
>>>> 2 files changed, 10 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>>>> index 764affa..ac1ed64 100644
>>>> --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>>>> +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>>>> @@ -25,12 +25,16 @@ properties:
>>>> maxItems: 1
>>>> power-domains:
>>>> - maxItems: 2
>>>> + minItems: 2
>>>> + maxItems: 3
>>>> power-domain-names:
>>>> + minItems: 2
>>>> + maxItems: 3
>>>> items:
>>>> - const: venus
>>>> - const: vcodec0
>>>> + - const: opp-pd
>>>
>>> Humm, looks suspicious. This is a phyical power island in this block?
>>
>> yes, this is used to represent the physical 'cx' power island in the SoC
>> (Its a shared power island, not a power island specific to this block)
>> that can be scaled to different 'performance levels' based on the frequency
>> the codec is expected to run at.
>
> Rob, Did you have any other concerns here? Should I be re-posting this?
Rob, ping.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-09 11:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 6:03 [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting Rajendra Nayak
2020-05-27 19:36 ` Rob Herring
2020-06-01 5:56 ` Rajendra Nayak
2020-07-01 11:20 ` Rajendra Nayak
2020-07-09 11:09 ` Rajendra Nayak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.