* [PATCH] perf powerpc: Don't ignore sym-handling.c file
@ 2020-05-09 11:21 Ravi Bangoria
2020-05-11 18:15 ` Sandipan Das
2020-05-12 13:59 ` Leo Yan
0 siblings, 2 replies; 5+ messages in thread
From: Ravi Bangoria @ 2020-05-09 11:21 UTC (permalink / raw)
To: acme; +Cc: leo.yan, sandipan, jolsa, naveen.n.rao, ravi.bangoria, linux-kernel
Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
removed powerpc specific sym-handling.c file from Build. This wasn't
caught by build CI because all functions in this file are declared
as __weak in common code. Fix it.
Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
Reported-by: Sandipan Das <sandipan@linux.ibm.com>
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
---
tools/perf/arch/powerpc/util/Build | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
index e5c9504f8586..e86e210bf514 100644
--- a/tools/perf/arch/powerpc/util/Build
+++ b/tools/perf/arch/powerpc/util/Build
@@ -2,6 +2,7 @@ perf-y += header.o
perf-y += kvm-stat.o
perf-y += perf_regs.o
perf-y += mem-events.o
+perf-y += sym-handling.o
perf-$(CONFIG_DWARF) += dwarf-regs.o
perf-$(CONFIG_DWARF) += skip-callchain-idx.o
--
2.21.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file
2020-05-09 11:21 [PATCH] perf powerpc: Don't ignore sym-handling.c file Ravi Bangoria
@ 2020-05-11 18:15 ` Sandipan Das
2020-05-12 13:27 ` Arnaldo Carvalho de Melo
2020-05-12 13:59 ` Leo Yan
1 sibling, 1 reply; 5+ messages in thread
From: Sandipan Das @ 2020-05-11 18:15 UTC (permalink / raw)
To: Ravi Bangoria, acme; +Cc: leo.yan, jolsa, naveen.n.rao, linux-kernel
On 09/05/20 4:51 pm, Ravi Bangoria wrote:
> Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> removed powerpc specific sym-handling.c file from Build. This wasn't
> caught by build CI because all functions in this file are declared
> as __weak in common code. Fix it.
>
> Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> Reported-by: Sandipan Das <sandipan@linux.ibm.com>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> ---
> tools/perf/arch/powerpc/util/Build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
> index e5c9504f8586..e86e210bf514 100644
> --- a/tools/perf/arch/powerpc/util/Build
> +++ b/tools/perf/arch/powerpc/util/Build
> @@ -2,6 +2,7 @@ perf-y += header.o
> perf-y += kvm-stat.o
> perf-y += perf_regs.o
> perf-y += mem-events.o
> +perf-y += sym-handling.o
>
> perf-$(CONFIG_DWARF) += dwarf-regs.o
> perf-$(CONFIG_DWARF) += skip-callchain-idx.o
>
Thanks for fixing this!
Acked-by: Sandipan Das <sandipan@linux.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file
2020-05-11 18:15 ` Sandipan Das
@ 2020-05-12 13:27 ` Arnaldo Carvalho de Melo
2020-05-13 14:16 ` Naveen N. Rao
0 siblings, 1 reply; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-05-12 13:27 UTC (permalink / raw)
To: Sandipan Das; +Cc: Ravi Bangoria, leo.yan, jolsa, naveen.n.rao, linux-kernel
Em Mon, May 11, 2020 at 11:45:09PM +0530, Sandipan Das escreveu:
>
> On 09/05/20 4:51 pm, Ravi Bangoria wrote:
> > Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> > removed powerpc specific sym-handling.c file from Build. This wasn't
> > caught by build CI because all functions in this file are declared
> > as __weak in common code. Fix it.
> >
> > Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> > Reported-by: Sandipan Das <sandipan@linux.ibm.com>
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> > ---
> > tools/perf/arch/powerpc/util/Build | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
> > index e5c9504f8586..e86e210bf514 100644
> > --- a/tools/perf/arch/powerpc/util/Build
> > +++ b/tools/perf/arch/powerpc/util/Build
> > @@ -2,6 +2,7 @@ perf-y += header.o
> > perf-y += kvm-stat.o
> > perf-y += perf_regs.o
> > perf-y += mem-events.o
> > +perf-y += sym-handling.o
> >
> > perf-$(CONFIG_DWARF) += dwarf-regs.o
> > perf-$(CONFIG_DWARF) += skip-callchain-idx.o
> >
>
> Thanks for fixing this!
>
> Acked-by: Sandipan Das <sandipan@linux.ibm.com>
Leo, Naveen, can you comment on this?
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file
2020-05-09 11:21 [PATCH] perf powerpc: Don't ignore sym-handling.c file Ravi Bangoria
2020-05-11 18:15 ` Sandipan Das
@ 2020-05-12 13:59 ` Leo Yan
1 sibling, 0 replies; 5+ messages in thread
From: Leo Yan @ 2020-05-12 13:59 UTC (permalink / raw)
To: Ravi Bangoria; +Cc: acme, sandipan, jolsa, naveen.n.rao, linux-kernel
On Sat, May 09, 2020 at 04:51:13PM +0530, Ravi Bangoria wrote:
> Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> removed powerpc specific sym-handling.c file from Build. This wasn't
> caught by build CI because all functions in this file are declared
> as __weak in common code. Fix it.
>
> Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> Reported-by: Sandipan Das <sandipan@linux.ibm.com>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> ---
> tools/perf/arch/powerpc/util/Build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
> index e5c9504f8586..e86e210bf514 100644
> --- a/tools/perf/arch/powerpc/util/Build
> +++ b/tools/perf/arch/powerpc/util/Build
> @@ -2,6 +2,7 @@ perf-y += header.o
> perf-y += kvm-stat.o
> perf-y += perf_regs.o
> perf-y += mem-events.o
> +perf-y += sym-handling.o
My bad, thanks for fixing. FWIW:
Reviewed-by: Leo Yan <leo.yan@linaro.org>
> perf-$(CONFIG_DWARF) += dwarf-regs.o
> perf-$(CONFIG_DWARF) += skip-callchain-idx.o
> --
> 2.21.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file
2020-05-12 13:27 ` Arnaldo Carvalho de Melo
@ 2020-05-13 14:16 ` Naveen N. Rao
0 siblings, 0 replies; 5+ messages in thread
From: Naveen N. Rao @ 2020-05-13 14:16 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Sandipan Das
Cc: jolsa, leo.yan, linux-kernel, Ravi Bangoria
Arnaldo Carvalho de Melo wrote:
> Em Mon, May 11, 2020 at 11:45:09PM +0530, Sandipan Das escreveu:
>>
>> On 09/05/20 4:51 pm, Ravi Bangoria wrote:
>> > Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
>> > removed powerpc specific sym-handling.c file from Build. This wasn't
>> > caught by build CI because all functions in this file are declared
>> > as __weak in common code. Fix it.
>> >
>> > Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
>> > Reported-by: Sandipan Das <sandipan@linux.ibm.com>
>> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
>> > ---
>> > tools/perf/arch/powerpc/util/Build | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
>> > index e5c9504f8586..e86e210bf514 100644
>> > --- a/tools/perf/arch/powerpc/util/Build
>> > +++ b/tools/perf/arch/powerpc/util/Build
>> > @@ -2,6 +2,7 @@ perf-y += header.o
>> > perf-y += kvm-stat.o
>> > perf-y += perf_regs.o
>> > perf-y += mem-events.o
>> > +perf-y += sym-handling.o
>> >
>> > perf-$(CONFIG_DWARF) += dwarf-regs.o
>> > perf-$(CONFIG_DWARF) += skip-callchain-idx.o
>> >
>>
>> Thanks for fixing this!
>>
>> Acked-by: Sandipan Das <sandipan@linux.ibm.com>
>
> Leo, Naveen, can you comment on this?
Shoot -- this is a bad miss, I should have caught it. FWIW:
Reviewed-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Thanks,
Naveen
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-13 14:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-09 11:21 [PATCH] perf powerpc: Don't ignore sym-handling.c file Ravi Bangoria
2020-05-11 18:15 ` Sandipan Das
2020-05-12 13:27 ` Arnaldo Carvalho de Melo
2020-05-13 14:16 ` Naveen N. Rao
2020-05-12 13:59 ` Leo Yan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.