* [PATCH] powercap: remove unused local MSR define
@ 2020-05-21 6:44 Sumeet Pawnikar
2020-05-25 9:01 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Sumeet Pawnikar @ 2020-05-21 6:44 UTC (permalink / raw)
To: rui.zhang, rjw, linux-pm, linux-kernel
Cc: andriy.shevchenko, srinivas.pandruvada, sumeet.r.pawnikar
Remove unused PLATFORM_POWER_LIMIT MSR local definition from file
intel_rapl_common.c. This was missed while splitting old RAPL code
intel_rapl.c file into two new files intel_rapl_msr.c and
intel_rapl_common.c as per the commit 3382388d7148
("intel_rapl: abstract RAPL common code"). Currently, this #define
entry is being used only in intel_rapl_msr.c file and local definition
present in this file.
Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
drivers/powercap/intel_rapl_common.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
index eb328655bc01..5527a7c76309 100644
--- a/drivers/powercap/intel_rapl_common.c
+++ b/drivers/powercap/intel_rapl_common.c
@@ -26,9 +26,6 @@
#include <asm/cpu_device_id.h>
#include <asm/intel-family.h>
-/* Local defines */
-#define MSR_PLATFORM_POWER_LIMIT 0x0000065C
-
/* bitmasks for RAPL MSRs, used by primitive access functions */
#define ENERGY_STATUS_MASK 0xffffffff
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powercap: remove unused local MSR define
2020-05-21 6:44 [PATCH] powercap: remove unused local MSR define Sumeet Pawnikar
@ 2020-05-25 9:01 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2020-05-25 9:01 UTC (permalink / raw)
To: Sumeet Pawnikar
Cc: Zhang, Rui, Rafael J. Wysocki, Linux PM,
Linux Kernel Mailing List, Shevchenko, Andriy,
Srinivas Pandruvada
On Thu, May 21, 2020 at 8:38 AM Sumeet Pawnikar
<sumeet.r.pawnikar@intel.com> wrote:
>
> Remove unused PLATFORM_POWER_LIMIT MSR local definition from file
> intel_rapl_common.c. This was missed while splitting old RAPL code
> intel_rapl.c file into two new files intel_rapl_msr.c and
> intel_rapl_common.c as per the commit 3382388d7148
> ("intel_rapl: abstract RAPL common code"). Currently, this #define
> entry is being used only in intel_rapl_msr.c file and local definition
> present in this file.
>
> Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> ---
> drivers/powercap/intel_rapl_common.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
> index eb328655bc01..5527a7c76309 100644
> --- a/drivers/powercap/intel_rapl_common.c
> +++ b/drivers/powercap/intel_rapl_common.c
> @@ -26,9 +26,6 @@
> #include <asm/cpu_device_id.h>
> #include <asm/intel-family.h>
>
> -/* Local defines */
> -#define MSR_PLATFORM_POWER_LIMIT 0x0000065C
> -
> /* bitmasks for RAPL MSRs, used by primitive access functions */
> #define ENERGY_STATUS_MASK 0xffffffff
>
> --
Applied as 5.8 material, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powercap: remove unused local MSR define
2020-05-20 11:36 Sumeet Pawnikar
@ 2020-05-20 11:53 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2020-05-20 11:53 UTC (permalink / raw)
To: Sumeet Pawnikar
Cc: rui.zhang, rjw, linux-pm, linux-kernel, srinivas.pandruvada
On Wed, May 20, 2020 at 05:06:18PM +0530, Sumeet Pawnikar wrote:
> From: "Pawnikar, Sumeet" <sumeet.r.pawnikar@intel.com>
>
> Remove unused PLATFORM_POWER_LIMIT MSR local definition from file
> intel_rapl_common.c. This was missed while splitting old RAPL code
> intel_rapl.c file into two new files intel_rapl_msr.c and
> intel_rapl_common.c as per the commit 3382388d7148
> ("intel_rapl: abstract RAPL common code"). Currently, this #define
> entry is being used only in intel_rapl_msr.c file and local definition
> present in this file.
> Signed-off-by: Pawnikar, Sumeet <sumeet.r.pawnikar@intel.com>
Reorganize this to avoid comma (this also should make From: gone in the top of
this message). After addressing,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> ---
> drivers/powercap/intel_rapl_common.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
> index eb328655bc01..5527a7c76309 100644
> --- a/drivers/powercap/intel_rapl_common.c
> +++ b/drivers/powercap/intel_rapl_common.c
> @@ -26,9 +26,6 @@
> #include <asm/cpu_device_id.h>
> #include <asm/intel-family.h>
>
> -/* Local defines */
> -#define MSR_PLATFORM_POWER_LIMIT 0x0000065C
> -
> /* bitmasks for RAPL MSRs, used by primitive access functions */
> #define ENERGY_STATUS_MASK 0xffffffff
>
> --
> 1.7.9.5
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] powercap: remove unused local MSR define
@ 2020-05-20 11:36 Sumeet Pawnikar
2020-05-20 11:53 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Sumeet Pawnikar @ 2020-05-20 11:36 UTC (permalink / raw)
To: rui.zhang, rjw, linux-pm, linux-kernel
Cc: andriy.shevchenko, srinivas.pandruvada, sumeet.r.pawnikar
From: "Pawnikar, Sumeet" <sumeet.r.pawnikar@intel.com>
Remove unused PLATFORM_POWER_LIMIT MSR local definition from file
intel_rapl_common.c. This was missed while splitting old RAPL code
intel_rapl.c file into two new files intel_rapl_msr.c and
intel_rapl_common.c as per the commit 3382388d7148
("intel_rapl: abstract RAPL common code"). Currently, this #define
entry is being used only in intel_rapl_msr.c file and local definition
present in this file.
Signed-off-by: Pawnikar, Sumeet <sumeet.r.pawnikar@intel.com>
---
drivers/powercap/intel_rapl_common.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
index eb328655bc01..5527a7c76309 100644
--- a/drivers/powercap/intel_rapl_common.c
+++ b/drivers/powercap/intel_rapl_common.c
@@ -26,9 +26,6 @@
#include <asm/cpu_device_id.h>
#include <asm/intel-family.h>
-/* Local defines */
-#define MSR_PLATFORM_POWER_LIMIT 0x0000065C
-
/* bitmasks for RAPL MSRs, used by primitive access functions */
#define ENERGY_STATUS_MASK 0xffffffff
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-25 9:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-21 6:44 [PATCH] powercap: remove unused local MSR define Sumeet Pawnikar
2020-05-25 9:01 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2020-05-20 11:36 Sumeet Pawnikar
2020-05-20 11:53 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.