* [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks
@ 2020-06-24 7:44 Tiezhu Yang
2020-06-24 7:44 ` [PATCH v3 01/14 RESEND] irqchip/ath79-misc: " Tiezhu Yang
` (11 more replies)
0 siblings, 12 replies; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 7:44 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-kernel, linux-mips, Xuefeng Li
[git send-email failed due to too many commands,
so only cc the major related email and resend it,
sorry for that]
When I test the irqchip code of Loongson, I read the related code of other
chips in drivers/irqchip and I find some potential resource leaks in the
error path, I think it is better to fix them.
v2:
- Split the first patch into a new patch series which
includes small patches and add "Fixes" tag
- Use "goto" label to handle error path in some patches
v3:
- Add missed variable "ret" in the patch #5 and #13,
sorry for that
Tiezhu Yang (14):
irqchip/ath79-misc: Fix potential resource leaks
irqchip/csky-apb-intc: Fix potential resource leaks
irqchip/csky-mpintc: Fix potential resource leaks
irqchip/davinci-aintc: Fix potential resource leaks
irqchip/davinci-cp-intc: Fix potential resource leaks
irqchip/digicolor: Fix potential resource leaks
irqchip/dw-apb-ictl: Fix potential resource leaks
irqchip/ls1x: Fix potential resource leaks
irqchip/mscc-ocelot: Fix potential resource leaks
irqchip/nvic: Fix potential resource leaks
irqchip/omap-intc: Fix potential resource leak
irqchip/riscv-intc: Fix potential resource leak
irqchip/s3c24xx: Fix potential resource leaks
irqchip/xilinx-intc: Fix potential resource leak
drivers/irqchip/irq-ath79-misc.c | 14 +++++++++++---
drivers/irqchip/irq-csky-apb-intc.c | 12 ++++++++++--
drivers/irqchip/irq-csky-mpintc.c | 26 ++++++++++++++++++++------
drivers/irqchip/irq-davinci-aintc.c | 17 +++++++++++++----
drivers/irqchip/irq-davinci-cp-intc.c | 18 +++++++++++++++---
drivers/irqchip/irq-digicolor.c | 14 +++++++++++---
drivers/irqchip/irq-dw-apb-ictl.c | 11 ++++++++---
drivers/irqchip/irq-ls1x.c | 4 +++-
drivers/irqchip/irq-mscc-ocelot.c | 6 ++++--
drivers/irqchip/irq-nvic.c | 12 +++++++++---
drivers/irqchip/irq-omap-intc.c | 4 +++-
drivers/irqchip/irq-riscv-intc.c | 1 +
drivers/irqchip/irq-s3c24xx.c | 23 +++++++++++++++++------
drivers/irqchip/irq-xilinx-intc.c | 4 +++-
14 files changed, 128 insertions(+), 38 deletions(-)
--
2.1.0
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v3 01/14 RESEND] irqchip/ath79-misc: Fix potential resource leaks
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
@ 2020-06-24 7:44 ` Tiezhu Yang
2020-06-24 7:44 ` [PATCH v3 02/14 RESEND] irqchip/csky-apb-intc: " Tiezhu Yang
` (10 subsequent siblings)
11 siblings, 0 replies; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 7:44 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-kernel, linux-mips, Xuefeng Li
There exists potential resource leaks in the error path, fix them.
Fixes: 07ba4b061a79 ("irqchip/ath79-misc: Move the MISC driver from arch/mips/ath79/")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-ath79-misc.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-ath79-misc.c b/drivers/irqchip/irq-ath79-misc.c
index 3d641bb..53e0c50 100644
--- a/drivers/irqchip/irq-ath79-misc.c
+++ b/drivers/irqchip/irq-ath79-misc.c
@@ -133,7 +133,7 @@ static int __init ath79_misc_intc_of_init(
{
struct irq_domain *domain;
void __iomem *base;
- int irq;
+ int irq, ret;
irq = irq_of_parse_and_map(node, 0);
if (!irq) {
@@ -144,18 +144,26 @@ static int __init ath79_misc_intc_of_init(
base = of_iomap(node, 0);
if (!base) {
pr_err("Failed to get MISC IRQ registers\n");
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_irq_dispose;
}
domain = irq_domain_add_linear(node, ATH79_MISC_IRQ_COUNT,
&misc_irq_domain_ops, base);
if (!domain) {
pr_err("Failed to add MISC irqdomain\n");
- return -EINVAL;
+ ret = -EINVAL;
+ goto err_iounmap;
}
ath79_misc_intc_domain_init(domain, irq);
return 0;
+
+err_iounmap:
+ iounmap(base);
+err_irq_dispose:
+ irq_dispose_mapping(irq);
+ return ret;
}
static int __init ar7100_misc_intc_of_init(
--
2.1.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 02/14 RESEND] irqchip/csky-apb-intc: Fix potential resource leaks
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
2020-06-24 7:44 ` [PATCH v3 01/14 RESEND] irqchip/ath79-misc: " Tiezhu Yang
@ 2020-06-24 7:44 ` Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 03/14 RESEND] irqchip/csky-mpintc: " Tiezhu Yang
` (9 subsequent siblings)
11 siblings, 0 replies; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 7:44 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-kernel, linux-mips, Xuefeng Li
There exists potential resource leaks in the error path, fix them.
Fixes: edff1b4835b7 ("irqchip: add C-SKY APB bus interrupt controller")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-csky-apb-intc.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-csky-apb-intc.c b/drivers/irqchip/irq-csky-apb-intc.c
index 5a2ec43..11a35eb 100644
--- a/drivers/irqchip/irq-csky-apb-intc.c
+++ b/drivers/irqchip/irq-csky-apb-intc.c
@@ -118,7 +118,8 @@ ck_intc_init_comm(struct device_node *node, struct device_node *parent)
&irq_generic_chip_ops, NULL);
if (!root_domain) {
pr_err("C-SKY Intc irq_domain_add failed.\n");
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_iounmap;
}
ret = irq_alloc_domain_generic_chips(root_domain, 32, 1,
@@ -126,10 +127,17 @@ ck_intc_init_comm(struct device_node *node, struct device_node *parent)
IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN, 0, 0);
if (ret) {
pr_err("C-SKY Intc irq_alloc_gc failed.\n");
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_domain_remove;
}
return 0;
+
+err_domain_remove:
+ irq_domain_remove(root_domain);
+err_iounmap:
+ iounmap(reg_base);
+ return ret;
}
static inline bool handle_irq_perbit(struct pt_regs *regs, u32 hwirq,
--
2.1.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 03/14 RESEND] irqchip/csky-mpintc: Fix potential resource leaks
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
2020-06-24 7:44 ` [PATCH v3 01/14 RESEND] irqchip/ath79-misc: " Tiezhu Yang
2020-06-24 7:44 ` [PATCH v3 02/14 RESEND] irqchip/csky-apb-intc: " Tiezhu Yang
@ 2020-06-24 7:45 ` Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 04/14 RESEND] irqchip/davinci-aintc: " Tiezhu Yang
` (8 subsequent siblings)
11 siblings, 0 replies; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 7:45 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-kernel, linux-mips, Xuefeng Li
There exists potential resource leaks in the error path, fix them.
Fixes: d8a5f5f79122 ("irqchip: add C-SKY SMP interrupt controller")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-csky-mpintc.c | 26 ++++++++++++++++++++------
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-csky-mpintc.c b/drivers/irqchip/irq-csky-mpintc.c
index a1534ed..c195e24 100644
--- a/drivers/irqchip/irq-csky-mpintc.c
+++ b/drivers/irqchip/irq-csky-mpintc.c
@@ -247,8 +247,10 @@ csky_mpintc_init(struct device_node *node, struct device_node *parent)
if (INTCG_base == NULL) {
INTCG_base = ioremap(mfcr("cr<31, 14>"),
INTCL_SIZE*nr_cpu_ids + INTCG_SIZE);
- if (INTCG_base == NULL)
- return -EIO;
+ if (INTCG_base == NULL) {
+ ret = -EIO;
+ goto err_free;
+ }
INTCL_base = INTCG_base + INTCG_SIZE;
@@ -257,8 +259,10 @@ csky_mpintc_init(struct device_node *node, struct device_node *parent)
root_domain = irq_domain_add_linear(node, nr_irq, &csky_irqdomain_ops,
NULL);
- if (!root_domain)
- return -ENXIO;
+ if (!root_domain) {
+ ret = -ENXIO;
+ goto err_iounmap;
+ }
/* for every cpu */
for_each_present_cpu(cpu) {
@@ -270,12 +274,22 @@ csky_mpintc_init(struct device_node *node, struct device_node *parent)
#ifdef CONFIG_SMP
ipi_irq = irq_create_mapping(root_domain, IPI_IRQ);
- if (!ipi_irq)
- return -EIO;
+ if (!ipi_irq) {
+ ret = -EIO;
+ goto err_domain_remove;
+ }
set_send_ipi(&csky_mpintc_send_ipi, ipi_irq);
#endif
return 0;
+
+err_domain_remove:
+ irq_domain_remove(root_domain);
+err_iounmap:
+ iounmap(INTCG_base);
+err_free:
+ kfree(__trigger);
+ return ret;
}
IRQCHIP_DECLARE(csky_mpintc, "csky,mpintc", csky_mpintc_init);
--
2.1.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 04/14 RESEND] irqchip/davinci-aintc: Fix potential resource leaks
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
` (2 preceding siblings ...)
2020-06-24 7:45 ` [PATCH v3 03/14 RESEND] irqchip/csky-mpintc: " Tiezhu Yang
@ 2020-06-24 7:45 ` Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 05/14 RESEND] irqchip/davinci-cp-intc: " Tiezhu Yang
` (7 subsequent siblings)
11 siblings, 0 replies; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 7:45 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-kernel, linux-mips, Xuefeng Li
There exists potential resource leaks in the error path, fix them.
Fixes: 0145beed9d26 ("irqchip: davinci-aintc: move the driver to drivers/irqchip")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-davinci-aintc.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-davinci-aintc.c b/drivers/irqchip/irq-davinci-aintc.c
index 810ccc4..12db502 100644
--- a/drivers/irqchip/irq-davinci-aintc.c
+++ b/drivers/irqchip/irq-davinci-aintc.c
@@ -96,7 +96,7 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config)
resource_size(&config->reg));
if (!davinci_aintc_base) {
pr_err("%s: unable to ioremap register range\n", __func__);
- return;
+ goto err_release;
}
/* Clear all interrupt requests */
@@ -133,7 +133,7 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config)
if (irq_base < 0) {
pr_err("%s: unable to allocate interrupt descriptors: %d\n",
__func__, irq_base);
- return;
+ goto err_iounmap;
}
davinci_aintc_irq_domain = irq_domain_add_legacy(NULL,
@@ -141,7 +141,7 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config)
&irq_domain_simple_ops, NULL);
if (!davinci_aintc_irq_domain) {
pr_err("%s: unable to create interrupt domain\n", __func__);
- return;
+ goto err_free_descs;
}
ret = irq_alloc_domain_generic_chips(davinci_aintc_irq_domain, 32, 1,
@@ -150,7 +150,7 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config)
if (ret) {
pr_err("%s: unable to allocate generic irq chips for domain\n",
__func__);
- return;
+ goto err_domain_remove;
}
for (irq_off = 0, reg_off = 0;
@@ -160,4 +160,13 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config)
irq_base + irq_off, 32);
set_handle_irq(davinci_aintc_handle_irq);
+
+err_domain_remove:
+ irq_domain_remove(davinci_aintc_irq_domain);
+err_free_descs:
+ irq_free_descs(irq_base, config->num_irqs);
+err_iounmap:
+ iounmap(davinci_aintc_base);
+err_release:
+ release_mem_region(config->reg.start, resource_size(&config->reg));
}
--
2.1.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 05/14 RESEND] irqchip/davinci-cp-intc: Fix potential resource leaks
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
` (3 preceding siblings ...)
2020-06-24 7:45 ` [PATCH v3 04/14 RESEND] irqchip/davinci-aintc: " Tiezhu Yang
@ 2020-06-24 7:45 ` Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 06/14 RESEND] irqchip/digicolor: " Tiezhu Yang
` (6 subsequent siblings)
11 siblings, 0 replies; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 7:45 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-kernel, linux-mips, Xuefeng Li
There exists potential resource leaks in the error path, fix them.
Fixes: 0fc3d74cf946 ("irqchip: davinci-cp-intc: move the driver to drivers/irqchip")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-davinci-cp-intc.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-davinci-cp-intc.c b/drivers/irqchip/irq-davinci-cp-intc.c
index 276da277..2c2e115 100644
--- a/drivers/irqchip/irq-davinci-cp-intc.c
+++ b/drivers/irqchip/irq-davinci-cp-intc.c
@@ -162,6 +162,7 @@ davinci_cp_intc_do_init(const struct davinci_cp_intc_config *config,
unsigned int num_regs = BITS_TO_LONGS(config->num_irqs);
int offset, irq_base;
void __iomem *req;
+ int ret;
req = request_mem_region(config->reg.start,
resource_size(&config->reg),
@@ -175,7 +176,8 @@ davinci_cp_intc_do_init(const struct davinci_cp_intc_config *config,
resource_size(&config->reg));
if (!davinci_cp_intc_base) {
pr_err("%s: unable to ioremap register range\n", __func__);
- return -EINVAL;
+ ret = -EINVAL;
+ goto err_release;
}
davinci_cp_intc_write(0, DAVINCI_CP_INTC_GLOBAL_ENABLE);
@@ -210,7 +212,8 @@ davinci_cp_intc_do_init(const struct davinci_cp_intc_config *config,
if (irq_base < 0) {
pr_err("%s: unable to allocate interrupt descriptors: %d\n",
__func__, irq_base);
- return irq_base;
+ ret = irq_base;
+ goto err_iounmap;
}
davinci_cp_intc_irq_domain = irq_domain_add_legacy(
@@ -219,7 +222,8 @@ davinci_cp_intc_do_init(const struct davinci_cp_intc_config *config,
if (!davinci_cp_intc_irq_domain) {
pr_err("%s: unable to create an interrupt domain\n", __func__);
- return -EINVAL;
+ ret = -EINVAL;
+ goto err_free_descs;
}
set_handle_irq(davinci_cp_intc_handle_irq);
@@ -228,6 +232,14 @@ davinci_cp_intc_do_init(const struct davinci_cp_intc_config *config,
davinci_cp_intc_write(1, DAVINCI_CP_INTC_GLOBAL_ENABLE);
return 0;
+
+err_free_descs:
+ irq_free_descs(irq_base, config->num_irqs);
+err_iounmap:
+ iounmap(davinci_cp_intc_base);
+err_release:
+ release_mem_region(config->reg.start, resource_size(&config->reg));
+ return ret;
}
int __init davinci_cp_intc_init(const struct davinci_cp_intc_config *config)
--
2.1.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 06/14 RESEND] irqchip/digicolor: Fix potential resource leaks
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
` (4 preceding siblings ...)
2020-06-24 7:45 ` [PATCH v3 05/14 RESEND] irqchip/davinci-cp-intc: " Tiezhu Yang
@ 2020-06-24 7:45 ` Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 07/14 RESEND] irqchip/dw-apb-ictl: " Tiezhu Yang
` (5 subsequent siblings)
11 siblings, 0 replies; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 7:45 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-kernel, linux-mips, Xuefeng Li
There exists potential resource leaks in the error path, fix them.
Fixes: 8041dfbd31cf ("irqchip: Conexant CX92755 interrupts controller driver")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-digicolor.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-digicolor.c b/drivers/irqchip/irq-digicolor.c
index fc38d2d..18c6e77 100644
--- a/drivers/irqchip/irq-digicolor.c
+++ b/drivers/irqchip/irq-digicolor.c
@@ -89,7 +89,8 @@ static int __init digicolor_of_init(struct device_node *node,
ucregs = syscon_regmap_lookup_by_phandle(node, "syscon");
if (IS_ERR(ucregs)) {
pr_err("%pOF: unable to map UC registers\n", node);
- return PTR_ERR(ucregs);
+ ret = PTR_ERR(ucregs);
+ goto err_iounmap;
}
/* channel 1, regular IRQs */
regmap_write(ucregs, UC_IRQ_CONTROL, 1);
@@ -98,7 +99,8 @@ static int __init digicolor_of_init(struct device_node *node,
irq_domain_add_linear(node, 64, &irq_generic_chip_ops, NULL);
if (!digicolor_irq_domain) {
pr_err("%pOF: unable to create IRQ domain\n", node);
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_iounmap;
}
ret = irq_alloc_domain_generic_chips(digicolor_irq_domain, 32, 1,
@@ -106,7 +108,7 @@ static int __init digicolor_of_init(struct device_node *node,
clr, 0, 0);
if (ret) {
pr_err("%pOF: unable to allocate IRQ gc\n", node);
- return ret;
+ goto err_domain_remove;
}
digicolor_set_gc(reg_base, 0, IC_INT0ENABLE_LO, IC_FLAG_CLEAR_LO);
@@ -115,5 +117,11 @@ static int __init digicolor_of_init(struct device_node *node,
set_handle_irq(digicolor_handle_irq);
return 0;
+
+err_domain_remove:
+ irq_domain_remove(digicolor_irq_domain);
+err_iounmap:
+ iounmap(reg_base);
+ return ret;
}
IRQCHIP_DECLARE(conexant_digicolor_ic, "cnxt,cx92755-ic", digicolor_of_init);
--
2.1.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 07/14 RESEND] irqchip/dw-apb-ictl: Fix potential resource leaks
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
` (5 preceding siblings ...)
2020-06-24 7:45 ` [PATCH v3 06/14 RESEND] irqchip/digicolor: " Tiezhu Yang
@ 2020-06-24 7:45 ` Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 08/14 RESEND] irqchip/ls1x: " Tiezhu Yang
` (4 subsequent siblings)
11 siblings, 0 replies; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 7:45 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-kernel, linux-mips, Xuefeng Li
There exists potential resource leaks in the error path, fix them.
Fixes: 350d71b94fc9 ("irqchip: add DesignWare APB ICTL interrupt controller")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-dw-apb-ictl.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-dw-apb-ictl.c b/drivers/irqchip/irq-dw-apb-ictl.c
index e4550e9..bc9b750 100644
--- a/drivers/irqchip/irq-dw-apb-ictl.c
+++ b/drivers/irqchip/irq-dw-apb-ictl.c
@@ -86,12 +86,13 @@ static int __init dw_apb_ictl_init(struct device_node *np,
ret = of_address_to_resource(np, 0, &r);
if (ret) {
pr_err("%pOF: unable to get resource\n", np);
- return ret;
+ goto err_irq_dispose;
}
if (!request_mem_region(r.start, resource_size(&r), np->full_name)) {
pr_err("%pOF: unable to request mem region\n", np);
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_irq_dispose;
}
iobase = ioremap(r.start, resource_size(&r));
@@ -133,7 +134,7 @@ static int __init dw_apb_ictl_init(struct device_node *np,
IRQ_GC_INIT_MASK_CACHE);
if (ret) {
pr_err("%pOF: unable to alloc irq domain gc\n", np);
- goto err_unmap;
+ goto err_domain_remove;
}
for (i = 0; i < DIV_ROUND_UP(nrirqs, 32); i++) {
@@ -150,10 +151,14 @@ static int __init dw_apb_ictl_init(struct device_node *np,
return 0;
+err_domain_remove:
+ irq_domain_remove(domain);
err_unmap:
iounmap(iobase);
err_release:
release_mem_region(r.start, resource_size(&r));
+err_irq_dispose:
+ irq_dispose_mapping(irq);
return ret;
}
IRQCHIP_DECLARE(dw_apb_ictl,
--
2.1.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 08/14 RESEND] irqchip/ls1x: Fix potential resource leaks
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
` (6 preceding siblings ...)
2020-06-24 7:45 ` [PATCH v3 07/14 RESEND] irqchip/dw-apb-ictl: " Tiezhu Yang
@ 2020-06-24 7:45 ` Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 09/14 RESEND] irqchip/mscc-ocelot: " Tiezhu Yang
` (3 subsequent siblings)
11 siblings, 0 replies; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 7:45 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-kernel, linux-mips, Xuefeng Li
There exists potential resource leaks in the error path, fix them.
Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-ls1x.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-ls1x.c b/drivers/irqchip/irq-ls1x.c
index 353111a..409001b 100644
--- a/drivers/irqchip/irq-ls1x.c
+++ b/drivers/irqchip/irq-ls1x.c
@@ -131,7 +131,7 @@ static int __init ls1x_intc_of_init(struct device_node *node,
if (!priv->domain) {
pr_err("ls1x-irq: cannot add IRQ domain\n");
err = -ENOMEM;
- goto out_iounmap;
+ goto out_dispose_irq;
}
err = irq_alloc_domain_generic_chips(priv->domain, 32, 2,
@@ -182,6 +182,8 @@ static int __init ls1x_intc_of_init(struct device_node *node,
out_free_domain:
irq_domain_remove(priv->domain);
+out_dispose_irq:
+ irq_dispose_mapping(parent_irq);
out_iounmap:
iounmap(priv->intc_base);
out_free_priv:
--
2.1.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 09/14 RESEND] irqchip/mscc-ocelot: Fix potential resource leaks
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
` (7 preceding siblings ...)
2020-06-24 7:45 ` [PATCH v3 08/14 RESEND] irqchip/ls1x: " Tiezhu Yang
@ 2020-06-24 7:45 ` Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 10/14 RESEND] irqchip/nvic: " Tiezhu Yang
` (2 subsequent siblings)
11 siblings, 0 replies; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 7:45 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-kernel, linux-mips, Xuefeng Li
There exists potential resource leaks in the error path, fix them.
Fixes: 19d99164480a ("irqchip: Add a driver for the Microsemi Ocelot controller")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-mscc-ocelot.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-mscc-ocelot.c b/drivers/irqchip/irq-mscc-ocelot.c
index 88143c0..e676ae2 100644
--- a/drivers/irqchip/irq-mscc-ocelot.c
+++ b/drivers/irqchip/irq-mscc-ocelot.c
@@ -73,7 +73,8 @@ static int __init ocelot_irq_init(struct device_node *node,
&irq_generic_chip_ops, NULL);
if (!domain) {
pr_err("%pOFn: unable to add irq domain\n", node);
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_irq_dispose;
}
ret = irq_alloc_domain_generic_chips(domain, OCELOT_NR_IRQ, 1,
@@ -109,9 +110,10 @@ static int __init ocelot_irq_init(struct device_node *node,
err_gc_free:
irq_free_generic_chip(gc);
-
err_domain_remove:
irq_domain_remove(domain);
+err_irq_dispose:
+ irq_dispose_mapping(parent_irq);
return ret;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 10/14 RESEND] irqchip/nvic: Fix potential resource leaks
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
` (8 preceding siblings ...)
2020-06-24 7:45 ` [PATCH v3 09/14 RESEND] irqchip/mscc-ocelot: " Tiezhu Yang
@ 2020-06-24 7:45 ` Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 11/14 RESEND] irqchip/omap-intc: Fix potential resource leak Tiezhu Yang
2020-06-24 8:30 ` [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Marc Zyngier
11 siblings, 0 replies; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 7:45 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-kernel, linux-mips, Xuefeng Li
There exists potential resource leaks in the error path, fix them.
Fixes: 292ec080491d ("irqchip: Add support for ARMv7-M NVIC")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-nvic.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
index f747e22..cd17f5d 100644
--- a/drivers/irqchip/irq-nvic.c
+++ b/drivers/irqchip/irq-nvic.c
@@ -94,7 +94,8 @@ static int __init nvic_of_init(struct device_node *node,
if (!nvic_irq_domain) {
pr_warn("Failed to allocate irq domain\n");
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto err_iounmap;
}
ret = irq_alloc_domain_generic_chips(nvic_irq_domain, 32, 1,
@@ -102,8 +103,7 @@ static int __init nvic_of_init(struct device_node *node,
clr, 0, IRQ_GC_INIT_MASK_CACHE);
if (ret) {
pr_warn("Failed to allocate irq chips\n");
- irq_domain_remove(nvic_irq_domain);
- return ret;
+ goto err_domain_remove;
}
for (i = 0; i < numbanks; ++i) {
@@ -129,5 +129,11 @@ static int __init nvic_of_init(struct device_node *node,
writel_relaxed(0, nvic_base + NVIC_IPR + i);
return 0;
+
+err_domain_remove:
+ irq_domain_remove(nvic_irq_domain);
+err_iounmap:
+ iounmap(nvic_base);
+ return ret;
}
IRQCHIP_DECLARE(armv7m_nvic, "arm,armv7m-nvic", nvic_of_init);
--
2.1.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v3 11/14 RESEND] irqchip/omap-intc: Fix potential resource leak
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
` (9 preceding siblings ...)
2020-06-24 7:45 ` [PATCH v3 10/14 RESEND] irqchip/nvic: " Tiezhu Yang
@ 2020-06-24 7:45 ` Tiezhu Yang
2020-06-24 8:30 ` [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Marc Zyngier
11 siblings, 0 replies; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 7:45 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-kernel, linux-mips, Xuefeng Li
There exists potential resource leak in the error path, fix it.
Fixes: 8598066cddd1 ("arm: omap: irq: move irq.c to drivers/irqchip/")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-omap-intc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-omap-intc.c b/drivers/irqchip/irq-omap-intc.c
index d360a6e..e711530 100644
--- a/drivers/irqchip/irq-omap-intc.c
+++ b/drivers/irqchip/irq-omap-intc.c
@@ -254,8 +254,10 @@ static int __init omap_init_irq_of(struct device_node *node)
omap_irq_soft_reset();
ret = omap_alloc_gc_of(domain, omap_irq_base);
- if (ret < 0)
+ if (ret < 0) {
irq_domain_remove(domain);
+ iounmap(omap_irq_base);
+ }
return ret;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
` (10 preceding siblings ...)
2020-06-24 7:45 ` [PATCH v3 11/14 RESEND] irqchip/omap-intc: Fix potential resource leak Tiezhu Yang
@ 2020-06-24 8:30 ` Marc Zyngier
2020-06-24 9:02 ` Tiezhu Yang
2020-06-28 11:25 ` Aleksandar Markovic
11 siblings, 2 replies; 21+ messages in thread
From: Marc Zyngier @ 2020-06-24 8:30 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Thomas Gleixner, Jason Cooper, linux-kernel, linux-mips, Xuefeng Li
On 2020-06-24 08:44, Tiezhu Yang wrote:
> [git send-email failed due to too many commands,
> so only cc the major related email and resend it,
> sorry for that]
This is becoming majorly annoying. Please fix your git setup
*before* dumping 57 emails for just 14 patches. You have done
the same thing yesterday, and I would hope you learned from your
mistakes.
Also, do not repost a series more than once per week. You have
already exceeded your quota by quite a margin.
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks
2020-06-24 8:30 ` [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Marc Zyngier
@ 2020-06-24 9:02 ` Tiezhu Yang
2020-06-24 11:48 ` Tiezhu Yang
2020-06-28 11:25 ` Aleksandar Markovic
1 sibling, 1 reply; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 9:02 UTC (permalink / raw)
To: Marc Zyngier
Cc: Thomas Gleixner, Jason Cooper, linux-kernel, linux-mips, Xuefeng Li
On 06/24/2020 04:30 PM, Marc Zyngier wrote:
> On 2020-06-24 08:44, Tiezhu Yang wrote:
>> [git send-email failed due to too many commands,
>> so only cc the major related email and resend it,
>> sorry for that]
>
> This is becoming majorly annoying. Please fix your git setup
> *before* dumping 57 emails for just 14 patches. You have done
> the same thing yesterday, and I would hope you learned from your
> mistakes.
>
> Also, do not repost a series more than once per week. You have
> already exceeded your quota by quite a margin.
I am very sorry for that.
I will wait for some days to resend this patch series.
>
> M.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks
2020-06-24 9:02 ` Tiezhu Yang
@ 2020-06-24 11:48 ` Tiezhu Yang
2020-06-24 11:52 ` Marc Zyngier
0 siblings, 1 reply; 21+ messages in thread
From: Tiezhu Yang @ 2020-06-24 11:48 UTC (permalink / raw)
To: Marc Zyngier
Cc: Thomas Gleixner, Jason Cooper, linux-kernel, linux-mips, Xuefeng Li
On 06/24/2020 05:02 PM, Tiezhu Yang wrote:
> On 06/24/2020 04:30 PM, Marc Zyngier wrote:
>> On 2020-06-24 08:44, Tiezhu Yang wrote:
>>> [git send-email failed due to too many commands,
>>> so only cc the major related email and resend it,
>>> sorry for that]
>>
>> This is becoming majorly annoying. Please fix your git setup
>> *before* dumping 57 emails for just 14 patches. You have done
>> the same thing yesterday, and I would hope you learned from your
>> mistakes.
>>
>> Also, do not repost a series more than once per week. You have
>> already exceeded your quota by quite a margin.
>
> I am very sorry for that.
> I will wait for some days to resend this patch series.
Hi Marc,
Since each patch of this series is independent, in order to avoid
git send-email failed, I prefer to resend each patch individually
and cc more related maintainer or supporter to review.
If you do not mind, I will resend each patch individually next week.
Sorry for the noisy and inconvenience.
>
>>
>> M.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks
2020-06-24 11:48 ` Tiezhu Yang
@ 2020-06-24 11:52 ` Marc Zyngier
0 siblings, 0 replies; 21+ messages in thread
From: Marc Zyngier @ 2020-06-24 11:52 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Thomas Gleixner, Jason Cooper, linux-kernel, linux-mips, Xuefeng Li
On 2020-06-24 12:48, Tiezhu Yang wrote:
> On 06/24/2020 05:02 PM, Tiezhu Yang wrote:
>> On 06/24/2020 04:30 PM, Marc Zyngier wrote:
>>> On 2020-06-24 08:44, Tiezhu Yang wrote:
>>>> [git send-email failed due to too many commands,
>>>> so only cc the major related email and resend it,
>>>> sorry for that]
>>>
>>> This is becoming majorly annoying. Please fix your git setup
>>> *before* dumping 57 emails for just 14 patches. You have done
>>> the same thing yesterday, and I would hope you learned from your
>>> mistakes.
>>>
>>> Also, do not repost a series more than once per week. You have
>>> already exceeded your quota by quite a margin.
>>
>> I am very sorry for that.
>> I will wait for some days to resend this patch series.
>
> Hi Marc,
>
> Since each patch of this series is independent, in order to avoid
> git send-email failed, I prefer to resend each patch individually
> and cc more related maintainer or supporter to review.
Don't do that. Just fix your GIT setup.
> If you do not mind, I will resend each patch individually next week.
> Sorry for the noisy and inconvenience.
They are perfectly fine as a series. As the person that will ultimately
merge these patches, I don't want to go and fish individual patches,
which is the best way to miss some.
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks
2020-06-24 8:30 ` [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Marc Zyngier
2020-06-24 9:02 ` Tiezhu Yang
@ 2020-06-28 11:25 ` Aleksandar Markovic
2020-06-28 12:06 ` Marc Zyngier
1 sibling, 1 reply; 21+ messages in thread
From: Aleksandar Markovic @ 2020-06-28 11:25 UTC (permalink / raw)
To: Marc Zyngier
Cc: Tiezhu Yang, Thomas Gleixner, Jason Cooper,
Linux Kernel Mailing List, open list:MIPS, Xuefeng Li
сре, 24. јун 2020. у 10:40 Marc Zyngier <maz@kernel.org> је написао/ла:
>
> On 2020-06-24 08:44, Tiezhu Yang wrote:
> > [git send-email failed due to too many commands,
> > so only cc the major related email and resend it,
> > sorry for that]
>
> This is becoming majorly annoying.
I don't think this is the right vocabulary to welcome newcomers,
however "terrible" thinks they did.
Rather, patience, calmness and clear and detailed explanations would
work much better - and certainly be much more helpful and useful to
the community in the long run.
Regards,
Aleksandar
> Please fix your git setup
> *before* dumping 57 emails for just 14 patches. You have done
> the same thing yesterday, and I would hope you learned from your
> mistakes.
>
> Also, do not repost a series more than once per week. You have
> already exceeded your quota by quite a margin.
>
> M.
> --
> Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks
2020-06-28 11:25 ` Aleksandar Markovic
@ 2020-06-28 12:06 ` Marc Zyngier
2020-06-28 12:48 ` Aleksandar Markovic
0 siblings, 1 reply; 21+ messages in thread
From: Marc Zyngier @ 2020-06-28 12:06 UTC (permalink / raw)
To: Aleksandar Markovic
Cc: Tiezhu Yang, Thomas Gleixner, Jason Cooper,
Linux Kernel Mailing List, open list:MIPS, Xuefeng Li
On 2020-06-28 12:25, Aleksandar Markovic wrote:
> сре, 24. јун 2020. у 10:40 Marc Zyngier <maz@kernel.org> је написао/ла:
>>
>> On 2020-06-24 08:44, Tiezhu Yang wrote:
>> > [git send-email failed due to too many commands,
>> > so only cc the major related email and resend it,
>> > sorry for that]
>>
>> This is becoming majorly annoying.
>
> I don't think this is the right vocabulary to welcome newcomers,
> however "terrible" thinks they did.
>
> Rather, patience, calmness and clear and detailed explanations would
> work much better - and certainly be much more helpful and useful to
> the community in the long run.
Pray tell how you would have handled this. I expressed *my* personal
frustration at a SNR hovering below the 25% mark. I have only indicated
that the current course of action was becoming a problem.
And instead of taking the moral high ground, maybe you could actually
share your wisdom with Teizhu and help him becoming a better
contributor?
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks
2020-06-28 12:06 ` Marc Zyngier
@ 2020-06-28 12:48 ` Aleksandar Markovic
2020-06-28 16:55 ` Marc Zyngier
0 siblings, 1 reply; 21+ messages in thread
From: Aleksandar Markovic @ 2020-06-28 12:48 UTC (permalink / raw)
To: Marc Zyngier
Cc: Tiezhu Yang, Thomas Gleixner, Jason Cooper,
Linux Kernel Mailing List, open list:MIPS, Xuefeng Li
нед, 28. јун 2020. у 14:06 Marc Zyngier <maz@kernel.org> је написао/ла:
>
> On 2020-06-28 12:25, Aleksandar Markovic wrote:
> > сре, 24. јун 2020. у 10:40 Marc Zyngier <maz@kernel.org> је написао/ла:
> >>
> >> On 2020-06-24 08:44, Tiezhu Yang wrote:
> >> > [git send-email failed due to too many commands,
> >> > so only cc the major related email and resend it,
> >> > sorry for that]
> >>
> >> This is becoming majorly annoying.
> >
> > I don't think this is the right vocabulary to welcome newcomers,
> > however "terrible" thinks they did.
> >
> > Rather, patience, calmness and clear and detailed explanations would
> > work much better - and certainly be much more helpful and useful to
> > the community in the long run.
>
> Pray tell how you would have handled this. I expressed *my* personal
> frustration at a SNR hovering below the 25% mark. I have only indicated
> that the current course of action was becoming a problem.
>
> And instead of taking the moral high ground, maybe you could actually
> share your wisdom with Teizhu and help him becoming a better
> contributor?
>
He will improve. This initial clumsiness is normal. It could have been
avoided, true - for example, if he had had someone more experienced at
hand, preferably a co-worker. He obviously acts alone. It will be
better.
> Thanks,
>
> M.
> --
> Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks
2020-06-28 12:48 ` Aleksandar Markovic
@ 2020-06-28 16:55 ` Marc Zyngier
2020-06-28 17:00 ` Aleksandar Markovic
0 siblings, 1 reply; 21+ messages in thread
From: Marc Zyngier @ 2020-06-28 16:55 UTC (permalink / raw)
To: Aleksandar Markovic
Cc: Tiezhu Yang, Thomas Gleixner, Jason Cooper,
Linux Kernel Mailing List, open list:MIPS, Xuefeng Li
On 2020-06-28 13:48, Aleksandar Markovic wrote:
> нед, 28. јун 2020. у 14:06 Marc Zyngier <maz@kernel.org> је написао/ла:
>>
>> On 2020-06-28 12:25, Aleksandar Markovic wrote:
>> > сре, 24. јун 2020. у 10:40 Marc Zyngier <maz@kernel.org> је написао/ла:
>> >>
>> >> On 2020-06-24 08:44, Tiezhu Yang wrote:
>> >> > [git send-email failed due to too many commands,
>> >> > so only cc the major related email and resend it,
>> >> > sorry for that]
>> >>
>> >> This is becoming majorly annoying.
>> >
>> > I don't think this is the right vocabulary to welcome newcomers,
>> > however "terrible" thinks they did.
>> >
>> > Rather, patience, calmness and clear and detailed explanations would
>> > work much better - and certainly be much more helpful and useful to
>> > the community in the long run.
>>
>> Pray tell how you would have handled this. I expressed *my* personal
>> frustration at a SNR hovering below the 25% mark. I have only
>> indicated
>> that the current course of action was becoming a problem.
>>
>> And instead of taking the moral high ground, maybe you could actually
>> share your wisdom with Teizhu and help him becoming a better
>> contributor?
>>
>
> He will improve. This initial clumsiness is normal. It could have been
> avoided, true - for example, if he had had someone more experienced at
> hand, preferably a co-worker. He obviously acts alone. It will be
> better.
I thank you for imparting your insight on us. You clearly have helped
things moving forward, and I am sure Teizhu now knows a lot more about
what he should have done.
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks
2020-06-28 16:55 ` Marc Zyngier
@ 2020-06-28 17:00 ` Aleksandar Markovic
0 siblings, 0 replies; 21+ messages in thread
From: Aleksandar Markovic @ 2020-06-28 17:00 UTC (permalink / raw)
To: Marc Zyngier
Cc: Tiezhu Yang, Thomas Gleixner, Jason Cooper,
Linux Kernel Mailing List, open list:MIPS, Xuefeng Li
нед, 28. јун 2020. у 18:55 Marc Zyngier <maz@kernel.org> је написао/ла:
>
> On 2020-06-28 13:48, Aleksandar Markovic wrote:
> > нед, 28. јун 2020. у 14:06 Marc Zyngier <maz@kernel.org> је написао/ла:
> >>
> >> On 2020-06-28 12:25, Aleksandar Markovic wrote:
> >> > сре, 24. јун 2020. у 10:40 Marc Zyngier <maz@kernel.org> је написао/ла:
> >> >>
> >> >> On 2020-06-24 08:44, Tiezhu Yang wrote:
> >> >> > [git send-email failed due to too many commands,
> >> >> > so only cc the major related email and resend it,
> >> >> > sorry for that]
> >> >>
> >> >> This is becoming majorly annoying.
> >> >
> >> > I don't think this is the right vocabulary to welcome newcomers,
> >> > however "terrible" thinks they did.
> >> >
> >> > Rather, patience, calmness and clear and detailed explanations would
> >> > work much better - and certainly be much more helpful and useful to
> >> > the community in the long run.
> >>
> >> Pray tell how you would have handled this. I expressed *my* personal
> >> frustration at a SNR hovering below the 25% mark. I have only
> >> indicated
> >> that the current course of action was becoming a problem.
> >>
> >> And instead of taking the moral high ground, maybe you could actually
> >> share your wisdom with Teizhu and help him becoming a better
> >> contributor?
> >>
> >
> > He will improve. This initial clumsiness is normal. It could have been
> > avoided, true - for example, if he had had someone more experienced at
> > hand, preferably a co-worker. He obviously acts alone. It will be
> > better.
>
> I thank you for imparting your insight on us. You clearly have helped
> things moving forward, and I am sure Teizhu now knows a lot more about
> what he should have done.
>
Irony and arrogance are certainly not the things that would attract
future contributors. I think that is a real new insight - for you.
Regards,
Aleksandar
> M.
> --
> Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2020-06-28 17:01 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-24 7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
2020-06-24 7:44 ` [PATCH v3 01/14 RESEND] irqchip/ath79-misc: " Tiezhu Yang
2020-06-24 7:44 ` [PATCH v3 02/14 RESEND] irqchip/csky-apb-intc: " Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 03/14 RESEND] irqchip/csky-mpintc: " Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 04/14 RESEND] irqchip/davinci-aintc: " Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 05/14 RESEND] irqchip/davinci-cp-intc: " Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 06/14 RESEND] irqchip/digicolor: " Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 07/14 RESEND] irqchip/dw-apb-ictl: " Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 08/14 RESEND] irqchip/ls1x: " Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 09/14 RESEND] irqchip/mscc-ocelot: " Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 10/14 RESEND] irqchip/nvic: " Tiezhu Yang
2020-06-24 7:45 ` [PATCH v3 11/14 RESEND] irqchip/omap-intc: Fix potential resource leak Tiezhu Yang
2020-06-24 8:30 ` [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Marc Zyngier
2020-06-24 9:02 ` Tiezhu Yang
2020-06-24 11:48 ` Tiezhu Yang
2020-06-24 11:52 ` Marc Zyngier
2020-06-28 11:25 ` Aleksandar Markovic
2020-06-28 12:06 ` Marc Zyngier
2020-06-28 12:48 ` Aleksandar Markovic
2020-06-28 16:55 ` Marc Zyngier
2020-06-28 17:00 ` Aleksandar Markovic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.