Re: [PULL 00/57] target-arm queue

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20200626151424.30117-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/57] target-arm queue
Type: series
Message-id: 20200626151424.30117-1-peter.maydell@linaro.org

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200626033144.790098-1-richard.henderson@linaro.org -> patchew/20200626033144.790098-1-richard.henderson@linaro.org
 * [new tag]         patchew/20200626151424.30117-1-peter.maydell@linaro.org -> patchew/20200626151424.30117-1-peter.maydell@linaro.org
Switched to a new branch 'test'
3d406b0 target/arm: Enable MTE
88fa004 target/arm: Add allocation tag storage for system mode
207f967 target/arm: Create tagged ram when MTE is enabled
d8f973e target/arm: Cache the Tagged bit for a page in MemTxAttrs
9c2ff86 target/arm: Always pass cacheattr to get_phys_addr
a3746dc target/arm: Set PSTATE.TCO on exception entry
b982379 target/arm: Implement data cache set allocation tags
4b83139 target/arm: Complete TBI clearing for user-only for SVE
d090020 target/arm: Add mte helpers for sve scatter/gather memory ops
3f3ac45 target/arm: Handle TBI for sve scalar + int memory ops
842d8a7 target/arm: Add mte helpers for sve scalar + int ff/nf loads
1fed9bb target/arm: Add mte helpers for sve scalar + int stores
d837320 target/arm: Add mte helpers for sve scalar + int loads
bea6e79 target/arm: Add arm_tlb_bti_gp
51f6bf5 target/arm: Tidy trans_LD1R_zpri
3349c22 target/arm: Use mte_check1 for sve LD1R
02ccebe target/arm: Use mte_checkN for sve unpredicated stores
aac1723 target/arm: Use mte_checkN for sve unpredicated loads
94569d3 target/arm: Add helper_mte_check_zva
ea15240 target/arm: Implement helper_mte_checkN
1da6db3 target/arm: Implement helper_mte_check1
9a34608 target/arm: Add gen_mte_checkN
ede3f47 target/arm: Add gen_mte_check1
32baf82 target/arm: Move regime_tcr to internals.h
cdeec48 target/arm: Move regime_el to internals.h
1e1c185 target/arm: Implement the access tag cache flushes
7be5f51 target/arm: Implement the LDGM, STGM, STZGM instructions
a566fd9 target/arm: Simplify DC_ZVA
776d65f target/arm: Restrict the values of DCZID.BS under TCG
7776f41 target/arm: Implement the STGP instruction
d37d71a target/arm: Implement LDG, STG, ST2G instructions
cd08598 target/arm: Define arm_cpu_do_unaligned_access for user-only
8661f55 target/arm: Implement the SUBP instruction
7511e2a target/arm: Implement the GMI instruction
339c07d target/arm: Implement the ADDG, SUBG instructions
9999137 target/arm: Revise decoding for disas_add_sub_imm
3a399a4 target/arm: Implement the IRG instruction
e7cb7d7 target/arm: Add MTE bits to tb_flags
4a68b7d target/arm: Add MTE system registers
6e399d3 target/arm: Add DISAS_UPDATE_NOCHAIN
65f6cfb target/arm: Rename DISAS_UPDATE to DISAS_UPDATE_EXIT
5b49b25 target/arm: Add support for MTE to HCR_EL2 and SCR_EL3
7a08bad target/arm: Add support for MTE to SCTLR_ELx
ac960a3 target/arm: Improve masking of SCR RES0 bits
a62f023 target/arm: Add isar tests for mte
05d18f3 hw/misc/pca9552: Model qdev output GPIOs
4284a62 hw/misc/pca9552: Trace GPIO change events
a249409 hw/arm/aspeed: Describe each PCA9552 device
a298de8 hw/misc/pca9552: Trace GPIO High/Low events
7b807ce hw/misc/pca9552: Add a 'description' property for debugging purpose
0f1dce5 hw/misc/pca9552: Add generic PCA955xClass, parent of TYPE_PCA9552
e941a0f hw/misc/pca9552: Rename generic code as pca955x
9f98958 hw/misc/pca9552: Rename 'nr_leds' as 'pin_count'
25a95f0 hw/i2c/core: Add i2c_try_create_slave() and i2c_realize_and_unref()
f05b44e hw/arm/aspeed: QOM'ify AspeedMachineState
0637263 hw/arm/aspeed: Rename AspeedBoardState as AspeedMachineState
a01b35a hw/arm/aspeed: Remove extraneous MemoryRegion object owner

=== OUTPUT BEGIN ===
1/57 Checking commit a01b35ada814 (hw/arm/aspeed: Remove extraneous MemoryRegion object owner)
2/57 Checking commit 0637263062c3 (hw/arm/aspeed: Rename AspeedBoardState as AspeedMachineState)
3/57 Checking commit f05b44e24563 (hw/arm/aspeed: QOM'ify AspeedMachineState)
4/57 Checking commit 25a95f084ed4 (hw/i2c/core: Add i2c_try_create_slave() and i2c_realize_and_unref())
5/57 Checking commit 9f989583b899 (hw/misc/pca9552: Rename 'nr_leds' as 'pin_count')
6/57 Checking commit e941a0f28f09 (hw/misc/pca9552: Rename generic code as pca955x)
7/57 Checking commit 0f1dce57c842 (hw/misc/pca9552: Add generic PCA955xClass, parent of TYPE_PCA9552)
8/57 Checking commit 7b807ce59b2d (hw/misc/pca9552: Add a 'description' property for debugging purpose)
9/57 Checking commit a298de8ad941 (hw/misc/pca9552: Trace GPIO High/Low events)
10/57 Checking commit a249409d96b3 (hw/arm/aspeed: Describe each PCA9552 device)
11/57 Checking commit 4284a629e85d (hw/misc/pca9552: Trace GPIO change events)
12/57 Checking commit 05d18f333a31 (hw/misc/pca9552: Model qdev output GPIOs)
13/57 Checking commit a62f02317eca (target/arm: Add isar tests for mte)
14/57 Checking commit ac960a34f0cd (target/arm: Improve masking of SCR RES0 bits)
15/57 Checking commit 7a08bad3b039 (target/arm: Add support for MTE to SCTLR_ELx)
16/57 Checking commit 5b49b25d3af2 (target/arm: Add support for MTE to HCR_EL2 and SCR_EL3)
17/57 Checking commit 65f6cfb92d65 (target/arm: Rename DISAS_UPDATE to DISAS_UPDATE_EXIT)
18/57 Checking commit 6e399d344353 (target/arm: Add DISAS_UPDATE_NOCHAIN)
19/57 Checking commit 4a68b7d932b4 (target/arm: Add MTE system registers)
20/57 Checking commit e7cb7d7afed1 (target/arm: Add MTE bits to tb_flags)
21/57 Checking commit 3a399a492603 (target/arm: Implement the IRG instruction)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 120 lines checked

Patch 21/57 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/57 Checking commit 999913777983 (target/arm: Revise decoding for disas_add_sub_imm)
23/57 Checking commit 339c07dcf391 (target/arm: Implement the ADDG, SUBG instructions)
24/57 Checking commit 7511e2ad5be3 (target/arm: Implement the GMI instruction)
25/57 Checking commit 8661f55627a8 (target/arm: Implement the SUBP instruction)
26/57 Checking commit cd08598e34ed (target/arm: Define arm_cpu_do_unaligned_access for user-only)
27/57 Checking commit d37d71a713eb (target/arm: Implement LDG, STG, ST2G instructions)
28/57 Checking commit 7776f41acb3e (target/arm: Implement the STGP instruction)
29/57 Checking commit 776d65f3fc1f (target/arm: Restrict the values of DCZID.BS under TCG)
30/57 Checking commit a566fd917c6e (target/arm: Simplify DC_ZVA)
31/57 Checking commit 7be5f5160b5d (target/arm: Implement the LDGM, STGM, STZGM instructions)
32/57 Checking commit 1e1c18548203 (target/arm: Implement the access tag cache flushes)
33/57 Checking commit cdeec48805fc (target/arm: Move regime_el to internals.h)
34/57 Checking commit 32baf829bfd9 (target/arm: Move regime_tcr to internals.h)
35/57 Checking commit ede3f4729281 (target/arm: Add gen_mte_check1)
36/57 Checking commit 9a34608ecc5e (target/arm: Add gen_mte_checkN)
37/57 Checking commit 1da6db37a42d (target/arm: Implement helper_mte_check1)
38/57 Checking commit ea15240957ba (target/arm: Implement helper_mte_checkN)
39/57 Checking commit 94569d32654e (target/arm: Add helper_mte_check_zva)
40/57 Checking commit aac17232317e (target/arm: Use mte_checkN for sve unpredicated loads)
41/57 Checking commit 02ccebe27c4c (target/arm: Use mte_checkN for sve unpredicated stores)
42/57 Checking commit 3349c228c5f4 (target/arm: Use mte_check1 for sve LD1R)
43/57 Checking commit 51f6bf5d9bd2 (target/arm: Tidy trans_LD1R_zpri)
44/57 Checking commit bea6e791dc8f (target/arm: Add arm_tlb_bti_gp)
45/57 Checking commit d83732014932 (target/arm: Add mte helpers for sve scalar + int loads)
46/57 Checking commit 1fed9bb8029a (target/arm: Add mte helpers for sve scalar + int stores)
47/57 Checking commit 842d8a7874e5 (target/arm: Add mte helpers for sve scalar + int ff/nf loads)
48/57 Checking commit 3f3ac45273a6 (target/arm: Handle TBI for sve scalar + int memory ops)
49/57 Checking commit d090020f1244 (target/arm: Add mte helpers for sve scatter/gather memory ops)
50/57 Checking commit 4b83139357c9 (target/arm: Complete TBI clearing for user-only for SVE)
ERROR: spaces required around that '*' (ctx:VxV)
#59: FILE: target/arm/sve_helper.c:3978:
+        (TYPEM)*(TYPEE *)(vd + H(reg_off)), ra);                            \
                ^

total: 1 errors, 0 warnings, 57 lines checked

Patch 50/57 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

51/57 Checking commit b98237925749 (target/arm: Implement data cache set allocation tags)
52/57 Checking commit a3746dcbb2a8 (target/arm: Set PSTATE.TCO on exception entry)
53/57 Checking commit 9c2ff8628f27 (target/arm: Always pass cacheattr to get_phys_addr)
54/57 Checking commit d8f973e40fac (target/arm: Cache the Tagged bit for a page in MemTxAttrs)
55/57 Checking commit 207f967cf3d7 (target/arm: Create tagged ram when MTE is enabled)
56/57 Checking commit 88fa004c2881 (target/arm: Add allocation tag storage for system mode)
57/57 Checking commit 3d406b0a874b (target/arm: Enable MTE)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200626151424.30117-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com