From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> To: Viresh Kumar <viresh.kumar@linaro.org> Cc: Thomas Abraham <thomas.ab@samsung.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Kukjin Kim <kgene.kim@samsung.com>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Lukasz Majewski <l.majewski@samsung.com>, Heiko Stuebner <heiko@sntech.de>, Chanwoo Choi <cw00.choi@samsung.com>, Kevin Hilman <khilman@linaro.org>, Javier Martinez Canillas <javier@dowhile0.org>, Tobias Jakobi <tjakobi@math.uni-bielefeld.de>, Anand Moon <linux.amoon@gmail.com>, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] cpufreq: opp: fix handling of turbo modes Date: Mon, 27 Jul 2015 12:24:30 +0200 [thread overview] Message-ID: <1595601.YD6UTxy5Qg@amdc1976> (raw) In-Reply-To: <20150727083531.GC31611@linux> Hi, On Monday, July 27, 2015 02:05:31 PM Viresh Kumar wrote: > $subject is a bit wrong, we aren't fixing any issue here. We are > supporting a new feature and so it should be like: Have you read my explanation of the issue? With your OPP-v2 patches cpufreq-dt picks turbo frequencies and uses them as normal ones. (More at: http://www.spinics.net/lists/arm-kernel/msg430397.html) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > cpufreq: Mark boost frequencies based on OPP's turbo mode > > On 09-07-15, 17:43, Bartlomiej Zolnierkiewicz wrote: > > Turbo modes should be marked with CPUFREQ_BOOST_FREQ flag in > > the frequency table entry. > > > > Cc: Tomasz Figa <tomasz.figa@gmail.com> > > Cc: Michael Turquette <mturquette@baylibre.com> > > Cc: Javier Martinez Canillas <javier@dowhile0.org> > > Cc: Thomas Abraham <thomas.ab@samsung.com> > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > --- > > drivers/cpufreq/cpufreq_opp.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c > > index 773bcde..f0cf502 100644 > > --- a/drivers/cpufreq/cpufreq_opp.c > > +++ b/drivers/cpufreq/cpufreq_opp.c > > @@ -75,6 +75,8 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev, > > } > > freq_table[i].driver_data = i; > > freq_table[i].frequency = rate / 1000; > > + if (dev_pm_opp_get_turbo_mode_setting(opp) == true) > > + freq_table[i].flags |= CPUFREQ_BOOST_FREQ; > > } > > > > freq_table[i].driver_data = i; > > Rest look fine.
WARNING: multiple messages have this Message-ID (diff)
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/7] cpufreq: opp: fix handling of turbo modes Date: Mon, 27 Jul 2015 12:24:30 +0200 [thread overview] Message-ID: <1595601.YD6UTxy5Qg@amdc1976> (raw) In-Reply-To: <20150727083531.GC31611@linux> Hi, On Monday, July 27, 2015 02:05:31 PM Viresh Kumar wrote: > $subject is a bit wrong, we aren't fixing any issue here. We are > supporting a new feature and so it should be like: Have you read my explanation of the issue? With your OPP-v2 patches cpufreq-dt picks turbo frequencies and uses them as normal ones. (More at: http://www.spinics.net/lists/arm-kernel/msg430397.html) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > cpufreq: Mark boost frequencies based on OPP's turbo mode > > On 09-07-15, 17:43, Bartlomiej Zolnierkiewicz wrote: > > Turbo modes should be marked with CPUFREQ_BOOST_FREQ flag in > > the frequency table entry. > > > > Cc: Tomasz Figa <tomasz.figa@gmail.com> > > Cc: Michael Turquette <mturquette@baylibre.com> > > Cc: Javier Martinez Canillas <javier@dowhile0.org> > > Cc: Thomas Abraham <thomas.ab@samsung.com> > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > --- > > drivers/cpufreq/cpufreq_opp.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c > > index 773bcde..f0cf502 100644 > > --- a/drivers/cpufreq/cpufreq_opp.c > > +++ b/drivers/cpufreq/cpufreq_opp.c > > @@ -75,6 +75,8 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev, > > } > > freq_table[i].driver_data = i; > > freq_table[i].frequency = rate / 1000; > > + if (dev_pm_opp_get_turbo_mode_setting(opp) == true) > > + freq_table[i].flags |= CPUFREQ_BOOST_FREQ; > > } > > > > freq_table[i].driver_data = i; > > Rest look fine.
next prev parent reply other threads:[~2015-07-27 10:25 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-09 15:43 [PATCH v2 0/7] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Bartlomiej Zolnierkiewicz 2015-07-09 15:43 ` Bartlomiej Zolnierkiewicz 2015-07-09 15:43 ` [PATCH v2 1/7] opp: add dev_pm_opp_get_turbo_mode_setting() helper Bartlomiej Zolnierkiewicz 2015-07-09 15:43 ` Bartlomiej Zolnierkiewicz 2015-07-10 2:17 ` Krzysztof Kozlowski 2015-07-10 2:17 ` Krzysztof Kozlowski 2015-07-27 8:33 ` Viresh Kumar 2015-07-27 8:33 ` Viresh Kumar 2015-07-09 15:43 ` [PATCH v2 2/7] cpufreq: opp: fix handling of turbo modes Bartlomiej Zolnierkiewicz 2015-07-09 15:43 ` Bartlomiej Zolnierkiewicz 2015-07-10 2:20 ` Krzysztof Kozlowski 2015-07-10 2:20 ` Krzysztof Kozlowski 2015-07-27 8:35 ` Viresh Kumar 2015-07-27 8:35 ` Viresh Kumar 2015-07-27 10:24 ` Bartlomiej Zolnierkiewicz [this message] 2015-07-27 10:24 ` Bartlomiej Zolnierkiewicz 2015-07-27 10:35 ` Viresh Kumar 2015-07-27 10:35 ` Viresh Kumar 2015-07-27 11:14 ` Bartlomiej Zolnierkiewicz 2015-07-27 11:14 ` Bartlomiej Zolnierkiewicz 2015-07-27 11:36 ` Viresh Kumar 2015-07-27 11:36 ` Viresh Kumar 2015-07-27 11:47 ` Bartlomiej Zolnierkiewicz 2015-07-27 11:47 ` Bartlomiej Zolnierkiewicz 2015-07-30 14:37 ` Kukjin Kim 2015-07-30 14:37 ` Kukjin Kim 2015-07-31 18:58 ` Bartlomiej Zolnierkiewicz 2015-07-31 18:58 ` Bartlomiej Zolnierkiewicz 2015-08-04 1:31 ` Krzysztof Kozlowski 2015-08-04 1:31 ` Krzysztof Kozlowski 2015-07-09 15:43 ` [PATCH v2 3/7] cpufreq-dt: add turbo modes support Bartlomiej Zolnierkiewicz 2015-07-09 15:43 ` Bartlomiej Zolnierkiewicz 2015-07-10 8:22 ` Krzysztof Kozlowski 2015-07-10 8:22 ` Krzysztof Kozlowski 2015-07-27 8:37 ` Viresh Kumar 2015-07-27 8:37 ` Viresh Kumar 2015-07-27 11:01 ` Bartlomiej Zolnierkiewicz 2015-07-27 11:01 ` Bartlomiej Zolnierkiewicz 2015-07-27 11:33 ` Viresh Kumar 2015-07-27 11:33 ` Viresh Kumar 2015-07-27 11:58 ` Bartlomiej Zolnierkiewicz 2015-07-27 11:58 ` Bartlomiej Zolnierkiewicz 2015-07-27 12:01 ` Viresh Kumar 2015-07-27 12:01 ` Viresh Kumar 2015-07-09 15:43 ` [PATCH v2 4/7] clk: samsung: exynos4x12: add cpu clock configuration data and instantiate cpu clock Bartlomiej Zolnierkiewicz 2015-07-09 15:43 ` Bartlomiej Zolnierkiewicz 2015-07-10 8:30 ` Krzysztof Kozlowski 2015-07-10 8:30 ` Krzysztof Kozlowski 2015-07-10 16:12 ` Javier Martinez Canillas 2015-07-10 16:12 ` Javier Martinez Canillas 2015-07-11 6:36 ` Krzysztof Kozlowski 2015-07-11 6:36 ` Krzysztof Kozlowski 2015-07-15 9:58 ` Sylwester nawrocki 2015-07-15 9:58 ` Sylwester nawrocki 2015-07-09 15:43 ` [PATCH v2 5/7] ARM: dts: Exynos4x12: add CPU OPP and regulator supply property Bartlomiej Zolnierkiewicz 2015-07-09 15:43 ` Bartlomiej Zolnierkiewicz 2015-07-09 15:43 ` Bartlomiej Zolnierkiewicz 2015-07-10 8:35 ` Krzysztof Kozlowski 2015-07-10 8:35 ` Krzysztof Kozlowski 2015-07-09 15:43 ` [PATCH v2 6/7] ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12 Bartlomiej Zolnierkiewicz 2015-07-09 15:43 ` Bartlomiej Zolnierkiewicz 2015-07-09 15:43 ` Bartlomiej Zolnierkiewicz 2015-07-10 8:55 ` Krzysztof Kozlowski 2015-07-10 8:55 ` Krzysztof Kozlowski 2015-07-09 15:43 ` [PATCH v2 7/7] cpufreq: exynos: remove Exynos4x12 specific cpufreq driver support Bartlomiej Zolnierkiewicz 2015-07-09 15:43 ` Bartlomiej Zolnierkiewicz 2015-07-09 15:43 ` Bartlomiej Zolnierkiewicz 2015-07-10 8:57 ` Krzysztof Kozlowski 2015-07-10 8:57 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1595601.YD6UTxy5Qg@amdc1976 \ --to=b.zolnierkie@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=heiko@sntech.de \ --cc=javier@dowhile0.org \ --cc=k.kozlowski@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=kgene@kernel.org \ --cc=khilman@linaro.org \ --cc=l.majewski@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux.amoon@gmail.com \ --cc=mturquette@baylibre.com \ --cc=s.nawrocki@samsung.com \ --cc=thomas.ab@samsung.com \ --cc=tjakobi@math.uni-bielefeld.de \ --cc=tomasz.figa@gmail.com \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.