* [Bug 1889288] [NEW] aarch64 BICS instruciton doesn't set flags @ 2020-07-28 17:05 Robert 2020-07-28 18:01 ` [Bug 1889288] " Peter Maydell 2020-07-28 20:42 ` Robert 0 siblings, 2 replies; 3+ messages in thread From: Robert @ 2020-07-28 17:05 UTC (permalink / raw) To: qemu-devel Public bug reported: When reading the source for translate-a64.c here: https://github.com/qemu/qemu/blob/a466dd084f51cdc9da2e99361f674f98d7218559/target/arm/translate-a64.c#L4783 I noticed that it does not appear to call gen_logic_CC for the BICS instruction so is not setting the flags as required. I haven't tried to produce a test case for it but it seems like it might be a bug. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1889288 Title: aarch64 BICS instruciton doesn't set flags Status in QEMU: New Bug description: When reading the source for translate-a64.c here: https://github.com/qemu/qemu/blob/a466dd084f51cdc9da2e99361f674f98d7218559/target/arm/translate-a64.c#L4783 I noticed that it does not appear to call gen_logic_CC for the BICS instruction so is not setting the flags as required. I haven't tried to produce a test case for it but it seems like it might be a bug. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1889288/+subscriptions ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug 1889288] Re: aarch64 BICS instruciton doesn't set flags 2020-07-28 17:05 [Bug 1889288] [NEW] aarch64 BICS instruciton doesn't set flags Robert @ 2020-07-28 18:01 ` Peter Maydell 2020-07-28 20:42 ` Robert 1 sibling, 0 replies; 3+ messages in thread From: Peter Maydell @ 2020-07-28 18:01 UTC (permalink / raw) To: qemu-devel The code is correct (though it is admittedly not entirely obvious at first glance). The switch statement at line 4753 is on "(opc | (invert << 2))" (where opc is a 2 bit field and invert a 1 bit field). Both ANDS and BICS have opc==3 and so will cause a call to gen_logic_CC(). The difference between the two insns is that ANDC has invert==0 and BICS has invert==1. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1889288 Title: aarch64 BICS instruciton doesn't set flags Status in QEMU: Invalid Bug description: When reading the source for translate-a64.c here: https://github.com/qemu/qemu/blob/a466dd084f51cdc9da2e99361f674f98d7218559/target/arm/translate-a64.c#L4783 I noticed that it does not appear to call gen_logic_CC for the BICS instruction so is not setting the flags as required. I haven't tried to produce a test case for it but it seems like it might be a bug. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1889288/+subscriptions ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug 1889288] Re: aarch64 BICS instruciton doesn't set flags 2020-07-28 17:05 [Bug 1889288] [NEW] aarch64 BICS instruciton doesn't set flags Robert 2020-07-28 18:01 ` [Bug 1889288] " Peter Maydell @ 2020-07-28 20:42 ` Robert 1 sibling, 0 replies; 3+ messages in thread From: Robert @ 2020-07-28 20:42 UTC (permalink / raw) To: qemu-devel Oh yes I see. Sorry for the false report. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1889288 Title: aarch64 BICS instruciton doesn't set flags Status in QEMU: Invalid Bug description: When reading the source for translate-a64.c here: https://github.com/qemu/qemu/blob/a466dd084f51cdc9da2e99361f674f98d7218559/target/arm/translate-a64.c#L4783 I noticed that it does not appear to call gen_logic_CC for the BICS instruction so is not setting the flags as required. I haven't tried to produce a test case for it but it seems like it might be a bug. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1889288/+subscriptions ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-28 20:51 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-28 17:05 [Bug 1889288] [NEW] aarch64 BICS instruciton doesn't set flags Robert 2020-07-28 18:01 ` [Bug 1889288] " Peter Maydell 2020-07-28 20:42 ` Robert
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.