Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver

[Neal Liu <neal.liu@mediatek.com>]

Hi Chun-Kuang,

On Sun, 2020-08-02 at 07:50 +0800, Chun-Kuang Hu wrote:
> Hi, Neal:
> 
> Neal Liu <neal.liu@mediatek.com> 於 2020年7月29日 週三 下午4:29寫道：
> >
> > MediaTek bus fabric provides TrustZone security support and data
> > protection to prevent slaves from being accessed by unexpected
> > masters.
> > The security violation is logged and sent to the processor for
> > further analysis or countermeasures.
> >
> > Any occurrence of security violation would raise an interrupt, and
> > it will be handled by mtk-devapc driver. The violation
> > information is printed in order to find the murderer.
> >
> > Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> > ---
> 
> [snip]
> 
> > +
> > +struct mtk_devapc_context {
> > +       struct device *dev;
> > +       u32 vio_idx_num;
> > +       void __iomem *devapc_pd_base;
> 
> This is devapc context, so prefix 'devapc' is redundant.
> And, what does 'pd' mean?

'pd' means power down. Of course we would also remove it as well.
I suggest to change it as 'infra_base'.

> 
> Regards,
> Chun-Kuang.
> 
> > +       struct mtk_devapc_vio_info *vio_info;
> > +       const struct mtk_devapc_pd_offset *offset;
> > +       const struct mtk_devapc_vio_dbgs *vio_dbgs;
> > +};
> > +