* [PATCH] ASoC: msm8916-wcd-analog: fix register Interrupt offset
@ 2020-08-11 10:34 ` Srinivas Kandagatla
0 siblings, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2020-08-11 10:34 UTC (permalink / raw)
To: broonie
Cc: tiwai, alsa-devel, linux-kernel, lgirdwood, john.stultz,
Srinivas Kandagatla
For some reason interrupt set and clear register offsets are
not set correctly.
This patch corrects them!
Fixes: 585e881e5b9e ("ASoC: codecs: Add msm8916-wcd analog codec")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
sound/soc/codecs/msm8916-wcd-analog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
index 4428c62e25cf..3ddd822240e3 100644
--- a/sound/soc/codecs/msm8916-wcd-analog.c
+++ b/sound/soc/codecs/msm8916-wcd-analog.c
@@ -19,8 +19,8 @@
#define CDC_D_REVISION1 (0xf000)
#define CDC_D_PERPH_SUBTYPE (0xf005)
-#define CDC_D_INT_EN_SET (0x015)
-#define CDC_D_INT_EN_CLR (0x016)
+#define CDC_D_INT_EN_SET (0xf015)
+#define CDC_D_INT_EN_CLR (0xf016)
#define MBHC_SWITCH_INT BIT(7)
#define MBHC_MIC_ELECTRICAL_INS_REM_DET BIT(6)
#define MBHC_BUTTON_PRESS_DET BIT(5)
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ASoC: msm8916-wcd-analog: fix register Interrupt offset
@ 2020-08-11 10:34 ` Srinivas Kandagatla
0 siblings, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2020-08-11 10:34 UTC (permalink / raw)
To: broonie
Cc: alsa-devel, linux-kernel, lgirdwood, tiwai, Srinivas Kandagatla,
john.stultz
For some reason interrupt set and clear register offsets are
not set correctly.
This patch corrects them!
Fixes: 585e881e5b9e ("ASoC: codecs: Add msm8916-wcd analog codec")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
sound/soc/codecs/msm8916-wcd-analog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
index 4428c62e25cf..3ddd822240e3 100644
--- a/sound/soc/codecs/msm8916-wcd-analog.c
+++ b/sound/soc/codecs/msm8916-wcd-analog.c
@@ -19,8 +19,8 @@
#define CDC_D_REVISION1 (0xf000)
#define CDC_D_PERPH_SUBTYPE (0xf005)
-#define CDC_D_INT_EN_SET (0x015)
-#define CDC_D_INT_EN_CLR (0x016)
+#define CDC_D_INT_EN_SET (0xf015)
+#define CDC_D_INT_EN_CLR (0xf016)
#define MBHC_SWITCH_INT BIT(7)
#define MBHC_MIC_ELECTRICAL_INS_REM_DET BIT(6)
#define MBHC_BUTTON_PRESS_DET BIT(5)
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ASoC: msm8916-wcd-analog: fix register Interrupt offset
2020-08-11 10:34 ` Srinivas Kandagatla
@ 2020-08-14 17:43 ` Stephan Gerhold
-1 siblings, 0 replies; 6+ messages in thread
From: Stephan Gerhold @ 2020-08-14 17:43 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: broonie, alsa-devel, linux-kernel, lgirdwood, tiwai, john.stultz
On Tue, Aug 11, 2020 at 11:34:52AM +0100, Srinivas Kandagatla wrote:
> For some reason interrupt set and clear register offsets are
> not set correctly.
> This patch corrects them!
>
> Fixes: 585e881e5b9e ("ASoC: codecs: Add msm8916-wcd analog codec")
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/codecs/msm8916-wcd-analog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index 4428c62e25cf..3ddd822240e3 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -19,8 +19,8 @@
>
> #define CDC_D_REVISION1 (0xf000)
> #define CDC_D_PERPH_SUBTYPE (0xf005)
> -#define CDC_D_INT_EN_SET (0x015)
> -#define CDC_D_INT_EN_CLR (0x016)
> +#define CDC_D_INT_EN_SET (0xf015)
> +#define CDC_D_INT_EN_CLR (0xf016)
> #define MBHC_SWITCH_INT BIT(7)
> #define MBHC_MIC_ELECTRICAL_INS_REM_DET BIT(6)
> #define MBHC_BUTTON_PRESS_DET BIT(5)
> --
> 2.21.0
>
It's surprising that we didn't notice this before. Seems like the HW
has exactly the IRQs we want enabled by default. Everything seems to be
still working fine after this patch, so FWIW:
Tested-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
Thanks!
Stephan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ASoC: msm8916-wcd-analog: fix register Interrupt offset
@ 2020-08-14 17:43 ` Stephan Gerhold
0 siblings, 0 replies; 6+ messages in thread
From: Stephan Gerhold @ 2020-08-14 17:43 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: alsa-devel, lgirdwood, tiwai, linux-kernel, broonie, john.stultz
On Tue, Aug 11, 2020 at 11:34:52AM +0100, Srinivas Kandagatla wrote:
> For some reason interrupt set and clear register offsets are
> not set correctly.
> This patch corrects them!
>
> Fixes: 585e881e5b9e ("ASoC: codecs: Add msm8916-wcd analog codec")
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/codecs/msm8916-wcd-analog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index 4428c62e25cf..3ddd822240e3 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -19,8 +19,8 @@
>
> #define CDC_D_REVISION1 (0xf000)
> #define CDC_D_PERPH_SUBTYPE (0xf005)
> -#define CDC_D_INT_EN_SET (0x015)
> -#define CDC_D_INT_EN_CLR (0x016)
> +#define CDC_D_INT_EN_SET (0xf015)
> +#define CDC_D_INT_EN_CLR (0xf016)
> #define MBHC_SWITCH_INT BIT(7)
> #define MBHC_MIC_ELECTRICAL_INS_REM_DET BIT(6)
> #define MBHC_BUTTON_PRESS_DET BIT(5)
> --
> 2.21.0
>
It's surprising that we didn't notice this before. Seems like the HW
has exactly the IRQs we want enabled by default. Everything seems to be
still working fine after this patch, so FWIW:
Tested-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
Thanks!
Stephan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: msm8916-wcd-analog: fix register Interrupt offset
2020-08-11 10:34 ` Srinivas Kandagatla
@ 2020-08-18 16:54 ` Mark Brown
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2020-08-18 16:54 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: john.stultz, tiwai, lgirdwood, linux-kernel, alsa-devel
On Tue, 11 Aug 2020 11:34:52 +0100, Srinivas Kandagatla wrote:
> For some reason interrupt set and clear register offsets are
> not set correctly.
> This patch corrects them!
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: msm8916-wcd-analog: fix register Interrupt offset
commit: ff69c97ef84c9f7795adb49e9f07c9adcdd0c288
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ASoC: msm8916-wcd-analog: fix register Interrupt offset
@ 2020-08-18 16:54 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2020-08-18 16:54 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: linux-kernel, alsa-devel, john.stultz, tiwai, lgirdwood
On Tue, 11 Aug 2020 11:34:52 +0100, Srinivas Kandagatla wrote:
> For some reason interrupt set and clear register offsets are
> not set correctly.
> This patch corrects them!
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: msm8916-wcd-analog: fix register Interrupt offset
commit: ff69c97ef84c9f7795adb49e9f07c9adcdd0c288
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-18 17:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 10:34 [PATCH] ASoC: msm8916-wcd-analog: fix register Interrupt offset Srinivas Kandagatla
2020-08-11 10:34 ` Srinivas Kandagatla
2020-08-14 17:43 ` Stephan Gerhold
2020-08-14 17:43 ` Stephan Gerhold
2020-08-18 16:54 ` Mark Brown
2020-08-18 16:54 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.