All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board
@ 2020-08-27  5:51 Lee Shawn C
  2020-08-27  6:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 10+ messages in thread
From: Lee Shawn C @ 2020-08-27  5:51 UTC (permalink / raw)
  To: intel-gfx; +Cc: Cooper Chiou, William Tseng, Jani Nikula

Customer report random display flicker issue on Nightfury board.
And we found this problem might be caused by VT-d and FBC are
both enabled. According to sighting report, it recommend to turn
drm/i915/fbc: disable FBC on Nightfury board

Customer report random display flicker issue on Nightfury board.
And we found this problem might be caused by VT-d and FBC are
both enabled. According to sighting report, it recommend to turn
FBC off to workaround this kind of issue.

This change refer to DMI BOARD_VENDOR and BOARD_NAME information
to disable FBC.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: William Tseng <william.tseng@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
 drivers/gpu/drm/i915/display/intel_fbc.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index 327af428d73f..20660fdbab36 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -39,6 +39,7 @@
  */
 
 #include <drm/drm_fourcc.h>
+#include <linux/dmi.h>
 
 #include "i915_drv.h"
 #include "i915_trace.h"
@@ -1439,6 +1440,24 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
 	return 0;
 }
 
+static int intel_fbc_vtd_callback(const struct dmi_system_id *id)
+{
+	DRM_DEBUG_KMS("Disabling FBC to prevent screen flicker on %s device\n", id->ident);
+	return 1;
+}
+
+static const struct dmi_system_id intel_fbc_vtd_detect[] = {
+	{
+		.callback = intel_fbc_vtd_callback,
+		.ident = "Google Nightfury",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Google"),
+			DMI_MATCH(DMI_BOARD_NAME, "Nightfury"),
+		},
+	},
+	{ }
+};
+
 static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
 {
 	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */
@@ -1450,6 +1469,9 @@ static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
 		return true;
 	}
 
+	if (dmi_check_system(intel_fbc_vtd_detect))
+		return true;
+
 	return false;
 }
 
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-09-21 13:16 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27  5:51 [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board Lee Shawn C
2020-08-27  6:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-08-27  8:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-09-11 13:48 ` [Intel-gfx] [PATCH v2] " Lee Shawn C
2020-09-11 14:21 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2020-09-15 13:18   ` Lee, Shawn C
2020-09-15 13:35     ` Ville Syrjälä
2020-09-21 13:15       ` Lee, Shawn C
2020-09-11 14:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: disable FBC on Nightfury board (rev2) Patchwork
2020-09-11 17:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.