* [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board
@ 2020-08-27 5:51 Lee Shawn C
2020-08-27 6:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Lee Shawn C @ 2020-08-27 5:51 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou, William Tseng, Jani Nikula
Customer report random display flicker issue on Nightfury board.
And we found this problem might be caused by VT-d and FBC are
both enabled. According to sighting report, it recommend to turn
drm/i915/fbc: disable FBC on Nightfury board
Customer report random display flicker issue on Nightfury board.
And we found this problem might be caused by VT-d and FBC are
both enabled. According to sighting report, it recommend to turn
FBC off to workaround this kind of issue.
This change refer to DMI BOARD_VENDOR and BOARD_NAME information
to disable FBC.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: William Tseng <william.tseng@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_fbc.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index 327af428d73f..20660fdbab36 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -39,6 +39,7 @@
*/
#include <drm/drm_fourcc.h>
+#include <linux/dmi.h>
#include "i915_drv.h"
#include "i915_trace.h"
@@ -1439,6 +1440,24 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
return 0;
}
+static int intel_fbc_vtd_callback(const struct dmi_system_id *id)
+{
+ DRM_DEBUG_KMS("Disabling FBC to prevent screen flicker on %s device\n", id->ident);
+ return 1;
+}
+
+static const struct dmi_system_id intel_fbc_vtd_detect[] = {
+ {
+ .callback = intel_fbc_vtd_callback,
+ .ident = "Google Nightfury",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Google"),
+ DMI_MATCH(DMI_BOARD_NAME, "Nightfury"),
+ },
+ },
+ { }
+};
+
static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
{
/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */
@@ -1450,6 +1469,9 @@ static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
return true;
}
+ if (dmi_check_system(intel_fbc_vtd_detect))
+ return true;
+
return false;
}
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: disable FBC on Nightfury board
2020-08-27 5:51 [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board Lee Shawn C
@ 2020-08-27 6:31 ` Patchwork
2020-08-27 8:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (4 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2020-08-27 6:31 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4601 bytes --]
== Series Details ==
Series: drm/i915/fbc: disable FBC on Nightfury board
URL : https://patchwork.freedesktop.org/series/81087/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8931 -> Patchwork_18415
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/index.html
Known issues
------------
Here are the changes found in Patchwork_18415 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-apl-guc: [PASS][1] -> [TIMEOUT][2] ([i915#1635])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/fi-apl-guc/igt@gem_exec_gttfill@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/fi-apl-guc/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_parallel@engines@contexts:
- fi-kbl-r: [PASS][3] -> [INCOMPLETE][4] ([i915#2398])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/fi-kbl-r/igt@gem_exec_parallel@engines@contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/fi-kbl-r/igt@gem_exec_parallel@engines@contexts.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-kbl-x1275: [DMESG-WARN][7] ([i915#1982] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][8] ([i915#1982] / [i915#62] / [i915#92])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/fi-kbl-x1275/igt@gem_exec_suspend@basic-s3.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/fi-kbl-x1275/igt@gem_exec_suspend@basic-s3.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][9] ([i915#62] / [i915#95]) -> [SKIP][10] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92]) -> [DMESG-WARN][12] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
* igt@prime_vgem@basic-fence-flip:
- fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][14] ([i915#62] / [i915#92])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2398]: https://gitlab.freedesktop.org/drm/intel/issues/2398
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (38 -> 34)
------------------------------
Additional (1): fi-cml-u2
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
Build changes
-------------
* Linux: CI_DRM_8931 -> Patchwork_18415
CI-20190529: 20190529
CI_DRM_8931: 7622838fc35246114e310b63e3dbb4635502e674 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5772: 53dfd92f87ecf44251948025533c88f6b889ffeb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18415: 250fdd190e71f7c3b5efa262371f37e39d346c6c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
250fdd190e71 drm/i915/fbc: disable FBC on Nightfury board
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/index.html
[-- Attachment #1.2: Type: text/html, Size: 6405 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/fbc: disable FBC on Nightfury board
2020-08-27 5:51 [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board Lee Shawn C
2020-08-27 6:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-08-27 8:28 ` Patchwork
2020-09-11 13:48 ` [Intel-gfx] [PATCH v2] " Lee Shawn C
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2020-08-27 8:28 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 18549 bytes --]
== Series Details ==
Series: drm/i915/fbc: disable FBC on Nightfury board
URL : https://patchwork.freedesktop.org/series/81087/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8931_full -> Patchwork_18415_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18415_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18415_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18415_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_persistence@processes:
- shard-skl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl5/igt@gem_ctx_persistence@processes.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl2/igt@gem_ctx_persistence@processes.html
Known issues
------------
Here are the changes found in Patchwork_18415_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_reloc@basic-concurrent0:
- shard-tglb: [PASS][3] -> [TIMEOUT][4] ([i915#1958]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-tglb8/igt@gem_exec_reloc@basic-concurrent0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-tglb5/igt@gem_exec_reloc@basic-concurrent0.html
- shard-apl: [PASS][5] -> [TIMEOUT][6] ([i915#1635] / [i915#1958]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-apl8/igt@gem_exec_reloc@basic-concurrent0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-apl6/igt@gem_exec_reloc@basic-concurrent0.html
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-glk: [PASS][7] -> [DMESG-WARN][8] ([i915#118] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-glk4/igt@gem_exec_whisper@basic-contexts-forked-all.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-glk5/igt@gem_exec_whisper@basic-contexts-forked-all.html
* igt@gem_exec_whisper@basic-fds-priority-all:
- shard-glk: [PASS][9] -> [TIMEOUT][10] ([i915#1958])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-glk6/igt@gem_exec_whisper@basic-fds-priority-all.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-glk9/igt@gem_exec_whisper@basic-fds-priority-all.html
* igt@i915_selftest@mock@contexts:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([i915#198] / [i915#2278])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl10/igt@i915_selftest@mock@contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl2/igt@i915_selftest@mock@contexts.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-iclb: [PASS][13] -> [FAIL][14] ([i915#1119])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-iclb7/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-iclb1/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html
* igt@kms_color@pipe-c-ctm-0-25:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +12 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl8/igt@kms_color@pipe-c-ctm-0-25.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl1/igt@kms_color@pipe-c-ctm-0-25.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#72])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-glk5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#1635] / [i915#1982]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-apl6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-apl4/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#79])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +6 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-kbl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-kbl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- shard-tglb: [PASS][25] -> [DMESG-WARN][26] ([i915#1982])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][27] -> [FAIL][28] ([i915#1188]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl1/igt@kms_hdr@bpc-switch-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#108145] / [i915#265]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][31] -> [FAIL][32] ([i915#173])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-iclb7/igt@kms_psr@no_drrs.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_psr@suspend:
- shard-skl: [PASS][35] -> [INCOMPLETE][36] ([i915#198])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl9/igt@kms_psr@suspend.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl5/igt@kms_psr@suspend.html
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-skl: [INCOMPLETE][37] ([i915#198]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl9/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl10/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_exec_gttfill@all:
- shard-apl: [TIMEOUT][39] ([i915#1635] / [i915#1958]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-apl2/igt@gem_exec_gttfill@all.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-apl8/igt@gem_exec_gttfill@all.html
* igt@gem_exec_whisper@basic-fds:
- shard-iclb: [TIMEOUT][41] ([i915#1958]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-iclb3/igt@gem_exec_whisper@basic-fds.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-iclb7/igt@gem_exec_whisper@basic-fds.html
* igt@gem_exec_whisper@basic-fds-priority:
- shard-kbl: [TIMEOUT][43] ([i915#1958]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-kbl1/igt@gem_exec_whisper@basic-fds-priority.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-kbl1/igt@gem_exec_whisper@basic-fds-priority.html
* igt@gem_exec_whisper@basic-forked:
- shard-skl: [TIMEOUT][45] ([i915#1958]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl9/igt@gem_exec_whisper@basic-forked.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl5/igt@gem_exec_whisper@basic-forked.html
* igt@gem_exec_whisper@basic-normal-all:
- shard-glk: [DMESG-WARN][47] ([i915#118] / [i915#95]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-glk5/igt@gem_exec_whisper@basic-normal-all.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-glk8/igt@gem_exec_whisper@basic-normal-all.html
* igt@gem_exec_whisper@basic-queues-forked-all:
- shard-glk: [TIMEOUT][49] ([i915#1958]) -> [PASS][50] +4 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-glk9/igt@gem_exec_whisper@basic-queues-forked-all.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-glk7/igt@gem_exec_whisper@basic-queues-forked-all.html
* igt@gem_sync@basic-store-all:
- shard-apl: [FAIL][51] ([i915#1635] / [i915#2356]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-apl7/igt@gem_sync@basic-store-all.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-apl1/igt@gem_sync@basic-store-all.html
* igt@i915_pm_rps@waitboost:
- shard-hsw: [INCOMPLETE][53] -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-hsw1/igt@i915_pm_rps@waitboost.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-hsw8/igt@i915_pm_rps@waitboost.html
* igt@i915_selftest@mock@contexts:
- shard-apl: [INCOMPLETE][55] ([i915#1635] / [i915#2278]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-apl8/igt@i915_selftest@mock@contexts.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-apl7/igt@i915_selftest@mock@contexts.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-glk: [FAIL][57] ([i915#1119]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-glk5/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-glk4/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][59] ([i915#180]) -> [PASS][60] +9 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_flip@2x-dpms-vs-vblank-race@ab-vga1-hdmi-a1:
- shard-hsw: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-hsw6/igt@kms_flip@2x-dpms-vs-vblank-race@ab-vga1-hdmi-a1.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-hsw7/igt@kms_flip@2x-dpms-vs-vblank-race@ab-vga1-hdmi-a1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp1:
- shard-kbl: [FAIL][63] ([i915#2122]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-kbl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp1.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-kbl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp1.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-cpu:
- shard-tglb: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-tglb7/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-cpu.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-tglb3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-skl: [FAIL][67] ([i915#49]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][69] ([fdo#108145] / [i915#265]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_cursor@pipe-b-overlay-size-256:
- shard-skl: [DMESG-WARN][71] ([i915#1982]) -> [PASS][72] +6 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl8/igt@kms_plane_cursor@pipe-b-overlay-size-256.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl1/igt@kms_plane_cursor@pipe-b-overlay-size-256.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][73] ([fdo#109441]) -> [PASS][74] +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-iclb4/igt@kms_psr@psr2_primary_mmap_cpu.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-c-accuracy-idle:
- shard-skl: [FAIL][75] ([i915#43]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl3/igt@kms_vblank@pipe-c-accuracy-idle.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl9/igt@kms_vblank@pipe-c-accuracy-idle.html
* igt@perf_pmu@module-unload:
- shard-iclb: [DMESG-WARN][77] ([i915#1982]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-iclb7/igt@perf_pmu@module-unload.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-iclb1/igt@perf_pmu@module-unload.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][79] ([i915#588]) -> [SKIP][80] ([i915#658])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-iclb3/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_color@pipe-b-ctm-max:
- shard-skl: [DMESG-WARN][81] ([i915#1982]) -> [FAIL][82] ([i915#168])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-skl8/igt@kms_color@pipe-b-ctm-max.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-skl1/igt@kms_color@pipe-b-ctm-max.html
* igt@kms_content_protection@lic:
- shard-kbl: [TIMEOUT][83] ([i915#1319]) -> [TIMEOUT][84] ([i915#1319] / [i915#1958])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8931/shard-kbl2/igt@kms_content_protection@lic.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/shard-kbl7/igt@kms_content_protection@lic.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1119]: https://gitlab.freedesktop.org/drm/intel/issues/1119
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#168]: https://gitlab.freedesktop.org/drm/intel/issues/168
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2278]: https://gitlab.freedesktop.org/drm/intel/issues/2278
[i915#2356]: https://gitlab.freedesktop.org/drm/intel/issues/2356
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8931 -> Patchwork_18415
CI-20190529: 20190529
CI_DRM_8931: 7622838fc35246114e310b63e3dbb4635502e674 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5772: 53dfd92f87ecf44251948025533c88f6b889ffeb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18415: 250fdd190e71f7c3b5efa262371f37e39d346c6c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18415/index.html
[-- Attachment #1.2: Type: text/html, Size: 22202 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/fbc: disable FBC on Nightfury board
2020-08-27 5:51 [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board Lee Shawn C
2020-08-27 6:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-08-27 8:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-09-11 13:48 ` Lee Shawn C
2020-09-11 14:21 ` [Intel-gfx] [PATCH] " Ville Syrjälä
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Lee Shawn C @ 2020-09-11 13:48 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou, William Tseng, Jani Nikula
Customer report random display flicker issue on Nightfury board.
And we found this problem might be caused by VT-d and FBC are
both enabled. According to sighting report, it recommend to turn
FBC off to workaround this kind of issue.
This change refer to DMI BOARD_VENDOR and BOARD_NAME information
to disable FBC.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: William Tseng <william.tseng@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
v2: fix typo.
---
drivers/gpu/drm/i915/display/intel_fbc.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index 327af428d73f..20660fdbab36 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -39,6 +39,7 @@
*/
#include <drm/drm_fourcc.h>
+#include <linux/dmi.h>
#include "i915_drv.h"
#include "i915_trace.h"
@@ -1439,6 +1440,24 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
return 0;
}
+static int intel_fbc_vtd_callback(const struct dmi_system_id *id)
+{
+ DRM_DEBUG_KMS("Disabling FBC to prevent screen flicker on %s device\n", id->ident);
+ return 1;
+}
+
+static const struct dmi_system_id intel_fbc_vtd_detect[] = {
+ {
+ .callback = intel_fbc_vtd_callback,
+ .ident = "Google Nightfury",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Google"),
+ DMI_MATCH(DMI_BOARD_NAME, "Nightfury"),
+ },
+ },
+ { }
+};
+
static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
{
/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */
@@ -1450,6 +1469,9 @@ static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
return true;
}
+ if (dmi_check_system(intel_fbc_vtd_detect))
+ return true;
+
return false;
}
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board
2020-08-27 5:51 [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board Lee Shawn C
` (2 preceding siblings ...)
2020-09-11 13:48 ` [Intel-gfx] [PATCH v2] " Lee Shawn C
@ 2020-09-11 14:21 ` Ville Syrjälä
2020-09-15 13:18 ` Lee, Shawn C
2020-09-11 14:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: disable FBC on Nightfury board (rev2) Patchwork
2020-09-11 17:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjälä @ 2020-09-11 14:21 UTC (permalink / raw)
To: Lee Shawn C; +Cc: Cooper Chiou, William Tseng, Jani Nikula, intel-gfx
On Thu, Aug 27, 2020 at 01:51:29PM +0800, Lee Shawn C wrote:
> Customer report random display flicker issue on Nightfury board.
> And we found this problem might be caused by VT-d and FBC are
> both enabled. According to sighting report, it recommend to turn
> drm/i915/fbc: disable FBC on Nightfury board
>
> Customer report random display flicker issue on Nightfury board.
> And we found this problem might be caused by VT-d and FBC are
> both enabled. According to sighting report, it recommend to turn
> FBC off to workaround this kind of issue.
>
> This change refer to DMI BOARD_VENDOR and BOARD_NAME information
> to disable FBC.
What is this "nightfury board" exactly?
I think we're missing at least one fbc vs. vt-d w/a on some
kbl/cfl/etc. era platforms:
git://github.com/vsyrjala/linux.git vtd_wa_1142
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: William Tseng <william.tseng@intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fbc.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index 327af428d73f..20660fdbab36 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -39,6 +39,7 @@
> */
>
> #include <drm/drm_fourcc.h>
> +#include <linux/dmi.h>
>
> #include "i915_drv.h"
> #include "i915_trace.h"
> @@ -1439,6 +1440,24 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
> return 0;
> }
>
> +static int intel_fbc_vtd_callback(const struct dmi_system_id *id)
> +{
> + DRM_DEBUG_KMS("Disabling FBC to prevent screen flicker on %s device\n", id->ident);
> + return 1;
> +}
> +
> +static const struct dmi_system_id intel_fbc_vtd_detect[] = {
> + {
> + .callback = intel_fbc_vtd_callback,
> + .ident = "Google Nightfury",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Google"),
> + DMI_MATCH(DMI_BOARD_NAME, "Nightfury"),
> + },
> + },
> + { }
> +};
> +
> static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
> {
> /* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */
> @@ -1450,6 +1469,9 @@ static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
> return true;
> }
>
> + if (dmi_check_system(intel_fbc_vtd_detect))
> + return true;
> +
> return false;
> }
>
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: disable FBC on Nightfury board (rev2)
2020-08-27 5:51 [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board Lee Shawn C
` (3 preceding siblings ...)
2020-09-11 14:21 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2020-09-11 14:45 ` Patchwork
2020-09-11 17:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2020-09-11 14:45 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 8616 bytes --]
== Series Details ==
Series: drm/i915/fbc: disable FBC on Nightfury board (rev2)
URL : https://patchwork.freedesktop.org/series/81087/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9001 -> Patchwork_18483
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/index.html
Known issues
------------
Here are the changes found in Patchwork_18483 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [PASS][3] -> [DMESG-WARN][4] ([i915#62] / [i915#92] / [i915#95])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-kbl-x1275/igt@kms_busy@basic@flip.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-kbl-x1275/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1:
- fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
* igt@vgem_basic@dmabuf-fence:
- fi-tgl-y: [PASS][11] -> [DMESG-WARN][12] ([i915#402])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-tgl-y/igt@vgem_basic@dmabuf-fence.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-tgl-y/igt@vgem_basic@dmabuf-fence.html
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@execlists:
- fi-icl-y: [INCOMPLETE][15] ([i915#2276]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-icl-y/igt@i915_selftest@live@execlists.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-icl-y/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gem_contexts:
- fi-tgl-u2: [INCOMPLETE][17] ([i915#2045]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [DMESG-WARN][19] ([i915#2203]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
* igt@kms_flip@basic-flip-vs-dpms@d-edp1:
- fi-tgl-y: [DMESG-WARN][23] ([i915#1982]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-tgl-y/igt@kms_flip@basic-flip-vs-dpms@d-edp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-tgl-y/igt@kms_flip@basic-flip-vs-dpms@d-edp1.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2:
- fi-skl-guc: [DMESG-WARN][25] ([i915#2203]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html
* igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y: [DMESG-WARN][27] ([i915#402]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][29] ([i915#62] / [i915#95]) -> [DMESG-FAIL][30] ([i915#62])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
- fi-kbl-guc: [DMESG-WARN][31] ([i915#2203]) -> [SKIP][32] ([fdo#109271])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-kbl-x1275: [DMESG-WARN][33] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][34] ([i915#62] / [i915#92]) +4 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-kbl-x1275/igt@kms_force_connector_basic@force-connector-state.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-kbl-x1275/igt@kms_force_connector_basic@force-connector-state.html
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][35] ([i915#62] / [i915#92]) -> [DMESG-WARN][36] ([i915#62] / [i915#92] / [i915#95]) +5 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2045]: https://gitlab.freedesktop.org/drm/intel/issues/2045
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2276]: https://gitlab.freedesktop.org/drm/intel/issues/2276
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (46 -> 40)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9001 -> Patchwork_18483
CI-20190529: 20190529
CI_DRM_9001: b6b9f8f7195b8b49b7fec6e3a66796698c1dcb35 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5781: 66766dd7cd99465d977ac07db8a2413dbbfe8d84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18483: bda9496309a18925a91f057b1a214de7ec610b0b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
bda9496309a1 drm/i915/fbc: disable FBC on Nightfury board
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/index.html
[-- Attachment #1.2: Type: text/html, Size: 11030 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/fbc: disable FBC on Nightfury board (rev2)
2020-08-27 5:51 [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board Lee Shawn C
` (4 preceding siblings ...)
2020-09-11 14:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: disable FBC on Nightfury board (rev2) Patchwork
@ 2020-09-11 17:47 ` Patchwork
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2020-09-11 17:47 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 18112 bytes --]
== Series Details ==
Series: drm/i915/fbc: disable FBC on Nightfury board (rev2)
URL : https://patchwork.freedesktop.org/series/81087/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9001_full -> Patchwork_18483_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18483_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-kbl3/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_exec_whisper@basic-fds-priority:
- shard-glk: [PASS][3] -> [DMESG-WARN][4] ([i915#118] / [i915#95])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-glk6/igt@gem_exec_whisper@basic-fds-priority.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-glk9/igt@gem_exec_whisper@basic-fds-priority.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-snb: [PASS][5] -> [TIMEOUT][6] ([i915#1958])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-snb2/igt@gem_workarounds@suspend-resume-fd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-snb4/igt@gem_workarounds@suspend-resume-fd.html
* igt@gen9_exec_parse@allowed-all:
- shard-skl: [PASS][7] -> [DMESG-WARN][8] ([i915#1436] / [i915#716])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl2/igt@gen9_exec_parse@allowed-all.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl6/igt@gen9_exec_parse@allowed-all.html
* igt@kms_cursor_crc@pipe-c-cursor-256x256-random:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#54])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-256x256-random.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-256x256-random.html
* igt@kms_cursor_edge_walk@pipe-c-128x128-top-edge:
- shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-glk8/igt@kms_cursor_edge_walk@pipe-c-128x128-top-edge.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-glk6/igt@kms_cursor_edge_walk@pipe-c-128x128-top-edge.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-skl: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +5 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl2/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#1635] / [i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-apl2/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-apl2/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#2122])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-glk5/igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-glk1/igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
- shard-hsw: [PASS][19] -> [INCOMPLETE][20] ([i915#2055])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-hsw4/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-hsw4/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#2122])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl9/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-tglb: [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render:
- shard-iclb: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-iclb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][27] -> [FAIL][28] ([i915#1188])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl10/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane@plane-panning-top-left-pipe-b-planes:
- shard-skl: [PASS][29] -> [FAIL][30] ([i915#1036]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl3/igt@kms_plane@plane-panning-top-left-pipe-b-planes.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl5/igt@kms_plane@plane-panning-top-left-pipe-b-planes.html
* igt@sysfs_heartbeat_interval@mixed@bcs0:
- shard-skl: [PASS][31] -> [FAIL][32] ([i915#1731])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl10/igt@sysfs_heartbeat_interval@mixed@bcs0.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl3/igt@sysfs_heartbeat_interval@mixed@bcs0.html
#### Possible fixes ####
* igt@gem_eio@kms:
- shard-snb: [DMESG-WARN][33] ([i915#1982]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-snb7/igt@gem_eio@kms.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-snb6/igt@gem_eio@kms.html
* igt@gem_exec_reloc@basic-many-active@vecs0:
- shard-glk: [FAIL][35] ([i915#2389]) -> [PASS][36] +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-glk9/igt@gem_exec_reloc@basic-many-active@vecs0.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-glk7/igt@gem_exec_reloc@basic-many-active@vecs0.html
* igt@gem_exec_whisper@basic-contexts-priority:
- shard-iclb: [DMESG-WARN][37] ([i915#1982]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-iclb2/igt@gem_exec_whisper@basic-contexts-priority.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-iclb1/igt@gem_exec_whisper@basic-contexts-priority.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][39] ([i915#1436] / [i915#716]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl6/igt@gen9_exec_parse@allowed-single.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl2/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][41] ([i915#454]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-iclb1/igt@i915_pm_dc@dc6-psr.html
* igt@i915_selftest@mock@contexts:
- shard-apl: [INCOMPLETE][43] ([i915#1635] / [i915#2278]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-apl7/igt@i915_selftest@mock@contexts.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-apl6/igt@i915_selftest@mock@contexts.html
* igt@kms_cursor_crc@pipe-b-cursor-64x64-rapid-movement:
- shard-snb: [SKIP][45] ([fdo#109271]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-snb4/igt@kms_cursor_crc@pipe-b-cursor-64x64-rapid-movement.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-snb2/igt@kms_cursor_crc@pipe-b-cursor-64x64-rapid-movement.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [INCOMPLETE][47] ([i915#300]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_edge_walk@pipe-c-64x64-top-edge:
- shard-skl: [DMESG-WARN][49] ([i915#1982]) -> [PASS][50] +4 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl3/igt@kms_cursor_edge_walk@pipe-c-64x64-top-edge.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl2/igt@kms_cursor_edge_walk@pipe-c-64x64-top-edge.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [FAIL][51] ([i915#96]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-hsw8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-hsw7/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][53] ([i915#2346]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size:
- shard-kbl: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-kbl6/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-kbl7/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1:
- shard-hsw: [INCOMPLETE][57] ([i915#2055]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-hsw6/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-hsw6/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [DMESG-WARN][59] ([i915#180]) -> [PASS][60] +9 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-kbl1/igt@kms_flip@flip-vs-suspend@c-dp1.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-kbl3/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [FAIL][61] ([i915#2122]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl9/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp1:
- shard-kbl: [FAIL][63] ([i915#2122]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-kbl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp1.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-kbl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp1.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render:
- shard-tglb: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-tglb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-tglb2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][67] ([fdo#109441]) -> [PASS][68] +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-iclb8/igt@kms_psr@psr2_suspend.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-iclb2/igt@kms_psr@psr2_suspend.html
* igt@kms_vblank@pipe-c-wait-forked-busy:
- shard-apl: [DMESG-WARN][69] ([i915#1635] / [i915#1982]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-apl6/igt@kms_vblank@pipe-c-wait-forked-busy.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-apl1/igt@kms_vblank@pipe-c-wait-forked-busy.html
#### Warnings ####
* igt@kms_content_protection@atomic-dpms:
- shard-apl: [TIMEOUT][71] ([i915#1319] / [i915#1635] / [i915#1958]) -> [TIMEOUT][72] ([i915#1319] / [i915#1635])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-apl2/igt@kms_content_protection@atomic-dpms.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-apl3/igt@kms_content_protection@atomic-dpms.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [DMESG-FAIL][73] ([i915#1982]) -> [DMESG-WARN][74] ([i915#1982])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [DMESG-WARN][75] ([i915#1982]) -> [FAIL][76] ([fdo#108145] / [i915#265])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][77] ([fdo#108145] / [i915#265]) -> [DMESG-FAIL][78] ([fdo#108145] / [i915#1982]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9001/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1036]: https://gitlab.freedesktop.org/drm/intel/issues/1036
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2278]: https://gitlab.freedesktop.org/drm/intel/issues/2278
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9001 -> Patchwork_18483
CI-20190529: 20190529
CI_DRM_9001: b6b9f8f7195b8b49b7fec6e3a66796698c1dcb35 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5781: 66766dd7cd99465d977ac07db8a2413dbbfe8d84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18483: bda9496309a18925a91f057b1a214de7ec610b0b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18483/index.html
[-- Attachment #1.2: Type: text/html, Size: 21672 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board
2020-09-11 14:21 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2020-09-15 13:18 ` Lee, Shawn C
2020-09-15 13:35 ` Ville Syrjälä
0 siblings, 1 reply; 11+ messages in thread
From: Lee, Shawn C @ 2020-09-15 13:18 UTC (permalink / raw)
To: Ville Syrjälä
Cc: Chiou, Cooper, Tseng, William, Nikula, Jani, intel-gfx
On Fri, Sept. 11, 2020, 2:21 p.m. Ville Syrjälä wrote:
>On Thu, Aug 27, 2020 at 01:51:29PM +0800, Lee Shawn C wrote:
>> Customer report random display flicker issue on Nightfury board.
>> And we found this problem might be caused by VT-d and FBC are both
>> enabled. According to sighting report, it recommend to turn
>> drm/i915/fbc: disable FBC on Nightfury board
>>
>> Customer report random display flicker issue on Nightfury board.
>> And we found this problem might be caused by VT-d and FBC are both
>> enabled. According to sighting report, it recommend to turn FBC off to
>> workaround this kind of issue.
>>
>> This change refer to DMI BOARD_VENDOR and BOARD_NAME information to
>> disable FBC.
>
>What is this "nightfury board" exactly?
It is chrome os project on CML platform. The board name is "nightfury".
>
>I think we're missing at least one fbc vs. vt-d w/a on some kbl/cfl/etc. era platforms:
>git://github.com/vsyrjala/linux.git vtd_wa_1142
>
>>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: William Tseng <william.tseng@intel.com>
>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_fbc.c | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c
>> b/drivers/gpu/drm/i915/display/intel_fbc.c
>> index 327af428d73f..20660fdbab36 100644
>> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
>> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
>> @@ -39,6 +39,7 @@
>> */
>>
>> #include <drm/drm_fourcc.h>
>> +#include <linux/dmi.h>
>>
>> #include "i915_drv.h"
>> #include "i915_trace.h"
>> @@ -1439,6 +1440,24 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
>> return 0;
>> }
>>
>> +static int intel_fbc_vtd_callback(const struct dmi_system_id *id) {
>> + DRM_DEBUG_KMS("Disabling FBC to prevent screen flicker on %s device\n", id->ident);
>> + return 1;
>> +}
>> +
>> +static const struct dmi_system_id intel_fbc_vtd_detect[] = {
>> + {
>> + .callback = intel_fbc_vtd_callback,
>> + .ident = "Google Nightfury",
>> + .matches = {
>> + DMI_MATCH(DMI_BOARD_VENDOR, "Google"),
>> + DMI_MATCH(DMI_BOARD_NAME, "Nightfury"),
>> + },
>> + },
>> + { }
>> +};
>> +
>> static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv) {
>> /* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */ @@ -1450,6 +1469,9
>> @@ static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
>> return true;
>> }
>>
>> + if (dmi_check_system(intel_fbc_vtd_detect))
>> + return true;
>> +
>> return false;
>> }
>>
>> --
>> 2.17.1
>
>--
>Ville Syrjälä
>Intel
Best regards,
Shawn
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board
2020-09-15 13:18 ` Lee, Shawn C
@ 2020-09-15 13:35 ` Ville Syrjälä
2020-09-21 13:15 ` Lee, Shawn C
0 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjälä @ 2020-09-15 13:35 UTC (permalink / raw)
To: 20200827055129.26566-1-shawn.c.lee
Cc: Chiou, Cooper, Tseng, William, Nikula, Jani, intel-gfx
On Tue, Sep 15, 2020 at 01:18:13PM +0000, Lee, Shawn C wrote:
> On Fri, Sept. 11, 2020, 2:21 p.m. Ville Syrjälä wrote:
> >On Thu, Aug 27, 2020 at 01:51:29PM +0800, Lee Shawn C wrote:
> >> Customer report random display flicker issue on Nightfury board.
> >> And we found this problem might be caused by VT-d and FBC are both
> >> enabled. According to sighting report, it recommend to turn
> >> drm/i915/fbc: disable FBC on Nightfury board
> >>
> >> Customer report random display flicker issue on Nightfury board.
> >> And we found this problem might be caused by VT-d and FBC are both
> >> enabled. According to sighting report, it recommend to turn FBC off to
> >> workaround this kind of issue.
> >>
> >> This change refer to DMI BOARD_VENDOR and BOARD_NAME information to
> >> disable FBC.
> >
> >What is this "nightfury board" exactly?
>
> It is chrome os project on CML platform. The board name is "nightfury".
OK, then someone should definitely test if that missing w/a
fixes the underruns.
>
> >
> >I think we're missing at least one fbc vs. vt-d w/a on some kbl/cfl/etc. era platforms:
> >git://github.com/vsyrjala/linux.git vtd_wa_1142
> >
> >>
> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> >> Cc: Jani Nikula <jani.nikula@intel.com>
> >> Cc: William Tseng <william.tseng@intel.com>
> >> Cc: Cooper Chiou <cooper.chiou@intel.com>
> >> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/display/intel_fbc.c | 22 ++++++++++++++++++++++
> >> 1 file changed, 22 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c
> >> b/drivers/gpu/drm/i915/display/intel_fbc.c
> >> index 327af428d73f..20660fdbab36 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> >> @@ -39,6 +39,7 @@
> >> */
> >>
> >> #include <drm/drm_fourcc.h>
> >> +#include <linux/dmi.h>
> >>
> >> #include "i915_drv.h"
> >> #include "i915_trace.h"
> >> @@ -1439,6 +1440,24 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
> >> return 0;
> >> }
> >>
> >> +static int intel_fbc_vtd_callback(const struct dmi_system_id *id) {
> >> + DRM_DEBUG_KMS("Disabling FBC to prevent screen flicker on %s device\n", id->ident);
> >> + return 1;
> >> +}
> >> +
> >> +static const struct dmi_system_id intel_fbc_vtd_detect[] = {
> >> + {
> >> + .callback = intel_fbc_vtd_callback,
> >> + .ident = "Google Nightfury",
> >> + .matches = {
> >> + DMI_MATCH(DMI_BOARD_VENDOR, "Google"),
> >> + DMI_MATCH(DMI_BOARD_NAME, "Nightfury"),
> >> + },
> >> + },
> >> + { }
> >> +};
> >> +
> >> static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv) {
> >> /* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */ @@ -1450,6 +1469,9
> >> @@ static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
> >> return true;
> >> }
> >>
> >> + if (dmi_check_system(intel_fbc_vtd_detect))
> >> + return true;
> >> +
> >> return false;
> >> }
> >>
> >> --
> >> 2.17.1
> >
> >--
> >Ville Syrjälä
> >Intel
>
> Best regards,
> Shawn
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board
2020-09-15 13:35 ` Ville Syrjälä
@ 2020-09-21 13:15 ` Lee, Shawn C
0 siblings, 0 replies; 11+ messages in thread
From: Lee, Shawn C @ 2020-09-21 13:15 UTC (permalink / raw)
To: Ville Syrjälä, 20200827055129.26566-1-shawn.c.lee
Cc: Nikula, Jani, Chiou, Cooper, intel-gfx, Tseng, William
On Tue, Sept. 15, 2020, 1:35 p.m. Ville Syrjälä wrote:
>On Tue, Sep 15, 2020 at 01:18:13PM +0000, Lee, Shawn C wrote:
>> On Fri, Sept. 11, 2020, 2:21 p.m. Ville Syrjälä wrote:
>> >On Thu, Aug 27, 2020 at 01:51:29PM +0800, Lee Shawn C wrote:
>> >> Customer report random display flicker issue on Nightfury board.
>> >> And we found this problem might be caused by VT-d and FBC are both
>> >> enabled. According to sighting report, it recommend to turn
>> >> drm/i915/fbc: disable FBC on Nightfury board
>> >>
>> >> Customer report random display flicker issue on Nightfury board.
>> >> And we found this problem might be caused by VT-d and FBC are both
>> >> enabled. According to sighting report, it recommend to turn FBC
>> >> off to workaround this kind of issue.
>> >>
>> >> This change refer to DMI BOARD_VENDOR and BOARD_NAME information
>> >> to disable FBC.
>> >
>> >What is this "nightfury board" exactly?
>>
>> It is chrome os project on CML platform. The board name is "nightfury".
>
>OK, then someone should definitely test if that missing w/a fixes the
>underruns.
Customer already confirmed display flicker issue disappear after applied this w/a.
BTW, here is the patch v2 to fix some typo in v1.
https://patchwork.freedesktop.org/series/81087/#rev2
Best regards,
Shawn
>
>>
>> >
>> >I think we're missing at least one fbc vs. vt-d w/a on some kbl/cfl/etc. era platforms:
>> >git://github.com/vsyrjala/linux.git vtd_wa_1142
>> >
>> >>
>> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> >> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>> >> Cc: Jani Nikula <jani.nikula@intel.com>
>> >> Cc: William Tseng <william.tseng@intel.com>
>> >> Cc: Cooper Chiou <cooper.chiou@intel.com>
>> >> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> >> ---
>> >> drivers/gpu/drm/i915/display/intel_fbc.c | 22
>> >> ++++++++++++++++++++++
>> >> 1 file changed, 22 insertions(+)
>> >>
>> >> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c
>> >> b/drivers/gpu/drm/i915/display/intel_fbc.c
>> >> index 327af428d73f..20660fdbab36 100644
>> >> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
>> >> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
>> >> @@ -39,6 +39,7 @@
>> >> */
>> >>
>> >> #include <drm/drm_fourcc.h>
>> >> +#include <linux/dmi.h>
>> >>
>> >> #include "i915_drv.h"
>> >> #include "i915_trace.h"
>> >> @@ -1439,6 +1440,24 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
>> >> return 0;
>> >> }
>> >>
>> >> +static int intel_fbc_vtd_callback(const struct dmi_system_id *id) {
>> >> + DRM_DEBUG_KMS("Disabling FBC to prevent screen flicker on %s device\n", id->ident);
>> >> + return 1;
>> >> +}
>> >> +
>> >> +static const struct dmi_system_id intel_fbc_vtd_detect[] = {
>> >> + {
>> >> + .callback = intel_fbc_vtd_callback,
>> >> + .ident = "Google Nightfury",
>> >> + .matches = {
>> >> + DMI_MATCH(DMI_BOARD_VENDOR, "Google"),
>> >> + DMI_MATCH(DMI_BOARD_NAME, "Nightfury"),
>> >> + },
>> >> + },
>> >> + { }
>> >> +};
>> >> +
>> >> static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv) {
>> >> /* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */ @@ -1450,6
>> >> +1469,9 @@ static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
>> >> return true;
>> >> }
>> >>
>> >> + if (dmi_check_system(intel_fbc_vtd_detect))
>> >> + return true;
>> >> +
>> >> return false;
>> >> }
>> >>
>> >> --
>> >> 2.17.1
>> >
>> >--
>> >Ville Syrjälä
>> >Intel
>>
>> Best regards,
>> Shawn
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board
@ 2020-09-21 13:09 Lee, Shawn C
0 siblings, 0 replies; 11+ messages in thread
From: Lee, Shawn C @ 2020-09-21 13:09 UTC (permalink / raw)
To: Ville Syrjälä
Cc: Chiou, Cooper, Tseng, William, Nikula, Jani, intel-gfx
On Tue, Sept. 15, 2020, 1:35 p.m. Ville Syrjälä wrote:
>On Tue, Sep 15, 2020 at 01:18:13PM +0000, Lee, Shawn C wrote:
>> On Fri, Sept. 11, 2020, 2:21 p.m. Ville Syrjälä wrote:
>> >On Thu, Aug 27, 2020 at 01:51:29PM +0800, Lee Shawn C wrote:
>> >> Customer report random display flicker issue on Nightfury board.
>> >> And we found this problem might be caused by VT-d and FBC are both
>> >> enabled. According to sighting report, it recommend to turn
>> >> drm/i915/fbc: disable FBC on Nightfury board
>> >>
>> >> Customer report random display flicker issue on Nightfury board.
>> >> And we found this problem might be caused by VT-d and FBC are both
>> >> enabled. According to sighting report, it recommend to turn FBC off to
>> >> workaround this kind of issue.
>> >>
>> >> This change refer to DMI BOARD_VENDOR and BOARD_NAME information to
>> >> disable FBC.
>> >
>> >What is this "nightfury board" exactly?
>>
>> It is chrome os project on CML platform. The board name is "nightfury".
>
>OK, then someone should definitely test if that missing w/a
>fixes the underruns.
Customer already confirmed display flicker issue disappear after
applied this w/a.
BTW, here is the patch v2 to fix some typo in v1.
https://patchwork.freedesktop.org/series/81087/#rev2
Best regards,
Shawn
>
>>
>> >
>> >I think we're missing at least one fbc vs. vt-d w/a on some kbl/cfl/etc. era platforms:
>> >git://github.com/vsyrjala/linux.git vtd_wa_1142
>> >
>> >>
>> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> >> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>> >> Cc: Jani Nikula <jani.nikula@intel.com>
>> >> Cc: William Tseng <william.tseng@intel.com>
>> >> Cc: Cooper Chiou <cooper.chiou@intel.com>
>> >> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> >> ---
>> >> drivers/gpu/drm/i915/display/intel_fbc.c | 22 ++++++++++++++++++++++
>> >> 1 file changed, 22 insertions(+)
>> >>
>> >> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c
>> >> b/drivers/gpu/drm/i915/display/intel_fbc.c
>> >> index 327af428d73f..20660fdbab36 100644
>> >> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
>> >> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
>> >> @@ -39,6 +39,7 @@
>> >> */
>> >>
>> >> #include <drm/drm_fourcc.h>
>> >> +#include <linux/dmi.h>
>> >>
>> >> #include "i915_drv.h"
>> >> #include "i915_trace.h"
>> >> @@ -1439,6 +1440,24 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
>> >> return 0;
>> >> }
>> >>
>> >> +static int intel_fbc_vtd_callback(const struct dmi_system_id *id) {
>> >> + DRM_DEBUG_KMS("Disabling FBC to prevent screen flicker on %s device\n", id->ident);
>> >> + return 1;
>> >> +}
>> >> +
>> >> +static const struct dmi_system_id intel_fbc_vtd_detect[] = {
>> >> + {
>> >> + .callback = intel_fbc_vtd_callback,
>> >> + .ident = "Google Nightfury",
>> >> + .matches = {
>> >> + DMI_MATCH(DMI_BOARD_VENDOR, "Google"),
>> >> + DMI_MATCH(DMI_BOARD_NAME, "Nightfury"),
>> >> + },
>> >> + },
>> >> + { }
>> >> +};
>> >> +
>> >> static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv) {
>> >> /* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */ @@ -1450,6 +1469,9
>> >> @@ static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
>> >> return true;
>> >> }
>> >>
>> >> + if (dmi_check_system(intel_fbc_vtd_detect))
>> >> + return true;
>> >> +
>> >> return false;
>> >> }
>> >>
>> >> --
>> >> 2.17.1
>> >
>> >--
>> >Ville Syrjälä
>> >Intel
>>
>> Best regards,
>> Shawn
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-09-21 13:16 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27 5:51 [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board Lee Shawn C
2020-08-27 6:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-08-27 8:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-09-11 13:48 ` [Intel-gfx] [PATCH v2] " Lee Shawn C
2020-09-11 14:21 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2020-09-15 13:18 ` Lee, Shawn C
2020-09-15 13:35 ` Ville Syrjälä
2020-09-21 13:15 ` Lee, Shawn C
2020-09-11 14:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: disable FBC on Nightfury board (rev2) Patchwork
2020-09-11 17:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-09-21 13:09 [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board Lee, Shawn C
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.