From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/5] drm/i915/guc: Delete GuC code unused in future patches
Date: Wed, 06 Jan 2021 03:11:41 +0000 [thread overview]
Message-ID: <160990270114.22606.3882503683077086744@build.alporthouse.com> (raw)
In-Reply-To: <0c89c2d0-fad1-47e8-65cb-bf9ea3c4f43d@intel.com>
Quoting Daniele Ceraolo Spurio (2021-01-06 02:28:46)
>
>
> On 1/5/2021 4:55 PM, Chris Wilson wrote:
> > Quoting Daniele Ceraolo Spurio (2021-01-05 23:19:43)
> >> From: Matthew Brost <matthew.brost@intel.com>
> >>
> >> Delete GuC code unused in future patches that rewrite the GuC interface
> >> to work with the new firmware. Most of the code deleted relates to
> >> workqueues or execlist port.
> > Should we not be complaining if i915.enable_guc=1 is set during this
> > time? We may already be, if so please mention it so that we know that
> > nobody can accidentally execute this code.
> > -Chris
>
> We already do, I'll add a note in the commit message.
With a quick explanation as to how it can do no harm,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-06 3:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 23:19 [Intel-gfx] [PATCH 0/5] Split GuC submission from execlists submission Daniele Ceraolo Spurio
2021-01-05 23:19 ` [Intel-gfx] [PATCH 1/5] drm/i915/guc: Delete GuC code unused in future patches Daniele Ceraolo Spurio
2021-01-06 0:55 ` Chris Wilson
2021-01-06 2:28 ` Daniele Ceraolo Spurio
2021-01-06 3:11 ` Chris Wilson [this message]
2021-01-05 23:19 ` [Intel-gfx] [PATCH 2/5] drm/i915/guc: do not dump execlists state with GuC submission Daniele Ceraolo Spurio
2021-01-06 0:58 ` Chris Wilson
2021-01-06 2:32 ` Daniele Ceraolo Spurio
2021-01-06 2:55 ` Chris Wilson
2021-01-06 17:21 ` Daniele Ceraolo Spurio
2021-01-06 19:43 ` Chris Wilson
2021-01-13 1:03 ` Daniele Ceraolo Spurio
2021-01-05 23:19 ` [Intel-gfx] [PATCH 3/5] drm/i915/guc: init engine directly in GuC submission mode Daniele Ceraolo Spurio
2021-01-05 23:33 ` Chris Wilson
2021-01-05 23:51 ` Daniele Ceraolo Spurio
2021-01-06 0:02 ` Chris Wilson
2021-01-06 3:14 ` Chris Wilson
2021-01-05 23:19 ` [Intel-gfx] [PATCH 4/5] drm/i915/guc: stop calling execlists_set_default_submission Daniele Ceraolo Spurio
2021-01-06 1:02 ` Chris Wilson
2021-01-06 2:38 ` Daniele Ceraolo Spurio
2021-01-06 3:09 ` Chris Wilson
2021-01-06 17:22 ` Daniele Ceraolo Spurio
2021-01-05 23:19 ` [Intel-gfx] [PATCH 5/5] drm/i915/guc: enable only the user interrupt when using GuC submission Daniele Ceraolo Spurio
2021-01-05 23:38 ` Chris Wilson
2021-01-05 23:56 ` Daniele Ceraolo Spurio
2021-01-06 0:15 ` Chris Wilson
2021-01-06 2:39 ` Daniele Ceraolo Spurio
2021-01-06 1:05 ` Chris Wilson
2021-01-06 0:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Split GuC submission from execlists submission Patchwork
2021-01-06 0:29 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-01-06 0:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-06 3:42 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160990270114.22606.3882503683077086744@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.