From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/5] drm/i915/guc: do not dump execlists state with GuC submission
Date: Wed, 6 Jan 2021 09:21:16 -0800 [thread overview]
Message-ID: <f2b54e5a-fc97-ef33-0c6c-6fe6833d3b73@intel.com> (raw)
In-Reply-To: <160990175565.22606.17511156121476669794@build.alporthouse.com>
On 1/5/2021 6:55 PM, Chris Wilson wrote:
> Quoting Daniele Ceraolo Spurio (2021-01-06 02:32:28)
>>
>> On 1/5/2021 4:58 PM, Chris Wilson wrote:
>>> Quoting Daniele Ceraolo Spurio (2021-01-05 23:19:44)
>>>> GuC owns the execlists state and the context IDs used for submission, so
>>>> the status of the ports and the CSB entries are not something we control
>>>> or can decode from the i915 side, therefore we can avoid dumping it. A
>>>> follow-up patch will also stop setting the csb pointers when using GuC
>>>> submission.
>>>>
>>>> GuC dumps all the required events in the GuC logs when verbosity is set
>>>> high enough.
>>> Would not be worth including, or is it not very helpful for debugging
>>> curious engine stalls?
>> GuC is going to reset the engine if it stalls, so we should get the GuC
>> logs and the engine state included in the error state.
> Here we would be focusing on "why hasn't a request been submitted/executed".
> A bad request is usually self-evident, but a missing one is tricky.
Agreed, but I still don't think we could use the CSB info even if we
dumped it. We currently can't map CSB events in GuC submission mode to
specific contexts, because the ctx IDs used by the GuC do not map to the
ones used by i915. We've asked the GuC team to expose a way to do such a
mapping, but that's still under discussion. In the meantime we plan to
add a few traces to make sure the requests reach the GuC and use the GuC
logs for what goes on inside the FW (GuC logs include the context IDs it
uses for submission and all CSB events on high verbosity).
Daniele
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-06 17:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 23:19 [Intel-gfx] [PATCH 0/5] Split GuC submission from execlists submission Daniele Ceraolo Spurio
2021-01-05 23:19 ` [Intel-gfx] [PATCH 1/5] drm/i915/guc: Delete GuC code unused in future patches Daniele Ceraolo Spurio
2021-01-06 0:55 ` Chris Wilson
2021-01-06 2:28 ` Daniele Ceraolo Spurio
2021-01-06 3:11 ` Chris Wilson
2021-01-05 23:19 ` [Intel-gfx] [PATCH 2/5] drm/i915/guc: do not dump execlists state with GuC submission Daniele Ceraolo Spurio
2021-01-06 0:58 ` Chris Wilson
2021-01-06 2:32 ` Daniele Ceraolo Spurio
2021-01-06 2:55 ` Chris Wilson
2021-01-06 17:21 ` Daniele Ceraolo Spurio [this message]
2021-01-06 19:43 ` Chris Wilson
2021-01-13 1:03 ` Daniele Ceraolo Spurio
2021-01-05 23:19 ` [Intel-gfx] [PATCH 3/5] drm/i915/guc: init engine directly in GuC submission mode Daniele Ceraolo Spurio
2021-01-05 23:33 ` Chris Wilson
2021-01-05 23:51 ` Daniele Ceraolo Spurio
2021-01-06 0:02 ` Chris Wilson
2021-01-06 3:14 ` Chris Wilson
2021-01-05 23:19 ` [Intel-gfx] [PATCH 4/5] drm/i915/guc: stop calling execlists_set_default_submission Daniele Ceraolo Spurio
2021-01-06 1:02 ` Chris Wilson
2021-01-06 2:38 ` Daniele Ceraolo Spurio
2021-01-06 3:09 ` Chris Wilson
2021-01-06 17:22 ` Daniele Ceraolo Spurio
2021-01-05 23:19 ` [Intel-gfx] [PATCH 5/5] drm/i915/guc: enable only the user interrupt when using GuC submission Daniele Ceraolo Spurio
2021-01-05 23:38 ` Chris Wilson
2021-01-05 23:56 ` Daniele Ceraolo Spurio
2021-01-06 0:15 ` Chris Wilson
2021-01-06 2:39 ` Daniele Ceraolo Spurio
2021-01-06 1:05 ` Chris Wilson
2021-01-06 0:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Split GuC submission from execlists submission Patchwork
2021-01-06 0:29 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-01-06 0:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-06 3:42 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2b54e5a-fc97-ef33-0c6c-6fe6833d3b73@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.