All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Oleksij Rempel <linux@rempel-privat.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to yaml schema
Date: Mon, 08 Feb 2021 10:55:22 -0600	[thread overview]
Message-ID: <1612803322.544738.1522086.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210205234734.3397-4-leoyang.li@nxp.com>

On Fri, 05 Feb 2021 17:47:22 -0600, Li Yang wrote:
> Convert the txt binding to yaml format and add description.  Also
> updated the recommended node name to ifc-bus to align with the
> simple-bus node name requirements.
> 
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
> ---
>  .../bindings/memory-controllers/fsl/ifc.txt   |  82 ----------
>  .../bindings/memory-controllers/fsl/ifc.yaml  | 140 ++++++++++++++++++
>  2 files changed, 140 insertions(+), 82 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.example.dts:36.27-49.19: Warning (simple_bus_reg): /example-0/soc/ifc-bus@ffe1e000/flash@0,0: simple-bus unit address format error, expected "0"
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.example.dts:51.27-64.19: Warning (simple_bus_reg): /example-0/soc/ifc-bus@ffe1e000/flash@1,0: simple-bus unit address format error, expected "100000000"
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.example.dts:66.26-71.19: Warning (simple_bus_reg): /example-0/soc/ifc-bus@ffe1e000/cpld@3,0: simple-bus unit address format error, expected "300000000"

See https://patchwork.ozlabs.org/patch/1436960

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Oleksij Rempel <linux@rempel-privat.de>,
	Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to yaml schema
Date: Mon, 08 Feb 2021 10:55:22 -0600	[thread overview]
Message-ID: <1612803322.544738.1522086.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210205234734.3397-4-leoyang.li@nxp.com>

On Fri, 05 Feb 2021 17:47:22 -0600, Li Yang wrote:
> Convert the txt binding to yaml format and add description.  Also
> updated the recommended node name to ifc-bus to align with the
> simple-bus node name requirements.
> 
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
> ---
>  .../bindings/memory-controllers/fsl/ifc.txt   |  82 ----------
>  .../bindings/memory-controllers/fsl/ifc.yaml  | 140 ++++++++++++++++++
>  2 files changed, 140 insertions(+), 82 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.example.dts:36.27-49.19: Warning (simple_bus_reg): /example-0/soc/ifc-bus@ffe1e000/flash@0,0: simple-bus unit address format error, expected "0"
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.example.dts:51.27-64.19: Warning (simple_bus_reg): /example-0/soc/ifc-bus@ffe1e000/flash@1,0: simple-bus unit address format error, expected "100000000"
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.example.dts:66.26-71.19: Warning (simple_bus_reg): /example-0/soc/ifc-bus@ffe1e000/cpld@3,0: simple-bus unit address format error, expected "300000000"

See https://patchwork.ozlabs.org/patch/1436960

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-02-08 18:48 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 23:47 [PATCH 00/15] Cleanup of LS1021a device trees Li Yang
2021-02-05 23:47 ` Li Yang
2021-02-05 23:47 ` [PATCH 01/15] dt-bindings: arm: fsl: add ls1021a-tsn board Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-06 11:22   ` Krzysztof Kozlowski
2021-02-06 11:22     ` Krzysztof Kozlowski
2021-02-11  0:02   ` Rob Herring
2021-02-11  0:02     ` Rob Herring
2021-02-05 23:47 ` [PATCH 02/15] dt-bindings: i2c: imx: update schema to align with original binding Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-06 11:27   ` Krzysztof Kozlowski
2021-02-06 11:27     ` Krzysztof Kozlowski
2021-02-05 23:47 ` [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to yaml schema Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-06 11:37   ` Krzysztof Kozlowski
2021-02-06 11:37     ` Krzysztof Kozlowski
2021-02-08 16:55   ` Rob Herring [this message]
2021-02-08 16:55     ` Rob Herring
2021-02-08 17:07     ` Leo Li
2021-02-08 17:07       ` Leo Li
2021-02-08 18:21       ` Rob Herring
2021-02-08 18:21         ` Rob Herring
2021-02-08 23:25         ` Leo Li
2021-02-08 23:25           ` Leo Li
2021-02-05 23:47 ` [PATCH 04/15] ARM: dts: ls1021a: change to use SPDX identifiers Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-06 11:42   ` Krzysztof Kozlowski
2021-02-06 11:42     ` Krzysztof Kozlowski
2021-02-05 23:47 ` [PATCH 05/15] ARM: dts: ls1021a-qds: Add node for QSPI flash Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-05 23:47 ` [PATCH 06/15] ARM: dts: ls1021a: update pcie nodes for dt-schema check Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-05 23:47 ` [PATCH 07/15] ARM: dts: ls1021a: fix board compatible to follow binding schema Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-05 23:47 ` [PATCH 08/15] ARM: dts: ls1021a: breakup long values in thermal node Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-05 23:47 ` [PATCH 09/15] ARM: dts: ls1021a: fix ifc node to follow binding schema Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-05 23:47 ` [PATCH 10/15] ARM: dts: ls1021a: remove regulators simple-bus Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-05 23:47 ` [PATCH 11/15] ARM: dts: ls1021a: fix memory node for schema check Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-05 23:47 ` [PATCH 12/15] ARM: dts: ls1021a: add #dma-cells to qdma node Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-05 23:47 ` [PATCH 13/15] ARM: dts: ls1021a: add #power-domain-cells for power-controller node Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-05 23:47 ` [PATCH 14/15] ARM: dts: ls1021a-qds: change fpga to simple-mfd device Li Yang
2021-02-05 23:47   ` Li Yang
2021-02-05 23:47 ` [PATCH 15/15] ARM: dts: ls1021a-tsn: remove undocumented property "position" from mma8452 node Li Yang
2021-02-05 23:47   ` Li Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1612803322.544738.1522086.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.