All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
To: <linux-clk@vger.kernel.org>
Cc: <devicetree@vger.kernel.org>, <mturquette@baylibre.com>,
	<sboyd@kernel.org>, <gregkh@linuxfoundation.org>,
	<shubhrajyoti.datta@gmail.com>, <miquel.raynal@bootlin.com>,
	"Shubhrajyoti Datta" <shubhrajyoti.datta@xilinx.com>
Subject: [PATCH v9 7/7] clk: clock-wizard: Update the fixed factor divisors
Date: Thu, 18 Feb 2021 10:19:51 +0530	[thread overview]
Message-ID: <1613623791-4598-8-git-send-email-shubhrajyoti.datta@xilinx.com> (raw)
In-Reply-To: <1613623791-4598-1-git-send-email-shubhrajyoti.datta@xilinx.com>

Update the fixed factor clock registration to register the divisors.

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
---
 drivers/clk/clk-xlnx-clock-wizard.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock-wizard.c
index d403a74..7f09522 100644
--- a/drivers/clk/clk-xlnx-clock-wizard.c
+++ b/drivers/clk/clk-xlnx-clock-wizard.c
@@ -472,8 +472,10 @@ static int clk_wzrd_probe(struct platform_device *pdev)
 	u32 reg, reg_f, mult;
 	unsigned long rate;
 	const char *clk_name;
+	void __iomem *ctrl_reg;
 	struct clk_wzrd *clk_wzrd;
 	int outputs;
+	unsigned long flags = 0;
 	struct device_node *np = pdev->dev.of_node;
 
 	clk_wzrd = devm_kzalloc(&pdev->dev, sizeof(*clk_wzrd), GFP_KERNEL);
@@ -543,16 +545,17 @@ static int clk_wzrd_probe(struct platform_device *pdev)
 	}
 
 	outputs = of_property_count_strings(np, "clock-output-names");
-	/* register div */
-	reg = (readl(clk_wzrd->base + WZRD_CLK_CFG_REG(0)) &
-			WZRD_DIVCLK_DIVIDE_MASK) >> WZRD_DIVCLK_DIVIDE_SHIFT;
+	if (outputs == 1)
+		flags = CLK_SET_RATE_PARENT;
 	clk_name = kasprintf(GFP_KERNEL, "%s_mul_div", dev_name(&pdev->dev));
 	if (!clk_name) {
 		ret = -ENOMEM;
 		goto err_rm_int_clk;
 	}
 
-	clk_wzrd->clks_internal[wzrd_clk_mul_div] = clk_register_fixed_factor
+	ctrl_reg = clk_wzrd->base + WZRD_CLK_CFG_REG(0);
+	/* register div */
+	clk_wzrd->clks_internal[wzrd_clk_mul_div] = clk_register_divider
 			(&pdev->dev, clk_name,
 			 __clk_get_name(clk_wzrd->clks_internal[wzrd_clk_mul]),
 			flags, ctrl_reg, 0, 8, CLK_DIVIDER_ONE_BASED |
@@ -577,7 +580,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
 		if (!i)
 			clk_wzrd->clkout[i] = clk_wzrd_register_divf
 				(&pdev->dev, clkout_name,
-				clk_name, 0,
+				clk_name, flags,
 				clk_wzrd->base, (WZRD_CLK_CFG_REG(2) + i * 12),
 				WZRD_CLKOUT_DIVIDE_SHIFT,
 				WZRD_CLKOUT_DIVIDE_WIDTH,
-- 
2.1.1


  parent reply	other threads:[~2021-02-18  4:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18  4:49 [PATCH v9 0/7] clk: clk-wizard: clock-wizard: Driver updates Shubhrajyoti Datta
2021-02-18  4:49 ` [PATCH v9 1/7] dt-bindings: add documentation of xilinx clocking wizard Shubhrajyoti Datta
2021-02-18  8:28   ` Miquel Raynal
2021-02-19  1:24     ` Stephen Boyd
2021-02-24 14:10       ` Shubhrajyoti Datta
2021-03-02 23:07         ` Stephen Boyd
2021-03-03  4:14           ` Shubhrajyoti Datta
2021-02-18 14:05   ` Rob Herring
2021-02-18  4:49 ` [PATCH v9 2/7] clk: clock-wizard: Add the clockwizard to clk directory Shubhrajyoti Datta
2021-02-18  8:26   ` Miquel Raynal
2021-02-18  4:49 ` [PATCH v9 3/7] clk: clock-wizard: Fix kernel-doc warning Shubhrajyoti Datta
2021-02-18  8:29   ` Miquel Raynal
2021-02-24 14:10     ` Shubhrajyoti Datta
2021-02-18  4:49 ` [PATCH v9 4/7] clk: clock-wizard: Add support for dynamic reconfiguration Shubhrajyoti Datta
2021-02-18  8:35   ` Miquel Raynal
2021-02-18  4:49 ` [PATCH v9 5/7] clk: clock-wizard: Add support for fractional support Shubhrajyoti Datta
2021-02-18  4:49 ` [PATCH v9 6/7] clk: clock-wizard: Remove the hardcoding of the clock outputs Shubhrajyoti Datta
2021-02-18  8:37   ` Miquel Raynal
2021-02-19  1:25     ` Stephen Boyd
2021-02-22  6:47       ` Shubhrajyoti Datta
2021-02-23  1:01         ` Stephen Boyd
2021-02-24 14:08           ` Shubhrajyoti Datta
2021-02-18  4:49 ` Shubhrajyoti Datta [this message]
2021-02-18  8:24 ` [PATCH v9 0/7] clk: clk-wizard: clock-wizard: Driver updates Miquel Raynal
2021-02-24 14:11   ` Shubhrajyoti Datta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1613623791-4598-8-git-send-email-shubhrajyoti.datta@xilinx.com \
    --to=shubhrajyoti.datta@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=shubhrajyoti.datta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.