All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Cc: <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<mturquette@baylibre.com>, <sboyd@kernel.org>,
	<gregkh@linuxfoundation.org>, <shubhrajyoti.datta@gmail.com>
Subject: Re: [PATCH v9 0/7] clk: clk-wizard: clock-wizard: Driver updates
Date: Thu, 18 Feb 2021 09:24:40 +0100	[thread overview]
Message-ID: <20210218092440.7ddeb617@xps13> (raw)
In-Reply-To: <1613623791-4598-1-git-send-email-shubhrajyoti.datta@xilinx.com>

Hi Shubhrajyoti,

Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> wrote on Thu, 18 Feb
2021 10:19:44 +0530:

> In the thread [1] Greg suggested that we move the driver
> to the clk from the staging.
> Add patches to address the concerns regarding the fractional and
> set rate support in the TODO.
> 
> The patch set does the following
> - Trivial fixes for kernel doc.
> - Move the driver to the clk folder
> - Add capability to set rate.
> - Add fractional support.
> - Add support for configurable outputs.
> - Make the output names unique so that multiple instances
> do not crib.

I think we prefer to move "clean" drivers out of the staging tree
rather than "to be fixed" code. So I would invert the order of the
patches in this series to make more sense:
* 3/7-7/7 (various fixes/improvements)
* 1/7 (bindings)
* 2/7 (move to clk)

> Shubhrajyoti Datta (7):
>   dt-bindings: add documentation of xilinx clocking wizard
>   clk: clock-wizard: Add the clockwizard to clk directory
>   clk: clock-wizard: Fix kernel-doc warning
>   clk: clock-wizard: Add support for dynamic reconfiguration
>   clk: clock-wizard: Add support for fractional support
>   clk: clock-wizard: Remove the hardcoding of the clock outputs
>   clk: clock-wizard: Update the fixed factor divisors
> 
>  .../bindings/clock/xlnx,clocking-wizard.yaml       |  65 ++
>  drivers/clk/Kconfig                                |   9 +
>  drivers/clk/Makefile                               |   1 +
>  drivers/clk/clk-xlnx-clock-wizard.c                | 689 +++++++++++++++++++++
>  drivers/staging/Kconfig                            |   2 -
>  drivers/staging/Makefile                           |   1 -
>  drivers/staging/clocking-wizard/Kconfig            |  10 -
>  drivers/staging/clocking-wizard/Makefile           |   2 -
>  drivers/staging/clocking-wizard/TODO               |  12 -
>  .../clocking-wizard/clk-xlnx-clock-wizard.c        | 333 ----------
>  drivers/staging/clocking-wizard/dt-binding.txt     |  30 -
>  11 files changed, 764 insertions(+), 390 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
>  create mode 100644 drivers/clk/clk-xlnx-clock-wizard.c
>  delete mode 100644 drivers/staging/clocking-wizard/Kconfig
>  delete mode 100644 drivers/staging/clocking-wizard/Makefile
>  delete mode 100644 drivers/staging/clocking-wizard/TODO
>  delete mode 100644 drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
>  delete mode 100644 drivers/staging/clocking-wizard/dt-binding.txt
> 

Thanks,
Miquèl

  parent reply	other threads:[~2021-02-18  8:28 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18  4:49 [PATCH v9 0/7] clk: clk-wizard: clock-wizard: Driver updates Shubhrajyoti Datta
2021-02-18  4:49 ` [PATCH v9 1/7] dt-bindings: add documentation of xilinx clocking wizard Shubhrajyoti Datta
2021-02-18  8:28   ` Miquel Raynal
2021-02-19  1:24     ` Stephen Boyd
2021-02-24 14:10       ` Shubhrajyoti Datta
2021-03-02 23:07         ` Stephen Boyd
2021-03-03  4:14           ` Shubhrajyoti Datta
2021-02-18 14:05   ` Rob Herring
2021-02-18  4:49 ` [PATCH v9 2/7] clk: clock-wizard: Add the clockwizard to clk directory Shubhrajyoti Datta
2021-02-18  8:26   ` Miquel Raynal
2021-02-18  4:49 ` [PATCH v9 3/7] clk: clock-wizard: Fix kernel-doc warning Shubhrajyoti Datta
2021-02-18  8:29   ` Miquel Raynal
2021-02-24 14:10     ` Shubhrajyoti Datta
2021-02-18  4:49 ` [PATCH v9 4/7] clk: clock-wizard: Add support for dynamic reconfiguration Shubhrajyoti Datta
2021-02-18  8:35   ` Miquel Raynal
2021-02-18  4:49 ` [PATCH v9 5/7] clk: clock-wizard: Add support for fractional support Shubhrajyoti Datta
2021-02-18  4:49 ` [PATCH v9 6/7] clk: clock-wizard: Remove the hardcoding of the clock outputs Shubhrajyoti Datta
2021-02-18  8:37   ` Miquel Raynal
2021-02-19  1:25     ` Stephen Boyd
2021-02-22  6:47       ` Shubhrajyoti Datta
2021-02-23  1:01         ` Stephen Boyd
2021-02-24 14:08           ` Shubhrajyoti Datta
2021-02-18  4:49 ` [PATCH v9 7/7] clk: clock-wizard: Update the fixed factor divisors Shubhrajyoti Datta
2021-02-18  8:24 ` Miquel Raynal [this message]
2021-02-24 14:11   ` [PATCH v9 0/7] clk: clk-wizard: clock-wizard: Driver updates Shubhrajyoti Datta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210218092440.7ddeb617@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=shubhrajyoti.datta@gmail.com \
    --cc=shubhrajyoti.datta@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.