From: Yang Li <yang.lee@linux.alibaba.com> To: herbert@gondor.apana.org.au Cc: davem@davemloft.net, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Yang Li <yang.lee@linux.alibaba.com> Subject: [PATCH] crypto/nx: add missing call to of_node_put() Date: Thu, 25 Feb 2021 16:56:57 +0800 [thread overview] Message-ID: <1614243417-48556-1-git-send-email-yang.lee@linux.alibaba.com> (raw) In one of the error paths of the for_each_child_of_node() loop, add missing call to of_node_put(). Fix the following coccicheck warning: ./drivers/crypto/nx/nx-common-powernv.c:927:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 936. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/crypto/nx/nx-common-powernv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/nx/nx-common-powernv.c b/drivers/crypto/nx/nx-common-powernv.c index 13c65de..b43c457 100644 --- a/drivers/crypto/nx/nx-common-powernv.c +++ b/drivers/crypto/nx/nx-common-powernv.c @@ -933,6 +933,7 @@ static int __init nx_powernv_probe_vas(struct device_node *pn) NX_CT_GZIP, "ibm,p9-nx-gzip", &ct_gzip); if (ret) + of_node_put(dn); return ret; } -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Yang Li <yang.lee@linux.alibaba.com> To: herbert@gondor.apana.org.au Cc: linux-kernel@vger.kernel.org, paulus@samba.org, linux-crypto@vger.kernel.org, Yang Li <yang.lee@linux.alibaba.com>, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Subject: [PATCH] crypto/nx: add missing call to of_node_put() Date: Thu, 25 Feb 2021 16:56:57 +0800 [thread overview] Message-ID: <1614243417-48556-1-git-send-email-yang.lee@linux.alibaba.com> (raw) In one of the error paths of the for_each_child_of_node() loop, add missing call to of_node_put(). Fix the following coccicheck warning: ./drivers/crypto/nx/nx-common-powernv.c:927:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 936. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/crypto/nx/nx-common-powernv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/nx/nx-common-powernv.c b/drivers/crypto/nx/nx-common-powernv.c index 13c65de..b43c457 100644 --- a/drivers/crypto/nx/nx-common-powernv.c +++ b/drivers/crypto/nx/nx-common-powernv.c @@ -933,6 +933,7 @@ static int __init nx_powernv_probe_vas(struct device_node *pn) NX_CT_GZIP, "ibm,p9-nx-gzip", &ct_gzip); if (ret) + of_node_put(dn); return ret; } -- 1.8.3.1
next reply other threads:[~2021-02-25 8:58 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-25 8:56 Yang Li [this message] 2021-02-25 8:56 ` [PATCH] crypto/nx: add missing call to of_node_put() Yang Li 2021-02-25 11:15 ` Michael Ellerman 2021-02-25 11:15 ` Michael Ellerman 2021-02-25 12:59 ` kernel test robot 2021-02-25 12:59 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1614243417-48556-1-git-send-email-yang.lee@linux.alibaba.com \ --to=yang.lee@linux.alibaba.com \ --cc=benh@kernel.crashing.org \ --cc=davem@davemloft.net \ --cc=herbert@gondor.apana.org.au \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.