All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto/nx: add missing call to of_node_put()
@ 2021-02-25  8:56 ` Yang Li
  0 siblings, 0 replies; 6+ messages in thread
From: Yang Li @ 2021-02-25  8:56 UTC (permalink / raw)
  To: herbert
  Cc: davem, mpe, benh, paulus, linux-crypto, linuxppc-dev,
	linux-kernel, Yang Li

In one of the error paths of the for_each_child_of_node() loop,
add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/crypto/nx/nx-common-powernv.c:927:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 936.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/crypto/nx/nx-common-powernv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/nx/nx-common-powernv.c b/drivers/crypto/nx/nx-common-powernv.c
index 13c65de..b43c457 100644
--- a/drivers/crypto/nx/nx-common-powernv.c
+++ b/drivers/crypto/nx/nx-common-powernv.c
@@ -933,6 +933,7 @@ static int __init nx_powernv_probe_vas(struct device_node *pn)
 				NX_CT_GZIP, "ibm,p9-nx-gzip", &ct_gzip);
 
 		if (ret)
+			of_node_put(dn);
 			return ret;
 	}
 
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-25 13:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25  8:56 [PATCH] crypto/nx: add missing call to of_node_put() Yang Li
2021-02-25  8:56 ` Yang Li
2021-02-25 11:15 ` Michael Ellerman
2021-02-25 11:15   ` Michael Ellerman
2021-02-25 12:59 ` kernel test robot
2021-02-25 12:59   ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.