All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/kmod: Stop producing results at all for kernel selftests on taint
@ 2021-02-25  8:35 Petri Latvala
  2021-02-25  9:42 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: Petri Latvala @ 2021-02-25  8:35 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Chris Wilson

Instead of producing skips for the rest when one selftest taints the
kernel, stop running them altogether. Having the skips produced yields
no value and just makes future improvements (like correctly tagging
tests that cause taints) harder. In effect, this gets us back to the
old setup when tainting made igt_runner immediately kill the test and
similarly made us not get spurious results for the rest of the
selftests.

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/igt_kmod.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index 2ae45a1a..55295fa5 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -658,9 +658,16 @@ void igt_kselftests(const char *module_name,
 	igt_kselftest_get_tests(tst.kmod, filter, &tests);
 	igt_subtest_with_dynamic(filter ?: "all") {
 		igt_list_for_each_entry_safe(tl, tn, &tests, link) {
+			unsigned long taints;
+
 			igt_dynamic_f("%s", unfilter(filter, tl->name))
 				igt_kselftest_execute(&tst, tl, options, result);
 			free(tl);
+
+			if (igt_kernel_tainted(&taints)) {
+				igt_info("Kernel tainted, not executing more selftests.\n");
+				break;
+			}
 		}
 	}
 
-- 
2.29.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-03-04  5:28 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25  8:35 [igt-dev] [PATCH i-g-t] lib/kmod: Stop producing results at all for kernel selftests on taint Petri Latvala
2021-02-25  9:42 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-02-25 10:56 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-03  8:00   ` Petri Latvala
2021-03-04  5:28     ` Vudum, Lakshminarayana
2021-03-02 11:48 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2021-03-02 12:39   ` Petri Latvala
2021-03-02 13:04     ` Chris Wilson
2021-03-02 13:23       ` Petri Latvala
2021-03-02 13:29         ` Chris Wilson
2021-03-02 13:54           ` Petri Latvala
2021-03-02 13:42         ` Chris Wilson
2021-03-03  8:01           ` Petri Latvala
2021-03-03 17:01 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.