From: guoren@kernel.org To: guoren@kernel.org Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-arch@vger.kernel.org, Guo Ren <guoren@linux.alibaba.com> Subject: [PATCH v4 0/4] riscv: Add qspinlock/qrwlock Date: Sat, 27 Mar 2021 18:06:35 +0000 [thread overview] Message-ID: <1616868399-82848-1-git-send-email-guoren@kernel.org> (raw) From: Guo Ren <guoren@linux.alibaba.com> Current riscv is still using baby spinlock implementation. It'll cause fairness and cache line bouncing problems. Many people are involved and pay the efforts to improve it: - The first version of patch was made in 2019.1: https://lore.kernel.org/linux-riscv/20190211043829.30096-1-michaeljclark@mac.com/#r - The second version was made in 2020.11: https://lore.kernel.org/linux-riscv/1606225437-22948-2-git-send-email-guoren@kernel.org/ - A good discussion at Platform HSC.2021-03-08: https://drive.google.com/drive/folders/1ooqdnIsYx7XKor5O1XTtM6D1CHp4hc0p Hope your comments and Tested-by or Co-developed-by or Reviewed-by ... Let's kick the qspinlock into riscv right now (Also for the architecture which hasn't xchg16 atomic instruction.) Change V4: - Remove custom sub-word xchg implementation - Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32 in locking/qspinlock Change V3: - Coding convention by Peter Zijlstra's advices Change V2: - Coding convention in cmpxchg.h - Re-implement short xchg - Remove char & cmpxchg implementations Guo Ren (3): riscv: cmpxchg.h: Cleanup unused code riscv: cmpxchg.h: Merge macros riscv: cmpxchg.h: Implement xchg for short Michael Clark (1): riscv: Convert custom spinlock/rwlock to generic qspinlock/qrwlock arch/riscv/Kconfig | 2 + arch/riscv/include/asm/Kbuild | 3 + arch/riscv/include/asm/cmpxchg.h | 211 ++++++------------------ arch/riscv/include/asm/spinlock.h | 126 +------------- arch/riscv/include/asm/spinlock_types.h | 15 +- 5 files changed, 58 insertions(+), 299 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: guoren@kernel.org To: guoren@kernel.org Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-arch@vger.kernel.org, Guo Ren <guoren@linux.alibaba.com> Subject: [PATCH v4 0/4] riscv: Add qspinlock/qrwlock Date: Sat, 27 Mar 2021 18:06:35 +0000 [thread overview] Message-ID: <1616868399-82848-1-git-send-email-guoren@kernel.org> (raw) From: Guo Ren <guoren@linux.alibaba.com> Current riscv is still using baby spinlock implementation. It'll cause fairness and cache line bouncing problems. Many people are involved and pay the efforts to improve it: - The first version of patch was made in 2019.1: https://lore.kernel.org/linux-riscv/20190211043829.30096-1-michaeljclark@mac.com/#r - The second version was made in 2020.11: https://lore.kernel.org/linux-riscv/1606225437-22948-2-git-send-email-guoren@kernel.org/ - A good discussion at Platform HSC.2021-03-08: https://drive.google.com/drive/folders/1ooqdnIsYx7XKor5O1XTtM6D1CHp4hc0p Hope your comments and Tested-by or Co-developed-by or Reviewed-by ... Let's kick the qspinlock into riscv right now (Also for the architecture which hasn't xchg16 atomic instruction.) Change V4: - Remove custom sub-word xchg implementation - Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32 in locking/qspinlock Change V3: - Coding convention by Peter Zijlstra's advices Change V2: - Coding convention in cmpxchg.h - Re-implement short xchg - Remove char & cmpxchg implementations Guo Ren (3): riscv: cmpxchg.h: Cleanup unused code riscv: cmpxchg.h: Merge macros riscv: cmpxchg.h: Implement xchg for short Michael Clark (1): riscv: Convert custom spinlock/rwlock to generic qspinlock/qrwlock arch/riscv/Kconfig | 2 + arch/riscv/include/asm/Kbuild | 3 + arch/riscv/include/asm/cmpxchg.h | 211 ++++++------------------ arch/riscv/include/asm/spinlock.h | 126 +------------- arch/riscv/include/asm/spinlock_types.h | 15 +- 5 files changed, 58 insertions(+), 299 deletions(-) -- 2.17.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2021-03-27 18:08 UTC|newest] Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-27 18:06 guoren [this message] 2021-03-27 18:06 ` [PATCH v4 0/4] riscv: Add qspinlock/qrwlock guoren 2021-03-27 18:06 ` [PATCH v4 1/4] riscv: cmpxchg.h: Cleanup unused code guoren 2021-03-27 18:06 ` guoren 2021-03-27 18:06 ` [PATCH v4 2/4] riscv: cmpxchg.h: Merge macros guoren 2021-03-27 18:06 ` guoren 2021-03-27 21:25 ` Arnd Bergmann 2021-03-27 21:25 ` Arnd Bergmann 2021-03-28 1:50 ` Guo Ren 2021-03-28 1:50 ` Guo Ren 2021-03-27 18:06 ` [PATCH v4 3/4] locking/qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32 guoren 2021-03-27 18:06 ` guoren 2021-03-27 18:43 ` Waiman Long 2021-03-27 18:43 ` Waiman Long 2021-03-28 1:48 ` Guo Ren 2021-03-28 1:48 ` Guo Ren 2021-03-29 7:50 ` Peter Zijlstra 2021-03-29 7:50 ` Peter Zijlstra 2021-03-29 9:41 ` Arnd Bergmann 2021-03-29 9:41 ` Arnd Bergmann 2021-03-29 11:16 ` Peter Zijlstra 2021-03-29 11:16 ` Peter Zijlstra 2021-03-29 11:29 ` Peter Zijlstra 2021-03-29 11:29 ` Peter Zijlstra 2021-03-29 12:52 ` Guo Ren 2021-03-29 12:52 ` Guo Ren 2021-03-29 13:56 ` Arnd Bergmann 2021-03-29 13:56 ` Arnd Bergmann 2021-03-30 2:26 ` Guo Ren 2021-03-30 2:26 ` Guo Ren 2021-03-30 5:51 ` Anup Patel 2021-03-30 5:51 ` Anup Patel 2021-03-30 6:26 ` Guo Ren 2021-03-30 6:26 ` Guo Ren 2021-03-30 7:11 ` Arnd Bergmann 2021-03-30 7:11 ` Arnd Bergmann 2021-03-31 4:18 ` Guo Ren 2021-03-31 4:18 ` Guo Ren 2021-03-31 5:33 ` Paul Campbell 2021-03-31 5:33 ` Paul Campbell 2021-04-05 16:12 ` Guo Ren 2021-04-05 16:12 ` Guo Ren 2021-03-31 6:44 ` Guo Ren 2021-03-31 6:44 ` Guo Ren 2021-03-31 7:12 ` Arnd Bergmann 2021-03-31 7:12 ` Arnd Bergmann 2021-03-29 11:19 ` Guo Ren 2021-03-29 11:19 ` Guo Ren 2021-03-29 11:26 ` Peter Zijlstra 2021-03-29 11:26 ` Peter Zijlstra 2021-03-29 12:01 ` Guo Ren 2021-03-29 12:01 ` Guo Ren 2021-03-29 12:49 ` Peter Zijlstra 2021-03-29 12:49 ` Peter Zijlstra 2021-03-30 3:13 ` Guo Ren 2021-03-30 3:13 ` Guo Ren 2021-03-30 4:54 ` Anup Patel 2021-03-30 4:54 ` Anup Patel 2021-03-30 6:27 ` Guo Ren 2021-03-30 6:27 ` Guo Ren 2021-03-30 8:31 ` David Laight 2021-03-30 8:31 ` David Laight 2021-03-30 14:09 ` Waiman Long 2021-03-30 14:09 ` Waiman Long 2021-03-31 14:47 ` Guo Ren 2021-03-31 14:47 ` Guo Ren 2021-04-05 16:45 ` Guo Ren 2021-04-05 16:45 ` Guo Ren 2021-03-30 16:08 ` Peter Zijlstra 2021-03-30 16:08 ` Peter Zijlstra 2021-03-30 22:35 ` Stafford Horne 2021-03-30 22:35 ` Stafford Horne 2021-03-31 7:23 ` Arnd Bergmann 2021-03-31 7:23 ` Arnd Bergmann 2021-03-31 12:31 ` Stafford Horne 2021-03-31 12:31 ` Stafford Horne 2021-03-31 15:10 ` Guo Ren 2021-03-31 15:10 ` Guo Ren 2021-04-06 8:51 ` Stafford Horne 2021-04-06 8:51 ` Stafford Horne 2021-04-06 3:50 ` Guo Ren 2021-04-06 3:50 ` Guo Ren 2021-04-06 8:56 ` Stafford Horne 2021-04-06 8:56 ` Stafford Horne 2021-04-07 8:42 ` Arnd Bergmann 2021-04-07 8:42 ` Arnd Bergmann 2021-04-07 11:36 ` Peter Zijlstra 2021-04-07 11:36 ` Peter Zijlstra 2021-04-07 11:57 ` Arnd Bergmann 2021-04-07 11:57 ` Arnd Bergmann 2021-04-07 12:02 ` Peter Zijlstra 2021-04-07 12:02 ` Peter Zijlstra 2021-04-05 16:40 ` Guo Ren 2021-04-05 16:40 ` Guo Ren 2021-03-31 15:22 ` Guo Ren 2021-03-31 15:22 ` Guo Ren 2021-04-06 7:15 ` Peter Zijlstra 2021-04-06 7:15 ` Peter Zijlstra 2021-04-07 9:42 ` Christoph Hellwig 2021-04-07 9:42 ` Christoph Hellwig 2021-04-07 14:29 ` Christoph Müllner 2021-04-07 14:29 ` Christoph Müllner 2021-04-07 14:34 ` Christoph Hellwig 2021-04-07 14:34 ` Christoph Hellwig 2021-04-07 15:51 ` Peter Zijlstra 2021-04-07 15:51 ` Peter Zijlstra 2021-04-07 16:44 ` Peter Zijlstra 2021-04-07 16:44 ` Peter Zijlstra 2021-04-07 15:52 ` Peter Zijlstra 2021-04-07 15:52 ` Peter Zijlstra 2021-04-07 16:54 ` Peter Zijlstra 2021-04-07 16:54 ` Peter Zijlstra 2021-04-07 16:00 ` Peter Zijlstra 2021-04-07 16:00 ` Peter Zijlstra 2021-04-07 19:50 ` Christoph Müllner 2021-04-07 19:50 ` Christoph Müllner 2021-04-06 17:24 ` Boqun Feng 2021-04-06 17:24 ` Boqun Feng 2021-04-07 9:26 ` Peter Zijlstra 2021-04-07 9:26 ` Peter Zijlstra 2021-03-29 12:13 ` Anup Patel 2021-03-29 12:13 ` Anup Patel 2021-03-29 12:54 ` Peter Zijlstra 2021-03-29 12:54 ` Peter Zijlstra 2021-03-27 18:06 ` [PATCH v4 4/4] riscv: Convert custom spinlock/rwlock to generic qspinlock/qrwlock guoren 2021-03-27 18:06 ` guoren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1616868399-82848-1-git-send-email-guoren@kernel.org \ --to=guoren@kernel.org \ --cc=guoren@linux.alibaba.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-csky@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.