From: Stephen Boyd <sboyd@kernel.org> To: Alain Volmat <avolmat@me.com>, Michael Turquette <mturquette@baylibre.com>, Patrice Chotard <patrice.chotard@foss.st.com>, Rob Herring <robh+dt@kernel.org> Cc: Lee Jones <lee.jones@linaro.org>, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alain Volmat <avolmat@me.com> Subject: Re: [PATCH v2 00/16] clk: st: embed clock outputs within drivers Date: Mon, 29 Mar 2021 19:01:00 -0700 [thread overview] Message-ID: <161706966003.3012082.13602640109563561014@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <20210325075018.6598-1-avolmat@me.com> Quoting Alain Volmat (2021-03-25 00:50:02) > Most of ST clock drivers used by STi platform are updated in > order to introduce clock outputs informations within each drivers > and thus allow to avoid having to rely on clock-output-names properties > within DT clock nodes. > For that purpose, drivers are updated to allow handling both modes > (with or without clock-output-names). > Once all DT will have been updated, the legacy mode could be removed > from the drivers. > This will also allow, once all STi DT will be corrected, to remove the > of_clk_detect_critical API from clk core code since STi clock drivers > are the only drivers using this API. > > This serie also contains modifications within STi DTS in order to use > the newly introduced compatible and remove clock-output-names > properties. Can you split the dts changes from the driver changes and only send the clk driver changes to clk maintainers? I don't intend to apply dts file changes to the clk tree. Those can go via arm-soc based on some immutable branch that lives in clk tree until next merge window closes. > > Alain Volmat (16): > clk: st: clkgen-pll: remove used variable of struct clkgen_pll > clk: st: flexgen: embed soc clock outputs within compatible data > dt-bindings: clock: st: flexgen: add new introduced compatible > clk: st: clkgen-pll: embed soc clock outputs within compatible data > dt-bindings: clock: st: clkgen-pll: add new introduced compatible > clk: st: clkgen-fsyn: embed soc clock outputs within compatible data > dt-bindings: clock: st: clkgen-fsyn: add new introduced compatible > ARM: dts: sti: update flexgen compatible within stih418-clock > ARM: dts: sti: update flexgen compatible within stih407-clock > ARM: dts: sti: update flexgen compatible within stih410-clock > ARM: dts: sti: update clkgen-pll entries in stih407-clock > ARM: dts: sti: update clkgen-pll entries in stih410-clock > ARM: dts: sti: update clkgen-pll entries in stih418-clock > ARM: dts: sti: update clkgen-fsyn entries in stih407-clock > ARM: dts: sti: update clkgen-fsyn entries in stih410-clock > ARM: dts: sti: update clkgen-fsyn entries in stih418-clock > > .../bindings/clock/st/st,clkgen-pll.txt | 3 + > .../bindings/clock/st/st,flexgen.txt | 10 + > .../bindings/clock/st/st,quadfs.txt | 3 + > arch/arm/boot/dts/stih407-clock.dtsi | 128 +------ > arch/arm/boot/dts/stih410-clock.dtsi | 138 +------ > arch/arm/boot/dts/stih418-clock.dtsi | 136 +------ > drivers/clk/st/clk-flexgen.c | 344 +++++++++++++++++- > drivers/clk/st/clkgen-fsyn.c | 113 +++++- > drivers/clk/st/clkgen-pll.c | 121 +++++- > 9 files changed, 588 insertions(+), 408 deletions(-) > > --- > v2: fix drivers to update some clocks as CLK_IS_CRITICAL > Please document in the code why CLK_IS_CRITICAL is used. For example, "This clk needs to be on so the CPU can keep fetching instructions from memory" or something like that.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org> To: Alain Volmat <avolmat@me.com>, Michael Turquette <mturquette@baylibre.com>, Patrice Chotard <patrice.chotard@foss.st.com>, Rob Herring <robh+dt@kernel.org> Cc: Lee Jones <lee.jones@linaro.org>, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alain Volmat <avolmat@me.com> Subject: Re: [PATCH v2 00/16] clk: st: embed clock outputs within drivers Date: Mon, 29 Mar 2021 19:01:00 -0700 [thread overview] Message-ID: <161706966003.3012082.13602640109563561014@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <20210325075018.6598-1-avolmat@me.com> Quoting Alain Volmat (2021-03-25 00:50:02) > Most of ST clock drivers used by STi platform are updated in > order to introduce clock outputs informations within each drivers > and thus allow to avoid having to rely on clock-output-names properties > within DT clock nodes. > For that purpose, drivers are updated to allow handling both modes > (with or without clock-output-names). > Once all DT will have been updated, the legacy mode could be removed > from the drivers. > This will also allow, once all STi DT will be corrected, to remove the > of_clk_detect_critical API from clk core code since STi clock drivers > are the only drivers using this API. > > This serie also contains modifications within STi DTS in order to use > the newly introduced compatible and remove clock-output-names > properties. Can you split the dts changes from the driver changes and only send the clk driver changes to clk maintainers? I don't intend to apply dts file changes to the clk tree. Those can go via arm-soc based on some immutable branch that lives in clk tree until next merge window closes. > > Alain Volmat (16): > clk: st: clkgen-pll: remove used variable of struct clkgen_pll > clk: st: flexgen: embed soc clock outputs within compatible data > dt-bindings: clock: st: flexgen: add new introduced compatible > clk: st: clkgen-pll: embed soc clock outputs within compatible data > dt-bindings: clock: st: clkgen-pll: add new introduced compatible > clk: st: clkgen-fsyn: embed soc clock outputs within compatible data > dt-bindings: clock: st: clkgen-fsyn: add new introduced compatible > ARM: dts: sti: update flexgen compatible within stih418-clock > ARM: dts: sti: update flexgen compatible within stih407-clock > ARM: dts: sti: update flexgen compatible within stih410-clock > ARM: dts: sti: update clkgen-pll entries in stih407-clock > ARM: dts: sti: update clkgen-pll entries in stih410-clock > ARM: dts: sti: update clkgen-pll entries in stih418-clock > ARM: dts: sti: update clkgen-fsyn entries in stih407-clock > ARM: dts: sti: update clkgen-fsyn entries in stih410-clock > ARM: dts: sti: update clkgen-fsyn entries in stih418-clock > > .../bindings/clock/st/st,clkgen-pll.txt | 3 + > .../bindings/clock/st/st,flexgen.txt | 10 + > .../bindings/clock/st/st,quadfs.txt | 3 + > arch/arm/boot/dts/stih407-clock.dtsi | 128 +------ > arch/arm/boot/dts/stih410-clock.dtsi | 138 +------ > arch/arm/boot/dts/stih418-clock.dtsi | 136 +------ > drivers/clk/st/clk-flexgen.c | 344 +++++++++++++++++- > drivers/clk/st/clkgen-fsyn.c | 113 +++++- > drivers/clk/st/clkgen-pll.c | 121 +++++- > 9 files changed, 588 insertions(+), 408 deletions(-) > > --- > v2: fix drivers to update some clocks as CLK_IS_CRITICAL > Please document in the code why CLK_IS_CRITICAL is used. For example, "This clk needs to be on so the CPU can keep fetching instructions from memory" or something like that. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-30 2:01 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-25 7:50 [PATCH v2 00/16] clk: st: embed clock outputs within drivers Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 01/16] clk: st: clkgen-pll: remove used variable of struct clkgen_pll Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 02/16] clk: st: flexgen: embed soc clock outputs within compatible data Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 03/16] dt-bindings: clock: st: flexgen: add new introduced compatible Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-27 17:43 ` Rob Herring 2021-03-27 17:43 ` Rob Herring 2021-03-25 7:50 ` [PATCH v2 04/16] clk: st: clkgen-pll: embed soc clock outputs within compatible data Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 05/16] dt-bindings: clock: st: clkgen-pll: add new introduced compatible Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-27 17:46 ` Rob Herring 2021-03-27 17:46 ` Rob Herring 2021-03-25 7:50 ` [PATCH v2 06/16] clk: st: clkgen-fsyn: embed soc clock outputs within compatible data Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 07/16] dt-bindings: clock: st: clkgen-fsyn: add new introduced compatible Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 08/16] ARM: dts: sti: update flexgen compatible within stih418-clock Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 09/16] ARM: dts: sti: update flexgen compatible within stih407-clock Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 10/16] ARM: dts: sti: update flexgen compatible within stih410-clock Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 11/16] ARM: dts: sti: update clkgen-pll entries in stih407-clock Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 12/16] ARM: dts: sti: update clkgen-pll entries in stih410-clock Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 13/16] ARM: dts: sti: update clkgen-pll entries in stih418-clock Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 14/16] ARM: dts: sti: update clkgen-fsyn entries in stih407-clock Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 15/16] ARM: dts: sti: update clkgen-fsyn entries in stih410-clock Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-25 7:50 ` [PATCH v2 16/16] ARM: dts: sti: update clkgen-fsyn entries in stih418-clock Alain Volmat 2021-03-25 7:50 ` Alain Volmat 2021-03-30 2:01 ` Stephen Boyd [this message] 2021-03-30 2:01 ` [PATCH v2 00/16] clk: st: embed clock outputs within drivers Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=161706966003.3012082.13602640109563561014@swboyd.mtv.corp.google.com \ --to=sboyd@kernel.org \ --cc=avolmat@me.com \ --cc=devicetree@vger.kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=patrice.chotard@foss.st.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.