From: Rob Herring <robh@kernel.org>
To: Mark Kettenis <kettenis@openbsd.org>
Cc: linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, Hector Martin <marcan@marcan.st>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl
Date: Mon, 10 May 2021 09:01:39 -0500 [thread overview]
Message-ID: <1620655299.786306.41436.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210508142000.85116-2-kettenis@openbsd.org>
On Sat, 08 May 2021 16:19:55 +0200, Mark Kettenis wrote:
> The Apple GPIO controller is a simple combined pin and GPIO conroller
> present on Apple ARM SoC platforms, including various iPhone and iPad
> devices and the "Apple Silicon" Macs.
>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
> .../bindings/pinctrl/apple,pinctrl.yaml | 103 ++++++++++++++++++
> MAINTAINERS | 2 +
> include/dt-bindings/pinctrl/apple.h | 13 +++
> 3 files changed, 118 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml
> create mode 100644 include/dt-bindings/pinctrl/apple.h
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/pinctrl/apple,pinctrl.example.dts:19:18: fatal error: dt-bindings/interrupt-controller/apple-aic.h: No such file or directory
19 | #include <dt-bindings/interrupt-controller/apple-aic.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:377: Documentation/devicetree/bindings/pinctrl/apple,pinctrl.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1414: dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1475875
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Mark Kettenis <kettenis@openbsd.org>
Cc: linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, Hector Martin <marcan@marcan.st>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl
Date: Mon, 10 May 2021 09:01:39 -0500 [thread overview]
Message-ID: <1620655299.786306.41436.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210508142000.85116-2-kettenis@openbsd.org>
On Sat, 08 May 2021 16:19:55 +0200, Mark Kettenis wrote:
> The Apple GPIO controller is a simple combined pin and GPIO conroller
> present on Apple ARM SoC platforms, including various iPhone and iPad
> devices and the "Apple Silicon" Macs.
>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
> .../bindings/pinctrl/apple,pinctrl.yaml | 103 ++++++++++++++++++
> MAINTAINERS | 2 +
> include/dt-bindings/pinctrl/apple.h | 13 +++
> 3 files changed, 118 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml
> create mode 100644 include/dt-bindings/pinctrl/apple.h
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/pinctrl/apple,pinctrl.example.dts:19:18: fatal error: dt-bindings/interrupt-controller/apple-aic.h: No such file or directory
19 | #include <dt-bindings/interrupt-controller/apple-aic.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:377: Documentation/devicetree/bindings/pinctrl/apple,pinctrl.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1414: dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1475875
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-10 14:09 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 14:19 [PATCH 0/2] Apple M1 pinctrl DT bindings Mark Kettenis
2021-05-08 14:19 ` Mark Kettenis
2021-05-08 14:19 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl Mark Kettenis
2021-05-08 14:19 ` Mark Kettenis
2021-05-08 21:09 ` Linus Walleij
2021-05-08 21:09 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl Linus Walleij
2021-05-08 23:02 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl Mark Kettenis
2021-05-08 23:02 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl Mark Kettenis
2021-05-09 0:27 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl Linus Walleij
2021-05-09 0:27 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl Linus Walleij
2021-05-09 9:50 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl Tomasz Figa
2021-05-09 9:50 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl Tomasz Figa
2021-05-10 13:09 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl Krzysztof Kozlowski
2021-05-10 13:09 ` Krzysztof Kozlowski
2021-05-09 0:18 ` Linus Walleij
2021-05-09 0:18 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl Linus Walleij
2021-05-09 9:46 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl Mark Kettenis
2021-05-09 9:46 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl Mark Kettenis
2021-05-09 10:49 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl Linus Walleij
2021-05-09 10:49 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl Linus Walleij
2021-05-10 13:03 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl Krzysztof Kozlowski
2021-05-10 13:03 ` Krzysztof Kozlowski
2021-05-10 17:09 ` Mark Kettenis
2021-05-10 17:09 ` Mark Kettenis
2021-05-10 14:01 ` Rob Herring [this message]
2021-05-10 14:01 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl Rob Herring
2021-05-10 18:18 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl Rob Herring
2021-05-10 18:18 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl Rob Herring
2021-05-10 14:19 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl Rob Herring
2021-05-10 14:19 ` Rob Herring
2021-05-10 17:06 ` Mark Kettenis
2021-05-10 17:06 ` Mark Kettenis
2021-05-19 23:27 ` Linus Walleij
2021-05-19 23:27 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl Linus Walleij
2021-05-20 11:22 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl Mark Kettenis
2021-05-20 11:22 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl Mark Kettenis
2021-05-08 14:19 ` [PATCH 2/2] arm64: apple: Add pinctrl nodes Mark Kettenis
2021-05-08 14:19 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1620655299.786306.41436.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.