* [PATCH -next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init()
@ 2021-04-02 9:32 Yang Yingliang
2021-04-06 8:30 ` Robert Foss
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2021-04-02 9:32 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, linux-media; +Cc: robert.foss
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/media/platform/qcom/camss/camss-csid.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
index 463760c29294..cc11fbfdae13 100644
--- a/drivers/media/platform/qcom/camss/camss-csid.c
+++ b/drivers/media/platform/qcom/camss/camss-csid.c
@@ -568,10 +568,8 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
csid->base = devm_ioremap_resource(dev, r);
- if (IS_ERR(csid->base)) {
- dev_err(dev, "could not map memory\n");
+ if (IS_ERR(csid->base))
return PTR_ERR(csid->base);
- }
/* Interrupt */
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init()
2021-04-02 9:32 [PATCH -next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init() Yang Yingliang
@ 2021-04-06 8:30 ` Robert Foss
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: Robert Foss @ 2021-04-06 8:30 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, MSM, linux-media
Hi Yang,
Thanks for the fix.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
On Fri, 2 Apr 2021 at 11:29, Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/media/platform/qcom/camss/camss-csid.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
> index 463760c29294..cc11fbfdae13 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid.c
> +++ b/drivers/media/platform/qcom/camss/camss-csid.c
> @@ -568,10 +568,8 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
>
> r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
> csid->base = devm_ioremap_resource(dev, r);
> - if (IS_ERR(csid->base)) {
> - dev_err(dev, "could not map memory\n");
> + if (IS_ERR(csid->base))
> return PTR_ERR(csid->base);
> - }
>
> /* Interrupt */
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init()
2021-04-02 9:32 [PATCH -next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init() Yang Yingliang
2021-04-06 8:30 ` Robert Foss
@ 2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-05-26 19:03 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Fri, 2 Apr 2021 17:32:55 +0800 you wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>
> [...]
Here is the summary with links:
- [-next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init()
https://git.kernel.org/qcom/c/6c0ed6d4b321
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-26 19:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-02 9:32 [PATCH -next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init() Yang Yingliang
2021-04-06 8:30 ` Robert Foss
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.