* [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m
@ 2021-06-08 10:56 ` Geert Uytterhoeven
0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2021-06-08 10:56 UTC (permalink / raw)
To: David S . Miller, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, Omkar Kulkarni, Hannes Reinecke, Dean Balandin,
Himanshu Madhani, Shai Malin
Cc: Petr Mladek, linux-nvme, netdev, linux-kernel, Geert Uytterhoeven
The help text for the symbol controlling support for the NVM Express
over Fabrics TCP offload common layer suggests to not enable this
support when unsure.
Hence drop the "default m", which actually means "default y" if
CONFIG_MODULES is not enabled.
Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/nvme/host/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index 9c6f4d776daf14cf..f76cc4690bfc37bc 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -88,7 +88,6 @@ config NVME_TCP
config NVME_TCP_OFFLOAD
tristate "NVM Express over Fabrics TCP offload common layer"
- default m
depends on BLOCK
depends on INET
select NVME_CORE
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m
@ 2021-06-08 10:56 ` Geert Uytterhoeven
0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2021-06-08 10:56 UTC (permalink / raw)
To: David S . Miller, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, Omkar Kulkarni, Hannes Reinecke, Dean Balandin,
Himanshu Madhani, Shai Malin
Cc: Petr Mladek, linux-nvme, netdev, linux-kernel, Geert Uytterhoeven
The help text for the symbol controlling support for the NVM Express
over Fabrics TCP offload common layer suggests to not enable this
support when unsure.
Hence drop the "default m", which actually means "default y" if
CONFIG_MODULES is not enabled.
Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/nvme/host/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index 9c6f4d776daf14cf..f76cc4690bfc37bc 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -88,7 +88,6 @@ config NVME_TCP
config NVME_TCP_OFFLOAD
tristate "NVM Express over Fabrics TCP offload common layer"
- default m
depends on BLOCK
depends on INET
select NVME_CORE
--
2.25.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m
2021-06-08 10:56 ` Geert Uytterhoeven
@ 2021-06-08 12:19 ` Christoph Hellwig
-1 siblings, 0 replies; 14+ messages in thread
From: Christoph Hellwig @ 2021-06-08 12:19 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: David S . Miller, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, Omkar Kulkarni, Hannes Reinecke, Dean Balandin,
Himanshu Madhani, Shai Malin, Petr Mladek, linux-nvme, netdev,
linux-kernel
On Tue, Jun 08, 2021 at 12:56:09PM +0200, Geert Uytterhoeven wrote:
> The help text for the symbol controlling support for the NVM Express
> over Fabrics TCP offload common layer suggests to not enable this
> support when unsure.
>
> Hence drop the "default m", which actually means "default y" if
> CONFIG_MODULES is not enabled.
>
> Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Err, where did this appear from? This code has not been accepted into
the NVMe tree and is indeed not acceptable in this form.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m
@ 2021-06-08 12:19 ` Christoph Hellwig
0 siblings, 0 replies; 14+ messages in thread
From: Christoph Hellwig @ 2021-06-08 12:19 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: David S . Miller, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, Omkar Kulkarni, Hannes Reinecke, Dean Balandin,
Himanshu Madhani, Shai Malin, Petr Mladek, linux-nvme, netdev,
linux-kernel
On Tue, Jun 08, 2021 at 12:56:09PM +0200, Geert Uytterhoeven wrote:
> The help text for the symbol controlling support for the NVM Express
> over Fabrics TCP offload common layer suggests to not enable this
> support when unsure.
>
> Hence drop the "default m", which actually means "default y" if
> CONFIG_MODULES is not enabled.
>
> Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Err, where did this appear from? This code has not been accepted into
the NVMe tree and is indeed not acceptable in this form.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m
2021-06-08 12:19 ` Christoph Hellwig
@ 2021-06-08 13:37 ` Geert Uytterhoeven
-1 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2021-06-08 13:37 UTC (permalink / raw)
To: Christoph Hellwig
Cc: David S . Miller, Keith Busch, Jens Axboe, Sagi Grimberg,
Omkar Kulkarni, Hannes Reinecke, Dean Balandin, Himanshu Madhani,
Shai Malin, Petr Mladek, linux-nvme, netdev,
Linux Kernel Mailing List
Hi Christoph,
On Tue, Jun 8, 2021 at 2:19 PM Christoph Hellwig <hch@lst.de> wrote:
> On Tue, Jun 08, 2021 at 12:56:09PM +0200, Geert Uytterhoeven wrote:
> > The help text for the symbol controlling support for the NVM Express
> > over Fabrics TCP offload common layer suggests to not enable this
> > support when unsure.
> >
> > Hence drop the "default m", which actually means "default y" if
> > CONFIG_MODULES is not enabled.
> >
> > Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Err, where did this appear from? This code has not been accepted into
> the NVMe tree and is indeed not acceptable in this form.
It was applied to net-next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m
@ 2021-06-08 13:37 ` Geert Uytterhoeven
0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2021-06-08 13:37 UTC (permalink / raw)
To: Christoph Hellwig
Cc: David S . Miller, Keith Busch, Jens Axboe, Sagi Grimberg,
Omkar Kulkarni, Hannes Reinecke, Dean Balandin, Himanshu Madhani,
Shai Malin, Petr Mladek, linux-nvme, netdev,
Linux Kernel Mailing List
Hi Christoph,
On Tue, Jun 8, 2021 at 2:19 PM Christoph Hellwig <hch@lst.de> wrote:
> On Tue, Jun 08, 2021 at 12:56:09PM +0200, Geert Uytterhoeven wrote:
> > The help text for the symbol controlling support for the NVM Express
> > over Fabrics TCP offload common layer suggests to not enable this
> > support when unsure.
> >
> > Hence drop the "default m", which actually means "default y" if
> > CONFIG_MODULES is not enabled.
> >
> > Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Err, where did this appear from? This code has not been accepted into
> the NVMe tree and is indeed not acceptable in this form.
It was applied to net-next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 14+ messages in thread* please drop the nvme code from net-next
2021-06-08 13:37 ` Geert Uytterhoeven
@ 2021-06-08 13:43 ` Christoph Hellwig
-1 siblings, 0 replies; 14+ messages in thread
From: Christoph Hellwig @ 2021-06-08 13:43 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: David S . Miller, Keith Busch, Jens Axboe, Sagi Grimberg,
Omkar Kulkarni, Hannes Reinecke, Dean Balandin, Himanshu Madhani,
Shai Malin, Petr Mladek, linux-nvme, netdev,
Linux Kernel Mailing List
Hi Dave,
please drop the nvme-offload code from net-next. Code for drivers/nvme/
needs ACKs from us nvme maintainers and for something this significant
also needs to go through the NVMe tree. And this code is not ready yet.
^ permalink raw reply [flat|nested] 14+ messages in thread
* please drop the nvme code from net-next
@ 2021-06-08 13:43 ` Christoph Hellwig
0 siblings, 0 replies; 14+ messages in thread
From: Christoph Hellwig @ 2021-06-08 13:43 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: David S . Miller, Keith Busch, Jens Axboe, Sagi Grimberg,
Omkar Kulkarni, Hannes Reinecke, Dean Balandin, Himanshu Madhani,
Shai Malin, Petr Mladek, linux-nvme, netdev,
Linux Kernel Mailing List
Hi Dave,
please drop the nvme-offload code from net-next. Code for drivers/nvme/
needs ACKs from us nvme maintainers and for something this significant
also needs to go through the NVMe tree. And this code is not ready yet.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: please drop the nvme code from net-next
2021-06-08 13:43 ` Christoph Hellwig
@ 2021-06-08 19:08 ` David Miller
-1 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2021-06-08 19:08 UTC (permalink / raw)
To: hch
Cc: geert, kbusch, axboe, sagi, okulkarni, hare, dbalandin,
himanshu.madhani, smalin, pmladek, linux-nvme, netdev,
linux-kernel
From: Christoph Hellwig <hch@lst.de>
Date: Tue, 8 Jun 2021 15:43:03 +0200
> please drop the nvme-offload code from net-next. Code for drivers/nvme/
> needs ACKs from us nvme maintainers and for something this significant
> also needs to go through the NVMe tree. And this code is not ready yet.
Please send me a revert, and I will apply it, thank you.
It's tricky because at least one driver uses the new interfaces.
Thank you.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: please drop the nvme code from net-next
@ 2021-06-08 19:08 ` David Miller
0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2021-06-08 19:08 UTC (permalink / raw)
To: hch
Cc: geert, kbusch, axboe, sagi, okulkarni, hare, dbalandin,
himanshu.madhani, smalin, pmladek, linux-nvme, netdev,
linux-kernel
From: Christoph Hellwig <hch@lst.de>
Date: Tue, 8 Jun 2021 15:43:03 +0200
> please drop the nvme-offload code from net-next. Code for drivers/nvme/
> needs ACKs from us nvme maintainers and for something this significant
> also needs to go through the NVMe tree. And this code is not ready yet.
Please send me a revert, and I will apply it, thank you.
It's tricky because at least one driver uses the new interfaces.
Thank you.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: please drop the nvme code from net-next
2021-06-08 19:08 ` David Miller
@ 2021-06-08 19:40 ` Keith Busch
-1 siblings, 0 replies; 14+ messages in thread
From: Keith Busch @ 2021-06-08 19:40 UTC (permalink / raw)
To: David Miller
Cc: hch, geert, axboe, sagi, okulkarni, hare, dbalandin,
himanshu.madhani, smalin, pmladek, linux-nvme, netdev,
linux-kernel
On Tue, Jun 08, 2021 at 12:08:39PM -0700, David Miller wrote:
> From: Christoph Hellwig <hch@lst.de>
> Date: Tue, 8 Jun 2021 15:43:03 +0200
>
> > please drop the nvme-offload code from net-next. Code for drivers/nvme/
> > needs ACKs from us nvme maintainers and for something this significant
> > also needs to go through the NVMe tree. And this code is not ready yet.
>
> Please send me a revert, and I will apply it, thank you.
>
> It's tricky because at least one driver uses the new interfaces.
Shouldn't whoever merged un-ACK'ed patches from a different subsystem
get to own the tricky revert?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: please drop the nvme code from net-next
@ 2021-06-08 19:40 ` Keith Busch
0 siblings, 0 replies; 14+ messages in thread
From: Keith Busch @ 2021-06-08 19:40 UTC (permalink / raw)
To: David Miller
Cc: hch, geert, axboe, sagi, okulkarni, hare, dbalandin,
himanshu.madhani, smalin, pmladek, linux-nvme, netdev,
linux-kernel
On Tue, Jun 08, 2021 at 12:08:39PM -0700, David Miller wrote:
> From: Christoph Hellwig <hch@lst.de>
> Date: Tue, 8 Jun 2021 15:43:03 +0200
>
> > please drop the nvme-offload code from net-next. Code for drivers/nvme/
> > needs ACKs from us nvme maintainers and for something this significant
> > also needs to go through the NVMe tree. And this code is not ready yet.
>
> Please send me a revert, and I will apply it, thank you.
>
> It's tricky because at least one driver uses the new interfaces.
Shouldn't whoever merged un-ACK'ed patches from a different subsystem
get to own the tricky revert?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m
2021-06-08 10:56 ` Geert Uytterhoeven
@ 2021-06-08 19:10 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 14+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-08 19:10 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: davem, kbusch, axboe, hch, sagi, okulkarni, hare, dbalandin,
himanshu.madhani, smalin, pmladek, linux-nvme, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 8 Jun 2021 12:56:09 +0200 you wrote:
> The help text for the symbol controlling support for the NVM Express
> over Fabrics TCP offload common layer suggests to not enable this
> support when unsure.
>
> Hence drop the "default m", which actually means "default y" if
> CONFIG_MODULES is not enabled.
>
> [...]
Here is the summary with links:
- nvme: NVME_TCP_OFFLOAD should not default to m
https://git.kernel.org/netdev/net-next/c/762411542050
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m
@ 2021-06-08 19:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 14+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-08 19:10 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: davem, kbusch, axboe, hch, sagi, okulkarni, hare, dbalandin,
himanshu.madhani, smalin, pmladek, linux-nvme, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 8 Jun 2021 12:56:09 +0200 you wrote:
> The help text for the symbol controlling support for the NVM Express
> over Fabrics TCP offload common layer suggests to not enable this
> support when unsure.
>
> Hence drop the "default m", which actually means "default y" if
> CONFIG_MODULES is not enabled.
>
> [...]
Here is the summary with links:
- nvme: NVME_TCP_OFFLOAD should not default to m
https://git.kernel.org/netdev/net-next/c/762411542050
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-10-13 6:16 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 10:56 [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m Geert Uytterhoeven
2021-06-08 10:56 ` Geert Uytterhoeven
2021-06-08 12:19 ` Christoph Hellwig
2021-06-08 12:19 ` Christoph Hellwig
2021-06-08 13:37 ` Geert Uytterhoeven
2021-06-08 13:37 ` Geert Uytterhoeven
2021-06-08 13:43 ` please drop the nvme code from net-next Christoph Hellwig
2021-06-08 13:43 ` Christoph Hellwig
2021-06-08 19:08 ` David Miller
2021-06-08 19:08 ` David Miller
2021-06-08 19:40 ` Keith Busch
2021-06-08 19:40 ` Keith Busch
2021-06-08 19:10 ` [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m patchwork-bot+netdevbpf
2021-06-08 19:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.