From: Sudeep Holla <sudeep.holla@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] firmware: arm_scmi: Avoid padding in sensor message structure
Date: Wed, 14 Jul 2021 17:38:21 +0100 [thread overview]
Message-ID: <162628065273.2615991.7447656949078196138.b4-ty@arm.com> (raw)
In-Reply-To: <20210628170042.34105-1-cristian.marussi@arm.com>
On Mon, 28 Jun 2021 18:00:42 +0100, Cristian Marussi wrote:
> Structure scmi_resp_sensor_reading_complete is meant to represent an SCMI
> asynchronous reading complete message: representing the readings field with
> a 64bit type forces padding and breaks reads in scmi_sensor_reading_get.
>
> Split it in two adjacent 32bit readings_low/high subfields to avoid padding
> or the need to make it packed.
Applied to sudeep.holla/linux (for-next/scmi), thanks!
[1/1] firmware: arm_scmi: Avoid padding in sensor message structure
https://git.kernel.org/sudeep.holla/c/187a002b07
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] firmware: arm_scmi: Avoid padding in sensor message structure
Date: Wed, 14 Jul 2021 17:38:21 +0100 [thread overview]
Message-ID: <162628065273.2615991.7447656949078196138.b4-ty@arm.com> (raw)
In-Reply-To: <20210628170042.34105-1-cristian.marussi@arm.com>
On Mon, 28 Jun 2021 18:00:42 +0100, Cristian Marussi wrote:
> Structure scmi_resp_sensor_reading_complete is meant to represent an SCMI
> asynchronous reading complete message: representing the readings field with
> a 64bit type forces padding and breaks reads in scmi_sensor_reading_get.
>
> Split it in two adjacent 32bit readings_low/high subfields to avoid padding
> or the need to make it packed.
Applied to sudeep.holla/linux (for-next/scmi), thanks!
[1/1] firmware: arm_scmi: Avoid padding in sensor message structure
https://git.kernel.org/sudeep.holla/c/187a002b07
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-14 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 17:00 [PATCH] firmware: arm_scmi: Avoid padding in sensor message structure Cristian Marussi
2021-06-28 17:00 ` Cristian Marussi
2021-07-14 16:38 ` Sudeep Holla [this message]
2021-07-14 16:38 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162628065273.2615991.7447656949078196138.b4-ty@arm.com \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.