From: Kewei Xu <kewei.xu@mediatek.com>
To: <wsa@the-dreams.de>
Cc: <matthias.bgg@gmail.com>, <robh+dt@kernel.org>,
<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>,
<qii.wang@mediatek.com>, <yuhan.wei@mediatek.com>,
<kewei.xu@mediatek.com>, <ot_daolong.zhu@mediatek.com>,
<liguo.zhang@mediatek.com>
Subject: [PATCH v4 1/8] i2c: mediatek: fixing the incorrect register offset
Date: Sat, 17 Jul 2021 18:17:52 +0800 [thread overview]
Message-ID: <1626517079-9057-2-git-send-email-kewei.xu@mediatek.com> (raw)
In-Reply-To: <1626517079-9057-1-git-send-email-kewei.xu@mediatek.com>
The reason for the modification here is that the previous
offset information is incorrect, OFFSET_DEBUGSTAT = 0xE4 is
the correct value.
Fixes: 25708278f810 ("i2c: mediatek: Add i2c support for MediaTek MT8183")
Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
---
drivers/i2c/busses/i2c-mt65xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 5ddfa4e56ee2..222ff765e55d 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -193,7 +193,7 @@ static const u16 mt_i2c_regs_v2[] = {
[OFFSET_CLOCK_DIV] = 0x48,
[OFFSET_SOFTRESET] = 0x50,
[OFFSET_SCL_MIS_COMP_POINT] = 0x90,
- [OFFSET_DEBUGSTAT] = 0xe0,
+ [OFFSET_DEBUGSTAT] = 0xe4,
[OFFSET_DEBUGCTRL] = 0xe8,
[OFFSET_FIFO_STAT] = 0xf4,
[OFFSET_FIFO_THRESH] = 0xf8,
--
2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Kewei Xu <kewei.xu@mediatek.com>
To: <wsa@the-dreams.de>
Cc: <matthias.bgg@gmail.com>, <robh+dt@kernel.org>,
<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>,
<qii.wang@mediatek.com>, <yuhan.wei@mediatek.com>,
<kewei.xu@mediatek.com>, <ot_daolong.zhu@mediatek.com>,
<liguo.zhang@mediatek.com>
Subject: [PATCH v4 1/8] i2c: mediatek: fixing the incorrect register offset
Date: Sat, 17 Jul 2021 18:17:52 +0800 [thread overview]
Message-ID: <1626517079-9057-2-git-send-email-kewei.xu@mediatek.com> (raw)
In-Reply-To: <1626517079-9057-1-git-send-email-kewei.xu@mediatek.com>
The reason for the modification here is that the previous
offset information is incorrect, OFFSET_DEBUGSTAT = 0xE4 is
the correct value.
Fixes: 25708278f810 ("i2c: mediatek: Add i2c support for MediaTek MT8183")
Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
---
drivers/i2c/busses/i2c-mt65xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 5ddfa4e56ee2..222ff765e55d 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -193,7 +193,7 @@ static const u16 mt_i2c_regs_v2[] = {
[OFFSET_CLOCK_DIV] = 0x48,
[OFFSET_SOFTRESET] = 0x50,
[OFFSET_SCL_MIS_COMP_POINT] = 0x90,
- [OFFSET_DEBUGSTAT] = 0xe0,
+ [OFFSET_DEBUGSTAT] = 0xe4,
[OFFSET_DEBUGCTRL] = 0xe8,
[OFFSET_FIFO_STAT] = 0xf4,
[OFFSET_FIFO_THRESH] = 0xf8,
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Kewei Xu <kewei.xu@mediatek.com>
To: <wsa@the-dreams.de>
Cc: <matthias.bgg@gmail.com>, <robh+dt@kernel.org>,
<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>,
<qii.wang@mediatek.com>, <yuhan.wei@mediatek.com>,
<kewei.xu@mediatek.com>, <ot_daolong.zhu@mediatek.com>,
<liguo.zhang@mediatek.com>
Subject: [PATCH v4 1/8] i2c: mediatek: fixing the incorrect register offset
Date: Sat, 17 Jul 2021 18:17:52 +0800 [thread overview]
Message-ID: <1626517079-9057-2-git-send-email-kewei.xu@mediatek.com> (raw)
In-Reply-To: <1626517079-9057-1-git-send-email-kewei.xu@mediatek.com>
The reason for the modification here is that the previous
offset information is incorrect, OFFSET_DEBUGSTAT = 0xE4 is
the correct value.
Fixes: 25708278f810 ("i2c: mediatek: Add i2c support for MediaTek MT8183")
Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
---
drivers/i2c/busses/i2c-mt65xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 5ddfa4e56ee2..222ff765e55d 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -193,7 +193,7 @@ static const u16 mt_i2c_regs_v2[] = {
[OFFSET_CLOCK_DIV] = 0x48,
[OFFSET_SOFTRESET] = 0x50,
[OFFSET_SCL_MIS_COMP_POINT] = 0x90,
- [OFFSET_DEBUGSTAT] = 0xe0,
+ [OFFSET_DEBUGSTAT] = 0xe4,
[OFFSET_DEBUGCTRL] = 0xe8,
[OFFSET_FIFO_STAT] = 0xf4,
[OFFSET_FIFO_THRESH] = 0xf8,
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-17 10:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 10:17 [PATCH V4 0/8] Introduce an attribute to choose timing setting Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` Kewei Xu [this message]
2021-07-17 10:17 ` [PATCH v4 1/8] i2c: mediatek: fixing the incorrect register offset Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` [PATCH v4 2/8] dt-bindings: i2c: update bindings for MT8195 SoC Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` [PATCH v4 3/8] i2c: mediatek: Reset the handshake signal between i2c and dma Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-08-11 8:41 ` Chen-Yu Tsai
2021-08-11 8:41 ` Chen-Yu Tsai
2021-08-11 8:41 ` Chen-Yu Tsai
2021-08-21 7:40 ` Kewei Xu
2021-08-21 7:40 ` Kewei Xu
2021-08-21 7:40 ` Kewei Xu
2021-07-17 10:17 ` [PATCH v4 4/8] i2c: mediatek: Dump i2c/dma register when a timeout occurs Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` [PATCH v4 5/8] dt-bindings: i2c: add attribute default-timing-adjust Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-22 3:10 ` Rob Herring
2021-07-22 3:10 ` Rob Herring
2021-07-22 3:10 ` Rob Herring
2021-08-18 6:37 ` Kewei Xu
2021-08-18 6:37 ` Kewei Xu
2021-08-18 6:37 ` Kewei Xu
2021-07-17 10:17 ` [PATCH v4 6/8] i2c: mediatek: Add OFFSET_EXT_CONF setting back Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` [PATCH v4 7/8] i2c: mediatek: Isolate speed setting via dts for special devices Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` [PATCH v4 8/8] i2c: mediatek: modify bus speed calculation formula Kewei Xu
2021-07-17 10:17 ` Kewei Xu
2021-07-17 10:17 ` Kewei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1626517079-9057-2-git-send-email-kewei.xu@mediatek.com \
--to=kewei.xu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=liguo.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ot_daolong.zhu@mediatek.com \
--cc=qii.wang@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
--cc=yuhan.wei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.