All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
	andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com,
	olteanv@gmail.com, vkochan@marvell.com, tchornyi@marvell.com,
	saeedm@nvidia.com, leon@kernel.org, jiri@nvidia.com,
	idosch@nvidia.com, lars.povlsen@microchip.com,
	Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com,
	grygorii.strashko@ti.com, jwi@linux.ibm.com,
	kgraul@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
	borntraeger@de.ibm.com, jianbol@nvidia.com, vladbu@nvidia.com,
	bjarni.jonasson@microchip.com, vigneshr@ti.com,
	tobias@waldekranz.com, linux-kernel@vger.kernel.org,
	linux-rdma@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org, linux-s390@vger.kernel.org,
	linux@armlinux.org.uk, idosch@idosch.org
Subject: Re: [PATCH v2 net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge
Date: Tue, 10 Aug 2021 20:30:05 +0000	[thread overview]
Message-ID: <162862740581.16281.10031076649352815360.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210810115024.1629983-1-vladimir.oltean@nxp.com>

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue, 10 Aug 2021 14:50:24 +0300 you wrote:
> The blamed commit a new field to struct switchdev_notifier_fdb_info, but
> did not make sure that all call paths set it to something valid. For
> example, a switchdev driver may emit a SWITCHDEV_FDB_ADD_TO_BRIDGE
> notifier, and since the 'is_local' flag is not set, it contains junk
> from the stack, so the bridge might interpret those notifications as
> being for local FDB entries when that was not intended.
> 
> [...]

Here is the summary with links:
  - [v2,net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge
    https://git.kernel.org/netdev/net/c/c35b57ceff90

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
	andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com,
	olteanv@gmail.com, vkochan@marvell.com, tchornyi@marvell.com,
	saeedm@nvidia.com, leon@kernel.org, jiri@nvidia.com,
	idosch@nvidia.com, lars.povlsen@microchip.com,
	Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com,
	grygorii.strashko@ti.com, jwi@linux.ibm.com,
	kgraul@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
	borntraeger@de.ibm.com, jianbol@nvidia.com, vladbu@nvidia.com,
	bjarni.jonasson@microchip.com, vigneshr@ti.com,
	tobias@waldekranz.com, linux-kernel@vger.kernel.org,
	linux-rdma@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org, linux-s390@vger.kernel.org,
	linux@armlinux.org.uk, idosch@idosch.org
Subject: Re: [PATCH v2 net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge
Date: Tue, 10 Aug 2021 20:30:05 +0000	[thread overview]
Message-ID: <162862740581.16281.10031076649352815360.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210810115024.1629983-1-vladimir.oltean@nxp.com>

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue, 10 Aug 2021 14:50:24 +0300 you wrote:
> The blamed commit a new field to struct switchdev_notifier_fdb_info, but
> did not make sure that all call paths set it to something valid. For
> example, a switchdev driver may emit a SWITCHDEV_FDB_ADD_TO_BRIDGE
> notifier, and since the 'is_local' flag is not set, it contains junk
> from the stack, so the bridge might interpret those notifications as
> being for local FDB entries when that was not intended.
> 
> [...]

Here is the summary with links:
  - [v2,net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge
    https://git.kernel.org/netdev/net/c/c35b57ceff90

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-08-10 20:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 11:50 [PATCH v2 net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge Vladimir Oltean
2021-08-10 11:50 ` Vladimir Oltean
2021-08-10 12:36 ` Leon Romanovsky
2021-08-10 12:36   ` Leon Romanovsky
2021-08-10 12:41 ` Karsten Graul
2021-08-10 12:41   ` Karsten Graul
2021-08-10 13:08   ` Vladimir Oltean
2021-08-10 13:08     ` Vladimir Oltean
2021-08-10 20:30 ` patchwork-bot+netdevbpf [this message]
2021-08-10 20:30   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162862740581.16281.10031076649352815360.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=Steen.Hegelund@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=bjarni.jonasson@microchip.com \
    --cc=borntraeger@de.ibm.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=gor@linux.ibm.com \
    --cc=grygorii.strashko@ti.com \
    --cc=hca@linux.ibm.com \
    --cc=idosch@idosch.org \
    --cc=idosch@nvidia.com \
    --cc=jianbol@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=jwi@linux.ibm.com \
    --cc=kgraul@linux.ibm.com \
    --cc=kuba@kernel.org \
    --cc=lars.povlsen@microchip.com \
    --cc=leon@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=saeedm@nvidia.com \
    --cc=tchornyi@marvell.com \
    --cc=tobias@waldekranz.com \
    --cc=vigneshr@ti.com \
    --cc=vivien.didelot@gmail.com \
    --cc=vkochan@marvell.com \
    --cc=vladbu@nvidia.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.