* [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the pinctrl-names rule
@ 2021-08-18 9:46 ` haibo.chen
0 siblings, 0 replies; 6+ messages in thread
From: haibo.chen @ 2021-08-18 9:46 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, ulf.hansson
Cc: kernel, festevam, linux-imx, aisheng.dong, devicetree,
linux-arm-kernel, linux-mmc
From: Haibo Chen <haibo.chen@nxp.com>
Change the pinctrl-names rule to cover all cases.
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
.../bindings/mmc/fsl-imx-esdhc.yaml | 21 +++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
index 17086f60f8a3..d324606a4f0a 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -116,12 +116,21 @@ properties:
- const: per
pinctrl-names:
- minItems: 1
- items:
- - const: default
- - const: state_100mhz
- - const: state_200mhz
- - const: sleep
+ oneOf:
+ - items:
+ - const: default
+ - const: state_100mhz
+ - const: state_200mhz
+ - const: sleep
+ - items:
+ - const: default
+ - const: state_100mhz
+ - const: state_200mhz
+ - items:
+ - const: default
+ - const: sleep
+ - items:
+ - const: default
required:
- compatible
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the pinctrl-names rule
@ 2021-08-18 9:46 ` haibo.chen
0 siblings, 0 replies; 6+ messages in thread
From: haibo.chen @ 2021-08-18 9:46 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, ulf.hansson
Cc: kernel, festevam, linux-imx, aisheng.dong, devicetree,
linux-arm-kernel, linux-mmc
From: Haibo Chen <haibo.chen@nxp.com>
Change the pinctrl-names rule to cover all cases.
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
.../bindings/mmc/fsl-imx-esdhc.yaml | 21 +++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
index 17086f60f8a3..d324606a4f0a 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -116,12 +116,21 @@ properties:
- const: per
pinctrl-names:
- minItems: 1
- items:
- - const: default
- - const: state_100mhz
- - const: state_200mhz
- - const: sleep
+ oneOf:
+ - items:
+ - const: default
+ - const: state_100mhz
+ - const: state_200mhz
+ - const: sleep
+ - items:
+ - const: default
+ - const: state_100mhz
+ - const: state_200mhz
+ - items:
+ - const: default
+ - const: sleep
+ - items:
+ - const: default
required:
- compatible
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the pinctrl-names rule
2021-08-18 9:46 ` haibo.chen
@ 2021-08-18 18:33 ` Rob Herring
-1 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-08-18 18:33 UTC (permalink / raw)
To: haibo.chen
Cc: shawnguo, s.hauer, ulf.hansson, kernel, festevam, linux-imx,
aisheng.dong, devicetree, linux-arm-kernel, linux-mmc
On Wed, Aug 18, 2021 at 05:46:24PM +0800, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> Change the pinctrl-names rule to cover all cases.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> .../bindings/mmc/fsl-imx-esdhc.yaml | 21 +++++++++++++------
> 1 file changed, 15 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> index 17086f60f8a3..d324606a4f0a 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> @@ -116,12 +116,21 @@ properties:
> - const: per
>
> pinctrl-names:
> - minItems: 1
> - items:
> - - const: default
> - - const: state_100mhz
> - - const: state_200mhz
> - - const: sleep
> + oneOf:
> + - items:
> + - const: default
> + - const: state_100mhz
> + - const: state_200mhz
> + - const: sleep
> + - items:
> + - const: default
> + - const: state_100mhz
> + - const: state_200mhz
You can drop this one and add 'minItems: 3' to the first case.
> + - items:
> + - const: default
> + - const: sleep
> + - items:
> + - const: default
Similar here too with the prior case. Or use 'minItems: 1' in the first
case. That additional allows the 2 entry case, but why isn't that valid?
Couldn't a board only support default+state_100mhz?
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the pinctrl-names rule
@ 2021-08-18 18:33 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-08-18 18:33 UTC (permalink / raw)
To: haibo.chen
Cc: shawnguo, s.hauer, ulf.hansson, kernel, festevam, linux-imx,
aisheng.dong, devicetree, linux-arm-kernel, linux-mmc
On Wed, Aug 18, 2021 at 05:46:24PM +0800, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> Change the pinctrl-names rule to cover all cases.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> .../bindings/mmc/fsl-imx-esdhc.yaml | 21 +++++++++++++------
> 1 file changed, 15 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> index 17086f60f8a3..d324606a4f0a 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> @@ -116,12 +116,21 @@ properties:
> - const: per
>
> pinctrl-names:
> - minItems: 1
> - items:
> - - const: default
> - - const: state_100mhz
> - - const: state_200mhz
> - - const: sleep
> + oneOf:
> + - items:
> + - const: default
> + - const: state_100mhz
> + - const: state_200mhz
> + - const: sleep
> + - items:
> + - const: default
> + - const: state_100mhz
> + - const: state_200mhz
You can drop this one and add 'minItems: 3' to the first case.
> + - items:
> + - const: default
> + - const: sleep
> + - items:
> + - const: default
Similar here too with the prior case. Or use 'minItems: 1' in the first
case. That additional allows the 2 entry case, but why isn't that valid?
Couldn't a board only support default+state_100mhz?
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the pinctrl-names rule
2021-08-18 18:33 ` Rob Herring
@ 2021-08-19 3:30 ` Bough Chen
-1 siblings, 0 replies; 6+ messages in thread
From: Bough Chen @ 2021-08-19 3:30 UTC (permalink / raw)
To: Rob Herring
Cc: shawnguo, s.hauer, ulf.hansson, kernel, festevam, dl-linux-imx,
Aisheng Dong, devicetree, linux-arm-kernel, linux-mmc
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: 2021年8月19日 2:33
> To: Bough Chen <haibo.chen@nxp.com>
> Cc: shawnguo@kernel.org; s.hauer@pengutronix.de; ulf.hansson@linaro.org;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-mmc@vger.kernel.org
> Subject: Re: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the
> pinctrl-names rule
>
> On Wed, Aug 18, 2021 at 05:46:24PM +0800, haibo.chen@nxp.com wrote:
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > Change the pinctrl-names rule to cover all cases.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> > .../bindings/mmc/fsl-imx-esdhc.yaml | 21 +++++++++++++------
> > 1 file changed, 15 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > index 17086f60f8a3..d324606a4f0a 100644
> > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > @@ -116,12 +116,21 @@ properties:
> > - const: per
> >
> > pinctrl-names:
> > - minItems: 1
> > - items:
> > - - const: default
> > - - const: state_100mhz
> > - - const: state_200mhz
> > - - const: sleep
> > + oneOf:
> > + - items:
> > + - const: default
> > + - const: state_100mhz
> > + - const: state_200mhz
> > + - const: sleep
> > + - items:
> > + - const: default
> > + - const: state_100mhz
> > + - const: state_200mhz
>
> You can drop this one and add 'minItems: 3' to the first case.
Okay, I will do that.
>
> > + - items:
> > + - const: default
> > + - const: sleep
> > + - items:
> > + - const: default
>
> Similar here too with the prior case. Or use 'minItems: 1' in the first case. That
> additional allows the 2 entry case, but why isn't that valid?
> Couldn't a board only support default+state_100mhz?
Logically not, for board, if support SD3.0 mode, this means it support both SDR104/SDR50/DDR50/HS200/HS400
State_100mhz is used for SDR50 and DDR50, state_200mhz is used for SDR104/HS200/HS400.
So, if there is state_100mhz, there should be state_200mhz.
Rest Regards
Haibo Chen
>
> Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the pinctrl-names rule
@ 2021-08-19 3:30 ` Bough Chen
0 siblings, 0 replies; 6+ messages in thread
From: Bough Chen @ 2021-08-19 3:30 UTC (permalink / raw)
To: Rob Herring
Cc: shawnguo, s.hauer, ulf.hansson, kernel, festevam, dl-linux-imx,
Aisheng Dong, devicetree, linux-arm-kernel, linux-mmc
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: 2021年8月19日 2:33
> To: Bough Chen <haibo.chen@nxp.com>
> Cc: shawnguo@kernel.org; s.hauer@pengutronix.de; ulf.hansson@linaro.org;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-mmc@vger.kernel.org
> Subject: Re: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the
> pinctrl-names rule
>
> On Wed, Aug 18, 2021 at 05:46:24PM +0800, haibo.chen@nxp.com wrote:
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > Change the pinctrl-names rule to cover all cases.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> > .../bindings/mmc/fsl-imx-esdhc.yaml | 21 +++++++++++++------
> > 1 file changed, 15 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > index 17086f60f8a3..d324606a4f0a 100644
> > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > @@ -116,12 +116,21 @@ properties:
> > - const: per
> >
> > pinctrl-names:
> > - minItems: 1
> > - items:
> > - - const: default
> > - - const: state_100mhz
> > - - const: state_200mhz
> > - - const: sleep
> > + oneOf:
> > + - items:
> > + - const: default
> > + - const: state_100mhz
> > + - const: state_200mhz
> > + - const: sleep
> > + - items:
> > + - const: default
> > + - const: state_100mhz
> > + - const: state_200mhz
>
> You can drop this one and add 'minItems: 3' to the first case.
Okay, I will do that.
>
> > + - items:
> > + - const: default
> > + - const: sleep
> > + - items:
> > + - const: default
>
> Similar here too with the prior case. Or use 'minItems: 1' in the first case. That
> additional allows the 2 entry case, but why isn't that valid?
> Couldn't a board only support default+state_100mhz?
Logically not, for board, if support SD3.0 mode, this means it support both SDR104/SDR50/DDR50/HS200/HS400
State_100mhz is used for SDR50 and DDR50, state_200mhz is used for SDR104/HS200/HS400.
So, if there is state_100mhz, there should be state_200mhz.
Rest Regards
Haibo Chen
>
> Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-19 3:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18 9:46 [PATCH] dt-bindings: mmc: fsl-imx-esdhc: change the pinctrl-names rule haibo.chen
2021-08-18 9:46 ` haibo.chen
2021-08-18 18:33 ` Rob Herring
2021-08-18 18:33 ` Rob Herring
2021-08-19 3:30 ` Bough Chen
2021-08-19 3:30 ` Bough Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.