* [PATCH] ovs: clear skb->tstamp in forwarding path
@ 2021-08-18 2:22 fankaixi.li
2021-08-18 9:32 ` Eric Dumazet
2021-08-18 10:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: fankaixi.li @ 2021-08-18 2:22 UTC (permalink / raw)
To: dev, netdev; +Cc: kaixi . fan, xiexiaohui, Cong Wang
From: kaixi.fan <fankaixi.li@bytedance.com>
fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs
doesn't clear skb->tstamp. We encountered a problem with linux
version 5.4.56 and ovs version 2.14.1, and packets failed to
dequeue from qdisc when fq qdisc was attached to ovs port.
Signed-off-by: kaixi.fan <fankaixi.li@bytedance.com>
Signed-off-by: xiexiaohui <xiexiaohui.xxh@bytedance.com>
Reviewed-by: Cong Wang <cong.wang@bytedance.com>
---
net/openvswitch/vport.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index 88deb5b41429..cf2ce5812489 100644
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c
@@ -507,6 +507,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto)
}
skb->dev = vport->dev;
+ skb->tstamp = 0;
vport->ops->send(skb);
return;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ovs: clear skb->tstamp in forwarding path
2021-08-18 2:22 [PATCH] ovs: clear skb->tstamp in forwarding path fankaixi.li
@ 2021-08-18 9:32 ` Eric Dumazet
2021-08-19 2:06 ` [External] " 范开喜
2021-08-18 10:40 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2021-08-18 9:32 UTC (permalink / raw)
To: fankaixi.li, dev, netdev; +Cc: xiexiaohui, Cong Wang
On 8/18/21 4:22 AM, fankaixi.li@bytedance.com wrote:
> From: kaixi.fan <fankaixi.li@bytedance.com>
>
> fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs
> doesn't clear skb->tstamp. We encountered a problem with linux
> version 5.4.56 and ovs version 2.14.1, and packets failed to
> dequeue from qdisc when fq qdisc was attached to ovs port.
>
Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
This is more precise than " version 5.4.56 and ovs version ..."
Thanks.
> Signed-off-by: kaixi.fan <fankaixi.li@bytedance.com>
> Signed-off-by: xiexiaohui <xiexiaohui.xxh@bytedance.com>
> Reviewed-by: Cong Wang <cong.wang@bytedance.com>
> ---
> net/openvswitch/vport.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
> index 88deb5b41429..cf2ce5812489 100644
> --- a/net/openvswitch/vport.c
> +++ b/net/openvswitch/vport.c
> @@ -507,6 +507,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto)
> }
>
> skb->dev = vport->dev;
> + skb->tstamp = 0;
> vport->ops->send(skb);
> return;
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ovs: clear skb->tstamp in forwarding path
2021-08-18 2:22 [PATCH] ovs: clear skb->tstamp in forwarding path fankaixi.li
2021-08-18 9:32 ` Eric Dumazet
@ 2021-08-18 10:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-18 10:40 UTC (permalink / raw)
To: =?utf-8?b?6IyD5byA5ZacIDxmYW5rYWl4aS5saUBieXRlZGFuY2UuY29tPg==?=
Cc: dev, netdev, xiexiaohui.xxh, cong.wang
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 18 Aug 2021 10:22:15 +0800 you wrote:
> From: kaixi.fan <fankaixi.li@bytedance.com>
>
> fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs
> doesn't clear skb->tstamp. We encountered a problem with linux
> version 5.4.56 and ovs version 2.14.1, and packets failed to
> dequeue from qdisc when fq qdisc was attached to ovs port.
>
> [...]
Here is the summary with links:
- ovs: clear skb->tstamp in forwarding path
https://git.kernel.org/netdev/net/c/01634047bf0d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [External] Re: [PATCH] ovs: clear skb->tstamp in forwarding path
2021-08-18 9:32 ` Eric Dumazet
@ 2021-08-19 2:06 ` 范开喜
0 siblings, 0 replies; 4+ messages in thread
From: 范开喜 @ 2021-08-19 2:06 UTC (permalink / raw)
To: Eric Dumazet; +Cc: dev, netdev, xiexiaohui, Cong Wang
Eric Dumazet <eric.dumazet@gmail.com> 于2021年8月18日周三 下午5:32写道:
>
>
>
> On 8/18/21 4:22 AM, fankaixi.li@bytedance.com wrote:
> > From: kaixi.fan <fankaixi.li@bytedance.com>
> >
> > fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs
> > doesn't clear skb->tstamp. We encountered a problem with linux
> > version 5.4.56 and ovs version 2.14.1, and packets failed to
> > dequeue from qdisc when fq qdisc was attached to ovs port.
> >
>
> Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
>
> This is more precise than " version 5.4.56 and ovs version ..."
>
> Thanks.
>
> > Signed-off-by: kaixi.fan <fankaixi.li@bytedance.com>
> > Signed-off-by: xiexiaohui <xiexiaohui.xxh@bytedance.com>
> > Reviewed-by: Cong Wang <cong.wang@bytedance.com>
> > ---
> > net/openvswitch/vport.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
> > index 88deb5b41429..cf2ce5812489 100644
> > --- a/net/openvswitch/vport.c
> > +++ b/net/openvswitch/vport.c
> > @@ -507,6 +507,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto)
> > }
> >
> > skb->dev = vport->dev;
> > + skb->tstamp = 0;
> > vport->ops->send(skb);
> > return;
> >
> >
Hi Eric Dumazet,
Yes and many thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-19 2:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18 2:22 [PATCH] ovs: clear skb->tstamp in forwarding path fankaixi.li
2021-08-18 9:32 ` Eric Dumazet
2021-08-19 2:06 ` [External] " 范开喜
2021-08-18 10:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.