From: Stephen Boyd <sboyd@kernel.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
Pavel Dubrova <pashadubrova@gmail.com>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Jonathan Marek <jonathan@marek.ca>,
Matthias Kaehlcke <mka@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent
Date: Tue, 31 Aug 2021 22:35:12 -0700 [thread overview]
Message-ID: <163047451225.42057.10341429266269552927@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <YS1lYui5aXadgkEr@Marijn-Arch-PC.localdomain>
Quoting Marijn Suijten (2021-08-30 16:10:26)
>
> I'm 95% sure this shouldn't cause any problems given current DTs and
> their history, but that's probably not enough. This might also impact
> DTs that have not yet been upstreamed, but afaik the general stance is
> to not care and actually serve as a fair hint/warning before new DTs
> make it to the list.
>
> If there is a protocol in place to deprecate, warn, and eventually
> remove this reliance on global clock names I'm more than happy to add
> .name as a temporary fallback, even if likely unneeded. Otherwise we
> might never get rid of it.
I'm not aware of any protocol to deprecate, warn, and remove the
fallback name. It's a fallback because it can't ever really be removed.
Anyway, if you're not willing to add the .name then that's fine. We can
deal with the problem easily by adding a .name in the future if someone
complains that things aren't working. Sound like a plan? If so, it's
probably good to add some sort of note in the commit text so that when
the bisector lands on this patch they can realize that this
intentionally broke them.
next prev parent reply other threads:[~2021-09-01 5:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 18:24 [PATCH v2 0/2] Use "ref" clocks from firmware for DSI PLL VCO parent Marijn Suijten
2021-08-30 18:24 ` Marijn Suijten
2021-08-30 18:24 ` [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for " Marijn Suijten
2021-08-30 18:24 ` Marijn Suijten
2021-08-30 22:16 ` Stephen Boyd
2021-08-30 22:16 ` Stephen Boyd
2021-08-30 22:45 ` Marijn Suijten
2021-08-30 22:45 ` Marijn Suijten
2021-08-30 22:53 ` Stephen Boyd
2021-08-30 22:53 ` Stephen Boyd
2021-08-30 23:10 ` Marijn Suijten
2021-08-30 23:10 ` Marijn Suijten
2021-09-01 5:35 ` Stephen Boyd [this message]
2021-09-01 5:35 ` Stephen Boyd
2021-09-01 8:49 ` Marijn Suijten
2021-09-01 8:49 ` Marijn Suijten
2021-09-02 3:46 ` Stephen Boyd
2021-09-02 3:46 ` Stephen Boyd
2021-09-02 7:27 ` AngeloGioacchino Del Regno
2021-09-02 7:27 ` AngeloGioacchino Del Regno
2021-08-30 18:24 ` [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock Marijn Suijten
2021-08-30 18:24 ` Marijn Suijten
2021-09-01 5:35 ` Stephen Boyd
2021-09-01 5:35 ` Stephen Boyd
2021-09-01 8:57 ` Marijn Suijten
2021-09-01 8:57 ` Marijn Suijten
2021-09-02 3:46 ` Stephen Boyd
2021-09-02 3:46 ` Stephen Boyd
2021-09-02 13:05 ` Marijn Suijten
2021-09-02 13:05 ` Marijn Suijten
2021-09-02 19:34 ` Stephen Boyd
2021-09-02 19:34 ` Stephen Boyd
2021-09-02 7:28 ` AngeloGioacchino Del Regno
2021-09-02 7:28 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163047451225.42057.10341429266269552927@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=abhinavk@codeaurora.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=pashadubrova@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.