From: Abel Vesa <abel.vesa@nxp.com> To: Rob Herring <robh@kernel.org>, Dong Aisheng <aisheng.dong@nxp.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, MyungJoo Ham <myungjoo.ham@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Georgi Djakov <djakov@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, Ahmad Fatoum <a.fatoum@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>, linux-serial@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Abel Vesa <abel.vesa@nxp.com> Subject: [RFC 03/19] devfreq: imx-bus: Decouple imx-bus from icc made Date: Mon, 13 Sep 2021 20:37:58 +0300 [thread overview] Message-ID: <1631554694-9599-4-git-send-email-abel.vesa@nxp.com> (raw) In-Reply-To: <1631554694-9599-1-git-send-email-abel.vesa@nxp.com> The link between an imx-bus device and its icc id will be done through the fsl,icc-id property in each dts node. The imx interconnect driver will pick up all the dts nodes that have that property defined and will link them to the rightfull icc id. Signed-off-by: Abel Vesa <abel.vesa@nxp.com> --- drivers/devfreq/imx-bus.c | 40 +++------------------------------------ 1 file changed, 3 insertions(+), 37 deletions(-) diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c index 9d8dc9824d21..95339de8cccf 100644 --- a/drivers/devfreq/imx-bus.c +++ b/drivers/devfreq/imx-bus.c @@ -53,36 +53,6 @@ static void imx_bus_exit(struct device *dev) platform_device_unregister(priv->icc_pdev); } -/* imx_bus_init_icc() - register matching icc provider if required */ -static int imx_bus_init_icc(struct device *dev) -{ - struct imx_bus *priv = dev_get_drvdata(dev); - const char *icc_driver_name; - - if (!of_get_property(dev->of_node, "#interconnect-cells", 0)) - return 0; - if (!IS_ENABLED(CONFIG_INTERCONNECT_IMX)) { - dev_warn(dev, "imx interconnect drivers disabled\n"); - return 0; - } - - icc_driver_name = of_device_get_match_data(dev); - if (!icc_driver_name) { - dev_err(dev, "unknown interconnect driver\n"); - return 0; - } - - priv->icc_pdev = platform_device_register_data( - dev, icc_driver_name, -1, NULL, 0); - if (IS_ERR(priv->icc_pdev)) { - dev_err(dev, "failed to register icc provider %s: %ld\n", - icc_driver_name, PTR_ERR(priv->icc_pdev)); - return PTR_ERR(priv->icc_pdev); - } - - return 0; -} - static int imx_bus_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -130,10 +100,6 @@ static int imx_bus_probe(struct platform_device *pdev) goto err; } - ret = imx_bus_init_icc(dev); - if (ret) - goto err; - return 0; err: @@ -142,9 +108,9 @@ static int imx_bus_probe(struct platform_device *pdev) } static const struct of_device_id imx_bus_of_match[] = { - { .compatible = "fsl,imx8mq-noc", .data = "imx8mq-interconnect", }, - { .compatible = "fsl,imx8mm-noc", .data = "imx8mm-interconnect", }, - { .compatible = "fsl,imx8mn-noc", .data = "imx8mn-interconnect", }, + { .compatible = "fsl,imx8mq-noc",}, + { .compatible = "fsl,imx8mm-noc",}, + { .compatible = "fsl,imx8mn-noc",}, { .compatible = "fsl,imx8m-noc", }, { .compatible = "fsl,imx8m-nic", }, { /* sentinel */ }, -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@nxp.com> To: Rob Herring <robh@kernel.org>, Dong Aisheng <aisheng.dong@nxp.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, MyungJoo Ham <myungjoo.ham@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Georgi Djakov <djakov@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, Ahmad Fatoum <a.fatoum@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>, linux-serial@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Abel Vesa <abel.vesa@nxp.com> Subject: [RFC 03/19] devfreq: imx-bus: Decouple imx-bus from icc made Date: Mon, 13 Sep 2021 20:37:58 +0300 [thread overview] Message-ID: <1631554694-9599-4-git-send-email-abel.vesa@nxp.com> (raw) In-Reply-To: <1631554694-9599-1-git-send-email-abel.vesa@nxp.com> The link between an imx-bus device and its icc id will be done through the fsl,icc-id property in each dts node. The imx interconnect driver will pick up all the dts nodes that have that property defined and will link them to the rightfull icc id. Signed-off-by: Abel Vesa <abel.vesa@nxp.com> --- drivers/devfreq/imx-bus.c | 40 +++------------------------------------ 1 file changed, 3 insertions(+), 37 deletions(-) diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c index 9d8dc9824d21..95339de8cccf 100644 --- a/drivers/devfreq/imx-bus.c +++ b/drivers/devfreq/imx-bus.c @@ -53,36 +53,6 @@ static void imx_bus_exit(struct device *dev) platform_device_unregister(priv->icc_pdev); } -/* imx_bus_init_icc() - register matching icc provider if required */ -static int imx_bus_init_icc(struct device *dev) -{ - struct imx_bus *priv = dev_get_drvdata(dev); - const char *icc_driver_name; - - if (!of_get_property(dev->of_node, "#interconnect-cells", 0)) - return 0; - if (!IS_ENABLED(CONFIG_INTERCONNECT_IMX)) { - dev_warn(dev, "imx interconnect drivers disabled\n"); - return 0; - } - - icc_driver_name = of_device_get_match_data(dev); - if (!icc_driver_name) { - dev_err(dev, "unknown interconnect driver\n"); - return 0; - } - - priv->icc_pdev = platform_device_register_data( - dev, icc_driver_name, -1, NULL, 0); - if (IS_ERR(priv->icc_pdev)) { - dev_err(dev, "failed to register icc provider %s: %ld\n", - icc_driver_name, PTR_ERR(priv->icc_pdev)); - return PTR_ERR(priv->icc_pdev); - } - - return 0; -} - static int imx_bus_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -130,10 +100,6 @@ static int imx_bus_probe(struct platform_device *pdev) goto err; } - ret = imx_bus_init_icc(dev); - if (ret) - goto err; - return 0; err: @@ -142,9 +108,9 @@ static int imx_bus_probe(struct platform_device *pdev) } static const struct of_device_id imx_bus_of_match[] = { - { .compatible = "fsl,imx8mq-noc", .data = "imx8mq-interconnect", }, - { .compatible = "fsl,imx8mm-noc", .data = "imx8mm-interconnect", }, - { .compatible = "fsl,imx8mn-noc", .data = "imx8mn-interconnect", }, + { .compatible = "fsl,imx8mq-noc",}, + { .compatible = "fsl,imx8mm-noc",}, + { .compatible = "fsl,imx8mn-noc",}, { .compatible = "fsl,imx8m-noc", }, { .compatible = "fsl,imx8m-nic", }, { /* sentinel */ }, -- 2.31.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-13 17:38 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-13 17:37 [RFC 00/19] Add interconnect and devfreq support for i.MX8MQ Abel Vesa 2021-09-13 17:37 ` Abel Vesa 2021-09-13 17:37 ` [RFC 01/19] dt-bindings: interconnect: imx8mq: Add missing pl301 and SAI ids Abel Vesa 2021-09-13 17:37 ` Abel Vesa 2021-09-15 8:09 ` Georgi Djakov 2021-09-15 8:09 ` Georgi Djakov 2021-09-13 17:37 ` [RFC 02/19] devfreq: imx-bus: Switch governor to powersave Abel Vesa 2021-09-13 17:37 ` Abel Vesa 2021-09-13 17:37 ` Abel Vesa [this message] 2021-09-13 17:37 ` [RFC 03/19] devfreq: imx-bus: Decouple imx-bus from icc made Abel Vesa 2021-09-13 17:37 ` [RFC 04/19] devfreq: imx8m-ddrc: Change governor to powersave Abel Vesa 2021-09-13 17:37 ` Abel Vesa 2021-09-13 17:38 ` [RFC 05/19] devfreq: imx8m-ddrc: Use the opps acquired from EL3 Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-15 3:29 ` Chanwoo Choi 2021-09-15 3:29 ` Chanwoo Choi 2021-09-15 18:12 ` Chanwoo Choi 2021-09-15 18:12 ` Chanwoo Choi 2021-09-13 17:38 ` [RFC 06/19] devfreq: imx8m-ddrc: Add late system sleep PM ops Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-15 3:37 ` Chanwoo Choi 2021-09-15 3:37 ` Chanwoo Choi 2021-10-25 20:59 ` Abel Vesa 2021-10-25 20:59 ` Abel Vesa 2021-11-10 12:15 ` Martin Kepplinger 2021-11-10 12:15 ` Martin Kepplinger 2021-11-30 20:06 ` Abel Vesa 2021-11-30 20:06 ` Abel Vesa 2021-12-01 9:35 ` Martin Kepplinger 2021-12-01 9:35 ` Martin Kepplinger 2021-12-06 12:33 ` Martin Kepplinger 2021-12-06 12:33 ` Martin Kepplinger 2021-09-13 17:38 ` [RFC 07/19] interconnect: imx: Switch from imx_icc_node_adj_desc to fsl,icc-id node assignment Abel Vesa 2021-09-13 17:38 ` [RFC 07/19] interconnect: imx: Switch from imx_icc_node_adj_desc to fsl, icc-id " Abel Vesa 2021-09-13 17:38 ` [RFC 08/19] interconnect: imx8: Remove the imx_icc_node_adj_desc Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-10-18 12:41 ` Adam Ford 2021-10-18 12:41 ` Adam Ford 2021-10-25 9:00 ` Abel Vesa 2021-10-25 9:00 ` Abel Vesa 2021-09-13 17:38 ` [RFC 09/19] interconnect: imx8mq: Add the pl301_per_m and pl301_wakeup nodes and subnodes Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-13 17:38 ` [RFC 10/19] interconnect: imx8mq: Add of_match_table Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-13 17:38 ` [RFC 11/19] interconnect: imx: Add imx_icc_get_bw and imx_icc_aggregate functions Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-13 17:38 ` [RFC 12/19] arm64: dts: imx8mq: Add fsl,icc-id property to ddrc node Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-13 17:38 ` [RFC 13/19] arm64: dts: imx8mq: Add fsl,icc-id to noc node Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-13 17:38 ` [RFC 14/19] arm64: dts: imx8mq: Add all pl301 nodes Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-13 17:38 ` [RFC 15/19] arm64: dts: imx8mq: Add the interconnect node Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-13 17:38 ` [RFC 16/19] arm64: dts: imx8mq: Add interconnect properties to icc consumer nodes Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-13 17:38 ` [RFC 17/19] net: ethernet: fec_main: Add interconnect support Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-13 17:38 ` [RFC 18/19] mmc: sdhci-esdhc-imx: " Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-13 17:38 ` [RFC 19/19] arm64: defconfig: Add necessary configs for icc+devfreq on i.MX8MQ Abel Vesa 2021-09-13 17:38 ` Abel Vesa 2021-09-24 10:20 ` [RFC 00/19] Add interconnect and devfreq support for i.MX8MQ Martin Kepplinger 2021-09-24 10:20 ` Martin Kepplinger 2021-09-29 11:44 ` Abel Vesa 2021-09-29 11:44 ` Abel Vesa 2021-09-30 8:03 ` Martin Kepplinger 2021-09-30 8:03 ` Martin Kepplinger 2021-09-30 14:22 ` Abel Vesa 2021-09-30 14:22 ` Abel Vesa 2021-10-05 13:34 ` Martin Kepplinger 2021-10-05 13:34 ` Martin Kepplinger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1631554694-9599-4-git-send-email-abel.vesa@nxp.com \ --to=abel.vesa@nxp.com \ --cc=a.fatoum@pengutronix.de \ --cc=adrian.hunter@intel.com \ --cc=aisheng.dong@nxp.com \ --cc=catalin.marinas@arm.com \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=djakov@kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=myungjoo.ham@samsung.com \ --cc=robh@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=ulf.hansson@linaro.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.