From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> To: Chander Kashyap <chander.kashyap@linaro.org> Cc: Mark Rutland <Mark.Rutland@arm.com>, Catalin Marinas <Catalin.Marinas@arm.com>, Tomasz Figa <t.figa@samsung.com>, Kukjin Kim <kgene.kim@samsung.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Vincent Guittot <vincent.guittot@linaro.org>, Nicolas Pitre <nico@linaro.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "grant.likely@linaro.org" <grant.likely@linaro.org>, Charles Garcia-Tobin <Charles.Garcia-Tobin@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Kevin Hilman <khilman@linaro.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, Sebastian Capella <sebcape@gmail.com>, Rob Herring <robh+dt@kernel.org>, Antti Miettinen <ananaza@iki.fi>, Paul Walmsley <paul@pwsan.com>, Peter De Schrijver <pdeschrijver@nvidia.com>, Stephen Boyd <sboyd@codeaurora.org>, Amit Subject: Re: [PATCH v5 7/8] drivers: cpuidle: initialize Exynos driver through DT Date: Fri, 18 Jul 2014 18:10:39 +0200 [thread overview] Message-ID: <1633432.ZfU5VfHtET@amdc1032> (raw) In-Reply-To: <CANuQgHEPocfO8wDPDTJUkBNGEfw6FoLEYAJK-zPPA7kd_L-34Q@mail.gmail.com> Hi, On Friday, July 18, 2014 02:15:01 PM Chander Kashyap wrote: > Hi Lorenzo, > > > On 17 July 2014 19:50, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > > On Wed, Jun 25, 2014 at 04:23:38PM +0100, Bartlomiej Zolnierkiewicz wrote: > >> > >> Hi, > >> > >> On Wednesday, June 25, 2014 03:10:20 PM Lorenzo Pieralisi wrote: > >> > With the introduction of DT based idle states, CPUidle drivers for > >> > ARM can now initialize idle states data through properties in the device > >> > tree. > >> > > >> > This patch adds code to the Exynos CPUidle driver to dynamically > >> > initialize idle states data through the updated device tree source > >> > files. > >> > > >> > Cc: Kukjin Kim <kgene.kim@samsung.com> > >> > Cc: Tomasz Figa <t.figa@samsung.com> > >> > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > >> > --- > >> > Compile tested, I am not sure I patched the right dts files, please check. > >> > >> cpuidle-exynos driver is currently working properly in deeper cpuidle > >> mode (AFTR) on Exynos4210 and Exynos5250 (please also see the following > >> patch from Tomasz Figa: [1]). There is ongoing work to AFTR mode work > >> also on Exynos4x12 and Exynos3250 but it is not complete yet. Exynos5410 > >> OTOH should probably use the generic big little cpuidle driver (this SoC > >> is similar to Exynos5420 one for which Chander Kashyap has developed > >> cpuidle-big_little support [2]). > >> > >> Making long story short, I think that your patch should depend on patch > >> [1] and update only exynos4210.dtsi and exynos5250.dtsi. Also for your > >> patch #6 there needs to be some coordination with merging of Chander's > >> patchset ([2]). > >> > >> [1] http://www.spinics.net/lists/arm-kernel/msg341023.html > >> [2] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg664470.html > > > > > > exynos4210.dtsi does not even have cpu nodes in it. Should I add them or > > this might trigger regression (ie cpu_logical_map()) ? > > Yes that can cause regression. Yes, two patches from Tomasz Figa are needed to fix it: - [PATCH 2/6] ARM: EXYNOS: Fix core ID used by platsmp and hotplug code http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32811.html - [PATCH] irqchip: gic: Fix core ID calculation when topology is read from DT http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg34277.html > > I will post a new version soon, should I just patch 5250 for now ? I posted patch adding CPU nodes for Exynos4 SoCs to DT: - [PATCH] ARM: dts: add CPU nodes for Exynos4 SoCs http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg34378.html Please make your series depend on it and add Exynos4210 support. > > I would need help to test this patch thanks. > > I can test the patch for 5250. I can do testing on Exynos4210 if needed. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > > > > Lorenzo > > > >> > .../devicetree/bindings/arm/exynos/idle-states.txt | 27 ++++++++++++++++++++ > >> > arch/arm/boot/dts/exynos3250.dtsi | 16 ++++++++++++ > >> > arch/arm/boot/dts/exynos5250.dtsi | 15 +++++++++++ > >> > arch/arm/boot/dts/exynos5410.dtsi | 17 +++++++++++++ > >> > drivers/cpuidle/Kconfig.arm | 1 + > >> > drivers/cpuidle/cpuidle-exynos.c | 29 +++++++++++++--------- > >> > 6 files changed, 93 insertions(+), 12 deletions(-) > >> > create mode 100644 Documentation/devicetree/bindings/arm/exynos/idle-states.txt
WARNING: multiple messages have this Message-ID (diff)
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 7/8] drivers: cpuidle: initialize Exynos driver through DT Date: Fri, 18 Jul 2014 18:10:39 +0200 [thread overview] Message-ID: <1633432.ZfU5VfHtET@amdc1032> (raw) In-Reply-To: <CANuQgHEPocfO8wDPDTJUkBNGEfw6FoLEYAJK-zPPA7kd_L-34Q@mail.gmail.com> Hi, On Friday, July 18, 2014 02:15:01 PM Chander Kashyap wrote: > Hi Lorenzo, > > > On 17 July 2014 19:50, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > > On Wed, Jun 25, 2014 at 04:23:38PM +0100, Bartlomiej Zolnierkiewicz wrote: > >> > >> Hi, > >> > >> On Wednesday, June 25, 2014 03:10:20 PM Lorenzo Pieralisi wrote: > >> > With the introduction of DT based idle states, CPUidle drivers for > >> > ARM can now initialize idle states data through properties in the device > >> > tree. > >> > > >> > This patch adds code to the Exynos CPUidle driver to dynamically > >> > initialize idle states data through the updated device tree source > >> > files. > >> > > >> > Cc: Kukjin Kim <kgene.kim@samsung.com> > >> > Cc: Tomasz Figa <t.figa@samsung.com> > >> > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > >> > --- > >> > Compile tested, I am not sure I patched the right dts files, please check. > >> > >> cpuidle-exynos driver is currently working properly in deeper cpuidle > >> mode (AFTR) on Exynos4210 and Exynos5250 (please also see the following > >> patch from Tomasz Figa: [1]). There is ongoing work to AFTR mode work > >> also on Exynos4x12 and Exynos3250 but it is not complete yet. Exynos5410 > >> OTOH should probably use the generic big little cpuidle driver (this SoC > >> is similar to Exynos5420 one for which Chander Kashyap has developed > >> cpuidle-big_little support [2]). > >> > >> Making long story short, I think that your patch should depend on patch > >> [1] and update only exynos4210.dtsi and exynos5250.dtsi. Also for your > >> patch #6 there needs to be some coordination with merging of Chander's > >> patchset ([2]). > >> > >> [1] http://www.spinics.net/lists/arm-kernel/msg341023.html > >> [2] https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg664470.html > > > > > > exynos4210.dtsi does not even have cpu nodes in it. Should I add them or > > this might trigger regression (ie cpu_logical_map()) ? > > Yes that can cause regression. Yes, two patches from Tomasz Figa are needed to fix it: - [PATCH 2/6] ARM: EXYNOS: Fix core ID used by platsmp and hotplug code http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg32811.html - [PATCH] irqchip: gic: Fix core ID calculation when topology is read from DT http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34277.html > > I will post a new version soon, should I just patch 5250 for now ? I posted patch adding CPU nodes for Exynos4 SoCs to DT: - [PATCH] ARM: dts: add CPU nodes for Exynos4 SoCs http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg34378.html Please make your series depend on it and add Exynos4210 support. > > I would need help to test this patch thanks. > > I can test the patch for 5250. I can do testing on Exynos4210 if needed. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > > > > Lorenzo > > > >> > .../devicetree/bindings/arm/exynos/idle-states.txt | 27 ++++++++++++++++++++ > >> > arch/arm/boot/dts/exynos3250.dtsi | 16 ++++++++++++ > >> > arch/arm/boot/dts/exynos5250.dtsi | 15 +++++++++++ > >> > arch/arm/boot/dts/exynos5410.dtsi | 17 +++++++++++++ > >> > drivers/cpuidle/Kconfig.arm | 1 + > >> > drivers/cpuidle/cpuidle-exynos.c | 29 +++++++++++++--------- > >> > 6 files changed, 93 insertions(+), 12 deletions(-) > >> > create mode 100644 Documentation/devicetree/bindings/arm/exynos/idle-states.txt
next prev parent reply other threads:[~2014-07-18 16:10 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-25 14:10 [PATCH v5 0/8] ARM generic idle states Lorenzo Pieralisi 2014-06-25 14:10 ` Lorenzo Pieralisi 2014-06-25 14:10 ` [PATCH v5 1/8] Documentation: arm: define DT idle states bindings Lorenzo Pieralisi 2014-06-25 14:10 ` Lorenzo Pieralisi 2014-06-25 14:58 ` Mark Rutland 2014-06-25 14:58 ` Mark Rutland 2014-06-25 17:37 ` Lorenzo Pieralisi 2014-06-25 17:37 ` Lorenzo Pieralisi 2014-06-26 18:32 ` Rob Herring 2014-06-26 18:32 ` Rob Herring 2014-06-27 10:53 ` Lorenzo Pieralisi 2014-06-27 10:53 ` Lorenzo Pieralisi 2014-06-25 15:56 ` Nicolas Pitre 2014-06-25 15:56 ` Nicolas Pitre 2014-06-26 10:17 ` Lorenzo Pieralisi 2014-06-26 10:17 ` Lorenzo Pieralisi 2014-06-26 19:30 ` Nicolas Pitre 2014-06-26 19:30 ` Nicolas Pitre 2014-06-25 14:10 ` [PATCH v5 2/8] Documentation: devicetree: psci: define CPU suspend parameter Lorenzo Pieralisi 2014-06-25 14:10 ` Lorenzo Pieralisi 2014-06-25 14:10 ` [PATCH v5 3/8] drivers: cpuidle: implement DT based idle states infrastructure Lorenzo Pieralisi 2014-06-25 14:10 ` Lorenzo Pieralisi 2014-06-25 15:59 ` Mark Rutland 2014-06-25 15:59 ` Mark Rutland 2014-06-26 16:01 ` Lorenzo Pieralisi 2014-06-26 16:01 ` Lorenzo Pieralisi [not found] ` <1403705421-17597-1-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org> 2014-06-25 14:10 ` [PATCH v5 4/8] arm64: add PSCI CPU_SUSPEND based cpu_suspend support Lorenzo Pieralisi 2014-06-25 14:10 ` Lorenzo Pieralisi 2014-06-25 16:09 ` Mark Rutland 2014-06-25 16:09 ` Mark Rutland 2014-06-26 11:23 ` Lorenzo Pieralisi 2014-06-26 11:23 ` Lorenzo Pieralisi 2014-06-25 20:52 ` Geoff Levand 2014-06-25 20:52 ` Geoff Levand 2014-06-26 16:55 ` Lorenzo Pieralisi 2014-06-26 16:55 ` Lorenzo Pieralisi 2014-06-25 14:10 ` [PATCH v5 5/8] drivers: cpuidle: CPU idle ARM64 driver Lorenzo Pieralisi 2014-06-25 14:10 ` Lorenzo Pieralisi 2014-06-25 20:34 ` Geoff Levand 2014-06-25 20:34 ` Geoff Levand 2014-06-25 14:10 ` [PATCH v5 6/8] drivers: cpuidle: initialize big.LITTLE driver through DT Lorenzo Pieralisi 2014-06-25 14:10 ` Lorenzo Pieralisi 2014-06-25 15:06 ` Mark Rutland 2014-06-25 15:06 ` Mark Rutland 2014-06-25 16:44 ` Lorenzo Pieralisi 2014-06-25 16:44 ` Lorenzo Pieralisi 2014-06-25 14:10 ` [PATCH v5 7/8] drivers: cpuidle: initialize Exynos " Lorenzo Pieralisi 2014-06-25 14:10 ` Lorenzo Pieralisi 2014-06-25 15:13 ` Mark Rutland 2014-06-25 15:13 ` Mark Rutland 2014-06-25 16:58 ` Lorenzo Pieralisi 2014-06-25 16:58 ` Lorenzo Pieralisi 2014-06-25 15:23 ` Bartlomiej Zolnierkiewicz 2014-06-25 15:23 ` Bartlomiej Zolnierkiewicz 2014-06-26 15:16 ` Lorenzo Pieralisi 2014-06-26 15:16 ` Lorenzo Pieralisi 2014-07-17 14:20 ` Lorenzo Pieralisi 2014-07-17 14:20 ` Lorenzo Pieralisi 2014-07-18 8:45 ` Chander Kashyap 2014-07-18 8:45 ` Chander Kashyap 2014-07-18 16:10 ` Bartlomiej Zolnierkiewicz [this message] 2014-07-18 16:10 ` Bartlomiej Zolnierkiewicz 2014-06-25 14:10 ` [PATCH v5 8/8] arm64: boot: dts: update rtsm aemv8 dts with PSCI and idle states Lorenzo Pieralisi 2014-06-25 14:10 ` Lorenzo Pieralisi 2014-06-25 14:27 ` Mark Rutland 2014-06-25 14:27 ` Mark Rutland 2014-06-25 17:47 ` Lorenzo Pieralisi 2014-06-25 17:47 ` Lorenzo Pieralisi 2014-06-25 14:29 ` Sudeep Holla 2014-06-25 14:29 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1633432.ZfU5VfHtET@amdc1032 \ --to=b.zolnierkie@samsung.com \ --cc=Catalin.Marinas@arm.com \ --cc=Charles.Garcia-Tobin@arm.com \ --cc=Mark.Rutland@arm.com \ --cc=ananaza@iki.fi \ --cc=chander.kashyap@linaro.org \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=grant.likely@linaro.org \ --cc=kgene.kim@samsung.com \ --cc=khilman@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=nico@linaro.org \ --cc=paul@pwsan.com \ --cc=pdeschrijver@nvidia.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=sebcape@gmail.com \ --cc=t.figa@samsung.com \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.