[PATCH net] net: phylink: avoid mvneta warning when setting pause parameters

[PATCH net] net: phylink: avoid mvneta warning when setting pause parameters

[Russell King (Oracle)]

mvneta does not support asymetric pause modes, and it flags this by the
lack of AsymPause in the supported field. When setting pause modes, we
check that pause->rx_pause == pause->tx_pause, but only when pause
autoneg is enabled. When pause autoneg is disabled, we still allow
pause->rx_pause != pause->tx_pause, which is incorrect when the MAC
does not support asymetric pause, and causes mvneta to issue a warning.

Fix this by removing the test for pause->autoneg, so we always check
that pause->rx_pause == pause->tx_pause for network devices that do not
support AsymPause.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 drivers/net/phy/phylink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 0a0abe8e4be0..5defc721dd05 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -1724,7 +1724,7 @@ int phylink_ethtool_set_pauseparam(struct phylink *pl,
 		return -EOPNOTSUPP;
 
 	if (!phylink_test(pl->supported, Asym_Pause) &&
-	    !pause->autoneg && pause->rx_pause != pause->tx_pause)
+	    pause->rx_pause != pause->tx_pause)
 		return -EINVAL;
 
 	pause_state = 0;
-- 
2.30.2

Re: [PATCH net] net: phylink: avoid mvneta warning when setting pause parameters

[Jakub Kicinski]

On Thu, 28 Oct 2021 15:55:34 +0100 Russell King (Oracle) wrote:
> mvneta does not support asymetric pause modes, and it flags this by the
> lack of AsymPause in the supported field. When setting pause modes, we
> check that pause->rx_pause == pause->tx_pause, but only when pause
> autoneg is enabled. When pause autoneg is disabled, we still allow
> pause->rx_pause != pause->tx_pause, which is incorrect when the MAC
> does not support asymetric pause, and causes mvneta to issue a warning.
> 
> Fix this by removing the test for pause->autoneg, so we always check
> that pause->rx_pause == pause->tx_pause for network devices that do not
> support AsymPause.

Fixes..?

Re: [PATCH net] net: phylink: avoid mvneta warning when setting pause parameters

[Russell King (Oracle)]

On Thu, Oct 28, 2021 at 08:06:07AM -0700, Jakub Kicinski wrote:
> On Thu, 28 Oct 2021 15:55:34 +0100 Russell King (Oracle) wrote:
> > mvneta does not support asymetric pause modes, and it flags this by the
> > lack of AsymPause in the supported field. When setting pause modes, we
> > check that pause->rx_pause == pause->tx_pause, but only when pause
> > autoneg is enabled. When pause autoneg is disabled, we still allow
> > pause->rx_pause != pause->tx_pause, which is incorrect when the MAC
> > does not support asymetric pause, and causes mvneta to issue a warning.
> > 
> > Fix this by removing the test for pause->autoneg, so we always check
> > that pause->rx_pause == pause->tx_pause for network devices that do not
> > support AsymPause.
> 
> Fixes..?

If people care...

Fixes: 9525ae83959b ("phylink: add phylink infrastructure")

but since no one reported the issue, I'd be tempted not to backport
the patch until there's a need to do so. Especially as it's going
to have conflicts.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH net] net: phylink: avoid mvneta warning when setting pause parameters

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Thu, 28 Oct 2021 15:55:34 +0100 you wrote:
> mvneta does not support asymetric pause modes, and it flags this by the
> lack of AsymPause in the supported field. When setting pause modes, we
> check that pause->rx_pause == pause->tx_pause, but only when pause
> autoneg is enabled. When pause autoneg is disabled, we still allow
> pause->rx_pause != pause->tx_pause, which is incorrect when the MAC
> does not support asymetric pause, and causes mvneta to issue a warning.
> 
> [...]

Here is the summary with links:
  - [net] net: phylink: avoid mvneta warning when setting pause parameters
    https://git.kernel.org/netdev/net/c/fd8d9731bcdf

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html