All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: conor.dooley@microchip.com
Cc: ivan.griffin@microchip.com, jassisinghbrar@gmail.com,
	geert@linux-m68k.org, lewis.hanly@microchip.com,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	aou@eecs.berkeley.edu, paul.walmsley@sifive.com,
	broonie@kernel.org, atish.patra@wdc.com,
	linux-riscv@lists.infradead.org, linux-i2c@vger.kernel.org,
	palmer@dabbelt.com, gregkh@linuxfoundation.org,
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	bin.meng@windriver.com, robh+dt@kernel.org,
	linux-crypto@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com,
	a.zummo@towertech.it, linus.walleij@linaro.org,
	daire.mcnamara@microchip.com, alexandre.belloni@bootlin.com,
	krzysztof.kozlowski@canonical.com
Subject: Re: [PATCH 11/13] dt-bindings: usb: add bindings for microchip mpfs musb
Date: Mon, 08 Nov 2021 22:06:29 -0600	[thread overview]
Message-ID: <1636430789.946637.743044.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211108150554.4457-12-conor.dooley@microchip.com>

On Mon, 08 Nov 2021 15:05:52 +0000, conor.dooley@microchip.com wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> Add device tree bindings for the usb controller on
> the Microchip PolarFire SoC.
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  .../bindings/usb/microchip,mpfs-usb-host.yaml | 70 +++++++++++++++++++
>  1 file changed, 70 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml: properties:interrupt-names: 'oneOf' conditional failed, one must be fixed:
	[{'const': 'dma'}, {'const': 'mc'}] is too long
	[{'const': 'dma'}, {'const': 'mc'}] is too short
	False schema does not allow 2
	1 was expected
	hint: "minItems" is only needed if less than the "items" list length
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml: ignoring, error in schema: properties: interrupt-names
warning: no schema found in file: ./Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml
Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.example.dts:19:18: fatal error: dt-bindings/clock/microchip,mpfs-clock.h: No such file or directory
   19 |         #include "dt-bindings/clock/microchip,mpfs-clock.h"
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1441: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1552389

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: conor.dooley@microchip.com
Cc: ivan.griffin@microchip.com, jassisinghbrar@gmail.com,
	geert@linux-m68k.org, lewis.hanly@microchip.com,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	aou@eecs.berkeley.edu, paul.walmsley@sifive.com,
	broonie@kernel.org, atish.patra@wdc.com,
	linux-riscv@lists.infradead.org, linux-i2c@vger.kernel.org,
	palmer@dabbelt.com, gregkh@linuxfoundation.org,
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	bin.meng@windriver.com, robh+dt@kernel.org,
	linux-crypto@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com,
	a.zummo@towertech.it, linus.walleij@linaro.org,
	daire.mcnamara@microchip.com, alexandre.belloni@bootlin.com,
	krzysztof.kozlowski@canonical.com
Subject: Re: [PATCH 11/13] dt-bindings: usb: add bindings for microchip mpfs musb
Date: Mon, 08 Nov 2021 22:06:29 -0600	[thread overview]
Message-ID: <1636430789.946637.743044.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211108150554.4457-12-conor.dooley@microchip.com>

On Mon, 08 Nov 2021 15:05:52 +0000, conor.dooley@microchip.com wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> Add device tree bindings for the usb controller on
> the Microchip PolarFire SoC.
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  .../bindings/usb/microchip,mpfs-usb-host.yaml | 70 +++++++++++++++++++
>  1 file changed, 70 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml: properties:interrupt-names: 'oneOf' conditional failed, one must be fixed:
	[{'const': 'dma'}, {'const': 'mc'}] is too long
	[{'const': 'dma'}, {'const': 'mc'}] is too short
	False schema does not allow 2
	1 was expected
	hint: "minItems" is only needed if less than the "items" list length
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml: ignoring, error in schema: properties: interrupt-names
warning: no schema found in file: ./Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml
Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.example.dts:19:18: fatal error: dt-bindings/clock/microchip,mpfs-clock.h: No such file or directory
   19 |         #include "dt-bindings/clock/microchip,mpfs-clock.h"
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1441: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1552389

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2021-11-09  4:06 UTC|newest]

Thread overview: 140+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 15:05 [PATCH 00/13]Update the icicle kit device tree conor.dooley
2021-11-08 15:05 ` conor.dooley
2021-11-08 15:05 ` [PATCH 01/13] dt-bindings: interrupt-controller: create a header for RISC-V interrupts conor.dooley
2021-11-08 15:05   ` conor.dooley
2021-11-23 11:07   ` Heiko Stübner
2021-11-23 11:07     ` Heiko Stübner
2021-11-23 11:35     ` Anup Patel
2021-11-23 11:35       ` Anup Patel
2021-11-29 19:57   ` Rob Herring
2021-11-29 19:57     ` Rob Herring
2021-11-08 15:05 ` [PATCH 02/13] dt-bindings: interrupt-controller: add defines for mpfs-plic conor.dooley
2021-11-08 15:05   ` conor.dooley
2021-11-23 11:17   ` Heiko Stübner
2021-11-23 11:17     ` Heiko Stübner
2021-11-29 19:56   ` Rob Herring
2021-11-29 19:56     ` Rob Herring
2021-11-30  8:15     ` Conor.Dooley
2021-11-30  8:15       ` Conor.Dooley
2021-11-08 15:05 ` [PATCH 03/13] dt-bindings: soc/microchip: update sys ctrlr compat string conor.dooley
2021-11-08 15:05   ` conor.dooley
2021-11-08 21:09   ` Krzysztof Kozlowski
2021-11-08 21:09     ` Krzysztof Kozlowski
2021-11-09  8:33   ` Geert Uytterhoeven
2021-11-09  8:33     ` Geert Uytterhoeven
2021-11-09 15:20     ` Conor.Dooley
2021-11-09 15:20       ` Conor.Dooley
2021-11-29 20:03   ` Rob Herring
2021-11-29 20:03     ` Rob Herring
2021-11-30  8:35     ` Conor.Dooley
2021-11-30  8:35       ` Conor.Dooley
2021-11-08 15:05 ` [PATCH 04/13] dt-bindings: riscv: update microchip polarfire binds conor.dooley
2021-11-08 15:05   ` conor.dooley
2021-11-08 21:10   ` Krzysztof Kozlowski
2021-11-08 21:10     ` Krzysztof Kozlowski
2021-11-09  8:34   ` Geert Uytterhoeven
2021-11-09  8:34     ` Geert Uytterhoeven
2021-11-09 12:08     ` Conor.Dooley
2021-11-09 12:08       ` Conor.Dooley
2021-11-09 13:04       ` Geert Uytterhoeven
2021-11-09 13:04         ` Geert Uytterhoeven
2021-11-23 11:24         ` Heiko Stübner
2021-11-23 11:24           ` Heiko Stübner
2021-11-08 15:05 ` [PATCH 05/13] dt-bindings: i2c: add bindings for microchip mpfs i2c conor.dooley
2021-11-08 15:05   ` conor.dooley
2021-11-08 21:13   ` Krzysztof Kozlowski
2021-11-08 21:13     ` Krzysztof Kozlowski
2021-11-09  4:06   ` Rob Herring
2021-11-09  4:06     ` Rob Herring
2021-11-08 15:05 ` [PATCH 06/13] dt-bindings: rng: add bindings for microchip mpfs rng conor.dooley
2021-11-08 15:05   ` conor.dooley
2021-11-08 21:16   ` Krzysztof Kozlowski
2021-11-08 21:16     ` Krzysztof Kozlowski
2021-11-09 12:54     ` Conor.Dooley
2021-11-09 12:54       ` Conor.Dooley
2021-11-09 12:56       ` Krzysztof Kozlowski
2021-11-09 12:56         ` Krzysztof Kozlowski
2021-11-09 13:36         ` Conor.Dooley
2021-11-09 13:36           ` Conor.Dooley
2021-11-10  7:43           ` Krzysztof Kozlowski
2021-11-10  7:43             ` Krzysztof Kozlowski
2021-11-10  9:46             ` Conor.Dooley
2021-11-10  9:46               ` Conor.Dooley
2021-11-29 20:08               ` Rob Herring
2021-11-29 20:08                 ` Rob Herring
2021-11-09  8:37   ` Geert Uytterhoeven
2021-11-09  8:37     ` Geert Uytterhoeven
2021-11-09 11:55     ` Conor.Dooley
2021-11-09 11:55       ` Conor.Dooley
2021-11-08 15:05 ` [PATCH 07/13] dt-bindings: rtc: add bindings for microchip mpfs rtc conor.dooley
2021-11-08 15:05   ` conor.dooley
2021-11-08 21:20   ` Krzysztof Kozlowski
2021-11-08 21:20     ` Krzysztof Kozlowski
2021-11-09  4:06   ` Rob Herring
2021-11-09  4:06     ` Rob Herring
2021-11-09  8:39   ` Geert Uytterhoeven
2021-11-09  8:39     ` Geert Uytterhoeven
2021-11-08 15:05 ` [PATCH 08/13] dt-bindings: soc/microchip: add bindings for mpfs system services conor.dooley
2021-11-08 15:05   ` conor.dooley
2021-11-08 21:20   ` Krzysztof Kozlowski
2021-11-08 21:20     ` Krzysztof Kozlowski
2021-11-08 15:05 ` [PATCH 09/13] dt-bindings: gpio: add bindings for microchip mpfs gpio conor.dooley
2021-11-08 15:05   ` conor.dooley
2021-11-08 21:22   ` Krzysztof Kozlowski
2021-11-08 21:22     ` Krzysztof Kozlowski
2021-11-09  4:06   ` Rob Herring
2021-11-09  4:06     ` Rob Herring
2021-11-09  8:43   ` Geert Uytterhoeven
2021-11-09  8:43     ` Geert Uytterhoeven
2021-11-08 15:05 ` [PATCH 10/13] dt-bindings: spi: add bindings for microchip mpfs spi conor.dooley
2021-11-08 15:05   ` conor.dooley
2021-11-08 21:24   ` Krzysztof Kozlowski
2021-11-08 21:24     ` Krzysztof Kozlowski
2021-11-09  4:06   ` Rob Herring
2021-11-09  4:06     ` Rob Herring
2021-11-09 12:16     ` Conor.Dooley
2021-11-09 12:16       ` Conor.Dooley
2021-11-09 12:53       ` Krzysztof Kozlowski
2021-11-09 12:53         ` Krzysztof Kozlowski
2021-11-09 12:58         ` Conor.Dooley
2021-11-09 12:58           ` Conor.Dooley
2021-11-09 13:04           ` Krzysztof Kozlowski
2021-11-09 13:04             ` Krzysztof Kozlowski
2021-11-09 13:20             ` Conor.Dooley
2021-11-09 13:20               ` Conor.Dooley
2021-11-10  7:45               ` Krzysztof Kozlowski
2021-11-10  7:45                 ` Krzysztof Kozlowski
2021-11-09  8:45   ` Geert Uytterhoeven
2021-11-09  8:45     ` Geert Uytterhoeven
2021-11-09 10:56     ` Conor.Dooley
2021-11-09 10:56       ` Conor.Dooley
2021-11-08 15:05 ` [PATCH 11/13] dt-bindings: usb: add bindings for microchip mpfs musb conor.dooley
2021-11-08 15:05   ` conor.dooley
2021-11-08 21:27   ` Krzysztof Kozlowski
2021-11-08 21:27     ` Krzysztof Kozlowski
2021-11-09  4:06   ` Rob Herring [this message]
2021-11-09  4:06     ` Rob Herring
2021-11-09  8:48   ` Geert Uytterhoeven
2021-11-09  8:48     ` Geert Uytterhoeven
2021-11-08 15:05 ` [PATCH 12/13] riscv: icicle-kit: update microchip icicle kit device tree conor.dooley
2021-11-08 15:05   ` conor.dooley
2021-11-08 21:40   ` Krzysztof Kozlowski
2021-11-08 21:40     ` Krzysztof Kozlowski
2021-11-10 12:07     ` Conor.Dooley
2021-11-10 12:07       ` Conor.Dooley
2021-11-09  9:04   ` Geert Uytterhoeven
2021-11-09  9:04     ` Geert Uytterhoeven
2021-11-10 14:19     ` Conor.Dooley
2021-11-10 14:19       ` Conor.Dooley
2021-11-10 14:58       ` Geert Uytterhoeven
2021-11-10 14:58         ` Geert Uytterhoeven
2021-11-10 15:07         ` Conor.Dooley
2021-11-10 15:07           ` Conor.Dooley
2021-11-15 15:39         ` Conor.Dooley
2021-11-15 15:39           ` Conor.Dooley
2021-11-15 16:17           ` Geert Uytterhoeven
2021-11-15 16:17             ` Geert Uytterhoeven
2021-11-17 12:17             ` Daire.McNamara
2021-11-17 12:17               ` Daire.McNamara
2021-11-08 15:05 ` [PATCH 13/13] MAINTAINERS: update riscv/microchip entry conor.dooley
2021-11-08 15:05   ` conor.dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1636430789.946637.743044.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=atish.patra@wdc.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=bin.meng@windriver.com \
    --cc=broonie@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ivan.griffin@microchip.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=lewis.hanly@microchip.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.