* [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr
@ 2021-11-11 9:11 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-11 9:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Arnd Bergmann, kernel test robot
Include the header with prototype of s3c2410_modify_misccr to fix W=1
warning:
arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
arch/arm/mach-s3c/gpio-samsung.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-samsung.c
index 76ef415789f2..fda2c01f5a08 100644
--- a/arch/arm/mach-s3c/gpio-samsung.c
+++ b/arch/arm/mach-s3c/gpio-samsung.c
@@ -35,6 +35,7 @@
#include "gpio-core.h"
#include "gpio-cfg.h"
#include "gpio-cfg-helpers.h"
+#include "hardware-s3c24xx.h"
#include "pm.h"
int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip,
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr
2021-11-11 9:11 ` Krzysztof Kozlowski
@ 2021-11-11 9:46 ` Arnd Bergmann
-1 siblings, 0 replies; 12+ messages in thread
From: Arnd Bergmann @ 2021-11-11 9:46 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Linux ARM, moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES,
Linux Kernel Mailing List, Arnd Bergmann, kernel test robot
On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> warning:
>
> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Thank you for fixing it,
Acked-by: Arnd Bergmann <arnd@arndb.de>
If you like, I can put it into the fixes branch of the soc tree directly,
otherwise I expect you'll send it in a pull request later.
Arnd
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr
@ 2021-11-11 9:46 ` Arnd Bergmann
0 siblings, 0 replies; 12+ messages in thread
From: Arnd Bergmann @ 2021-11-11 9:46 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Linux ARM, moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES,
Linux Kernel Mailing List, Arnd Bergmann, kernel test robot
On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> warning:
>
> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Thank you for fixing it,
Acked-by: Arnd Bergmann <arnd@arndb.de>
If you like, I can put it into the fixes branch of the soc tree directly,
otherwise I expect you'll send it in a pull request later.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr
2021-11-11 9:46 ` Arnd Bergmann
@ 2021-11-11 9:56 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-11 9:56 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linux ARM, moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES,
Linux Kernel Mailing List, kernel test robot
On 11/11/2021 10:46, Arnd Bergmann wrote:
> On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> Include the header with prototype of s3c2410_modify_misccr to fix W=1
>> warning:
>>
>> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
>> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> Thank you for fixing it,
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> If you like, I can put it into the fixes branch of the soc tree directly,
> otherwise I expect you'll send it in a pull request later.
It's not a serious bug and was there since long time, so maybe let's
send it via regular pull request.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr
@ 2021-11-11 9:56 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-11 9:56 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linux ARM, moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES,
Linux Kernel Mailing List, kernel test robot
On 11/11/2021 10:46, Arnd Bergmann wrote:
> On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> Include the header with prototype of s3c2410_modify_misccr to fix W=1
>> warning:
>>
>> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
>> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> Thank you for fixing it,
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> If you like, I can put it into the fixes branch of the soc tree directly,
> otherwise I expect you'll send it in a pull request later.
It's not a serious bug and was there since long time, so maybe let's
send it via regular pull request.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr
2021-11-11 9:56 ` Krzysztof Kozlowski
@ 2021-11-11 16:41 ` Arnd Bergmann
-1 siblings, 0 replies; 12+ messages in thread
From: Arnd Bergmann @ 2021-11-11 16:41 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Arnd Bergmann, Linux ARM,
moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES,
Linux Kernel Mailing List, kernel test robot
On Thu, Nov 11, 2021 at 10:56 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> On 11/11/2021 10:46, Arnd Bergmann wrote:
> > On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@canonical.com> wrote:
> >>
> >> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> >> warning:
> >>
> >> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> >> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
> >>
> >> Reported-by: kernel test robot <lkp@intel.com>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >
> > Thank you for fixing it,
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
> > If you like, I can put it into the fixes branch of the soc tree directly,
> > otherwise I expect you'll send it in a pull request later.
>
> It's not a serious bug and was there since long time, so maybe let's
> send it via regular pull request.
Ok, sounds good. I was worried for a bit that this would break builds
with CONFIG_WERROR, but of course that is already broken in
many ways with W=1.
Arnd
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr
@ 2021-11-11 16:41 ` Arnd Bergmann
0 siblings, 0 replies; 12+ messages in thread
From: Arnd Bergmann @ 2021-11-11 16:41 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Arnd Bergmann, Linux ARM,
moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES,
Linux Kernel Mailing List, kernel test robot
On Thu, Nov 11, 2021 at 10:56 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> On 11/11/2021 10:46, Arnd Bergmann wrote:
> > On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@canonical.com> wrote:
> >>
> >> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> >> warning:
> >>
> >> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> >> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
> >>
> >> Reported-by: kernel test robot <lkp@intel.com>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >
> > Thank you for fixing it,
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
> > If you like, I can put it into the fixes branch of the soc tree directly,
> > otherwise I expect you'll send it in a pull request later.
>
> It's not a serious bug and was there since long time, so maybe let's
> send it via regular pull request.
Ok, sounds good. I was worried for a bit that this would break builds
with CONFIG_WERROR, but of course that is already broken in
many ways with W=1.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr
2021-11-11 9:11 ` Krzysztof Kozlowski
@ 2021-11-11 16:28 ` Alim Akhtar
-1 siblings, 0 replies; 12+ messages in thread
From: Alim Akhtar @ 2021-11-11 16:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-samsung-soc, open list, Arnd Bergmann,
kernel test robot
Hi Krzysztof,
On Thu, Nov 11, 2021 at 2:42 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> warning:
>
> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> arch/arm/mach-s3c/gpio-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-samsung.c
> index 76ef415789f2..fda2c01f5a08 100644
> --- a/arch/arm/mach-s3c/gpio-samsung.c
> +++ b/arch/arm/mach-s3c/gpio-samsung.c
> @@ -35,6 +35,7 @@
> #include "gpio-core.h"
> #include "gpio-cfg.h"
> #include "gpio-cfg-helpers.h"
> +#include "hardware-s3c24xx.h"
> #include "pm.h"
>
> int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip,
> --
> 2.32.0
>
--
Regards,
Alim
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr
@ 2021-11-11 16:28 ` Alim Akhtar
0 siblings, 0 replies; 12+ messages in thread
From: Alim Akhtar @ 2021-11-11 16:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-kernel, linux-samsung-soc, open list, Arnd Bergmann,
kernel test robot
Hi Krzysztof,
On Thu, Nov 11, 2021 at 2:42 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> warning:
>
> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> arch/arm/mach-s3c/gpio-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-samsung.c
> index 76ef415789f2..fda2c01f5a08 100644
> --- a/arch/arm/mach-s3c/gpio-samsung.c
> +++ b/arch/arm/mach-s3c/gpio-samsung.c
> @@ -35,6 +35,7 @@
> #include "gpio-core.h"
> #include "gpio-cfg.h"
> #include "gpio-cfg-helpers.h"
> +#include "hardware-s3c24xx.h"
> #include "pm.h"
>
> int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip,
> --
> 2.32.0
>
--
Regards,
Alim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr
2021-11-11 9:11 ` Krzysztof Kozlowski
@ 2021-11-15 13:11 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-15 13:11 UTC (permalink / raw)
To: linux-samsung-soc, linux-arm-kernel, Krzysztof Kozlowski, linux-kernel
Cc: kernel test robot, Arnd Bergmann
On Thu, 11 Nov 2021 10:11:23 +0100, Krzysztof Kozlowski wrote:
> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> warning:
>
> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>
>
> [...]
Applied, thanks!
[1/1] ARM: s3c: include header for prototype of s3c2410_modify_misccr
commit: 90dc0df9168b6c1ddb339481b440d7c13cc4417c
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr
@ 2021-11-15 13:11 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-15 13:11 UTC (permalink / raw)
To: linux-samsung-soc, linux-arm-kernel, Krzysztof Kozlowski, linux-kernel
Cc: kernel test robot, Arnd Bergmann
On Thu, 11 Nov 2021 10:11:23 +0100, Krzysztof Kozlowski wrote:
> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> warning:
>
> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>
>
> [...]
Applied, thanks!
[1/1] ARM: s3c: include header for prototype of s3c2410_modify_misccr
commit: 90dc0df9168b6c1ddb339481b440d7c13cc4417c
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread