Re: [PATCH v4 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

["Heiko Stübner" <heiko@sntech.de>]

Hi Marc,

Am Mittwoch, 13. Juni 2018, 15:01:27 CEST schrieb Marc Zyngier:
> On 12/06/18 14:20, Heiko Stuebner wrote:
> > From: Sandy Huang <hjc@rock-chips.com>
> > 
> > The vop irq is shared between vop and iommu and irq probing in the
> > iommu driver moved to the probe function recently. This can in some
> > cases lead to a stall if the irq is triggered while the vop driver
> > still has it disabled, but the vop irq handler gets called.
> > 
> > But there is no real need to disable the irq, as the vop can simply
> > also track its enabled state and ignore irqs in that case.
> > For this we can simply check the power-domain state of the vop,
> > similar to how the iommu driver does it.
> > 
> > So remove the enable/disable handling and add appropriate condition
> > to the irq handler.
> > 
> > changes in v2:
> > - move to just check the power-domain state
> > - add clock handling
> > changes in v3:
> > - clarify comment to speak of runtime-pm not power-domain
> > changes in v4:
> > - address Marc's comments (clk-enable WARN_ON and style improvement)
> > 
> > Fixes: d0b912bd4c23 ("iommu/rockchip: Request irqs in rk_iommu_probe()")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > Tested-by: Ezequiel Garcia <ezequiel@collabora.com>
> 
> Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>

could I ask you to also look at patch1 of this series, to give it an
Ack or Review? drm-misc documentation very strongly suggests [0]
to have at least another set of eyes on a patch and so far noone
came forward ;-)

This of course also applies to everybody else in the Cc list :-D .


Thanks
Heiko


[0] https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html#merge-criteria