From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
robh@kernel.org, bhelgaas@google.com, kw@linux.com,
michal.simek@xilinx.com
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PCI: xilinx-nwl: Simplify code and fix a memory leak
Date: Mon, 29 Nov 2021 13:41:05 +0000 [thread overview]
Message-ID: <163819324863.26090.8890227197735152343.b4-ty@arm.com> (raw)
In-Reply-To: <5483f10a44b06aad55728576d489adfa16c3be91.1636279388.git.christophe.jaillet@wanadoo.fr>
On Sun, 7 Nov 2021 11:04:43 +0100, Christophe JAILLET wrote:
> Allocate space for 'bitmap' in 'struct nwl_msi' at build time instead of
> dynamically allocating the memory at runtime.
>
> This simplifies code (especially error handling paths) and avoid some
> open-coded arithmetic in allocator arguments
>
> This also fixes a potential memory leak. The bitmap was never freed. It is
> now part of a managed resource.
>
> [...]
Applied to pci/xilinx-nwl, thanks!
[1/1] PCI: xilinx-nwl: Simplify code and fix a memory leak
https://git.kernel.org/lpieralisi/pci/c/e2b86f9777
Thanks,
Lorenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
robh@kernel.org, bhelgaas@google.com, kw@linux.com,
michal.simek@xilinx.com
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PCI: xilinx-nwl: Simplify code and fix a memory leak
Date: Mon, 29 Nov 2021 13:41:05 +0000 [thread overview]
Message-ID: <163819324863.26090.8890227197735152343.b4-ty@arm.com> (raw)
In-Reply-To: <5483f10a44b06aad55728576d489adfa16c3be91.1636279388.git.christophe.jaillet@wanadoo.fr>
On Sun, 7 Nov 2021 11:04:43 +0100, Christophe JAILLET wrote:
> Allocate space for 'bitmap' in 'struct nwl_msi' at build time instead of
> dynamically allocating the memory at runtime.
>
> This simplifies code (especially error handling paths) and avoid some
> open-coded arithmetic in allocator arguments
>
> This also fixes a potential memory leak. The bitmap was never freed. It is
> now part of a managed resource.
>
> [...]
Applied to pci/xilinx-nwl, thanks!
[1/1] PCI: xilinx-nwl: Simplify code and fix a memory leak
https://git.kernel.org/lpieralisi/pci/c/e2b86f9777
Thanks,
Lorenzo
next prev parent reply other threads:[~2021-11-29 13:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 10:04 [PATCH] PCI: xilinx-nwl: Simplify code and fix a memory leak Christophe JAILLET
2021-11-07 10:04 ` Christophe JAILLET
2021-11-08 0:31 ` Krzysztof Wilczyński
2021-11-08 0:31 ` Krzysztof Wilczyński
2021-11-08 6:37 ` Christophe JAILLET
2021-11-08 6:37 ` Christophe JAILLET
2021-11-29 13:41 ` Lorenzo Pieralisi [this message]
2021-11-29 13:41 ` Lorenzo Pieralisi
2021-11-30 16:55 ` Bjorn Helgaas
2021-11-30 16:55 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163819324863.26090.8890227197735152343.b4-ty@arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.