* [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats
@ 2021-11-18 6:25 Vidya Srinivas
2021-11-18 7:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (18 more replies)
0 siblings, 19 replies; 39+ messages in thread
From: Vidya Srinivas @ 2021-11-18 6:25 UTC (permalink / raw)
To: intel-gfx; +Cc: Yashashvi Shantam
PLANE_CUS_CTL has a restriction of 4096 width even though
PLANE_SIZE and scaler size registers supports max 5120.
Reject 5k on HDR plane for planar formats like NV12
to let the user space know about it.
Without this patch, when 5k content is sent on HDR plane
with NV12 content, FIFO underrun is seen and screen blanks
out. Issue is seen on both TGL and ADL platforms.
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
---
drivers/gpu/drm/i915/display/skl_scaler.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index 37eabeff8197..e2e52f5dca3b 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -86,6 +86,7 @@ static u16 skl_scaler_calc_phase(int sub, int scale, bool chroma_cosited)
#define ICL_MAX_DST_H 4096
#define SKL_MIN_YUV_420_SRC_W 16
#define SKL_MIN_YUV_420_SRC_H 16
+#define MAX_CUSCTL_W 4096
static int
skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,
@@ -221,6 +222,14 @@ int skl_update_scaler_plane(struct intel_crtc_state *crtc_state,
bool force_detach = !fb || !plane_state->uapi.visible;
bool need_scaler = false;
+ /* PLANE_CUS_CTL size max 4096 */
+ if (icl_is_hdr_plane(dev_priv, intel_plane->id) &&
+ fb && intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier) &&
+ (drm_rect_width(&plane_state->uapi.src) >> 16) > MAX_CUSCTL_W) {
+ DRM_ERROR("HDR chroma upsampler size exceeds limits\n");
+ return -EINVAL;
+ }
+
/* Pre-gen11 and SDR planes always need a scaler for planar formats. */
if (!icl_is_hdr_plane(dev_priv, intel_plane->id) &&
fb && intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
--
2.33.0
^ permalink raw reply related [flat|nested] 39+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject 5k on HDR planes for planar fb formats
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
@ 2021-11-18 7:12 ` Patchwork
2021-11-18 15:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
` (17 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-11-18 7:12 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4064 bytes --]
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats
URL : https://patchwork.freedesktop.org/series/97053/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10897 -> Patchwork_21625
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/index.html
Participating hosts (39 -> 31)
------------------------------
Missing (8): fi-kbl-soraka bat-dg1-6 fi-hsw-4200u fi-skl-guc fi-icl-u2 fi-bsw-cyan fi-ctg-p8600 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_21625 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][2] -> [INCOMPLETE][3] ([i915#2940])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/fi-bsw-nick/igt@i915_selftest@live@execlists.html
* igt@runner@aborted:
- fi-bsw-nick: NOTRUN -> [FAIL][4] ([fdo#109271] / [i915#1436] / [i915#2722] / [i915#3428] / [i915#4312])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/fi-bsw-nick/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-skl-6600u: [FAIL][5] ([i915#3239]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/fi-skl-6600u/igt@i915_pm_rpm@basic-pci-d3-state.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/fi-skl-6600u/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@gt_heartbeat:
- {fi-tgl-dsi}: [DMESG-FAIL][7] ([i915#541]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][9] ([i915#3921]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3239]: https://gitlab.freedesktop.org/drm/intel/issues/3239
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4290]: https://gitlab.freedesktop.org/drm/intel/issues/4290
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Build changes
-------------
* Linux: CI_DRM_10897 -> Patchwork_21625
CI-20190529: 20190529
CI_DRM_10897: 6afd200919ae894c775326ea99e607e5a8adf51b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6284: 2971051d07d02da90c20ccb842e76ee711b02ecb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21625: 1115e33cd27836f37a8840e9fe9940310466e059 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
1115e33cd278 drm/i915: Reject 5k on HDR planes for planar fb formats
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/index.html
[-- Attachment #2: Type: text/html, Size: 4810 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Reject 5k on HDR planes for planar fb formats
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
2021-11-18 7:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-11-18 15:48 ` Patchwork
2021-11-30 9:30 ` [Intel-gfx] [PATCH] " Ville Syrjälä
` (16 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-11-18 15:48 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30278 bytes --]
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats
URL : https://patchwork.freedesktop.org/series/97053/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10897_full -> Patchwork_21625_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_21625_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21625_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21625_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-rc_ccs-cc-to-x} (NEW):
- {shard-rkl}: NOTRUN -> [FAIL][1] +21 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-rkl-2/igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-rc_ccs-cc-to-x.html
#### Warnings ####
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [FAIL][2] ([i915#4275]) -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-iclb5/igt@i915_pm_dc@dc9-dpms.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-iclb5/igt@i915_pm_dc@dc9-dpms.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-to-linear:
- {shard-rkl}: NOTRUN -> [FAIL][4] +17 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-rkl-2/igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-to-linear.html
New tests
---------
New tests have been introduced between CI_DRM_10897_full and Patchwork_21625_full:
### New IGT tests (32) ###
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-linear-to-y-rc_ccs:
- Statuses : 1 fail(s)
- Exec time: [0.23] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-linear-to-y-rc_ccs-cc:
- Statuses : 1 fail(s)
- Exec time: [0.20] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-x-to-y-rc_ccs:
- Statuses : 1 fail(s)
- Exec time: [0.23] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-x-to-y-rc_ccs-cc:
- Statuses : 1 fail(s)
- Exec time: [0.20] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-rc_ccs-cc-to-linear:
- Statuses : 1 pass(s)
- Exec time: [0.30] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-rc_ccs-cc-to-x:
- Statuses : 1 pass(s)
- Exec time: [0.30] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-rc_ccs-cc-to-y:
- Statuses : 1 pass(s)
- Exec time: [0.27] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-rc_ccs-cc-to-y-rc_ccs:
- Statuses : 1 pass(s)
- Exec time: [0.27] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-rc_ccs-cc-to-y-rc_ccs-cc:
- Statuses : 1 pass(s)
- Exec time: [0.27] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-rc_ccs-to-linear:
- Statuses : 1 pass(s)
- Exec time: [0.30] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-rc_ccs-to-x:
- Statuses : 1 pass(s)
- Exec time: [0.30] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-rc_ccs-to-y:
- Statuses : 1 pass(s)
- Exec time: [0.27] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-rc_ccs-to-y-rc_ccs:
- Statuses : 1 pass(s)
- Exec time: [0.41] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-rc_ccs-to-y-rc_ccs-cc:
- Statuses : 1 pass(s)
- Exec time: [0.23] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-to-y-rc_ccs:
- Statuses : 1 fail(s)
- Exec time: [0.29] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-a-y-to-y-rc_ccs-cc:
- Statuses : 1 fail(s)
- Exec time: [0.23] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-linear-to-y-rc_ccs:
- Statuses : 1 fail(s)
- Exec time: [0.20] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-linear-to-y-rc_ccs-cc:
- Statuses : 1 fail(s)
- Exec time: [0.20] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-x-to-y-rc_ccs:
- Statuses : 1 fail(s)
- Exec time: [0.20] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-x-to-y-rc_ccs-cc:
- Statuses : 1 fail(s)
- Exec time: [0.20] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-rc_ccs-cc-to-linear:
- Statuses : 1 fail(s)
- Exec time: [0.20] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-rc_ccs-cc-to-x:
- Statuses : 1 fail(s)
- Exec time: [0.20] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-rc_ccs-cc-to-y:
- Statuses : 1 fail(s)
- Exec time: [0.21] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-rc_ccs-cc-to-y-rc_ccs:
- Statuses : 1 fail(s)
- Exec time: [0.23] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-rc_ccs-cc-to-y-rc_ccs-cc:
- Statuses : 1 fail(s)
- Exec time: [0.22] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-rc_ccs-to-linear:
- Statuses : 1 fail(s)
- Exec time: [0.20] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-rc_ccs-to-x:
- Statuses : 1 fail(s)
- Exec time: [0.20] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-rc_ccs-to-y:
- Statuses : 1 fail(s)
- Exec time: [0.23] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-rc_ccs-to-y-rc_ccs:
- Statuses : 1 fail(s)
- Exec time: [0.42] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-rc_ccs-to-y-rc_ccs-cc:
- Statuses : 1 fail(s)
- Exec time: [0.23] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-to-y-rc_ccs:
- Statuses : 1 fail(s)
- Exec time: [0.23] s
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-2-pipe-b-y-to-y-rc_ccs-cc:
- Statuses : 1 fail(s)
- Exec time: [0.23] s
Known issues
------------
Here are the changes found in Patchwork_21625_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-glk: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [FAIL][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29]) ([i915#4392]) -> ([PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk9/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk9/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk8/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk8/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk8/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk7/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk7/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk7/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk5/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk5/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk3/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk3/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk3/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk2/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk2/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk2/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk1/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk9/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk9/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk8/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk8/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk8/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk7/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk7/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk7/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk5/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk5/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk4/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk4/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk4/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk3/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk3/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk2/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk2/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk1/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk1/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk1/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][55] ([i915#3002])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-apl8/igt@gem_create@create-massive.html
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-skl: [PASS][56] -> [INCOMPLETE][57] ([i915#198])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-skl9/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-skl10/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_ctx_param@set-priority-not-supported:
- shard-tglb: NOTRUN -> [SKIP][58] ([fdo#109314])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb5/igt@gem_ctx_param@set-priority-not-supported.html
* igt@gem_eio@in-flight-suspend:
- shard-tglb: [PASS][59] -> [INCOMPLETE][60] ([i915#456])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-tglb5/igt@gem_eio@in-flight-suspend.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb7/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_balancer@parallel-contexts:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#4525]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb3/igt@gem_exec_balancer@parallel-contexts.html
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][62] -> [INCOMPLETE][63] ([i915#2369])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-skl9/igt@gem_exec_capture@pi@rcs0.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-skl10/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_capture@pi@vcs1:
- shard-tglb: [PASS][64] -> [INCOMPLETE][65] ([i915#3371])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-tglb5/igt@gem_exec_capture@pi@vcs1.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb7/igt@gem_exec_capture@pi@vcs1.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][66] -> [FAIL][67] ([i915#2842])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][68] -> [FAIL][69] ([i915#2842])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-kbl7/igt@gem_exec_fair@basic-none@vcs0.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-kbl1/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [PASS][70] -> [FAIL][71] ([i915#2842] / [i915#3468])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-apl6/igt@gem_exec_fair@basic-none@vecs0.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-apl3/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [PASS][72] -> [FAIL][73] ([i915#2842])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-tglb8/igt@gem_exec_fair@basic-pace@rcs0.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb6/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][74] ([i915#2842])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][75] -> [FAIL][76] ([i915#2842])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk4/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_params@no-vebox:
- shard-skl: NOTRUN -> [SKIP][77] ([fdo#109271]) +49 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-skl7/igt@gem_exec_params@no-vebox.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][78] -> [SKIP][79] ([i915#2190])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-tglb3/igt@gem_huc_copy@huc-copy.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-multi:
- shard-tglb: NOTRUN -> [SKIP][80] ([i915#4555]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb3/igt@gem_lmem_swapping@parallel-multi.html
* igt@gem_pxp@verify-pxp-execution-after-suspend-resume:
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#4270])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb5/igt@gem_pxp@verify-pxp-execution-after-suspend-resume.html
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-tglb: NOTRUN -> [SKIP][82] ([i915#3297])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb5/igt@gem_userptr_blits@unsync-unmap-cycles.html
* igt@gen7_exec_parse@basic-allocation:
- shard-glk: NOTRUN -> [SKIP][83] ([fdo#109271]) +39 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk9/igt@gen7_exec_parse@basic-allocation.html
* igt@gen7_exec_parse@oacontrol-tracking:
- shard-tglb: NOTRUN -> [SKIP][84] ([fdo#109289])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb5/igt@gen7_exec_parse@oacontrol-tracking.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][85] -> [DMESG-WARN][86] ([i915#1436] / [i915#716])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-skl7/igt@gen9_exec_parse@allowed-single.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-skl4/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][87] -> [FAIL][88] ([i915#454])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
- shard-tglb: NOTRUN -> [FAIL][89] ([i915#454])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb3/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#1937])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-apl8/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-tglb: NOTRUN -> [WARN][91] ([i915#2681] / [i915#2684])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb5/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-tglb: NOTRUN -> [SKIP][92] ([fdo#111644] / [i915#1397] / [i915#2411])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb5/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-tglb: NOTRUN -> [SKIP][93] ([fdo#109506] / [i915#2411])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb3/igt@i915_pm_rpm@modeset-pc8-residency-stress.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][94] ([fdo#111614])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb3/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#3777]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-kbl2/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-skl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#3777])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-skl7/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-glk: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#3777])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk9/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-64bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][98] ([fdo#111615])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb3/igt@kms_big_fb@yf-tiled-64bpp-rotate-180.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][99] ([i915#3689] / [i915#3886])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb3/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#3886]) +8 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-kbl1/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][101] ([fdo#111615] / [i915#3689])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb5/igt@kms_ccs@pipe-c-bad-pixel-format-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#3886])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-apl8/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#3689]) +3 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb5/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#3886]) +2 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk9/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#3886]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-skl7/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][106] ([fdo#109271] / [fdo#111827]) +2 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-skl7/igt@kms_chamelium@dp-hpd-storm-disable.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-kbl: NOTRUN -> [SKIP][107] ([fdo#109271] / [fdo#111827]) +8 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-kbl7/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:
- shard-tglb: NOTRUN -> [SKIP][108] ([fdo#109284] / [fdo#111827]) +6 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb5/igt@kms_color_chamelium@pipe-c-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-d-ctm-blue-to-red:
- shard-glk: NOTRUN -> [SKIP][109] ([fdo#109271] / [fdo#111827]) +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk9/igt@kms_color_chamelium@pipe-d-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-d-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][110] ([fdo#109271] / [fdo#111827]) +2 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-apl8/igt@kms_color_chamelium@pipe-d-ctm-limited-range.html
* igt@kms_content_protection@atomic-dpms:
- shard-kbl: NOTRUN -> [TIMEOUT][111] ([i915#1319])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-kbl2/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@legacy:
- shard-apl: NOTRUN -> [TIMEOUT][112] ([i915#1319])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-apl8/igt@kms_content_protection@legacy.html
* igt@kms_cursor_crc@pipe-a-cursor-512x170-random:
- shard-tglb: NOTRUN -> [SKIP][113] ([fdo#109279] / [i915#3359]) +2 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-512x170-random.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][114] -> [DMESG-WARN][115] ([i915#180]) +3 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-32x10-onscreen:
- shard-tglb: NOTRUN -> [SKIP][116] ([i915#3359]) +2 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb3/igt@kms_cursor_crc@pipe-d-cursor-32x10-onscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-32x32-offscreen:
- shard-apl: NOTRUN -> [SKIP][117] ([fdo#109271]) +19 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-apl8/igt@kms_cursor_crc@pipe-d-cursor-32x32-offscreen.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size:
- shard-tglb: NOTRUN -> [SKIP][118] ([i915#4103]) +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][119] -> [FAIL][120] ([i915#2346])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-kbl: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#533])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-kbl1/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1:
- shard-apl: [PASS][122] -> [FAIL][123] ([i915#79])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-apl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1.html
* igt@kms_flip@flip-vs-fences@a-edp1:
- shard-skl: [PASS][124] -> [DMESG-WARN][125] ([i915#1982])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-skl8/igt@kms_flip@flip-vs-fences@a-edp1.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-skl10/igt@kms_flip@flip-vs-fences@a-edp1.html
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-apl: [PASS][126] -> [DMESG-WARN][127] ([i915#180]) +1 similar issue
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-apl6/igt@kms_flip@flip-vs-suspend@b-dp1.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-apl3/igt@kms_flip@flip-vs-suspend@b-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [PASS][128] -> [FAIL][129] ([i915#2122]) +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-skl9/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-kbl: NOTRUN -> [SKIP][130] ([fdo#109271] / [i915#2672])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-kbl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-iclb: [PASS][131] -> [SKIP][132] ([i915#3701])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-render:
- shard-tglb: NOTRUN -> [SKIP][133] ([fdo#111825]) +18 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render:
- shard-kbl: NOTRUN -> [SKIP][134] ([fdo#109271]) +140 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-kbl2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][135] -> [FAIL][136] ([i915#1188])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10897/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-skl9/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_hdr@static-toggle-suspend:
- shard-tglb: NOTRUN -> [SKIP][137] ([i915#1187])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-tglb3/igt@kms_hdr@static-toggle-suspend.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d:
- shard-glk: NOTRUN -> [SKIP][138] ([fdo#109271] / [i915#533])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/shard-glk9/igt@kms_pipe_crc_basic@read-crc-pipe-d.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-skl: NOTRUN -> [SKIP
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21625/index.html
[-- Attachment #2: Type: text/html, Size: 34342 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
2021-11-18 7:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-11-18 15:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-11-30 9:30 ` Ville Syrjälä
2021-11-30 16:20 ` Srinivas, Vidya
2021-11-30 16:05 ` [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width Vidya Srinivas
` (15 subsequent siblings)
18 siblings, 1 reply; 39+ messages in thread
From: Ville Syrjälä @ 2021-11-30 9:30 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: Yashashvi Shantam, intel-gfx
On Thu, Nov 18, 2021 at 11:55:16AM +0530, Vidya Srinivas wrote:
> PLANE_CUS_CTL has a restriction of 4096 width even though
> PLANE_SIZE and scaler size registers supports max 5120.
> Reject 5k on HDR plane for planar formats like NV12
> to let the user space know about it.
>
> Without this patch, when 5k content is sent on HDR plane
> with NV12 content, FIFO underrun is seen and screen blanks
> out. Issue is seen on both TGL and ADL platforms.
>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
> ---
> drivers/gpu/drm/i915/display/skl_scaler.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
> index 37eabeff8197..e2e52f5dca3b 100644
> --- a/drivers/gpu/drm/i915/display/skl_scaler.c
> +++ b/drivers/gpu/drm/i915/display/skl_scaler.c
> @@ -86,6 +86,7 @@ static u16 skl_scaler_calc_phase(int sub, int scale, bool chroma_cosited)
> #define ICL_MAX_DST_H 4096
> #define SKL_MIN_YUV_420_SRC_W 16
> #define SKL_MIN_YUV_420_SRC_H 16
> +#define MAX_CUSCTL_W 4096
>
> static int
> skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,
> @@ -221,6 +222,14 @@ int skl_update_scaler_plane(struct intel_crtc_state *crtc_state,
> bool force_detach = !fb || !plane_state->uapi.visible;
> bool need_scaler = false;
>
> + /* PLANE_CUS_CTL size max 4096 */
> + if (icl_is_hdr_plane(dev_priv, intel_plane->id) &&
> + fb && intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier) &&
> + (drm_rect_width(&plane_state->uapi.src) >> 16) > MAX_CUSCTL_W) {
> + DRM_ERROR("HDR chroma upsampler size exceeds limits\n");
> + return -EINVAL;
> + }
Wrong place. Should go into the plane->max_width() hook. There also
seems to be a minimum height requirement for the CUS which we're not
checking either.
> +
> /* Pre-gen11 and SDR planes always need a scaler for planar formats. */
> if (!icl_is_hdr_plane(dev_priv, intel_plane->id) &&
> fb && intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
> --
> 2.33.0
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (2 preceding siblings ...)
2021-11-30 9:30 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2021-11-30 16:05 ` Vidya Srinivas
2021-11-30 16:30 ` Ville Syrjälä
` (2 more replies)
2021-11-30 16:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev2) Patchwork
` (14 subsequent siblings)
18 siblings, 3 replies; 39+ messages in thread
From: Vidya Srinivas @ 2021-11-30 16:05 UTC (permalink / raw)
To: intel-gfx; +Cc: Yashashvi Shantam
PLANE_CUS_CTL has a restriction of 4096 width even though
PLANE_SIZE and scaler size registers supports max 5120.
Take care of this restriction in max_width.
Without this patch, when 5k content is sent on HDR plane
with NV12 content, FIFO underrun is seen and screen blanks
out.
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
Change-Id: If629c478ba044c8bde633de9f0fc638aa6c44233
---
.../gpu/drm/i915/display/intel_display_types.h | 3 ++-
.../gpu/drm/i915/display/skl_universal_plane.c | 17 +++++++++++++----
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index ea1e8a6e10b0..0455ea340329 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1358,7 +1358,8 @@ struct intel_plane {
int (*min_width)(const struct drm_framebuffer *fb,
int color_plane,
unsigned int rotation);
- int (*max_width)(const struct drm_framebuffer *fb,
+ int (*max_width)(struct intel_plane *plane,
+ const struct drm_framebuffer *fb,
int color_plane,
unsigned int rotation);
int (*max_height)(const struct drm_framebuffer *fb,
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 28890876bdeb..a49829c5a863 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -313,7 +313,8 @@ static int skl_plane_min_cdclk(const struct intel_crtc_state *crtc_state,
return DIV_ROUND_UP(pixel_rate * num, den);
}
-static int skl_plane_max_width(const struct drm_framebuffer *fb,
+static int skl_plane_max_width(struct intel_plane *plane,
+ const struct drm_framebuffer *fb,
int color_plane,
unsigned int rotation)
{
@@ -352,7 +353,8 @@ static int skl_plane_max_width(const struct drm_framebuffer *fb,
}
}
-static int glk_plane_max_width(const struct drm_framebuffer *fb,
+static int glk_plane_max_width(struct intel_plane *plane,
+ const struct drm_framebuffer *fb,
int color_plane,
unsigned int rotation)
{
@@ -420,10 +422,17 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb,
}
}
-static int icl_plane_max_width(const struct drm_framebuffer *fb,
+static int icl_plane_max_width(struct intel_plane *plane,
+ const struct drm_framebuffer *fb,
int color_plane,
unsigned int rotation)
{
+ struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
+
+ if (icl_is_hdr_plane(dev_priv, plane->id) &&
+ intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
+ return 4096;
+
return 5120;
}
@@ -1377,7 +1386,7 @@ static int intel_plane_max_width(struct intel_plane *plane,
unsigned int rotation)
{
if (plane->max_width)
- return plane->max_width(fb, color_plane, rotation);
+ return plane->max_width(plane, fb, color_plane, rotation);
else
return INT_MAX;
}
--
2.33.0
^ permalink raw reply related [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats
2021-11-30 9:30 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2021-11-30 16:20 ` Srinivas, Vidya
0 siblings, 0 replies; 39+ messages in thread
From: Srinivas, Vidya @ 2021-11-30 16:20 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Yashashvi, Shantam, Lobo, Melanie, intel-gfx
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Tuesday, November 30, 2021 3:01 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam
> <shantam.yashashvi@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar
> fb formats
>
> On Thu, Nov 18, 2021 at 11:55:16AM +0530, Vidya Srinivas wrote:
> > PLANE_CUS_CTL has a restriction of 4096 width even though PLANE_SIZE
> > and scaler size registers supports max 5120.
> > Reject 5k on HDR plane for planar formats like NV12 to let the user
> > space know about it.
> >
> > Without this patch, when 5k content is sent on HDR plane with NV12
> > content, FIFO underrun is seen and screen blanks out. Issue is seen on
> > both TGL and ADL platforms.
> >
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/skl_scaler.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c
> > b/drivers/gpu/drm/i915/display/skl_scaler.c
> > index 37eabeff8197..e2e52f5dca3b 100644
> > --- a/drivers/gpu/drm/i915/display/skl_scaler.c
> > +++ b/drivers/gpu/drm/i915/display/skl_scaler.c
> > @@ -86,6 +86,7 @@ static u16 skl_scaler_calc_phase(int sub, int scale,
> > bool chroma_cosited) #define ICL_MAX_DST_H 4096 #define
> > SKL_MIN_YUV_420_SRC_W 16 #define SKL_MIN_YUV_420_SRC_H 16
> > +#define MAX_CUSCTL_W 4096
> >
> > static int
> > skl_update_scaler(struct intel_crtc_state *crtc_state, bool
> > force_detach, @@ -221,6 +222,14 @@ int skl_update_scaler_plane(struct
> intel_crtc_state *crtc_state,
> > bool force_detach = !fb || !plane_state->uapi.visible;
> > bool need_scaler = false;
> >
> > + /* PLANE_CUS_CTL size max 4096 */
> > + if (icl_is_hdr_plane(dev_priv, intel_plane->id) &&
> > + fb && intel_format_info_is_yuv_semiplanar(fb->format, fb-
> >modifier) &&
> > + (drm_rect_width(&plane_state->uapi.src) >> 16) >
> MAX_CUSCTL_W) {
> > + DRM_ERROR("HDR chroma upsampler size exceeds
> limits\n");
> > + return -EINVAL;
> > + }
>
> Wrong place. Should go into the plane->max_width() hook. There also seems
> to be a minimum height requirement for the CUS which we're not checking
> either.
>
Thank you very much Ville for the patch review. Have moved the check to max_width.
Minimum horizontal should be 8 and vertical should be 4 - Haven't added in this yet.
Can you kindly have a check please https://patchwork.freedesktop.org/patch/464727/
Regards
Vidya
> > +
> > /* Pre-gen11 and SDR planes always need a scaler for planar
> formats. */
> > if (!icl_is_hdr_plane(dev_priv, intel_plane->id) &&
> > fb && intel_format_info_is_yuv_semiplanar(fb->format,
> > fb->modifier))
> > --
> > 2.33.0
>
> --
> Ville Syrjälä
> Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-11-30 16:05 ` [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width Vidya Srinivas
@ 2021-11-30 16:30 ` Ville Syrjälä
2021-11-30 17:25 ` Srinivas, Vidya
2021-11-30 16:56 ` Vidya Srinivas
2021-11-30 17:12 ` Vidya Srinivas
2 siblings, 1 reply; 39+ messages in thread
From: Ville Syrjälä @ 2021-11-30 16:30 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: Yashashvi Shantam, intel-gfx
On Tue, Nov 30, 2021 at 09:35:34PM +0530, Vidya Srinivas wrote:
> PLANE_CUS_CTL has a restriction of 4096 width even though
> PLANE_SIZE and scaler size registers supports max 5120.
> Take care of this restriction in max_width.
>
> Without this patch, when 5k content is sent on HDR plane
> with NV12 content, FIFO underrun is seen and screen blanks
> out.
>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
> Change-Id: If629c478ba044c8bde633de9f0fc638aa6c44233
> ---
> .../gpu/drm/i915/display/intel_display_types.h | 3 ++-
> .../gpu/drm/i915/display/skl_universal_plane.c | 17 +++++++++++++----
> 2 files changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index ea1e8a6e10b0..0455ea340329 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1358,7 +1358,8 @@ struct intel_plane {
> int (*min_width)(const struct drm_framebuffer *fb,
> int color_plane,
> unsigned int rotation);
> - int (*max_width)(const struct drm_framebuffer *fb,
> + int (*max_width)(struct intel_plane *plane,
> + const struct drm_framebuffer *fb,
> int color_plane,
> unsigned int rotation);
> int (*max_height)(const struct drm_framebuffer *fb,
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index 28890876bdeb..a49829c5a863 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -313,7 +313,8 @@ static int skl_plane_min_cdclk(const struct intel_crtc_state *crtc_state,
> return DIV_ROUND_UP(pixel_rate * num, den);
> }
>
> -static int skl_plane_max_width(const struct drm_framebuffer *fb,
> +static int skl_plane_max_width(struct intel_plane *plane,
> + const struct drm_framebuffer *fb,
> int color_plane,
> unsigned int rotation)
> {
> @@ -352,7 +353,8 @@ static int skl_plane_max_width(const struct drm_framebuffer *fb,
> }
> }
>
> -static int glk_plane_max_width(const struct drm_framebuffer *fb,
> +static int glk_plane_max_width(struct intel_plane *plane,
> + const struct drm_framebuffer *fb,
> int color_plane,
> unsigned int rotation)
> {
> @@ -420,10 +422,17 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb,
> }
> }
>
> -static int icl_plane_max_width(const struct drm_framebuffer *fb,
> +static int icl_plane_max_width(struct intel_plane *plane,
> + const struct drm_framebuffer *fb,
> int color_plane,
> unsigned int rotation)
> {
> + struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
> +
> + if (icl_is_hdr_plane(dev_priv, plane->id) &&
We could just have separate functions for hdr and sdr planes instead.
> + intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
> + return 4096;
> +
> return 5120;
> }
>
> @@ -1377,7 +1386,7 @@ static int intel_plane_max_width(struct intel_plane *plane,
> unsigned int rotation)
> {
> if (plane->max_width)
> - return plane->max_width(fb, color_plane, rotation);
> + return plane->max_width(plane, fb, color_plane, rotation);
> else
> return INT_MAX;
> }
> --
> 2.33.0
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev2)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (3 preceding siblings ...)
2021-11-30 16:05 ` [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width Vidya Srinivas
@ 2021-11-30 16:54 ` Patchwork
2021-11-30 16:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (13 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-11-30 16:54 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev2)
URL : https://patchwork.freedesktop.org/series/97053/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
84c898254500 drm/i915: Add PLANE_CUS_CTL restriction in max_width
-:16: ERROR:GERRIT_CHANGE_ID: Remove Gerrit Change-Id's before submitting upstream
#16:
Change-Id: If629c478ba044c8bde633de9f0fc638aa6c44233
-:42: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#42: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:317:
+static int skl_plane_max_width(struct intel_plane *plane,
+ const struct drm_framebuffer *fb,
-:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#52: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:357:
+static int glk_plane_max_width(struct intel_plane *plane,
+ const struct drm_framebuffer *fb,
-:62: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#62: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:426:
+static int icl_plane_max_width(struct intel_plane *plane,
+ const struct drm_framebuffer *fb,
total: 1 errors, 0 warnings, 3 checks, 53 lines checked
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev2)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (4 preceding siblings ...)
2021-11-30 16:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev2) Patchwork
@ 2021-11-30 16:55 ` Patchwork
2021-11-30 17:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (12 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-11-30 16:55 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev2)
URL : https://patchwork.freedesktop.org/series/97053/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-11-30 16:05 ` [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width Vidya Srinivas
2021-11-30 16:30 ` Ville Syrjälä
@ 2021-11-30 16:56 ` Vidya Srinivas
2021-11-30 17:12 ` Vidya Srinivas
2 siblings, 0 replies; 39+ messages in thread
From: Vidya Srinivas @ 2021-11-30 16:56 UTC (permalink / raw)
To: intel-gfx; +Cc: Yashashvi Shantam
PLANE_CUS_CTL has a restriction of 4096 width even though
PLANE_SIZE and scaler size registers supports max 5120.
Take care of this restriction in max_width.
Without this patch, when 5k content is sent on HDR plane
with NV12 content, FIFO underrun is seen and screen blanks
out.
v2: Addressed review comments from Ville. Added separate
functions for max_width - for HDR and SDR
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
---
.../gpu/drm/i915/display/skl_universal_plane.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 28890876bdeb..d320a3ba1ade 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -420,7 +420,17 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb,
}
}
-static int icl_plane_max_width(const struct drm_framebuffer *fb,
+static int icl_plane_max_width_hdr(const struct drm_framebuffer *fb,
+ int color_plane,
+ unsigned int rotation)
+{
+ if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
+ return 4096;
+ else
+ return 5120;
+}
+
+static int icl_plane_max_width_sdr(const struct drm_framebuffer *fb,
int color_plane,
unsigned int rotation)
{
@@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
if (DISPLAY_VER(dev_priv) >= 11) {
plane->min_width = icl_plane_min_width;
- plane->max_width = icl_plane_max_width;
+ if (icl_is_hdr_plane(dev_priv, plane_id))
+ plane->max_width = icl_plane_max_width_hdr;
+ else
+ plane->max_width = icl_plane_max_width_sdr;
plane->max_height = icl_plane_max_height;
plane->min_cdclk = icl_plane_min_cdclk;
} else if (DISPLAY_VER(dev_priv) >= 10) {
--
2.33.0
^ permalink raw reply related [flat|nested] 39+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-11-30 16:05 ` [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width Vidya Srinivas
2021-11-30 16:30 ` Ville Syrjälä
2021-11-30 16:56 ` Vidya Srinivas
@ 2021-11-30 17:12 ` Vidya Srinivas
2021-11-30 18:09 ` Ville Syrjälä
` (3 more replies)
2 siblings, 4 replies; 39+ messages in thread
From: Vidya Srinivas @ 2021-11-30 17:12 UTC (permalink / raw)
To: intel-gfx; +Cc: Yashashvi Shantam
PLANE_CUS_CTL has a restriction of 4096 width even though
PLANE_SIZE and scaler size registers supports max 5120.
Take care of this restriction in max_width.
Without this patch, when 5k content is sent on HDR plane
with NV12 content, FIFO underrun is seen and screen blanks
out.
v2: Addressed review comments from Ville. Added separate
functions for max_width - for HDR and SDR
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
---
.../gpu/drm/i915/display/skl_universal_plane.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 28890876bdeb..d320a3ba1ade 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -420,7 +420,17 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb,
}
}
-static int icl_plane_max_width(const struct drm_framebuffer *fb,
+static int icl_plane_max_width_hdr(const struct drm_framebuffer *fb,
+ int color_plane,
+ unsigned int rotation)
+{
+ if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
+ return 4096;
+ else
+ return 5120;
+}
+
+static int icl_plane_max_width_sdr(const struct drm_framebuffer *fb,
int color_plane,
unsigned int rotation)
{
@@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
if (DISPLAY_VER(dev_priv) >= 11) {
plane->min_width = icl_plane_min_width;
- plane->max_width = icl_plane_max_width;
+ if (icl_is_hdr_plane(dev_priv, plane_id))
+ plane->max_width = icl_plane_max_width_hdr;
+ else
+ plane->max_width = icl_plane_max_width_sdr;
plane->max_height = icl_plane_max_height;
plane->min_cdclk = icl_plane_min_cdclk;
} else if (DISPLAY_VER(dev_priv) >= 10) {
--
2.33.0
^ permalink raw reply related [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-11-30 16:30 ` Ville Syrjälä
@ 2021-11-30 17:25 ` Srinivas, Vidya
0 siblings, 0 replies; 39+ messages in thread
From: Srinivas, Vidya @ 2021-11-30 17:25 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Yashashvi, Shantam, intel-gfx
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Tuesday, November 30, 2021 10:00 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma
> <uma.shankar@intel.com>; Yashashvi, Shantam
> <shantam.yashashvi@intel.com>
> Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
>
> On Tue, Nov 30, 2021 at 09:35:34PM +0530, Vidya Srinivas wrote:
> > PLANE_CUS_CTL has a restriction of 4096 width even though PLANE_SIZE
> > and scaler size registers supports max 5120.
> > Take care of this restriction in max_width.
> >
> > Without this patch, when 5k content is sent on HDR plane with NV12
> > content, FIFO underrun is seen and screen blanks out.
> >
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
> > Change-Id: If629c478ba044c8bde633de9f0fc638aa6c44233
> > ---
> > .../gpu/drm/i915/display/intel_display_types.h | 3 ++-
> > .../gpu/drm/i915/display/skl_universal_plane.c | 17 +++++++++++++----
> > 2 files changed, 15 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> > b/drivers/gpu/drm/i915/display/intel_display_types.h
> > index ea1e8a6e10b0..0455ea340329 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> > @@ -1358,7 +1358,8 @@ struct intel_plane {
> > int (*min_width)(const struct drm_framebuffer *fb,
> > int color_plane,
> > unsigned int rotation);
> > - int (*max_width)(const struct drm_framebuffer *fb,
> > + int (*max_width)(struct intel_plane *plane,
> > + const struct drm_framebuffer *fb,
> > int color_plane,
> > unsigned int rotation);
> > int (*max_height)(const struct drm_framebuffer *fb, diff --git
> > a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > index 28890876bdeb..a49829c5a863 100644
> > --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > @@ -313,7 +313,8 @@ static int skl_plane_min_cdclk(const struct
> intel_crtc_state *crtc_state,
> > return DIV_ROUND_UP(pixel_rate * num, den); }
> >
> > -static int skl_plane_max_width(const struct drm_framebuffer *fb,
> > +static int skl_plane_max_width(struct intel_plane *plane,
> > + const struct drm_framebuffer *fb,
> > int color_plane,
> > unsigned int rotation)
> > {
> > @@ -352,7 +353,8 @@ static int skl_plane_max_width(const struct
> drm_framebuffer *fb,
> > }
> > }
> >
> > -static int glk_plane_max_width(const struct drm_framebuffer *fb,
> > +static int glk_plane_max_width(struct intel_plane *plane,
> > + const struct drm_framebuffer *fb,
> > int color_plane,
> > unsigned int rotation)
> > {
> > @@ -420,10 +422,17 @@ static int icl_plane_min_width(const struct
> drm_framebuffer *fb,
> > }
> > }
> >
> > -static int icl_plane_max_width(const struct drm_framebuffer *fb,
> > +static int icl_plane_max_width(struct intel_plane *plane,
> > + const struct drm_framebuffer *fb,
> > int color_plane,
> > unsigned int rotation)
> > {
> > + struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
> > +
> > + if (icl_is_hdr_plane(dev_priv, plane->id) &&
>
> We could just have separate functions for hdr and sdr planes instead.
Thank you very much Ville, for the patch review. Have added two different functions as suggested.
Can you kindly have a check.
Sorry - Not sure why, I don't see the change reflect in patchwork website although I am seeing the mail.
Regards
Vidya
>
> > + intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
> > + return 4096;
> > +
> > return 5120;
> > }
> >
> > @@ -1377,7 +1386,7 @@ static int intel_plane_max_width(struct
> intel_plane *plane,
> > unsigned int rotation)
> > {
> > if (plane->max_width)
> > - return plane->max_width(fb, color_plane, rotation);
> > + return plane->max_width(plane, fb, color_plane, rotation);
> > else
> > return INT_MAX;
> > }
> > --
> > 2.33.0
>
> --
> Ville Syrjälä
> Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Reject 5k on HDR planes for planar fb formats (rev2)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (5 preceding siblings ...)
2021-11-30 16:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2021-11-30 17:27 ` Patchwork
2021-11-30 17:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev4) Patchwork
` (11 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-11-30 17:27 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5534 bytes --]
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev2)
URL : https://patchwork.freedesktop.org/series/97053/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10945 -> Patchwork_21704
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21704 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21704, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21704/index.html
Participating hosts (40 -> 33)
------------------------------
Missing (7): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-6 bat-adlp-4 bat-jsl-2 bat-jsl-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21704:
### IGT changes ###
#### Possible regressions ####
* igt@core_hotunplug@unbind-rebind:
- fi-snb-2520m: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-snb-2520m/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21704/fi-snb-2520m/igt@core_hotunplug@unbind-rebind.html
Known issues
------------
Here are the changes found in Patchwork_21704 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-rkl-guc: NOTRUN -> [SKIP][3] ([fdo#109315]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21704/fi-rkl-guc/igt@amdgpu/amd_basic@cs-gfx.html
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> [SKIP][4] ([fdo#109271]) +17 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21704/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html
* igt@runner@aborted:
- fi-snb-2520m: NOTRUN -> [FAIL][5] ([i915#2426] / [i915#4312])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21704/fi-snb-2520m/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [FAIL][6] ([i915#1888]) -> [PASS][7] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21704/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [INCOMPLETE][8] ([i915#2940]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21704/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_engines:
- fi-rkl-guc: [INCOMPLETE][10] ([i915#4432]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21704/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][12] ([i915#4269]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21704/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
- fi-cfl-8109u: [DMESG-FAIL][14] ([i915#295]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21704/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][16] ([i915#295]) -> [PASS][17] +10 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21704/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4432]: https://gitlab.freedesktop.org/drm/intel/issues/4432
Build changes
-------------
* Linux: CI_DRM_10945 -> Patchwork_21704
CI-20190529: 20190529
CI_DRM_10945: ac459a8e27b90b5010d6e35302c429c1721016a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6295: 2d7f671b872ed856a97957051098974be2380019 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21704: 84c898254500ee8419ac107e513d2b1c6a9e0cb4 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
84c898254500 drm/i915: Add PLANE_CUS_CTL restriction in max_width
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21704/index.html
[-- Attachment #2: Type: text/html, Size: 6453 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev4)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (6 preceding siblings ...)
2021-11-30 17:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2021-11-30 17:52 ` Patchwork
2021-11-30 18:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (10 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-11-30 17:52 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev4)
URL : https://patchwork.freedesktop.org/series/97053/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2930434c940d drm/i915: Add PLANE_CUS_CTL restriction in max_width
-:30: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#30: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:424:
+static int icl_plane_max_width_hdr(const struct drm_framebuffer *fb,
+ int color_plane,
-:40: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#40: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:434:
+static int icl_plane_max_width_sdr(const struct drm_framebuffer *fb,
int color_plane,
total: 0 errors, 0 warnings, 2 checks, 29 lines checked
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-11-30 17:12 ` Vidya Srinivas
@ 2021-11-30 18:09 ` Ville Syrjälä
2021-12-01 1:33 ` Srinivas, Vidya
2021-12-01 1:23 ` Vidya Srinivas
` (2 subsequent siblings)
3 siblings, 1 reply; 39+ messages in thread
From: Ville Syrjälä @ 2021-11-30 18:09 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: Yashashvi Shantam, intel-gfx
On Tue, Nov 30, 2021 at 10:42:20PM +0530, Vidya Srinivas wrote:
> PLANE_CUS_CTL has a restriction of 4096 width even though
> PLANE_SIZE and scaler size registers supports max 5120.
> Take care of this restriction in max_width.
>
> Without this patch, when 5k content is sent on HDR plane
> with NV12 content, FIFO underrun is seen and screen blanks
> out.
>
> v2: Addressed review comments from Ville. Added separate
> functions for max_width - for HDR and SDR
>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
> ---
> .../gpu/drm/i915/display/skl_universal_plane.c | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index 28890876bdeb..d320a3ba1ade 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -420,7 +420,17 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb,
> }
> }
>
> -static int icl_plane_max_width(const struct drm_framebuffer *fb,
> +static int icl_plane_max_width_hdr(const struct drm_framebuffer *fb,
Naming wise I would probably go with icl_hdr_plane_max_width() and
icl_sdr_plane_max_width().
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> + int color_plane,
> + unsigned int rotation)
> +{
> + if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
> + return 4096;
> + else
> + return 5120;
> +}
> +
> +static int icl_plane_max_width_sdr(const struct drm_framebuffer *fb,
> int color_plane,
> unsigned int rotation)
> {
> @@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
>
> if (DISPLAY_VER(dev_priv) >= 11) {
> plane->min_width = icl_plane_min_width;
> - plane->max_width = icl_plane_max_width;
> + if (icl_is_hdr_plane(dev_priv, plane_id))
> + plane->max_width = icl_plane_max_width_hdr;
> + else
> + plane->max_width = icl_plane_max_width_sdr;
> plane->max_height = icl_plane_max_height;
> plane->min_cdclk = icl_plane_min_cdclk;
> } else if (DISPLAY_VER(dev_priv) >= 10) {
> --
> 2.33.0
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject 5k on HDR planes for planar fb formats (rev4)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (7 preceding siblings ...)
2021-11-30 17:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev4) Patchwork
@ 2021-11-30 18:21 ` Patchwork
2021-11-30 19:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev5) Patchwork
` (9 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-11-30 18:21 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5174 bytes --]
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev4)
URL : https://patchwork.freedesktop.org/series/97053/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10945 -> Patchwork_21705
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21705/index.html
Participating hosts (40 -> 33)
------------------------------
Missing (7): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-6 bat-adlp-4 bat-jsl-2 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_21705 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-rkl-guc: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21705/fi-rkl-guc/igt@amdgpu/amd_basic@cs-gfx.html
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21705/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html
* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: [PASS][3] -> [FAIL][4] ([i915#4547])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-skl-6600u/igt@gem_flink_basic@bad-flink.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21705/fi-skl-6600u/igt@gem_flink_basic@bad-flink.html
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][5] -> [DMESG-FAIL][6] ([i915#4528])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-blb-e6850/igt@i915_selftest@live@requests.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21705/fi-blb-e6850/igt@i915_selftest@live@requests.html
* igt@runner@aborted:
- fi-blb-e6850: NOTRUN -> [FAIL][7] ([fdo#109271] / [i915#2403] / [i915#4312])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21705/fi-blb-e6850/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [FAIL][8] ([i915#1888]) -> [PASS][9] +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21705/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [INCOMPLETE][10] ([i915#2940]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21705/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_engines:
- fi-rkl-guc: [INCOMPLETE][12] ([i915#4432]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21705/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-FAIL][14] ([i915#295]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21705/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][16] ([i915#295]) -> [PASS][17] +10 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21705/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4432]: https://gitlab.freedesktop.org/drm/intel/issues/4432
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
Build changes
-------------
* Linux: CI_DRM_10945 -> Patchwork_21705
CI-20190529: 20190529
CI_DRM_10945: ac459a8e27b90b5010d6e35302c429c1721016a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6295: 2d7f671b872ed856a97957051098974be2380019 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21705: 2930434c940dc9667d2b86a145091fcdeb4e9230 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2930434c940d drm/i915: Add PLANE_CUS_CTL restriction in max_width
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21705/index.html
[-- Attachment #2: Type: text/html, Size: 6151 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev5)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (8 preceding siblings ...)
2021-11-30 18:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-11-30 19:02 ` Patchwork
2021-11-30 19:46 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (8 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-11-30 19:02 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev5)
URL : https://patchwork.freedesktop.org/series/97053/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
09f89f851e74 drm/i915: Add PLANE_CUS_CTL restriction in max_width
-:34: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#34: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:424:
+static int icl_plane_max_width_hdr(const struct drm_framebuffer *fb,
+ int color_plane,
-:44: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#44: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:434:
+static int icl_plane_max_width_sdr(const struct drm_framebuffer *fb,
int color_plane,
total: 0 errors, 0 warnings, 2 checks, 29 lines checked
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Reject 5k on HDR planes for planar fb formats (rev5)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (9 preceding siblings ...)
2021-11-30 19:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev5) Patchwork
@ 2021-11-30 19:46 ` Patchwork
2021-12-01 3:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev7) Patchwork
` (7 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-11-30 19:46 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5067 bytes --]
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev5)
URL : https://patchwork.freedesktop.org/series/97053/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10945 -> Patchwork_21707
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21707 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21707, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21707/index.html
Participating hosts (40 -> 33)
------------------------------
Missing (7): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-6 bat-adlp-4 bat-jsl-2 bat-jsl-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21707:
### CI changes ###
#### Possible regressions ####
* boot:
- fi-bxt-dsi: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-bxt-dsi/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21707/fi-bxt-dsi/boot.html
Known issues
------------
Here are the changes found in Patchwork_21707 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> [SKIP][3] ([fdo#109271]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21707/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html
* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> [SKIP][4] ([fdo#109271]) +18 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21707/fi-skl-6600u/igt@amdgpu/amd_cs_nop@sync-fork-gfx0.html
* igt@gem_exec_suspend@basic-s3:
- fi-bdw-5557u: [PASS][5] -> [INCOMPLETE][6] ([i915#146])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21707/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [FAIL][7] ([i915#1888]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21707/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [INCOMPLETE][9] ([i915#2940]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21707/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-FAIL][11] ([i915#295]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21707/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][13] ([i915#295]) -> [PASS][14] +10 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21707/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [FAIL][15] ([i915#4547]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10945/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21707/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
Build changes
-------------
* Linux: CI_DRM_10945 -> Patchwork_21707
CI-20190529: 20190529
CI_DRM_10945: ac459a8e27b90b5010d6e35302c429c1721016a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6295: 2d7f671b872ed856a97957051098974be2380019 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21707: 09f89f851e74a41e4b1850611f1e98e839b588ed @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
09f89f851e74 drm/i915: Add PLANE_CUS_CTL restriction in max_width
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21707/index.html
[-- Attachment #2: Type: text/html, Size: 6038 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-11-30 17:12 ` Vidya Srinivas
2021-11-30 18:09 ` Ville Syrjälä
@ 2021-12-01 1:23 ` Vidya Srinivas
2021-12-01 1:35 ` Vidya Srinivas
2021-12-01 3:47 ` Vidya Srinivas
3 siblings, 0 replies; 39+ messages in thread
From: Vidya Srinivas @ 2021-12-01 1:23 UTC (permalink / raw)
To: intel-gfx; +Cc: Yashashvi Shantam
PLANE_CUS_CTL has a restriction of 4096 width even though
PLANE_SIZE and scaler size registers supports max 5120.
Take care of this restriction in max_width.
Without this patch, when 5k content is sent on HDR plane
with NV12 content, FIFO underrun is seen and screen blanks
out.
v2: Addressed review comments from Ville. Added separate
functions for max_width - for HDR and SDR
v3: Addressed review comments from Ville. Changed names of
HDR and SDR max_width functions to icl_hdr_plane_max_width
and icl_sdr_plane_max_width
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.co
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
---
.../gpu/drm/i915/display/skl_universal_plane.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 28890876bdeb..e7205a53dc2f 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -420,7 +420,17 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb,
}
}
-static int icl_plane_max_width(const struct drm_framebuffer *fb,
+static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
+ int color_plane,
+ unsigned int rotation)
+{
+ if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
+ return 4096;
+ else
+ return 5120;
+}
+
+static int icl_sdr_plane_max_width(const struct drm_framebuffer *fb,
int color_plane,
unsigned int rotation)
{
@@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
if (DISPLAY_VER(dev_priv) >= 11) {
plane->min_width = icl_plane_min_width;
- plane->max_width = icl_plane_max_width;
+ if (icl_is_hdr_plane(dev_priv, plane_id))
+ plane->max_width = icl_hdr_plane_max_width;
+ else
+ plane->max_width = icl_sdr_plane_max_width;
plane->max_height = icl_plane_max_height;
plane->min_cdclk = icl_plane_min_cdclk;
} else if (DISPLAY_VER(dev_priv) >= 10) {
--
2.33.0
^ permalink raw reply related [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-11-30 18:09 ` Ville Syrjälä
@ 2021-12-01 1:33 ` Srinivas, Vidya
0 siblings, 0 replies; 39+ messages in thread
From: Srinivas, Vidya @ 2021-12-01 1:33 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Yashashvi, Shantam, intel-gfx
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Tuesday, November 30, 2021 11:40 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma
> <uma.shankar@intel.com>; Yashashvi, Shantam
> <shantam.yashashvi@intel.com>
> Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
>
> On Tue, Nov 30, 2021 at 10:42:20PM +0530, Vidya Srinivas wrote:
> > PLANE_CUS_CTL has a restriction of 4096 width even though PLANE_SIZE
> > and scaler size registers supports max 5120.
> > Take care of this restriction in max_width.
> >
> > Without this patch, when 5k content is sent on HDR plane with NV12
> > content, FIFO underrun is seen and screen blanks out.
> >
> > v2: Addressed review comments from Ville. Added separate functions for
> > max_width - for HDR and SDR
> >
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
> > ---
> > .../gpu/drm/i915/display/skl_universal_plane.c | 17
> > +++++++++++++++--
> > 1 file changed, 15 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > index 28890876bdeb..d320a3ba1ade 100644
> > --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > @@ -420,7 +420,17 @@ static int icl_plane_min_width(const struct
> drm_framebuffer *fb,
> > }
> > }
> >
> > -static int icl_plane_max_width(const struct drm_framebuffer *fb,
> > +static int icl_plane_max_width_hdr(const struct drm_framebuffer *fb,
>
> Naming wise I would probably go with icl_hdr_plane_max_width() and
> icl_sdr_plane_max_width().
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thank you very much Ville, for the patch review and RB. Have fixed the naming.
Regards
Vidya
>
> > + int color_plane,
> > + unsigned int rotation)
> > +{
> > + if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
> > + return 4096;
> > + else
> > + return 5120;
> > +}
> > +
> > +static int icl_plane_max_width_sdr(const struct drm_framebuffer *fb,
> > int color_plane,
> > unsigned int rotation)
> > {
> > @@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct
> > drm_i915_private *dev_priv,
> >
> > if (DISPLAY_VER(dev_priv) >= 11) {
> > plane->min_width = icl_plane_min_width;
> > - plane->max_width = icl_plane_max_width;
> > + if (icl_is_hdr_plane(dev_priv, plane_id))
> > + plane->max_width = icl_plane_max_width_hdr;
> > + else
> > + plane->max_width = icl_plane_max_width_sdr;
> > plane->max_height = icl_plane_max_height;
> > plane->min_cdclk = icl_plane_min_cdclk;
> > } else if (DISPLAY_VER(dev_priv) >= 10) {
> > --
> > 2.33.0
>
> --
> Ville Syrjälä
> Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-11-30 17:12 ` Vidya Srinivas
2021-11-30 18:09 ` Ville Syrjälä
2021-12-01 1:23 ` Vidya Srinivas
@ 2021-12-01 1:35 ` Vidya Srinivas
2021-12-01 3:47 ` Vidya Srinivas
3 siblings, 0 replies; 39+ messages in thread
From: Vidya Srinivas @ 2021-12-01 1:35 UTC (permalink / raw)
To: intel-gfx; +Cc: Yashashvi Shantam
PLANE_CUS_CTL has a restriction of 4096 width even though
PLANE_SIZE and scaler size registers supports max 5120.
Take care of this restriction in max_width.
Without this patch, when 5k content is sent on HDR plane
with NV12 content, FIFO underrun is seen and screen blanks
out.
v2: Addressed review comments from Ville. Added separate
functions for max_width - for HDR and SDR
v3: Addressed review comments from Ville. Changed names of
HDR and SDR max_width functions to icl_hdr_plane_max_width
and icl_sdr_plane_max_width
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
---
.../gpu/drm/i915/display/skl_universal_plane.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 28890876bdeb..e7205a53dc2f 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -420,7 +420,17 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb,
}
}
-static int icl_plane_max_width(const struct drm_framebuffer *fb,
+static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
+ int color_plane,
+ unsigned int rotation)
+{
+ if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
+ return 4096;
+ else
+ return 5120;
+}
+
+static int icl_sdr_plane_max_width(const struct drm_framebuffer *fb,
int color_plane,
unsigned int rotation)
{
@@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
if (DISPLAY_VER(dev_priv) >= 11) {
plane->min_width = icl_plane_min_width;
- plane->max_width = icl_plane_max_width;
+ if (icl_is_hdr_plane(dev_priv, plane_id))
+ plane->max_width = icl_hdr_plane_max_width;
+ else
+ plane->max_width = icl_sdr_plane_max_width;
plane->max_height = icl_plane_max_height;
plane->min_cdclk = icl_plane_min_cdclk;
} else if (DISPLAY_VER(dev_priv) >= 10) {
--
2.33.0
^ permalink raw reply related [flat|nested] 39+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev7)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (10 preceding siblings ...)
2021-11-30 19:46 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2021-12-01 3:36 ` Patchwork
2021-12-01 4:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev8) Patchwork
` (6 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-12-01 3:36 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev7)
URL : https://patchwork.freedesktop.org/series/97053/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
24b77f8800af drm/i915: Add PLANE_CUS_CTL restriction in max_width
-:38: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#38: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:424:
+static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
+ int color_plane,
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:434:
+static int icl_sdr_plane_max_width(const struct drm_framebuffer *fb,
int color_plane,
total: 0 errors, 0 warnings, 2 checks, 29 lines checked
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-11-30 17:12 ` Vidya Srinivas
` (2 preceding siblings ...)
2021-12-01 1:35 ` Vidya Srinivas
@ 2021-12-01 3:47 ` Vidya Srinivas
2021-12-01 15:02 ` Ville Syrjälä
2021-12-02 11:08 ` Vidya Srinivas
3 siblings, 2 replies; 39+ messages in thread
From: Vidya Srinivas @ 2021-12-01 3:47 UTC (permalink / raw)
To: intel-gfx; +Cc: Yashashvi Shantam
PLANE_CUS_CTL has a restriction of 4096 width even though
PLANE_SIZE and scaler size registers supports max 5120.
Take care of this restriction in max_width.
Without this patch, when 5k content is sent on HDR plane
with NV12 content, FIFO underrun is seen and screen blanks
out.
v2: Addressed review comments from Ville. Added separate
functions for max_width - for HDR and SDR
v3: Addressed review comments from Ville. Changed names of
HDR and SDR max_width functions to icl_hdr_plane_max_width
and icl_sdr_plane_max_width
v4: Fixed paranthesis alignment. No code change
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
---
.../drm/i915/display/skl_universal_plane.c | 21 +++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 28890876bdeb..e717eb58b105 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -420,9 +420,19 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb,
}
}
-static int icl_plane_max_width(const struct drm_framebuffer *fb,
- int color_plane,
- unsigned int rotation)
+static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
+ int color_plane,
+ unsigned int rotation)
+{
+ if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
+ return 4096;
+ else
+ return 5120;
+}
+
+static int icl_sdr_plane_max_width(const struct drm_framebuffer *fb,
+ int color_plane,
+ unsigned int rotation)
{
return 5120;
}
@@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
if (DISPLAY_VER(dev_priv) >= 11) {
plane->min_width = icl_plane_min_width;
- plane->max_width = icl_plane_max_width;
+ if (icl_is_hdr_plane(dev_priv, plane_id))
+ plane->max_width = icl_hdr_plane_max_width;
+ else
+ plane->max_width = icl_sdr_plane_max_width;
plane->max_height = icl_plane_max_height;
plane->min_cdclk = icl_plane_min_cdclk;
} else if (DISPLAY_VER(dev_priv) >= 10) {
--
2.33.0
^ permalink raw reply related [flat|nested] 39+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev8)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (11 preceding siblings ...)
2021-12-01 3:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev7) Patchwork
@ 2021-12-01 4:12 ` Patchwork
2021-12-01 4:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject 5k on HDR planes for planar fb formats (rev7) Patchwork
` (5 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-12-01 4:12 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev8)
URL : https://patchwork.freedesktop.org/series/97053/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
dd6fd0244481 drm/i915: Add PLANE_CUS_CTL restriction in max_width
-:42: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#42: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:424:
+static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
+ int color_plane,
-:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#52: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:434:
+static int icl_sdr_plane_max_width(const struct drm_framebuffer *fb,
+ int color_plane,
total: 0 errors, 0 warnings, 2 checks, 33 lines checked
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject 5k on HDR planes for planar fb formats (rev7)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (12 preceding siblings ...)
2021-12-01 4:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev8) Patchwork
@ 2021-12-01 4:20 ` Patchwork
2021-12-01 4:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject 5k on HDR planes for planar fb formats (rev8) Patchwork
` (4 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-12-01 4:20 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5336 bytes --]
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev7)
URL : https://patchwork.freedesktop.org/series/97053/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10948 -> Patchwork_21709
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/index.html
Participating hosts (39 -> 34)
------------------------------
Additional (2): fi-kbl-soraka fi-pnv-d510
Missing (7): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-6 bat-adlp-4 bat-jsl-2 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_21709 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [PASS][2] -> [FAIL][3] ([i915#1888])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: [PASS][4] -> [FAIL][5] ([i915#4547])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/fi-skl-6600u/igt@gem_flink_basic@bad-flink.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/fi-skl-6600u/igt@gem_flink_basic@bad-flink.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@gt_engines:
- fi-rkl-guc: [PASS][8] -> [INCOMPLETE][9] ([i915#4432])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][10] ([i915#1886] / [i915#2291])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#533])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][13] ([fdo#109271]) +57 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/fi-pnv-d510/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][14] ([i915#3363] / [i915#4312])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/fi-skl-6600u/igt@runner@aborted.html
- fi-rkl-guc: NOTRUN -> [FAIL][15] ([i915#3928] / [i915#4312])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/fi-rkl-guc/igt@runner@aborted.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3928]: https://gitlab.freedesktop.org/drm/intel/issues/3928
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4432]: https://gitlab.freedesktop.org/drm/intel/issues/4432
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_10948 -> Patchwork_21709
CI-20190529: 20190529
CI_DRM_10948: 2a3a3bac4f6f02af651626eed357bbd13117055a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6295: 2d7f671b872ed856a97957051098974be2380019 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21709: 24b77f8800afcdcd537b72aa580d7a55b5abc718 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
24b77f8800af drm/i915: Add PLANE_CUS_CTL restriction in max_width
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21709/index.html
[-- Attachment #2: Type: text/html, Size: 6617 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject 5k on HDR planes for planar fb formats (rev8)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (13 preceding siblings ...)
2021-12-01 4:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject 5k on HDR planes for planar fb formats (rev7) Patchwork
@ 2021-12-01 4:52 ` Patchwork
2021-12-01 7:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
` (3 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-12-01 4:52 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5375 bytes --]
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev8)
URL : https://patchwork.freedesktop.org/series/97053/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10948 -> Patchwork_21710
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/index.html
Participating hosts (39 -> 33)
------------------------------
Additional (1): fi-kbl-soraka
Missing (7): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-6 bat-adlp-4 bat-jsl-2 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_21710 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: [PASS][2] -> [INCOMPLETE][3] ([i915#198] / [i915#4547])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/fi-skl-6600u/igt@gem_flink_basic@bad-flink.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/fi-skl-6600u/igt@gem_flink_basic@bad-flink.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@gt_engines:
- fi-rkl-guc: [PASS][6] -> [INCOMPLETE][7] ([i915#4432])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#1886] / [i915#2291])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@requests:
- fi-kbl-soraka: NOTRUN -> [DMESG-WARN][9] ([i915#4391])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/fi-kbl-soraka/igt@i915_selftest@live@requests.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#533])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][12] ([i915#2722] / [i915#3363] / [i915#4312])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/fi-skl-6600u/igt@runner@aborted.html
- fi-rkl-guc: NOTRUN -> [FAIL][13] ([i915#3928] / [i915#4312])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/fi-rkl-guc/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3928]: https://gitlab.freedesktop.org/drm/intel/issues/3928
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4432]: https://gitlab.freedesktop.org/drm/intel/issues/4432
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_10948 -> Patchwork_21710
CI-20190529: 20190529
CI_DRM_10948: 2a3a3bac4f6f02af651626eed357bbd13117055a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6295: 2d7f671b872ed856a97957051098974be2380019 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21710: dd6fd02444810be9d384940c7c6c45e49b7a4a13 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
dd6fd0244481 drm/i915: Add PLANE_CUS_CTL restriction in max_width
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/index.html
[-- Attachment #2: Type: text/html, Size: 6501 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Reject 5k on HDR planes for planar fb formats (rev8)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (14 preceding siblings ...)
2021-12-01 4:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject 5k on HDR planes for planar fb formats (rev8) Patchwork
@ 2021-12-01 7:32 ` Patchwork
2021-12-02 13:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev9) Patchwork
` (2 subsequent siblings)
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-12-01 7:32 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30154 bytes --]
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev8)
URL : https://patchwork.freedesktop.org/series/97053/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10948_full -> Patchwork_21710_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_21710_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_capture@pi@vcs0:
- shard-skl: NOTRUN -> [INCOMPLETE][1] ([i915#4547])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl7/igt@gem_exec_capture@pi@vcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [PASS][2] -> [FAIL][3] ([i915#2842])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-apl6/igt@gem_exec_fair@basic-none@vcs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl6/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][4] -> [FAIL][5] ([i915#2842]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-skl: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl9/igt@gem_lmem_swapping@heavy-verify-random.html
* igt@gem_userptr_blits@input-checking:
- shard-kbl: NOTRUN -> [DMESG-WARN][7] ([i915#3002])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl2/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@vma-merge:
- shard-kbl: NOTRUN -> [FAIL][8] ([i915#3318])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl2/igt@gem_userptr_blits@vma-merge.html
* igt@i915_pm_dc@dc6-dpms:
- shard-skl: NOTRUN -> [FAIL][9] ([i915#454])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl6/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][10] -> [INCOMPLETE][11] ([i915#3921])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-snb6/igt@i915_selftest@live@hangcheck.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-snb7/igt@i915_selftest@live@hangcheck.html
* igt@kms_addfb_basic@small-bo:
- shard-skl: [PASS][12] -> [DMESG-WARN][13] ([i915#1982])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-skl8/igt@kms_addfb_basic@small-bo.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl9/igt@kms_addfb_basic@small-bo.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-tglb: [PASS][14] -> [FAIL][15] ([i915#2521])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-tglb8/igt@kms_async_flips@alternate-sync-async-flip.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-tglb6/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-skl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#3777])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][17] ([i915#3763])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#3886]) +4 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl6/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#3886]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl3/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#3886]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl4/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_ccs:
- shard-iclb: NOTRUN -> [SKIP][21] ([fdo#109278]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-iclb4/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_ccs.html
* igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs:
- shard-kbl: NOTRUN -> [SKIP][22] ([fdo#109271]) +57 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl4/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs.html
* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-kbl: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +4 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl4/igt@kms_chamelium@hdmi-hpd-storm-disable.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl6/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-c-ctm-negative:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827]) +6 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl1/igt@kms_color_chamelium@pipe-c-ctm-negative.html
* igt@kms_content_protection@srm:
- shard-kbl: NOTRUN -> [TIMEOUT][26] ([i915#1319])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl4/igt@kms_content_protection@srm.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: NOTRUN -> [INCOMPLETE][27] ([i915#180] / [i915#1982])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl3/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-plain-flip-ts-check@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][28] -> [FAIL][29] ([i915#2122])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check@ab-hdmi-a1-hdmi-a2.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][30] -> [FAIL][31] ([i915#79])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-edp1:
- shard-iclb: [PASS][32] -> [DMESG-WARN][33] ([i915#2867])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-iclb4/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-iclb2/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [PASS][34] -> [FAIL][35] ([i915#2122]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl1/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][36] -> [DMESG-WARN][37] ([i915#180]) +6 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@psr-1p-rte:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271]) +30 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl3/igt@kms_frontbuffer_tracking@psr-1p-rte.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-move:
- shard-skl: NOTRUN -> [SKIP][39] ([fdo#109271]) +75 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-move.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#533])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl4/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: [PASS][41] -> [INCOMPLETE][42] ([i915#198] / [i915#2828])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-skl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl10/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#533]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#658])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-kbl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#658])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl4/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][46] -> [SKIP][47] ([fdo#109642] / [fdo#111068] / [i915#658])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-iclb3/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][48] -> [SKIP][49] ([fdo#109441]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_setmode@basic:
- shard-glk: [PASS][50] -> [FAIL][51] ([i915#31])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-glk4/igt@kms_setmode@basic.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-glk4/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [PASS][52] -> [DMESG-WARN][53] ([i915#180]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-apl1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#2437])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl3/igt@kms_writeback@writeback-fb-id.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-skl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#2437])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl6/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf@polling-small-buf:
- shard-skl: [PASS][56] -> [FAIL][57] ([i915#1722])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-skl8/igt@perf@polling-small-buf.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl9/igt@perf@polling-small-buf.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2994])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl3/igt@sysfs_clients@fair-7.html
* igt@sysfs_clients@recycle-many:
- shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#2994]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl4/igt@sysfs_clients@recycle-many.html
* igt@sysfs_clients@sema-25:
- shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2994])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl4/igt@sysfs_clients@sema-25.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][61] ([i915#658]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-iclb4/igt@feature_discovery@psr2.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][63] ([i915#2846]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-glk9/igt@gem_exec_fair@basic-deadline.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-glk2/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-apl: [SKIP][65] ([fdo#109271]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-apl2/igt@gem_exec_fair@basic-none-share@rcs0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl6/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][67] ([i915#2842]) -> [PASS][68] +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-kbl7/igt@gem_exec_fair@basic-none@vcs0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl1/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [FAIL][69] ([i915#2842]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-apl6/igt@gem_exec_fair@basic-none@vecs0.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl6/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-iclb: [FAIL][71] ([i915#2842]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-iclb3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-iclb7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_whisper@basic-contexts-forked:
- shard-glk: [DMESG-WARN][73] ([i915#118]) -> [PASS][74] +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-glk3/igt@gem_exec_whisper@basic-contexts-forked.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-glk5/igt@gem_exec_whisper@basic-contexts-forked.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][75] ([i915#180]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-apl3/igt@gem_workarounds@suspend-resume-context.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl3/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-skl: [DMESG-WARN][77] ([i915#1982]) -> [PASS][78] +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-skl10/igt@i915_module_load@reload-with-fault-injection.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl5/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][79] ([i915#2521]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-skl6/igt@kms_async_flips@alternate-sync-async-flip.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl1/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][81] ([i915#180]) -> [PASS][82] +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [FAIL][83] ([i915#72]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-glk8/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-iclb: [SKIP][85] ([i915#3701]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][87] ([i915#1188]) -> [PASS][88] +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][89] ([fdo#109441]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][91] ([i915#1542]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-skl6/igt@perf@polling-parameterized.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl1/igt@perf@polling-parameterized.html
#### Warnings ####
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][93] ([i915#2852]) -> [FAIL][94] ([i915#2842])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-iclb8/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-iclb4/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][95] ([i915#2684]) -> [WARN][96] ([i915#1804] / [i915#2684])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-iclb7/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-glk: [SKIP][97] ([fdo#109271] / [i915#3886]) -> [SKIP][98] ([fdo#109271] / [i915#1888] / [i915#3886])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-glk3/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-glk3/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][99] ([i915#2920]) -> [SKIP][100] ([i915#658])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-iclb3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3:
- shard-iclb: [SKIP][101] ([i915#658]) -> [SKIP][102] ([i915#2920]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-iclb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][103], [FAIL][104], [FAIL][105], [FAIL][106], [FAIL][107], [FAIL][108], [FAIL][109], [FAIL][110]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2426] / [i915#3002] / [i915#3363] / [i915#4312] / [i915#602]) -> ([FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122]) ([fdo#109271] / [i915#1436] / [i915#180] / [i915#1814] / [i915#2426] / [i915#3002] / [i915#3363] / [i915#4312])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-kbl7/igt@runner@aborted.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-kbl7/igt@runner@aborted.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-kbl7/igt@runner@aborted.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-kbl4/igt@runner@aborted.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-kbl4/igt@runner@aborted.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-kbl4/igt@runner@aborted.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-kbl6/igt@runner@aborted.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-kbl1/igt@runner@aborted.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl4/igt@runner@aborted.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl2/igt@runner@aborted.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl1/igt@runner@aborted.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl7/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl3/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl7/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl6/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl4/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl7/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl6/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl6/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-kbl1/igt@runner@aborted.html
- shard-apl: ([FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#2426] / [i915#3002] / [i915#3363] / [i915#4312]) -> ([FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134]) ([i915#180] / [i915#1814] / [i915#2426] / [i915#3002] / [i915#3363] / [i915#4312])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-apl8/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-apl4/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-apl2/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-apl6/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-apl6/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-apl3/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl1/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl3/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl4/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl6/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl3/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-apl4/igt@runner@aborted.html
- shard-skl: ([FAIL][135], [FAIL][136], [FAIL][137]) ([i915#2426] / [i915#3002] / [i915#3363] / [i915#4312]) -> ([FAIL][138], [FAIL][139], [FAIL][140]) ([i915#3002] / [i915#3363] / [i915#4312])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-skl10/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-skl5/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10948/shard-skl1/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl8/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl7/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/shard-skl7/igt@runner@aborted.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2828]: https://gitlab.freedesktop.org/drm/intel/issues/2828
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2852]: https://gitlab.freedesktop.org/drm/intel/issues/2852
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3763]: https://gitlab.freedesktop.org/drm/intel/issues/3763
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#602]: https://gitlab.freedesktop.org/drm/intel/issues/602
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_10948 -> Patchwork_21710
CI-20190529: 20190529
CI_DRM_10948: 2a3a3bac4f6f02af651626eed357bbd13117055a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6295: 2d7f671b872ed856a97957051098974be2380019 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21710: dd6fd02444810be9d384940c7c6c45e49b7a4a13 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21710/index.html
[-- Attachment #2: Type: text/html, Size: 38216 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-12-01 3:47 ` Vidya Srinivas
@ 2021-12-01 15:02 ` Ville Syrjälä
2021-12-02 3:25 ` Srinivas, Vidya
2021-12-02 11:08 ` Vidya Srinivas
1 sibling, 1 reply; 39+ messages in thread
From: Ville Syrjälä @ 2021-12-01 15:02 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: Yashashvi Shantam, intel-gfx
On Wed, Dec 01, 2021 at 09:17:27AM +0530, Vidya Srinivas wrote:
> PLANE_CUS_CTL has a restriction of 4096 width even though
> PLANE_SIZE and scaler size registers supports max 5120.
> Take care of this restriction in max_width.
>
> Without this patch, when 5k content is sent on HDR plane
> with NV12 content, FIFO underrun is seen and screen blanks
> out.
>
> v2: Addressed review comments from Ville. Added separate
> functions for max_width - for HDR and SDR
>
> v3: Addressed review comments from Ville. Changed names of
> HDR and SDR max_width functions to icl_hdr_plane_max_width
> and icl_sdr_plane_max_width
>
> v4: Fixed paranthesis alignment. No code change
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
Hmm. What's this extra sob doing here?
> ---
> .../drm/i915/display/skl_universal_plane.c | 21 +++++++++++++++----
> 1 file changed, 17 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index 28890876bdeb..e717eb58b105 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -420,9 +420,19 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb,
> }
> }
>
> -static int icl_plane_max_width(const struct drm_framebuffer *fb,
> - int color_plane,
> - unsigned int rotation)
> +static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
> + int color_plane,
> + unsigned int rotation)
> +{
> + if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
> + return 4096;
> + else
> + return 5120;
> +}
> +
> +static int icl_sdr_plane_max_width(const struct drm_framebuffer *fb,
> + int color_plane,
> + unsigned int rotation)
> {
> return 5120;
> }
> @@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
>
> if (DISPLAY_VER(dev_priv) >= 11) {
> plane->min_width = icl_plane_min_width;
> - plane->max_width = icl_plane_max_width;
> + if (icl_is_hdr_plane(dev_priv, plane_id))
> + plane->max_width = icl_hdr_plane_max_width;
> + else
> + plane->max_width = icl_sdr_plane_max_width;
> plane->max_height = icl_plane_max_height;
> plane->min_cdclk = icl_plane_min_cdclk;
> } else if (DISPLAY_VER(dev_priv) >= 10) {
> --
> 2.33.0
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-12-01 15:02 ` Ville Syrjälä
@ 2021-12-02 3:25 ` Srinivas, Vidya
2021-12-02 10:55 ` Ville Syrjälä
0 siblings, 1 reply; 39+ messages in thread
From: Srinivas, Vidya @ 2021-12-02 3:25 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Yashashvi, Shantam, intel-gfx
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Wednesday, December 1, 2021 8:33 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam
> <shantam.yashashvi@intel.com>
> Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
>
> On Wed, Dec 01, 2021 at 09:17:27AM +0530, Vidya Srinivas wrote:
> > PLANE_CUS_CTL has a restriction of 4096 width even though PLANE_SIZE
> > and scaler size registers supports max 5120.
> > Take care of this restriction in max_width.
> >
> > Without this patch, when 5k content is sent on HDR plane with NV12
> > content, FIFO underrun is seen and screen blanks out.
> >
> > v2: Addressed review comments from Ville. Added separate functions for
> > max_width - for HDR and SDR
> >
> > v3: Addressed review comments from Ville. Changed names of HDR and
> SDR
> > max_width functions to icl_hdr_plane_max_width and
> > icl_sdr_plane_max_width
> >
> > v4: Fixed paranthesis alignment. No code change
> >
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
>
> Hmm. What's this extra sob doing here?
Hello Ville, sincere apologies. When I run checkpatch.pl I see no warnings on my host.
However patchwork keeps reporting paranthesis alignment warning.
I tried to push it multiple times after running checkpatch.pl on my host. Really sorry about that.
Regards
Vidya
>
> > ---
> > .../drm/i915/display/skl_universal_plane.c | 21 +++++++++++++++----
> > 1 file changed, 17 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > index 28890876bdeb..e717eb58b105 100644
> > --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > @@ -420,9 +420,19 @@ static int icl_plane_min_width(const struct
> drm_framebuffer *fb,
> > }
> > }
> >
> > -static int icl_plane_max_width(const struct drm_framebuffer *fb,
> > - int color_plane,
> > - unsigned int rotation)
> > +static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
> > + int color_plane,
> > + unsigned int rotation)
> > +{
> > + if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
> > + return 4096;
> > + else
> > + return 5120;
> > +}
> > +
> > +static int icl_sdr_plane_max_width(const struct drm_framebuffer *fb,
> > + int color_plane,
> > + unsigned int rotation)
> > {
> > return 5120;
> > }
> > @@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct
> > drm_i915_private *dev_priv,
> >
> > if (DISPLAY_VER(dev_priv) >= 11) {
> > plane->min_width = icl_plane_min_width;
> > - plane->max_width = icl_plane_max_width;
> > + if (icl_is_hdr_plane(dev_priv, plane_id))
> > + plane->max_width = icl_hdr_plane_max_width;
> > + else
> > + plane->max_width = icl_sdr_plane_max_width;
> > plane->max_height = icl_plane_max_height;
> > plane->min_cdclk = icl_plane_min_cdclk;
> > } else if (DISPLAY_VER(dev_priv) >= 10) {
> > --
> > 2.33.0
>
> --
> Ville Syrjälä
> Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-12-02 3:25 ` Srinivas, Vidya
@ 2021-12-02 10:55 ` Ville Syrjälä
2021-12-02 11:10 ` Srinivas, Vidya
0 siblings, 1 reply; 39+ messages in thread
From: Ville Syrjälä @ 2021-12-02 10:55 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: Yashashvi, Shantam, intel-gfx
On Thu, Dec 02, 2021 at 03:25:34AM +0000, Srinivas, Vidya wrote:
>
>
> > -----Original Message-----
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Sent: Wednesday, December 1, 2021 8:33 PM
> > To: Srinivas, Vidya <vidya.srinivas@intel.com>
> > Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam
> > <shantam.yashashvi@intel.com>
> > Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
> >
> > On Wed, Dec 01, 2021 at 09:17:27AM +0530, Vidya Srinivas wrote:
> > > PLANE_CUS_CTL has a restriction of 4096 width even though PLANE_SIZE
> > > and scaler size registers supports max 5120.
> > > Take care of this restriction in max_width.
> > >
> > > Without this patch, when 5k content is sent on HDR plane with NV12
> > > content, FIFO underrun is seen and screen blanks out.
> > >
> > > v2: Addressed review comments from Ville. Added separate functions for
> > > max_width - for HDR and SDR
> > >
> > > v3: Addressed review comments from Ville. Changed names of HDR and
> > SDR
> > > max_width functions to icl_hdr_plane_max_width and
> > > icl_sdr_plane_max_width
> > >
> > > v4: Fixed paranthesis alignment. No code change
> > >
> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
> >
> > Hmm. What's this extra sob doing here?
>
> Hello Ville, sincere apologies. When I run checkpatch.pl I see no warnings on my host.
> However patchwork keeps reporting paranthesis alignment warning.
> I tried to push it multiple times after running checkpatch.pl on my host. Really sorry about that.
I was asking about the extra "signed-off-by" (sob).
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-12-01 3:47 ` Vidya Srinivas
2021-12-01 15:02 ` Ville Syrjälä
@ 2021-12-02 11:08 ` Vidya Srinivas
2021-12-02 13:06 ` Ville Syrjälä
1 sibling, 1 reply; 39+ messages in thread
From: Vidya Srinivas @ 2021-12-02 11:08 UTC (permalink / raw)
To: intel-gfx
PLANE_CUS_CTL has a restriction of 4096 width even though
PLANE_SIZE and scaler size registers supports max 5120.
Take care of this restriction in max_width.
Without this patch, when 5k content is sent on HDR plane
with NV12 content, FIFO underrun is seen and screen blanks
out.
v2: Addressed review comments from Ville. Added separate
functions for max_width - for HDR and SDR
v3: Addressed review comments from Ville. Changed names of
HDR and SDR max_width functions to icl_hdr_plane_max_width
and icl_sdr_plane_max_width
v4: Fixed paranthesis alignment. No code change
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
.../drm/i915/display/skl_universal_plane.c | 21 +++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 28890876bdeb..e717eb58b105 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -420,9 +420,19 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb,
}
}
-static int icl_plane_max_width(const struct drm_framebuffer *fb,
- int color_plane,
- unsigned int rotation)
+static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
+ int color_plane,
+ unsigned int rotation)
+{
+ if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
+ return 4096;
+ else
+ return 5120;
+}
+
+static int icl_sdr_plane_max_width(const struct drm_framebuffer *fb,
+ int color_plane,
+ unsigned int rotation)
{
return 5120;
}
@@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
if (DISPLAY_VER(dev_priv) >= 11) {
plane->min_width = icl_plane_min_width;
- plane->max_width = icl_plane_max_width;
+ if (icl_is_hdr_plane(dev_priv, plane_id))
+ plane->max_width = icl_hdr_plane_max_width;
+ else
+ plane->max_width = icl_sdr_plane_max_width;
plane->max_height = icl_plane_max_height;
plane->min_cdclk = icl_plane_min_cdclk;
} else if (DISPLAY_VER(dev_priv) >= 10) {
--
2.33.0
^ permalink raw reply related [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-12-02 10:55 ` Ville Syrjälä
@ 2021-12-02 11:10 ` Srinivas, Vidya
2021-12-02 11:13 ` Ville Syrjälä
0 siblings, 1 reply; 39+ messages in thread
From: Srinivas, Vidya @ 2021-12-02 11:10 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Yashashvi, Shantam, intel-gfx
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Thursday, December 2, 2021 4:26 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam
> <shantam.yashashvi@intel.com>
> Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
>
> On Thu, Dec 02, 2021 at 03:25:34AM +0000, Srinivas, Vidya wrote:
> >
> >
> > > -----Original Message-----
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Sent: Wednesday, December 1, 2021 8:33 PM
> > > To: Srinivas, Vidya <vidya.srinivas@intel.com>
> > > Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam
> > > <shantam.yashashvi@intel.com>
> > > Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in
> > > max_width
> > >
> > > On Wed, Dec 01, 2021 at 09:17:27AM +0530, Vidya Srinivas wrote:
> > > > PLANE_CUS_CTL has a restriction of 4096 width even though
> > > > PLANE_SIZE and scaler size registers supports max 5120.
> > > > Take care of this restriction in max_width.
> > > >
> > > > Without this patch, when 5k content is sent on HDR plane with NV12
> > > > content, FIFO underrun is seen and screen blanks out.
> > > >
> > > > v2: Addressed review comments from Ville. Added separate functions
> > > > for max_width - for HDR and SDR
> > > >
> > > > v3: Addressed review comments from Ville. Changed names of HDR and
> > > SDR
> > > > max_width functions to icl_hdr_plane_max_width and
> > > > icl_sdr_plane_max_width
> > > >
> > > > v4: Fixed paranthesis alignment. No code change
> > > >
> > > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > > Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
> > >
> > > Hmm. What's this extra sob doing here?
> >
> > Hello Ville, sincere apologies. When I run checkpatch.pl I see no warnings
> on my host.
> > However patchwork keeps reporting paranthesis alignment warning.
> > I tried to push it multiple times after running checkpatch.pl on my host.
> Really sorry about that.
>
> I was asking about the extra "signed-off-by" (sob).
Hello Ville, I am really sorry about that. Should I keep single signed-off-by and push the patch
again? Kindly let me know. Thank you.
Regards
Vidya
>
> --
> Ville Syrjälä
> Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-12-02 11:10 ` Srinivas, Vidya
@ 2021-12-02 11:13 ` Ville Syrjälä
2021-12-02 11:19 ` Srinivas, Vidya
0 siblings, 1 reply; 39+ messages in thread
From: Ville Syrjälä @ 2021-12-02 11:13 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: Yashashvi, Shantam, intel-gfx
On Thu, Dec 02, 2021 at 11:10:37AM +0000, Srinivas, Vidya wrote:
>
>
> > -----Original Message-----
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Sent: Thursday, December 2, 2021 4:26 PM
> > To: Srinivas, Vidya <vidya.srinivas@intel.com>
> > Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam
> > <shantam.yashashvi@intel.com>
> > Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
> >
> > On Thu, Dec 02, 2021 at 03:25:34AM +0000, Srinivas, Vidya wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Sent: Wednesday, December 1, 2021 8:33 PM
> > > > To: Srinivas, Vidya <vidya.srinivas@intel.com>
> > > > Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam
> > > > <shantam.yashashvi@intel.com>
> > > > Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in
> > > > max_width
> > > >
> > > > On Wed, Dec 01, 2021 at 09:17:27AM +0530, Vidya Srinivas wrote:
> > > > > PLANE_CUS_CTL has a restriction of 4096 width even though
> > > > > PLANE_SIZE and scaler size registers supports max 5120.
> > > > > Take care of this restriction in max_width.
> > > > >
> > > > > Without this patch, when 5k content is sent on HDR plane with NV12
> > > > > content, FIFO underrun is seen and screen blanks out.
> > > > >
> > > > > v2: Addressed review comments from Ville. Added separate functions
> > > > > for max_width - for HDR and SDR
> > > > >
> > > > > v3: Addressed review comments from Ville. Changed names of HDR and
> > > > SDR
> > > > > max_width functions to icl_hdr_plane_max_width and
> > > > > icl_sdr_plane_max_width
> > > > >
> > > > > v4: Fixed paranthesis alignment. No code change
> > > > >
> > > > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > > > Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
> > > >
> > > > Hmm. What's this extra sob doing here?
> > >
> > > Hello Ville, sincere apologies. When I run checkpatch.pl I see no warnings
> > on my host.
> > > However patchwork keeps reporting paranthesis alignment warning.
> > > I tried to push it multiple times after running checkpatch.pl on my host.
> > Really sorry about that.
> >
> > I was asking about the extra "signed-off-by" (sob).
>
> Hello Ville, I am really sorry about that. Should I keep single signed-off-by and push the patch
> again? Kindly let me know. Thank you.
Yeah, please resend with proper signed-off-by.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-12-02 11:13 ` Ville Syrjälä
@ 2021-12-02 11:19 ` Srinivas, Vidya
0 siblings, 0 replies; 39+ messages in thread
From: Srinivas, Vidya @ 2021-12-02 11:19 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Yashashvi, Shantam, intel-gfx
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Thursday, December 2, 2021 4:43 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam
> <shantam.yashashvi@intel.com>
> Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
>
> On Thu, Dec 02, 2021 at 11:10:37AM +0000, Srinivas, Vidya wrote:
> >
> >
> > > -----Original Message-----
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Sent: Thursday, December 2, 2021 4:26 PM
> > > To: Srinivas, Vidya <vidya.srinivas@intel.com>
> > > Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam
> > > <shantam.yashashvi@intel.com>
> > > Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in
> > > max_width
> > >
> > > On Thu, Dec 02, 2021 at 03:25:34AM +0000, Srinivas, Vidya wrote:
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > Sent: Wednesday, December 1, 2021 8:33 PM
> > > > > To: Srinivas, Vidya <vidya.srinivas@intel.com>
> > > > > Cc: intel-gfx@lists.freedesktop.org; Yashashvi, Shantam
> > > > > <shantam.yashashvi@intel.com>
> > > > > Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in
> > > > > max_width
> > > > >
> > > > > On Wed, Dec 01, 2021 at 09:17:27AM +0530, Vidya Srinivas wrote:
> > > > > > PLANE_CUS_CTL has a restriction of 4096 width even though
> > > > > > PLANE_SIZE and scaler size registers supports max 5120.
> > > > > > Take care of this restriction in max_width.
> > > > > >
> > > > > > Without this patch, when 5k content is sent on HDR plane with
> > > > > > NV12 content, FIFO underrun is seen and screen blanks out.
> > > > > >
> > > > > > v2: Addressed review comments from Ville. Added separate
> > > > > > functions for max_width - for HDR and SDR
> > > > > >
> > > > > > v3: Addressed review comments from Ville. Changed names of HDR
> > > > > > and
> > > > > SDR
> > > > > > max_width functions to icl_hdr_plane_max_width and
> > > > > > icl_sdr_plane_max_width
> > > > > >
> > > > > > v4: Fixed paranthesis alignment. No code change
> > > > > >
> > > > > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > > > > > Signed-off-by: Yashashvi Shantam <shantam.yashashvi@intel.com>
> > > > >
> > > > > Hmm. What's this extra sob doing here?
> > > >
> > > > Hello Ville, sincere apologies. When I run checkpatch.pl I see no
> > > > warnings
> > > on my host.
> > > > However patchwork keeps reporting paranthesis alignment warning.
> > > > I tried to push it multiple times after running checkpatch.pl on my host.
> > > Really sorry about that.
> > >
> > > I was asking about the extra "signed-off-by" (sob).
> >
> > Hello Ville, I am really sorry about that. Should I keep single
> > signed-off-by and push the patch again? Kindly let me know. Thank you.
>
> Yeah, please resend with proper signed-off-by.
Hello Ville, I have kept a single signed-off-by and pushed
https://patchwork.freedesktop.org/patch/465010/?series=97053&rev=9
Apologies for bothering you. Thank you very much. Kindly have a check.
Regards
Vidya
>
> --
> Ville Syrjälä
> Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev9)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (15 preceding siblings ...)
2021-12-01 7:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-12-02 13:01 ` Patchwork
2021-12-02 13:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-02 16:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-12-02 13:01 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev9)
URL : https://patchwork.freedesktop.org/series/97053/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
30dac13d1d1c drm/i915: Add PLANE_CUS_CTL restriction in max_width
-:41: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#41: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:424:
+static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
+ int color_plane,
-:51: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#51: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:434:
+static int icl_sdr_plane_max_width(const struct drm_framebuffer *fb,
+ int color_plane,
total: 0 errors, 0 warnings, 2 checks, 33 lines checked
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-12-02 11:08 ` Vidya Srinivas
@ 2021-12-02 13:06 ` Ville Syrjälä
2021-12-02 16:59 ` Srinivas, Vidya
0 siblings, 1 reply; 39+ messages in thread
From: Ville Syrjälä @ 2021-12-02 13:06 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: intel-gfx
On Thu, Dec 02, 2021 at 04:38:36PM +0530, Vidya Srinivas wrote:
> PLANE_CUS_CTL has a restriction of 4096 width even though
> PLANE_SIZE and scaler size registers supports max 5120.
> Take care of this restriction in max_width.
>
> Without this patch, when 5k content is sent on HDR plane
> with NV12 content, FIFO underrun is seen and screen blanks
> out.
>
> v2: Addressed review comments from Ville. Added separate
> functions for max_width - for HDR and SDR
>
> v3: Addressed review comments from Ville. Changed names of
> HDR and SDR max_width functions to icl_hdr_plane_max_width
> and icl_sdr_plane_max_width
>
> v4: Fixed paranthesis alignment. No code change
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
Pushed to drm-intel-next. Thanks.
> ---
> .../drm/i915/display/skl_universal_plane.c | 21 +++++++++++++++----
> 1 file changed, 17 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index 28890876bdeb..e717eb58b105 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -420,9 +420,19 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb,
> }
> }
>
> -static int icl_plane_max_width(const struct drm_framebuffer *fb,
> - int color_plane,
> - unsigned int rotation)
> +static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
> + int color_plane,
> + unsigned int rotation)
> +{
> + if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
> + return 4096;
> + else
> + return 5120;
> +}
> +
> +static int icl_sdr_plane_max_width(const struct drm_framebuffer *fb,
> + int color_plane,
> + unsigned int rotation)
> {
> return 5120;
> }
> @@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
>
> if (DISPLAY_VER(dev_priv) >= 11) {
> plane->min_width = icl_plane_min_width;
> - plane->max_width = icl_plane_max_width;
> + if (icl_is_hdr_plane(dev_priv, plane_id))
> + plane->max_width = icl_hdr_plane_max_width;
> + else
> + plane->max_width = icl_sdr_plane_max_width;
> plane->max_height = icl_plane_max_height;
> plane->min_cdclk = icl_plane_min_cdclk;
> } else if (DISPLAY_VER(dev_priv) >= 10) {
> --
> 2.33.0
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject 5k on HDR planes for planar fb formats (rev9)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (16 preceding siblings ...)
2021-12-02 13:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev9) Patchwork
@ 2021-12-02 13:25 ` Patchwork
2021-12-02 16:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-12-02 13:25 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3980 bytes --]
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev9)
URL : https://patchwork.freedesktop.org/series/97053/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10954 -> Patchwork_21728
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/index.html
Participating hosts (33 -> 32)
------------------------------
Additional (1): fi-kbl-soraka
Missing (2): fi-bsw-cyan fi-pnv-d510
Known issues
------------
Here are the changes found in Patchwork_21728 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][2] ([i915#4221])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/fi-kbl-soraka/igt@gem_exec_suspend@basic-s0.html
* igt@i915_pm_rpm@basic-rte:
- fi-hsw-4770: [PASS][3] -> [SKIP][4] ([fdo#109271]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/fi-hsw-4770/igt@i915_pm_rpm@basic-rte.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/fi-hsw-4770/igt@i915_pm_rpm@basic-rte.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-6600u: [PASS][5] -> [FAIL][6] ([i915#579])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/fi-skl-6600u/igt@i915_pm_rpm@module-reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/fi-skl-6600u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][7] -> [INCOMPLETE][8] ([i915#2940])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/fi-bsw-nick/igt@i915_selftest@live@execlists.html
* igt@runner@aborted:
- fi-bsw-nick: NOTRUN -> [FAIL][9] ([fdo#109271] / [i915#1436] / [i915#2722] / [i915#3428] / [i915#4312])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/fi-bsw-nick/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-1115g4: [FAIL][10] ([i915#1888]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#4221]: https://gitlab.freedesktop.org/drm/intel/issues/4221
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
Build changes
-------------
* Linux: CI_DRM_10954 -> Patchwork_21728
CI-20190529: 20190529
CI_DRM_10954: 8ea5e088c7d1b759052d0c04e51d31bd2c72f98d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6299: 0933b7ccdb2bb054b6a8154171e35315d84299b7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21728: 30dac13d1d1cc585c3ccd8cc0705e477c90b70a1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
30dac13d1d1c drm/i915: Add PLANE_CUS_CTL restriction in max_width
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/index.html
[-- Attachment #2: Type: text/html, Size: 4874 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Reject 5k on HDR planes for planar fb formats (rev9)
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
` (17 preceding siblings ...)
2021-12-02 13:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-12-02 16:48 ` Patchwork
18 siblings, 0 replies; 39+ messages in thread
From: Patchwork @ 2021-12-02 16:48 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30284 bytes --]
== Series Details ==
Series: drm/i915: Reject 5k on HDR planes for planar fb formats (rev9)
URL : https://patchwork.freedesktop.org/series/97053/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10954_full -> Patchwork_21728_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21728_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21728_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21728_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gtt:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-iclb5/igt@i915_selftest@live@gtt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb7/igt@i915_selftest@live@gtt.html
#### Warnings ####
* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [SKIP][3] ([i915#658]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-iclb1/igt@kms_psr2_su@page_flip-nv12.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html
Known issues
------------
Here are the changes found in Patchwork_21728_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-apl: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29]) -> ([PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [FAIL][54]) ([i915#4386])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl1/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl1/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl1/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl2/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl2/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl2/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl3/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl3/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl3/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl3/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl4/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl4/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl4/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl6/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl6/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl6/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl7/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl7/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl7/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl7/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl8/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl8/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl8/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl1/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl8/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl8/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl8/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl8/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl7/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl7/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl7/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl6/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl3/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl3/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl3/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl2/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl2/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl1/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl1/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl1/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl1/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-glk: NOTRUN -> [DMESG-WARN][55] ([i915#3002])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-glk8/igt@gem_create@create-massive.html
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-kbl: [PASS][56] -> [DMESG-WARN][57] ([i915#180]) +5 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl6/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][58] -> [TIMEOUT][59] ([i915#2481] / [i915#3070])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-iclb1/igt@gem_eio@unwedge-stress.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb2/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][60] -> [FAIL][61] ([i915#2846])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-glk5/igt@gem_exec_fair@basic-deadline.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-glk2/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-kbl: [PASS][62] -> [FAIL][63] ([i915#2842])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-kbl3/igt@gem_exec_fair@basic-none@rcs0.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl3/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][64] ([i915#2842])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [PASS][65] -> [FAIL][66] ([i915#2842])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-tglb3/igt@gem_exec_fair@basic-pace@vecs0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-tglb5/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_params@secure-non-master:
- shard-tglb: NOTRUN -> [SKIP][67] ([fdo#112283])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-tglb6/igt@gem_exec_params@secure-non-master.html
* igt@gem_lmem_swapping@parallel-multi:
- shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#4613]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl7/igt@gem_lmem_swapping@parallel-multi.html
* igt@gem_lmem_swapping@parallel-random:
- shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#4613])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl1/igt@gem_lmem_swapping@parallel-random.html
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-glk: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#4613])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-glk8/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][71] ([i915#2658])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl7/igt@gem_pwrite@basic-exhaustion.html
- shard-kbl: NOTRUN -> [WARN][72] ([i915#2658])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl3/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_render_copy@y-tiled-to-vebox-x-tiled:
- shard-iclb: NOTRUN -> [SKIP][73] ([i915#768])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb8/igt@gem_render_copy@y-tiled-to-vebox-x-tiled.html
* igt@gem_userptr_blits@input-checking:
- shard-iclb: NOTRUN -> [DMESG-WARN][74] ([i915#3002])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb6/igt@gem_userptr_blits@input-checking.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][75] -> [FAIL][76] ([i915#454])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-iclb4/igt@i915_pm_dc@dc6-dpms.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
- shard-kbl: NOTRUN -> [FAIL][77] ([i915#454])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl3/igt@i915_pm_dc@dc6-dpms.html
- shard-skl: NOTRUN -> [FAIL][78] ([i915#454])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl7/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_selftest@perf@engine_cs:
- shard-tglb: NOTRUN -> [DMESG-WARN][79] ([i915#2867]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-tglb6/igt@i915_selftest@perf@engine_cs.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][80] -> [DMESG-WARN][81] ([i915#180]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl6/igt@i915_suspend@sysfs-reader.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/igt@i915_suspend@sysfs-reader.html
- shard-kbl: NOTRUN -> [INCOMPLETE][82] ([i915#3614])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl2/igt@i915_suspend@sysfs-reader.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#3777])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
- shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#3777])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][85] ([i915#3763])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl9/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- shard-glk: [PASS][86] -> [DMESG-WARN][87] ([i915#118])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-glk7/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-glk4/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][88] ([i915#3743]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl4/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_joiner@invalid-modeset:
- shard-iclb: NOTRUN -> [SKIP][89] ([i915#2705])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb8/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#3886]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-glk8/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#3689]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-tglb3/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#3886]) +10 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl4/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#3886]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#3886]) +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl1/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][95] ([fdo#109271] / [fdo#111827]) +14 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl9/igt@kms_chamelium@hdmi-hpd-storm-disable.html
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [PASS][96] -> [DMESG-WARN][97] ([i915#1982]) +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-skl6/igt@kms_color@pipe-a-ctm-0-5.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl10/igt@kms_color@pipe-a-ctm-0-5.html
* igt@kms_color_chamelium@pipe-a-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][98] ([fdo#109284] / [fdo#111827])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb6/igt@kms_color_chamelium@pipe-a-ctm-0-5.html
* igt@kms_color_chamelium@pipe-b-ctm-max:
- shard-glk: NOTRUN -> [SKIP][99] ([fdo#109271] / [fdo#111827]) +2 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-glk8/igt@kms_color_chamelium@pipe-b-ctm-max.html
* igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:
- shard-apl: NOTRUN -> [SKIP][100] ([fdo#109271] / [fdo#111827]) +2 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/igt@kms_color_chamelium@pipe-b-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-b-gamma:
- shard-tglb: NOTRUN -> [SKIP][101] ([fdo#109284] / [fdo#111827]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-tglb6/igt@kms_color_chamelium@pipe-b-gamma.html
* igt@kms_color_chamelium@pipe-c-ctm-max:
- shard-kbl: NOTRUN -> [SKIP][102] ([fdo#109271] / [fdo#111827]) +11 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl3/igt@kms_color_chamelium@pipe-c-ctm-max.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#3116])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-tglb6/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> [TIMEOUT][104] ([i915#1319])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl3/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@srm:
- shard-apl: NOTRUN -> [TIMEOUT][105] ([i915#1319])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109278])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb6/igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding.html
* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-skl: NOTRUN -> [SKIP][107] ([fdo#109271]) +219 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][108] -> [INCOMPLETE][109] ([i915#180] / [i915#636])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][110] -> [FAIL][111] ([i915#79])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][112] ([i915#180]) +3 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-kbl: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#2672])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
- shard-skl: NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#2672])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][115] ([fdo#109280]) +2 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move:
- shard-tglb: NOTRUN -> [SKIP][116] ([fdo#111825]) +4 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-snb: [PASS][117] -> [SKIP][118] ([fdo#109271])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-snb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-snb6/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-blt:
- shard-apl: NOTRUN -> [SKIP][119] ([fdo#109271]) +39 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-blt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: NOTRUN -> [FAIL][120] ([i915#1188])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl7/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#533])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl1/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][122] ([i915#265]) +1 similar issue
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][123] ([fdo#108145] / [i915#265]) +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][124] ([fdo#108145] / [i915#265]) +2 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl4/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
- shard-apl: NOTRUN -> [FAIL][125] ([fdo#108145] / [i915#265])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-d-alpha-opaque-fb:
- shard-glk: NOTRUN -> [SKIP][126] ([fdo#109271]) +24 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-glk8/igt@kms_plane_alpha_blend@pipe-d-alpha-opaque-fb.html
* igt@kms_plane_multiple@atomic-pipe-d-tiling-x:
- shard-kbl: NOTRUN -> [SKIP][127] ([fdo#109271]) +130 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl3/igt@kms_plane_multiple@atomic-pipe-d-tiling-x.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-tglb: NOTRUN -> [SKIP][128] ([i915#2920]) +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-tglb3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-apl: NOTRUN -> [SKIP][129] ([fdo#109271] / [i915#658]) +1 similar issue
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- shard-skl: NOTRUN -> [SKIP][130] ([fdo#109271] / [i915#658]) +5 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-kbl: NOTRUN -> [SKIP][131] ([fdo#109271] / [i915#658]) +5 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][132] -> [SKIP][133] ([fdo#109441])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: NOTRUN -> [SKIP][134] ([fdo#109441])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb8/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_setmode@basic:
- shard-glk: [PASS][135] -> [FAIL][136] ([i915#31])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-glk9/igt@kms_setmode@basic.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-glk3/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-skl: [PASS][137] -> [INCOMPLETE][138] ([i915#198] / [i915#2828])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-skl8/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl4/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
* igt@kms_writeback@writeback-fb-id:
- shard-skl: NOTRUN -> [SKIP][139] ([fdo#109271] / [i915#2437])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl7/igt@kms_writeback@writeback-fb-id.html
* igt@perf@polling-parameterized:
- shard-skl: NOTRUN -> [FAIL][140] ([i915#1542])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl4/igt@perf@polling-parameterized.html
* igt@prime_vgem@basic-userptr:
- shard-tglb: NOTRUN -> [SKIP][141] ([i915#3301])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-tglb6/igt@prime_vgem@basic-userptr.html
* igt@sysfs_clients@busy:
- shard-skl: NOTRUN -> [SKIP][142] ([fdo#109271] / [i915#2994]) +2 similar issues
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-skl4/igt@sysfs_clients@busy.html
- shard-apl: NOTRUN -> [SKIP][143] ([fdo#109271] / [i915#2994])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/igt@sysfs_clients@busy.html
* igt@sysfs_clients@sema-10:
- shard-kbl: NOTRUN -> [SKIP][144] ([fdo#109271] / [i915#2994])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl7/igt@sysfs_clients@sema-10.html
#### Possible fixes ####
* igt@gem_eio@in-flight-contexts-1us:
- shard-tglb: [TIMEOUT][145] ([i915#3063]) -> [PASS][146]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-tglb6/igt@gem_eio@in-flight-contexts-1us.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-tglb6/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][147] ([i915#2842]) -> [PASS][148] +3 similar issues
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][149] ([i915#2842]) -> [PASS][150] +1 similar issue
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-glk: [FAIL][151] ([i915#2842]) -> [PASS][152]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [SKIP][153] ([fdo#109271]) -> [PASS][154]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][155] ([i915#2849]) -> [PASS][156]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][157] ([i915#180]) -> [PASS][158]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-apl4/igt@gem_workarounds@suspend-resume-context.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][159] ([i915#180]) -> [PASS][160] +4 similar issues
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-kbl6/igt@kms_hdr@bpc-switch-suspend.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-kbl3/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][161] ([fdo#109441]) -> [PASS][162] +1 similar issue
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10954/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][163] ([i915#180] / [i915#295]) -> [PASS][164]
[163]:
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21728/index.html
[-- Attachment #2: Type: text/html, Size: 33685 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
2021-12-02 13:06 ` Ville Syrjälä
@ 2021-12-02 16:59 ` Srinivas, Vidya
0 siblings, 0 replies; 39+ messages in thread
From: Srinivas, Vidya @ 2021-12-02 16:59 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Thursday, December 2, 2021 6:37 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width
>
> On Thu, Dec 02, 2021 at 04:38:36PM +0530, Vidya Srinivas wrote:
> > PLANE_CUS_CTL has a restriction of 4096 width even though PLANE_SIZE
> > and scaler size registers supports max 5120.
> > Take care of this restriction in max_width.
> >
> > Without this patch, when 5k content is sent on HDR plane with NV12
> > content, FIFO underrun is seen and screen blanks out.
> >
> > v2: Addressed review comments from Ville. Added separate functions for
> > max_width - for HDR and SDR
> >
> > v3: Addressed review comments from Ville. Changed names of HDR and
> SDR
> > max_width functions to icl_hdr_plane_max_width and
> > icl_sdr_plane_max_width
> >
> > v4: Fixed paranthesis alignment. No code change
> >
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>
> Pushed to drm-intel-next. Thanks.
Hello Ville, thank you very much for all the help.
Regards
Vidya
>
> > ---
> > .../drm/i915/display/skl_universal_plane.c | 21 +++++++++++++++----
> > 1 file changed, 17 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > index 28890876bdeb..e717eb58b105 100644
> > --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > @@ -420,9 +420,19 @@ static int icl_plane_min_width(const struct
> drm_framebuffer *fb,
> > }
> > }
> >
> > -static int icl_plane_max_width(const struct drm_framebuffer *fb,
> > - int color_plane,
> > - unsigned int rotation)
> > +static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
> > + int color_plane,
> > + unsigned int rotation)
> > +{
> > + if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
> > + return 4096;
> > + else
> > + return 5120;
> > +}
> > +
> > +static int icl_sdr_plane_max_width(const struct drm_framebuffer *fb,
> > + int color_plane,
> > + unsigned int rotation)
> > {
> > return 5120;
> > }
> > @@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct
> > drm_i915_private *dev_priv,
> >
> > if (DISPLAY_VER(dev_priv) >= 11) {
> > plane->min_width = icl_plane_min_width;
> > - plane->max_width = icl_plane_max_width;
> > + if (icl_is_hdr_plane(dev_priv, plane_id))
> > + plane->max_width = icl_hdr_plane_max_width;
> > + else
> > + plane->max_width = icl_sdr_plane_max_width;
> > plane->max_height = icl_plane_max_height;
> > plane->min_cdclk = icl_plane_min_cdclk;
> > } else if (DISPLAY_VER(dev_priv) >= 10) {
> > --
> > 2.33.0
>
> --
> Ville Syrjälä
> Intel
^ permalink raw reply [flat|nested] 39+ messages in thread
end of thread, other threads:[~2021-12-02 16:59 UTC | newest]
Thread overview: 39+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18 6:25 [Intel-gfx] [PATCH] drm/i915: Reject 5k on HDR planes for planar fb formats Vidya Srinivas
2021-11-18 7:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-11-18 15:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-11-30 9:30 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2021-11-30 16:20 ` Srinivas, Vidya
2021-11-30 16:05 ` [Intel-gfx] [PATCH] drm/i915: Add PLANE_CUS_CTL restriction in max_width Vidya Srinivas
2021-11-30 16:30 ` Ville Syrjälä
2021-11-30 17:25 ` Srinivas, Vidya
2021-11-30 16:56 ` Vidya Srinivas
2021-11-30 17:12 ` Vidya Srinivas
2021-11-30 18:09 ` Ville Syrjälä
2021-12-01 1:33 ` Srinivas, Vidya
2021-12-01 1:23 ` Vidya Srinivas
2021-12-01 1:35 ` Vidya Srinivas
2021-12-01 3:47 ` Vidya Srinivas
2021-12-01 15:02 ` Ville Syrjälä
2021-12-02 3:25 ` Srinivas, Vidya
2021-12-02 10:55 ` Ville Syrjälä
2021-12-02 11:10 ` Srinivas, Vidya
2021-12-02 11:13 ` Ville Syrjälä
2021-12-02 11:19 ` Srinivas, Vidya
2021-12-02 11:08 ` Vidya Srinivas
2021-12-02 13:06 ` Ville Syrjälä
2021-12-02 16:59 ` Srinivas, Vidya
2021-11-30 16:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev2) Patchwork
2021-11-30 16:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-11-30 17:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-11-30 17:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev4) Patchwork
2021-11-30 18:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-30 19:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev5) Patchwork
2021-11-30 19:46 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-12-01 3:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev7) Patchwork
2021-12-01 4:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev8) Patchwork
2021-12-01 4:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject 5k on HDR planes for planar fb formats (rev7) Patchwork
2021-12-01 4:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject 5k on HDR planes for planar fb formats (rev8) Patchwork
2021-12-01 7:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-12-02 13:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reject 5k on HDR planes for planar fb formats (rev9) Patchwork
2021-12-02 13:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-02 16:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.